summaryrefslogtreecommitdiff
path: root/libreofficekit
AgeCommit message (Collapse)Author
2018-07-18coverity#1437959 Copy into fixed size bufferCaolán McNamara
Change-Id: I5578e195c834b2a3ceacd5c528f58d1d03502c2e Reviewed-on: https://gerrit.libreoffice.org/57461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18tilebench: add --preinit mode.Michael Meeks
Also cleanup DISPLAY to avoid various weird problems. Change-Id: Ib480c94fc50baab6185ecadaabda9a8063cedfee Reviewed-on: https://gerrit.libreoffice.org/57146 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/57328 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-07-17tilebench: add dialog profiling mode.Michael Meeks
Change-Id: I4661664d1206aacdaf22a4a8f05d7962547faf45 (cherry picked from commit a8ebc12eabe2e49e7d1564027c7128898279944e) (cherry picked from commit 8a2414e4691ceb61559233570dd9df1221d164ea) Reviewed-on: https://gerrit.libreoffice.org/57326 Tested-by: pranavk <pranavk@collabora.co.uk> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-07-17lok: be informative and exit when tilebench fails to initializeAshod Nakashian
Change-Id: I11078e36aafc715b7103998a17e0cb01926b8e97 Reviewed-on: https://gerrit.libreoffice.org/51618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 519293447189f75e842065f7ff211d395d0da4b6) Reviewed-on: https://gerrit.libreoffice.org/57575 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-07-17More loplugin:cstylecast: libreofficekitStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Iaa166a248f5c1e9fcf62834f65475265403e4322 (cherry picked from commit 4fdd5eff7d4e10eb0a709c79b30b7411e4297d42) Reviewed-on: https://gerrit.libreoffice.org/57574 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-04-20sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 83b7bfc0efefb3c77e5c59553320e98539250c62) sw lok: followup commit for change about scrolling to visible cursor Revert small part of this commit: 83b7bfc0efefb3c77e5c59553320e98539250c62 Thanks Jan Holesovsky to catching it. Change-Id: I885c9f3da622052685d1e46f6358783fc7f8cb9a Reviewed-on: https://gerrit.libreoffice.org/52684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 508013d799358bb1c92b5cfea5257fe53c695cee) Reviewed-on: https://gerrit.libreoffice.org/53178 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2018-03-27lokdialog: debug red-colored boundary for last painted regionPranav Kant
Easier to see what's going on inside the LOK dialog. Change-Id: I59974200af3d2356b7c27eb3dd4032a59c00dbed Reviewed-on: https://gerrit.libreoffice.org/51263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 859b7b09f5b1330b7135744795c578358736ded3)
2018-03-27lokdocview: new property 'is-initialized'; fix gtktiledviewer for calcPranav Kant
there's no lokdocview property to tell if the doc has been completely initialized (initializeForRendering() has been called, etc.). This new property takes care of that which we now use to ignore configure event fired before document is initialized for rendering. Configure event handler queries document for row/col header which asserts because some values hasn't been initialized yet. Change-Id: I58385b2cb56bf317fe20ecf0570b7095f7260174 Reviewed-on: https://gerrit.libreoffice.org/51156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit f495a324921589d731d7d16f4554e36d4230476b)
2018-03-25Fix build, for real this timePranav Kant
Add a few missing processEventsToIdle()'s in the tests. Let's disable one of the assertion until I figure out what's going on. Change-Id: I82cbe443b4013d4402151ddae4b06044dfb394bd (cherry picked from commit 25ca8af596342ed254eb793ad1b8d47a86be4d40)
2018-03-20LOK: support tile-dumping in tilebenchAshod Nakashian
And other improvements. (cherry picked from commit b7d893d8a1ecb24290c4470e12d71caba2b85216) Reviewed-on: https://gerrit.libreoffice.org/46678 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 0e7ccbdd559df3a446e73c367b12824c6c143579) Change-Id: I5a27d6d2df5f946a708dd3b0b4fef8159da86e5c Reviewed-on: https://gerrit.libreoffice.org/46985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 62c36eb8c600fe328954c22d83b6f8dda57d5d15)
2018-03-20LOK: tilebench improvementsAshod Nakashian
* Arguments for max number of parts and tiles to render (optional). + Automatic estimation of maximum tiles to render based on max parts for Writer docs, since there is only 1 part, this caps the number of pages to render, similar to other doc types. * Fixed rendering of Writer documents over and over (as many times as pages). + Writer has a single part, unlike other doc types. + No point in rendering the whole document in writer to a single tile, since that's completely unrealistic and impractical (it takes forever for large docs and artificially spikes the memory). * Rendering starts at the current part and not the first. + This gives the spreadsheet of interest priority (if saved as visible). * The tile size is now more realistic as we use the same dimensions as the Online client does. * When rendering tiles at scale, we use the same dimensions as the Online client rather than splitting the width by 4, for realism. * Rendering of tiles is done rows-first, rather than columns-first, which is similar to what the Online client does, which is more cache friendly, therefore more realistic. * Enabled compiling of tilebench when GTK3 is disabled, which was erroneous, since tilebench doesn't have any dependency on GTK. + Now it's possible to compile with local Cairo/Pixman libs. Reviewed-on: https://gerrit.libreoffice.org/44936 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 7db98521548de9eab955ee25a5aacaaef42df323) Change-Id: I6ad2e97f39572778dd7d0c12d14550841c1d6963 Reviewed-on: https://gerrit.libreoffice.org/46984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a692cdf779dc998f58ebf9e9f84f22edf7dbe421)
2018-03-19lokdocview: Handle INVALIDATE_HEADER cbPranav Kant
With this calc gtktiledviewer or any other lok client shouldn't crash anymore when a new view is opened. And while at it, update documentation of callbacks. (cherry picked from commit 71cd37fad9792038279969c82e0cb209df06f024) Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b
2018-03-19lokdialog: If we already have the title, emit it during creationPranav Kant
Some dialogs load the UI before we "Execute()" the dialog, or before the dialog fires the InitShow event. In those cases, the title event has already been fired and won't be fired after dialog is created. Make sure that we send the title for such dialogs. Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4 (cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d) (cherry picked from commit 49a58e6e735a90532720f74c8d255056cd018a1a)
2018-03-19lokdialog: gtv: Set dialog title on callbackPranav Kant
Change-Id: I6d96a9e2287afdcaad2f770e4b4c73d3671fc76b (cherry picked from commit f0a6fd58575ff6b9ebbfb0835aa8694923ddbffd) (cherry picked from commit 40990006eafa161ad509c4646a80fd28770e2914)
2018-03-19lokdialog: multiview: Do not mix one view with otherPranav Kant
In GTV, use correct application window object to fetch the dialog object. Use correct view shell to notify window (dialogs, etc.) callbacks. Change-Id: I7d82b39d4522a4b4904e156757a032c342c71efb (cherry picked from commit 727c2303cb70a62a35f2e7ff7cd47cdb3ccd556d)
2018-03-19lokdialog: Merge dialog & dialog child mouse event APIs into onePranav Kant
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca (cherry picked from commit b1bcc70d2a5a51d2cb4b2e9e2a8e6641719fe18b)
2018-03-19lokdialog: Rename postDialogKeyEvent -> postWindowKeyEventPranav Kant
Change-Id: I78b434106fbef153adde255d4fcc8f74a7169175 (cherry picked from commit ae412b57e3f7866e24b120f0afb8ac80618a8d07)
2018-03-19lokdialog: Simplify; make the LOK dialog API more genericPranav Kant
Merge the dialog floating window callbacks and function calls into one. Unique window ids across vcl::Window is enough to distinguish between them. Floating windows don't have a LOK notifier as they are created in the vcl itself (so we can't access them from sfx2). Use the parent LOK notifier in that case (which would be a dialog). This API should also help in autopopup filter tunneling later. (cherry picked from commit b5e27fd809845577a90cc1811de062c070110078) Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
2018-03-19lokdialog: Do not underestimate the dialog sizePranav Kant
Some of them like, EditStyle, can be much bigger. Change-Id: Iaad02fadba18846976b959369f06e2020feffc6f (cherry picked from commit 3d8154ec427777eadf5719f194662e5ade78fae5)
2018-03-19lokdialog: Allow closing a dialog from LOK clientPranav Kant
... and rename paintDialog -> paintWindow before it's too late. We not only render dialogs now but also popups. Change-Id: I6b1253c4d9be0c79199b683df4413658a461f850 (cherry picked from commit 2f2679a56c0ae5dbcab6a0e6aa523587ecdc84fe)
2018-03-19gtv: Width, height properties should not be construct onlyPranav Kant
Change-Id: I2d1b29f52c1fe0449cf9afe47c509ef6250804a8 (cherry picked from commit cc05f8d9d27a8b28421a91cbfb059898d9619974)
2018-03-19gtv: Remember recently executed UNO commandsPranav Kant
Saves the recently executed UNO commands in a temp file and make it accessible to user in a combo box. Useful when debugging. Change-Id: Ic66961a388cc59dee3f65cb8d4de3c29a8a75eaa Reviewed-on: https://gerrit.libreoffice.org/45540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 0d5ccc4eb114117b11f7ec53a2c75f9efcb4c651)
2018-03-19lokdialog: Remove getDialogInfo + update gtktiledviewer accordingly.Pranav Kant
Change-Id: I6f810c97f2fadd3b1ea602a97e24c8b42f4a84b9 (cherry picked from commit d0f0a3c289c269476e1724f5b6bb527210121c3d)
2018-03-19gtv: Kill dialog selector combo boxPranav Kant
Change-Id: I2cd27dff95f2bc49a15ab395b8282b5496e1e229 (cherry picked from commit faf01731b20b96c2863b7a26277472cb47bb544a)
2018-03-19lokdialog: Make vcl::DialogID an integerPranav Kant
This will help launching multiple instances of dialog from multiple views. The earlier approach of using the UNO command strings as dialog id would not have been useful for multi-view case. Change-Id: I01cfb3c8b204d5654df2417efdac6b50dc920f0e (cherry picked from commit f3f4c039072657739d2bedb7210f2a22b85fdb55)
2018-03-19lokdialog: Create dialog when callback is receivedPranav Kant
With this, we do away with initial approach of rendering the dialog on a large surface. We now create the cairo surface with dimensions of the dialog. Change-Id: Icb034693c7f1c656b7daae7f5c711b5bd4d8e880 (cherry picked from commit 2798e1aae5311094c30d8e667c1e8be4e4314f8d)
2018-03-19lokdialog: gtv: Add width and height props to Dialog GObjectPranav Kant
Change-Id: I488a94d9c6cefd37624f755c6308f0b75595df84 (cherry picked from commit 91b7c8bb605dfc8090922d765b9ac4cffef973fe)
2018-03-19Revert "Revert the incomplete dialog tunneling, the API has changed ..."Andras Timar
This reverts commit 9364ae836e6975da64abf87eb7c2b02e601e69db. Change-Id: I88e09818149871a8e3130d4e87ec4e14b080ecb5
2018-01-05lokdocview: use std::string where possiblePranav Kant
This also prevents an invalid memory access: we were storing the pointer to a temporary in the struct and then using it after temporary was gone. Change-Id: I2b6d9df16bc24b222095ccbf45c9f0bd9c86ed65 (cherry picked from commit 9d2e0d60c0381a4bb23fada14c80e032b68bf2a8) Reviewed-on: https://gerrit.libreoffice.org/46949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-22lokdocview: Handle INVALIDATE_HEADER cbPranav Kant
With this calc gtktiledviewer or any other lok client shouldn't crash anymore when a new view is opened. And while at it, update documentation of callbacks. Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b (cherry picked from commit 71cd37fad9792038279969c82e0cb209df06f024) Reviewed-on: https://gerrit.libreoffice.org/46950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-22rhbz#1527945 segv on failed open of password protected doc in gnome-documentsCaolán McNamara
Change-Id: I1bec502ae20d03214c673d8911792c89669c0fe9 Reviewed-on: https://gerrit.libreoffice.org/46922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-21Revert the incomplete dialog tunneling, the API has changed completely.Jan Holesovsky
Change-Id: I50fb8c83365cefb8c8e76096fe257d31970a68b4 Reviewed-on: https://gerrit.libreoffice.org/46927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-14gtktiledviewer downgrade min gtk+ to 3.16Ashod Nakashian
Change-Id: Ieb964ec1bbdeb632bd771db9b773f64b78107fc5 Reviewed-on: https://gerrit.libreoffice.org/44724 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Move getting dialog information in separate LOK callPranav Kant
Using outparameters to get the dialog information with the paintDialog call was quite confusing. Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2 Reviewed-on: https://gerrit.libreoffice.org/44473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Support painting parts of the dialogPranav Kant
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-30Fix typoAndrea Gelmini
Change-Id: I51351518d4df9fbe44f70cbcea92b360f1acc94a Reviewed-on: https://gerrit.libreoffice.org/44060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-28lokdialog: Tunnel dialog title to lokclient as outparamPranav Kant
Change-Id: I1beb5ab3f06debdca7ebf999af7ac879a41ea47e Reviewed-on: https://gerrit.libreoffice.org/43959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28lokdialog: Clear the pointer after destroyingPranav Kant
Change-Id: Iebbe3fab6f6144f0cf1de9a1c45a0b2a62b07e0b Reviewed-on: https://gerrit.libreoffice.org/43958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-24fix build errorDavid Tardon
Change-Id: I1e65f075a0519db86836b3aa09848178796a020b
2017-10-23loplugin:includeform: libreofficekitStephan Bergmann
Change-Id: I58a78a6339a0c8ef1b509604e8b79a339497cf8f
2017-10-20tdf#113311 disable CppunitTest_libreofficekit_tiledrendering for nowMichael Stahl
Change-Id: I0f6e284d232388019bfa33f07a4afc864e0040a9
2017-10-02Fix typosAndrea Gelmini
Change-Id: I325141f90104496c62af8704d75568df3418952a Reviewed-on: https://gerrit.libreoffice.org/43050 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-02lokdialog: Smoother mouse move on floating windowsPranav Kant
Do away with an early hack to create the floating window with every invalidate. This gets rid of persistent blinking when moving the mouse over a listbox, for example. Change-Id: Ida9367156605edc9835529f83529363ad97beaee
2017-10-02lokdialog: button press type debug infoPranav Kant
Change-Id: I193e0ab82e998905b670f7de73daae784de3ef00
2017-10-02lokdialog: Emit dialog close callback upon dialog closePranav Kant
Change-Id: I4ccef76cc3b2926dd8916f825671bb732e101027
2017-10-02Change CB_DIALOG_INVALIDATE to CB_DIALOGPranav Kant
We can specify whether it is an invalidation or something else in the payload. Change-Id: I95c5fc0a0a88b5277eaa93c8d1f9b937bddce7b3
2017-10-02lokdialog: Mouse events for dialog floating child windowsPranav Kant
Change-Id: I06a081835d246f752e57f8cc289162ed31fc91d4
2017-10-02lokdialog: drawing area needs to have focus to capture key eventsPranav Kant
With this, key events successfully work now. Change-Id: I6dc6aff91dea08fcbc7ab840a77e2542ab9048ce
2017-10-02lokdialog: Move the floating window to its actual positionPranav Kant
gtk_window_move them to the position broadcasted to us by vcl Change-Id: Id27b52a24e721b51d7a153cc7c0e03197a99ee2f
generated by cgit (git 2.34.1) at 2024-06-29 09:00:14 +0000