Age | Commit message (Collapse) | Author |
|
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by
SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling
if the cursor is move by an other user.
The second instance in the LO online code, for it we need to pass the
viewid identifying the view which moved the cursor.
Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52
Reviewed-on: https://gerrit.libreoffice.org/52220
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 83b7bfc0efefb3c77e5c59553320e98539250c62)
sw lok: followup commit for change about scrolling to visible cursor
Revert small part of this commit:
83b7bfc0efefb3c77e5c59553320e98539250c62
Thanks Jan Holesovsky to catching it.
Change-Id: I885c9f3da622052685d1e46f6358783fc7f8cb9a
Reviewed-on: https://gerrit.libreoffice.org/52684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 508013d799358bb1c92b5cfea5257fe53c695cee)
Reviewed-on: https://gerrit.libreoffice.org/53178
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
|
|
Easier to see what's going on inside the LOK dialog.
Change-Id: I59974200af3d2356b7c27eb3dd4032a59c00dbed
Reviewed-on: https://gerrit.libreoffice.org/51263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit 859b7b09f5b1330b7135744795c578358736ded3)
|
|
there's no lokdocview property to tell if the doc has been completely
initialized (initializeForRendering() has been called, etc.). This new
property takes care of that which we now use to ignore
configure event fired before document is initialized for rendering.
Configure event handler queries document for row/col header which
asserts because some values hasn't been initialized yet.
Change-Id: I58385b2cb56bf317fe20ecf0570b7095f7260174
Reviewed-on: https://gerrit.libreoffice.org/51156
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit f495a324921589d731d7d16f4554e36d4230476b)
|
|
Add a few missing processEventsToIdle()'s in the tests.
Let's disable one of the assertion until I figure out what's going on.
Change-Id: I82cbe443b4013d4402151ddae4b06044dfb394bd
(cherry picked from commit 25ca8af596342ed254eb793ad1b8d47a86be4d40)
|
|
And other improvements.
(cherry picked from commit b7d893d8a1ecb24290c4470e12d71caba2b85216)
Reviewed-on: https://gerrit.libreoffice.org/46678
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 0e7ccbdd559df3a446e73c367b12824c6c143579)
Change-Id: I5a27d6d2df5f946a708dd3b0b4fef8159da86e5c
Reviewed-on: https://gerrit.libreoffice.org/46985
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 62c36eb8c600fe328954c22d83b6f8dda57d5d15)
|
|
* Arguments for max number of parts and tiles to render (optional).
+ Automatic estimation of maximum tiles to render based on max parts
for Writer docs, since there is only 1 part, this caps the number
of pages to render, similar to other doc types.
* Fixed rendering of Writer documents over and over (as many times as pages).
+ Writer has a single part, unlike other doc types.
+ No point in rendering the whole document in writer to a single tile,
since that's completely unrealistic and impractical (it takes
forever for large docs and artificially spikes the memory).
* Rendering starts at the current part and not the first.
+ This gives the spreadsheet of interest priority (if saved as visible).
* The tile size is now more realistic as we use the same dimensions
as the Online client does.
* When rendering tiles at scale, we use the same dimensions as the
Online client rather than splitting the width by 4, for realism.
* Rendering of tiles is done rows-first, rather than columns-first,
which is similar to what the Online client does, which is more
cache friendly, therefore more realistic.
* Enabled compiling of tilebench when GTK3 is disabled, which
was erroneous, since tilebench doesn't have any dependency on GTK.
+ Now it's possible to compile with local Cairo/Pixman libs.
Reviewed-on: https://gerrit.libreoffice.org/44936
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 7db98521548de9eab955ee25a5aacaaef42df323)
Change-Id: I6ad2e97f39572778dd7d0c12d14550841c1d6963
Reviewed-on: https://gerrit.libreoffice.org/46984
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit a692cdf779dc998f58ebf9e9f84f22edf7dbe421)
|
|
With this calc gtktiledviewer or any other lok client shouldn't crash
anymore when a new view is opened.
And while at it, update documentation of callbacks.
(cherry picked from commit 71cd37fad9792038279969c82e0cb209df06f024)
Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b
|
|
Some dialogs load the UI before we "Execute()" the dialog, or before the
dialog fires the InitShow event. In those cases, the title event has
already been fired and won't be fired after dialog is created.
Make sure that we send the title for such dialogs.
Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4
(cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d)
(cherry picked from commit 49a58e6e735a90532720f74c8d255056cd018a1a)
|
|
Change-Id: I6d96a9e2287afdcaad2f770e4b4c73d3671fc76b
(cherry picked from commit f0a6fd58575ff6b9ebbfb0835aa8694923ddbffd)
(cherry picked from commit 40990006eafa161ad509c4646a80fd28770e2914)
|
|
In GTV, use correct application window object to fetch the dialog
object.
Use correct view shell to notify window (dialogs, etc.) callbacks.
Change-Id: I7d82b39d4522a4b4904e156757a032c342c71efb
(cherry picked from commit 727c2303cb70a62a35f2e7ff7cd47cdb3ccd556d)
|
|
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca
(cherry picked from commit b1bcc70d2a5a51d2cb4b2e9e2a8e6641719fe18b)
|
|
Change-Id: I78b434106fbef153adde255d4fcc8f74a7169175
(cherry picked from commit ae412b57e3f7866e24b120f0afb8ac80618a8d07)
|
|
Merge the dialog floating window callbacks and function calls into one.
Unique window ids across vcl::Window is enough to distinguish between
them.
Floating windows don't have a LOK notifier as they are created in the
vcl itself (so we can't access them from sfx2). Use the parent LOK
notifier in that case (which would be a dialog).
This API should also help in autopopup filter tunneling later.
(cherry picked from commit b5e27fd809845577a90cc1811de062c070110078)
Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
|
|
Some of them like, EditStyle, can be much bigger.
Change-Id: Iaad02fadba18846976b959369f06e2020feffc6f
(cherry picked from commit 3d8154ec427777eadf5719f194662e5ade78fae5)
|
|
... and rename paintDialog -> paintWindow before it's too late. We not
only render dialogs now but also popups.
Change-Id: I6b1253c4d9be0c79199b683df4413658a461f850
(cherry picked from commit 2f2679a56c0ae5dbcab6a0e6aa523587ecdc84fe)
|
|
Change-Id: I2d1b29f52c1fe0449cf9afe47c509ef6250804a8
(cherry picked from commit cc05f8d9d27a8b28421a91cbfb059898d9619974)
|
|
Saves the recently executed UNO commands in a temp file and make it
accessible to user in a combo box. Useful when debugging.
Change-Id: Ic66961a388cc59dee3f65cb8d4de3c29a8a75eaa
Reviewed-on: https://gerrit.libreoffice.org/45540
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
(cherry picked from commit 0d5ccc4eb114117b11f7ec53a2c75f9efcb4c651)
|
|
Change-Id: I6f810c97f2fadd3b1ea602a97e24c8b42f4a84b9
(cherry picked from commit d0f0a3c289c269476e1724f5b6bb527210121c3d)
|
|
Change-Id: I2cd27dff95f2bc49a15ab395b8282b5496e1e229
(cherry picked from commit faf01731b20b96c2863b7a26277472cb47bb544a)
|
|
This will help launching multiple instances of dialog from multiple
views. The earlier approach of using the UNO command strings as dialog
id would not have been useful for multi-view case.
Change-Id: I01cfb3c8b204d5654df2417efdac6b50dc920f0e
(cherry picked from commit f3f4c039072657739d2bedb7210f2a22b85fdb55)
|
|
With this, we do away with initial approach of rendering the dialog on a
large surface. We now create the cairo surface with dimensions of the
dialog.
Change-Id: Icb034693c7f1c656b7daae7f5c711b5bd4d8e880
(cherry picked from commit 2798e1aae5311094c30d8e667c1e8be4e4314f8d)
|
|
Change-Id: I488a94d9c6cefd37624f755c6308f0b75595df84
(cherry picked from commit 91b7c8bb605dfc8090922d765b9ac4cffef973fe)
|
|
This reverts commit 9364ae836e6975da64abf87eb7c2b02e601e69db.
Change-Id: I88e09818149871a8e3130d4e87ec4e14b080ecb5
|
|
This also prevents an invalid memory access: we were storing the pointer
to a temporary in the struct and then using it after temporary was gone.
Change-Id: I2b6d9df16bc24b222095ccbf45c9f0bd9c86ed65
(cherry picked from commit 9d2e0d60c0381a4bb23fada14c80e032b68bf2a8)
Reviewed-on: https://gerrit.libreoffice.org/46949
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
With this calc gtktiledviewer or any other lok client shouldn't crash
anymore when a new view is opened.
And while at it, update documentation of callbacks.
Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b
(cherry picked from commit 71cd37fad9792038279969c82e0cb209df06f024)
Reviewed-on: https://gerrit.libreoffice.org/46950
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I1bec502ae20d03214c673d8911792c89669c0fe9
Reviewed-on: https://gerrit.libreoffice.org/46922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I50fb8c83365cefb8c8e76096fe257d31970a68b4
Reviewed-on: https://gerrit.libreoffice.org/46927
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: Ieb964ec1bbdeb632bd771db9b773f64b78107fc5
Reviewed-on: https://gerrit.libreoffice.org/44724
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
|
|
Using outparameters to get the dialog information with the paintDialog
call was quite confusing.
Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2
Reviewed-on: https://gerrit.libreoffice.org/44473
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
Pass the dimensions of the region to the paintDialog call to paint only
that much of the region in the dialog.
The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in
the payload that tells the region of the dialog invalidated. It can be
used in combination with the new paintDialog call then to paint only the
invalidated region in the dialog.
Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906
Reviewed-on: https://gerrit.libreoffice.org/44472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I51351518d4df9fbe44f70cbcea92b360f1acc94a
Reviewed-on: https://gerrit.libreoffice.org/44060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I1beb5ab3f06debdca7ebf999af7ac879a41ea47e
Reviewed-on: https://gerrit.libreoffice.org/43959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: Iebbe3fab6f6144f0cf1de9a1c45a0b2a62b07e0b
Reviewed-on: https://gerrit.libreoffice.org/43958
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
... not the frame id from the .ui file
Remove temporary hacks introduced earlier in GTV also.
Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c
Reviewed-on: https://gerrit.libreoffice.org/43957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
|
|
Change-Id: I1e65f075a0519db86836b3aa09848178796a020b
|
|
Change-Id: I58a78a6339a0c8ef1b509604e8b79a339497cf8f
|
|
Change-Id: I0f6e284d232388019bfa33f07a4afc864e0040a9
|
|
Change-Id: I325141f90104496c62af8704d75568df3418952a
Reviewed-on: https://gerrit.libreoffice.org/43050
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Do away with an early hack to create the floating window with every
invalidate.
This gets rid of persistent blinking when moving the mouse over a
listbox, for example.
Change-Id: Ida9367156605edc9835529f83529363ad97beaee
|
|
Change-Id: I193e0ab82e998905b670f7de73daae784de3ef00
|
|
Change-Id: I4ccef76cc3b2926dd8916f825671bb732e101027
|
|
We can specify whether it is an invalidation or something else in the
payload.
Change-Id: I95c5fc0a0a88b5277eaa93c8d1f9b937bddce7b3
|
|
Change-Id: I06a081835d246f752e57f8cc289162ed31fc91d4
|
|
With this, key events successfully work now.
Change-Id: I6dc6aff91dea08fcbc7ab840a77e2542ab9048ce
|
|
gtk_window_move them to the position broadcasted to us by vcl
Change-Id: Id27b52a24e721b51d7a153cc7c0e03197a99ee2f
|
|
Now gtktiledviewer can show floating window dialog widgets when user
clicks any of such widget in the dialog.
Change-Id: I13d756f236379bc8b2041ed41cb7b502f7fd9b24
|
|
Change-Id: Icfc210b08c7f1d8ebaf9c731ed64bb128cfc4356
|
|
Change-Id: I1d744c91f01eb098e9273d2459b63a5444558f39
|
|
For now, temporarily trigger paints for all the opened
dialogs whenever a dialog invalidation callback is emitted. This solves
the problem for some of the dialogs where hard coded uno command, which
we are using as dialog IDs in GTV, doesn't match with the dialog id
contained in the payload of the invalidation callback.
With this SearchDialog, AcceptChangeTracking and few others are
responding well to mouse clicks and invalidate instantaneously while to
invalidate and repaint some other dialogs, one needs to refocus them.
Change-Id: Iac2acbda60c8e2d0eabe65440f3fbda3ef271d7a
|
|
The current implementation works well - the mouse events are properly
handled by the opened dialog changing the dialog states.
However, since the uno commands (dialog IDs) are different from what is
returned by LOK_CALLBACK_DIALOG_INVALIDATE, the invalidation doesn't
instantaneously, so one have to make the dialog window out-of-focus and
then again back to focus to trigger the paint and see the updated dialog
state.
The mouse coordinates are forwarded in pixels as of now.
Enable mouse GDK Motion mask too for mouse move operation.
Change-Id: Ia915f734e8cbf4586da2b70da5840fe1568b39bd
|