summaryrefslogtreecommitdiff
path: root/libreofficekit
AgeCommit message (Collapse)Author
2017-03-24lok: Forgotten file for the unit test.Jan Holesovsky
Change-Id: Id20c32c1451bd0144377821ffaacbbdeaecbe7bd
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
2017-03-20lok: Fix crash in paintPartTile() when the current view was destroyed.Jan Holesovsky
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e
2017-02-28libreofficekit: adapt README to realityMiklos Vajna
Change-Id: I7098e5c304a0fa945e3d3ba794be2b7932788c74 (cherry picked from commit 28974126aa02d98b1808fd8fc01bc45f9a407a90)
2017-02-28gtktiledviewer: Different reply uno command for impressPranav Kant
Change-Id: I9dcd32a7e64198ca4772f263ed89a458e298c53b (cherry picked from commit 57d75ba3176063249e27524a7c7e425b3a2e75b4)
2017-02-28gtktiledviewer: Id param is string nowPranav Kant
It was changed in ce96c5957c38384f8911d6307605c502eca0c644 Change-Id: I4cc1f90d85e31044306ab36eaeac9d4424d965c0 (cherry picked from commit c62d2317472e2a02c7ace08a2f8ecc4135a9ba2c)
2017-02-28gtktiledviewer: Adjust for different delete uno cmd for impressPranav Kant
Change-Id: I7fa82096298a8a7c9f586a1d3c06aa5852e6842e (cherry picked from commit 6a4bf88c581b7fc1b6303099c804235027fd9f3e)
2017-02-28gtktiledviewer: enable comment sidebar for all doctypesPranav Kant
Impress was the only doctype remaining which didn't have comments api yet, but now it does Change-Id: I4e287301e879dff1c29c26880305505466ceaba4 (cherry picked from commit 6b4103984f31b42c791800925328dda00f17f122)
2017-02-18gtktiledviewer: Different UNO command for calcPranav Kant
Change-Id: I229451bac7cf4c223efd3fa18c177d650d3f9954 Reviewed-on: https://gerrit.libreoffice.org/34327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 748361ada42ffef774a7cb68f704de0e9edb5639)
2017-02-18gtktiledviewer: This is a better place to change doc-specific controlsPranav Kant
Change-Id: Id8fbebe2f6e339120741ed3744b18f50941c995e (cherry picked from commit a6c4552e792f6ab20fae83d354b369defd3bb345)
2017-02-18gtktiledviewer: Kill CommentsSidebar's docConfigurePranav Kant
Move this code to initWindow too (cherry picked from commit 2d6ec9761df5fcd36dd0ce7964d1ae6876ec9943) Change-Id: I057d9b8f60b9da2c20b28901ab958f9fc2095df3
2017-02-18gtktiledviewer: Kill signalSize; move its code to initWindowPranav Kant
Change-Id: I8aa0a00768e074b016ea20680c67884f19fe26df (cherry picked from commit abef7dfae3d87f52464d1f0879927ffdcfd41656)
2017-02-18gtktiledviewer: Factor out per view code to separate functionPranav Kant
This code (populating part selector, part mode selector etc.) is something that needs to be executed for each view, not just the view that makes open_document call. Put all such code in initWindow function from now. Change-Id: Ibf9b12adb156258aa3cfdf959fffb541a88da529 (cherry picked from commit 786107e674877478b8c7fdc4e6b545c44ac6b6ac)
2017-02-18gtktiledviewer: Store author name of each viewPranav Kant
Change-Id: I9a5be9050f3bedd14b6b5602b51bf40da0a11175 (cherry picked from commit 2c622c188757143ecf2131210f34b1ca1b0c33e2)
2017-02-18gtktiledviewer: comment id can be a string too nowPranav Kant
Change-Id: Ia94041884b7fde5f6c104a41c77c6a3aa96b7be1 (cherry picked from commit f5f3103187545952babf7b7efbdebc7d969f0974)
2017-02-18gtktiledviewer: gtk version checksPranav Kant
There is no major harm in excluding these lines of code on platforms with older gtk. Change-Id: Ica3f1e2b4f60f0bab55254632663ace7b4c61d4d (cherry picked from commit 96f597acf70ce52f2bdb59c85dd052be54b8d629)
2017-02-18gtktiledviewer: Handle comment callback with Modify flagPranav Kant
Change-Id: I8333876cc4b540c385e316ce8dcbc5f7bd1f7902 (cherry picked from commit d1a5c549d7908ca4b73ab9562fb3517ca1b00050)
2017-02-18gtktiledviewer: Unused variablePranav Kant
Change-Id: I1bf8833041cf0e0a42aca1b6d851f6f4ca28d68f (cherry picked from commit c4b76c46db899776545fb7ea66abe1d708ffcef3)
2017-02-18gtktiledviewer: Mark reply comments with lightgreen backgroundPranav Kant
Change-Id: Ic6623ebc05f1a09d5fc1b6bae5fab149d98724ab (cherry picked from commit a9153b4e1c00f7e85e50c333fdba94cc5601acb8)
2017-02-18gtktiledviewer: Can edit comment from comment sidebar nowPranav Kant
TODO: Ideal would be to replace these buttons with a popover menu containing all the actions that can be taken on a comment Change-Id: Iec19e6c4a934394f84bcf4bb20cc14f207ef95be (cherry picked from commit bc713d0670b02c9f267fcf1e5f3373525bcda047)
2017-02-18gtktiledviewer: Can reply, delete comments from sidebarPranav Kant
... and put the sidebar in a scrolled window Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c (cherry picked from commit 464d9249d44d2b36d5334d42ad8b38aab62c3f47)
2017-02-18gtktiledviewer: factor out user prompt entry dialogPranav Kant
Change-Id: I282390f7319de2e24564e0122e8c0081235a0ef5 (cherry picked from commit 621e143c1c9c071e024e287a9d63fe16c7eb4f49)
2017-02-18lokdocview: 'comment' signal for comment callbacksPranav Kant
Change-Id: I82040893added83ff13395db3917b230ef6b01d5 (cherry picked from commit b3178e2fced804d37efc47fddb77b516ef8d2684)
2017-02-18gtktiledviewer: Comment dialog when tiled annotations are offPranav Kant
Change-Id: I6762baac6c387d968dc6ee94d3494907c817214c (cherry picked from commit 8b3ea2ad62fd781e2fe253ee0c2bb0ce143912f4)
2017-02-18lokdocview: Separate gobject property for turning off commentsPranav Kant
Pass --enable-tiled-annotations to gtktiledviewer on command line to turn comments on again, by default they are turned off now. Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e Reviewed-on: https://gerrit.libreoffice.org/33622 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 3616f875b014b7d58f81cd871ff7bbf9fd6c78d5)
2017-02-18gtktiledviewer: Comments sidebarPranav Kant
Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41 Reviewed-on: https://gerrit.libreoffice.org/33621 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 99a2a1f975da68c33ec213fab0f9cf75c31b49c8)
2017-02-17lok: Implement new callbacks for comment notificationsPranav Kant
Change-Id: I298183b295c68c4a39cb1f6fffe4b89b4eaee0f3 Reviewed-on: https://gerrit.libreoffice.org/33469 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 5f5073a84518e4a8660e0153c2e218fb75a85ec4)
2017-02-17lokdocview: Turn off annotations rendering herePranav Kant
Change-Id: Ia1ee4f54a05ab3daca62a78fe335e731e4cfc02d Reviewed-on: https://gerrit.libreoffice.org/33465 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 0f0164d647e01c2e7d2a42a0dd9d58d5e7b765d4)
2017-02-17gtktiledviewer: Make edit mode the default onePranav Kant
This is a testing tool, most of the time developers want to do something with the document to test some functionality, lets keep edit mode on by default and save them a second. Change-Id: I61bbd2b85054b7ebdd14e69ca170674e260368e5 (cherry picked from commit 18fe7c8687182a1c5e6e497ec433d57b010d2e55)
2017-02-17lokdocview: Handle keypad enterPranav Kant
Change-Id: Ia892c346d4a3c0a5439c7977963cc502d287e6f7 Reviewed-on: https://gerrit.libreoffice.org/33445 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 5128e503ba8f602d1fda47c89e5b6ee4be6b7029)
2017-02-17lok: Listen for state change events for cell alignment commandsPranav Kant
We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit a27e09079596eeae81cced01eaeabf94d6675085)
2017-02-17gtktiledviewer: Lets avoid using manual buffer sizesPranav Kant
Change-Id: I76e70ccb5b1f40193a1eda1cbca19b3444168dae (cherry picked from commit 29f697711e06b88fb8387518e7f8440cf49f0933)
2017-02-17gtktiledviewer: Override alignment buttons uno commands for calcPranav Kant
Use .uno:HorizontalAlignment instead of .uno:XXXPara for calc Change-Id: I5af4fe62dc3075af4ba779499d062e6d91f21ecf Reviewed-on: https://gerrit.libreoffice.org/32773 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 6ccd698371a8e88ea06ed0e144171dd1b6236aa7)
2017-02-17gtktiledviewer: Support for posting arguments to uno commandsPranav Kant
Change-Id: I5db217b525d0f976ef6a7840e370f8f6a21d60cb Reviewed-on: https://gerrit.libreoffice.org/32772 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 3ab6e2783bf7142729924cb95ca730404d0c54e1)
2017-02-17lokdocview: Handle insert keyPranav Kant
Change-Id: Idb5ad17a3a94b9a6fba1113a759207c59acfb7bd (cherry picked from commit de6e3d1e87d0e620bcef115605404a76800600a9)
2016-11-10re-apply "use material style selection handles""Christian Lohmaier
and account for the libreofficekit changes This reverts commit 50e9065cbbb2c62fa925cf5b561a85c715a0eb1e. that did in turn revert 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3. Change-Id: Ie02d8743b3608120ed63bfe2a014fa4139577b01
2016-10-24revert string::find changesNoel Grandin
this reverts commit 610f59651563205564a0f4818b5c1d347ca02132 fix "cppcheck:stlIfStrFind" and commit 5c1bb338ef0d781648d5b33ffc9d64c2be6d9926 cppcheck:stlIfStrFind which are deficient in one way or another, the original logic, while inefficient, is still most accurate Change-Id: I4907d2569c9c2976533f8ac9f4b8b45eb1807b72
2016-10-24fix "cppcheck:stlIfStrFind"Noel Grandin
in commit 5c1bb338ef0d781648d5b33ffc9d64c2be6d9926, compare does not do a startswith Change-Id: If518b3f6880848a5b5463c09fb73974d972010fd
2016-10-24cppcheck:stlIfStrFindJulien Nabet
Change-Id: Ic3c1b37b0c2cf9995e0bd1017cdbaed427fb296c Reviewed-on: https://gerrit.libreoffice.org/30185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14LOK: handle "EMPTY" invalid tile msg with part number in payloadMarco Cecchetti
What's new: 1) RectangleAndPart handles "EMPTY" payloads 2) LOK_CALLBACK_INVALIDATE_TILES msg type with "EMPTY" payload are handled in CallbackFlushHandler::queue 3) gtktiledviewer handles "EMPTY" LOK_CALLBACK_INVALIDATE_TILES msg even if the part number is included in the payload Change-Id: I21f4a71ec875d24f4bbd100e4aacf8437d745ae4
2016-10-10Handle loplugin:fpcomparison false positives by whitelistStephan Bergmann
Change-Id: I58e2beb0695a27922856bd8f8988d9e4508aceb6
2016-10-01let approxEqual() not scale too early for large representable integer valuesEike Rathke
And since this is now too much code for inline move implementation to math.cxx Which again made it necessary to give libreofficekit lokdocview.cxx its own implementation that doesn't even claim to build against sal ... Change-Id: I0f80be9d9172ee20693b9babde715206f2c3d8c1 Reviewed-on: https://gerrit.libreoffice.org/29428 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4
2016-09-23gtktiledviewer: Wrap dialogs in a GtkScrolledWindowPranav Kant
Change-Id: I33be18779ea680f7a9c20814ca3c3d94d206900b
2016-09-21lok::Document::getCommandValues: expose sw redline author colorsMiklos Vajna
These colors are used in the tiles, so it's a good idea if the client can use matching colors for cursors and selections. But to be able to do that, we need an API to expose these colors. Change-Id: Ia688c07e6c300fecdf8dc428d5a3f000d1857387
2016-09-20lokdocview: guard against int overflowMiklos Vajna
If a too large rectangle is parsed, the width or the height may be larger than std::numeric_limits<int>::max(), in that case just set width/height to that max value, instead of allowing an overflow. Change-Id: Ic01319b01a3f9286501c346ea765868be57466a1
2016-09-19sw: emit LOK_CALLBACK_STATE_CHANGED when cursor enters/leaves a redlineMiklos Vajna
For now only care about the start of the cursor, which can be only at a single redline. Add matching testcase + expose it in the gtktiledviewer status bar for interactive manual testing. Change-Id: Ib61757412d6b54bef64361d4a8563795ca0bab6c
2016-09-16lok::Document: rename getViews() to getViewsCount()Miklos Vajna
As this only returns the number of views, not the actual views. Since it's a rename, it's just an API (but not an ABI) change. Change-Id: Ib4f0ea56a90e5ae9c80ee1781aa2f29aff4259e7
2016-09-15sw: allow select of redline by indexMiklos Vajna
Previously .uno:NextTrackedChange always worked by cursor position, but redlines are stored in the redline table, so they have a unique index. Allow specifying that index when invoking the command, and in that case ignore the cursor position. Change-Id: I7dbe8044feca8fcc48635482a22317b024f40ffa
2016-09-12gtktiledviewer - Calc fix: selection handlers were not removedMarco Cecchetti
Change-Id: I2b4ad4dbf281458d0994eff176a2f62e20fb603b