Age | Commit message (Collapse) | Author |
|
So a view can be aware where cursors of other views are.
Change-Id: I6133fb55aa2869843c0284b7d76264bab3b3d5da
Reviewed-on: https://gerrit.libreoffice.org/26513
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
This fixes the following problem:
- createView() = 1
- createView() = 2
- destroyView(1)
and then view #2 was renumbered to 1.
Instead expose the pointer address of the SfxViewShell as the ID, which
is not changing in such a situation.
Note that the SfxViewShell <-> ID mapping is an implementation detail of
SfxLokHelper, and only pointers are converted to IDs, user-supplied IDs
are never converted back to pointers.
Change-Id: If79ef8b99ba391011b5d82b219ad13447d44cd5a
Reviewed-on: https://gerrit.libreoffice.org/26423
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Its purpose was to allow incrementally migrate all callers of
SdrModel::libreOfficeKitCallback() to use
SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only
the currently active or all views) instead. That is done by now, so it
can go.
Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3
Reviewed-on: https://gerrit.libreoffice.org/26413
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
This requires porting the sw/sd/sc_tiledrendering test code to the new
internal API, as only the public LOK API is unchanged.
Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9
Reviewed-on: https://gerrit.libreoffice.org/26379
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
... to fire desired UNO commands from a dialog. Helpful when you
need to check some arbitrary UNO commands not supported via UI
yet.
Change-Id: I55df75ef235f5eb6922c50619610caf1c88241fb
|
|
Not all buttons are toggle buttons.
Change-Id: I6cddc619f3f760e447ea3ffea07f776e03cdaab9
|
|
Otherwise the following can happen:
- view #0 is created
- view #1 is created
- view #1 changes part, so lok_doc_view_reset_view() gets called
- view #1 calls postMouseEvent(), but claims it happened on view #0
Also log all setView() calls in the widget.
Change-Id: Iefcf82d9396b2af75586e79dde59998320f41d60
Reviewed-on: https://gerrit.libreoffice.org/26245
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Need to populate it & register handlers for the non-first windows as
well.
Change-Id: I27231027c3f33fb081768c51ecc291b9f2a7e99b
Reviewed-on: https://gerrit.libreoffice.org/26225
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
It's a GtkToolButton, but not a GtkToggleToolButton, so don't cast
command buttons down unconditionally.
Change-Id: Ie7c9bdf6fa8725363e40c1544f4e1e835a559f3a
Reviewed-on: https://gerrit.libreoffice.org/26171
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Icdb14e9a5fedb3dcfbad502e323b333c3dbcc534
|
|
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
|
|
Change-Id: Idd4db9259448d3dcf4e0820b8845a1ab395f0bff
Reviewed-on: https://gerrit.libreoffice.org/24427
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I36af712274e1a3f9dacd5d62ab42032ca9e9acdd
Reviewed-on: https://gerrit.libreoffice.org/24390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
...which takes a raw filesystem pathname that is internally converted to a file
URL (similarly to what is supported for the INIFILENAME and URE_BOOTSTRAP
bootstrap variables in rtl::Bootstrap). That way, the gtktiledviewer executable
doesn't need to try convert a pathname into a URL.
Also adapted various parameter names to make it obvious that URLs get passed,
not pathnames.
Change-Id: I33ab31fe142d94ee47885033ef48278ef5ff55a2
Reviewed-on: https://gerrit.libreoffice.org/24241
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
So that users of the widget can use a custom user profile, allowing
running widgets users and LibreOffice in parallel.
Change-Id: I1bd0a8e53aa3216adc721052cf30f0dd174327bd
Reviewed-on: https://gerrit.libreoffice.org/24237
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I0968689630e10f838c075e86357eb36a9a220d0d
|
|
...in LibreOfficeKintInit.h's lok_loadlib, now that RTLD_GLOBAL isn't only
needed for UBSan (62b124b2704adf11a63681164d05a8eb49dfb105 "Ensure RTTI symbol
visibility for Linux Clang -fsanitize=function,vptr") but also for
-stdlib=libc++ on Linux (see
<https://whatofhow.wordpress.com/2016/03/01/libclibcabi-on-linux/>).
Change-Id: I24ed6612c3d922eba695423d46af5635c77f7077
|
|
Change-Id: I6d71071371ef54f70613246162c893daa56b7bb9
|
|
Change-Id: I35fda96885375996a1b0b05ecc04a0ac35104b88
|
|
This can happen when no document has been loaded yet.
Change-Id: Ib9c18e22b6c344528d05eb781bf9b3052060089a
|
|
Change-Id: I189d33cd25f394f5740d54fb5fe5567ac71299e4
|
|
Change-Id: Iffbe71ab161d5c50a98fd17ee0fdd0ab4d065e9d
|
|
Change-Id: I891519d54212ecd99273a54aca2a44e2d54c1933
|
|
Change-Id: Id6cf77ee7597fb992a306649c2f2a3639bf6dad8
|
|
Don't crash then.
Change-Id: I4980fe4ea56e023cbf303fa43d1e6b383d983d2e
|
|
Change-Id: I3e86b57b6384370666f023115ae7d4671f1eaca1
|
|
Change-Id: I996dc17ba0c01bf23283687dffb563b0eac3a31a
|
|
Change-Id: Ifb48dc528e95519097477faf79b10e3e7637869d
|
|
Find code that compares floating point values with == or !=
It should rather use rtl::math::approxEqual
Change-Id: I9026e08823340fa1d6a042c430515344c93215bd
Reviewed-on: https://gerrit.libreoffice.org/21997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If7c84a7b24f2072439718fb0c473b73243f2ecc1
|
|
Change-Id: I606a1112c8eb4c1cc4596d6947ce1223543cc87c
Reviewed-on: https://gerrit.libreoffice.org/21861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
... and implement it in Writer.
Otherwise there is no way we can perform e.g. page down in an expected
way. Without this, the core visible area depends on the zoom in the
document, and the client visible area can be something entirely
different.
Change-Id: Iadfb5a225da09a2551ffa41ddf503bb3d22b3eae
|
|
Change-Id: Ib63959ad64fe52b648e0c0d3fe6d49fb282d57ee
|
|
This is similar to what is implemented in online.git's leaflet. If the
zoom factor changes, then inform LOK about it on the first keyboard hit.
Change-Id: I2db4ffed3897db5c852f4b8aea8f4e2d3500a25a
|
|
Change-Id: I16e7c0fee34077d5bbb493d9d9502ff82355c2c6
|
|
Change-Id: I4930837c2a5bd78c16a83dcccde34843d3026618
|
|
Add setOptionalFeatures() function that clients must call during
initialization, and enum LibreOfficeKitOptionalFeatures.
Change-Id: I73035193c87033052921c3aad94fdc057fe81111
Reviewed-on: https://gerrit.libreoffice.org/21809
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I3b3b0c0e64965280c24842b0cf70a21b8abb4dfb
|
|
Change-Id: I119633474236faa95ecf5fd26cd89789b313e382
|
|
Change-Id: I7706fe40705bc74bcebd53b58239c4b159bab7c0
|
|
Change-Id: Ifaf96dee8b6554282f6a19ac6d6e0d14318aa1f4
|
|
These buttons, such as, bold, italic, underline, paste, doesn't
make any sense in view-only mode. Lets make them insensitive in
view-only mode.
Change-Id: I194f6a4d707b72d1d6aa3967aa526092445f0926
Reviewed-on: https://gerrit.libreoffice.org/21642
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I8d7f8ffb1c5ddd07ccf7d56bdf0ccc866c927401
Reviewed-on: https://gerrit.libreoffice.org/21624
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Pranav Kant <pranavk@gnome.org>
|
|
Now since, LOKDocView has started to get clients, we need to ship
all of its dependencies with the widget.
Reviewed on:
https://gerrit.libreoffice.org/21605
Change-Id: I874eb416587a80b7760c5f00183d6004dfca4cce
|
|
Change-Id: I0e7783cf73d2d4bfcd4f0c75ca3ad82336048b27
|
|
A GError needs a valid GQuark as the domain. Passing 0 leads to:
GLib-WARNING **: (gerror.c:408):g_error_new_valist: runtime check
failed: (domain != 0)
Change-Id: I2f252eaa83a1519b5d16c7ba22c8f593732807ca
Reviewed-on: https://gerrit.libreoffice.org/21261
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Pranav Kant <pranavk@gnome.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I83ce360622eea0fb805833650c0d2126bcd5d8db
|
|
Change-Id: Ibee485909dca1ea4a3774fca7a840afbf2d9883c
Reviewed-on: https://gerrit.libreoffice.org/20819
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I13de7e6eae4e73932e8441ba2e2ad3e4ff888f41
Reviewed-on: https://gerrit.libreoffice.org/20799
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I481b402e0d3b42de5b486a159acb8a25e345b8b8
|