summaryrefslogtreecommitdiff
path: root/lingucomponent
AgeCommit message (Collapse)Author
2017-02-25Clean up use of integer typesStephan Bergmann
Change-Id: I06364be5bbbe7862d20ea24ee155cf468f63f0b0
2017-02-20Prefix membersKhaled Hosny
Change-Id: I342ac49877c928c52eb3001f5a7bab07588636fa Reviewed-on: https://gerrit.libreoffice.org/34463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-20loplugin:dynexcspec (macOS), lingucomponentStephan Bergmann
Change-Id: I11f7419babd1ceb158ab0a329dd3d8699b7b2702
2017-01-19New loplugin:dynexcspec: Add @throws documentation, lingucomponentStephan Bergmann
Change-Id: Iebd0a98c86803342ee54f30c848e7194a752335f
2016-12-15fix collisionCaolán McNamara
Change-Id: I73371e19877a8b192b188c1c6367ba0d391530df
2016-12-15hunspell defines this for some time nowDavid Tardon
Change-Id: I5cd3cd11f24bee87266822ec13e64132ee470d6a
2016-12-15fix build with hunspell < 1.5David Tardon
Change-Id: I66810d2bf9bbd08990dd8e995e34c50caa472ff8
2016-12-15if building against system hunspell < 1.5.4 > 1.4.0Caolán McNamara
Change-Id: I9ba1b9c3c0e3efb00538b2f3ed4fcffc29f9e931
2016-12-14update to latest hunspell 1-5 releaseCaolán McNamara
Change-Id: Ifb412506f2e36878d44d0e4f6360ae8d070ffa15 Reviewed-on: https://gerrit.libreoffice.org/28488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10Search for old style dictionaries in DICPATHJookia
When searching in system directories for old style dictionaries, also look in the DICPATH environment variable much like the Hunspell application does. This gives a lot more flexibility for users and packagers in finding dictionaries at runtime. The patch is simple, it just moves a block of code from GetOldStyleDics that handles searching a directory to a new function, GetOldStyleDicsInDir. Then if DICPATH is set, its directories are passed to the new function. Original system directories are also passed so dictionaries in system-wide directories are found. Change-Id: I56ac66539495f03f41376b533ca19c6c8d615ec3 Reviewed-on: https://gerrit.libreoffice.org/29543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-09-24we shouldn't need explicit lt_rtl_OUString, etc things anymoreCaolán McNamara
Change-Id: Ibeec3fcc353e07e61fb2c838b318e0a04081ce2c
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: If6d03fd0d3b5b69f3b07e697c4f6d7a3668ee69a
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-07-20The thesaruses are in mythes formatCaolán McNamara
Change-Id: Idf633d7d310c920ae605b7a1996d251352fad079
2016-06-20cppcheck: oppositeInnerCondition if new fails, its going to throwCaolán McNamara
not return nullptr Change-Id: I8f46e49b28fd9547fb3e32dca0c6b99ee2cd5c7d
2016-06-13Fix typosAndrea Gelmini
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-12Removed 'altstrfunc.cxx' and .hxxKrishna Keshav
renamed and moved 'start()' to it's only call site - as 'startsAsciiCaseInsensitive' lingucomponent/source/languageguessing/simpleguesser.cxx. moved inline bool to it's only call site - as 'isSeparator(const char)' from altstrfunc.hxx to lingucomponent/source/languageguessing/guess.cxx. Change-Id: Ic624ba3cab90bd454311219966c19fb550388da1 Reviewed-on: https://gerrit.libreoffice.org/24864 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-10tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav
replaced tolower with to AsciiLowerCase() in lingucomponent/source/languageguessing/altstrfunc.cxx l10ntools/source/gL10nMem.cxx Change-Id: I1340da18b263a4a921e2e8d96c0f133fe300086e Reviewed-on: https://gerrit.libreoffice.org/24682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22loplugin:salboolStephan Bergmann
Change-Id: I186376ceeb53126bc31d63d00a988be6cb7a5637
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Ia4afa4cc65215053ac44cc0b48e528064837c49e
2016-04-18try next hunspell 1.4.0 prerelease milestoneCaolán McNamara
try using reverse iterators here then and remove dictmgr which we don't seem to use or need Change-Id: I981fccc4ca7562d5ab707dc2f605e409169dec07
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-11tdf#94306 replace boost::noncopyable ...Jochen Nitschke
... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02Attempted fix for "Resolves: #i126762# Ignore dictionary not in specified...Stephan Bergmann
...location." Caused many crashed during "make check", when aLocaleNames is a sequence of 17 ("ar-SA", "ar-DZ", ...), but aLcoations merely a sequence of 2 (".../dict-ar/ar.aff", ".../dict-ar/ar.dic"). From comments further down below, it looks like aLocations will always contain exactly two entries ("also both files have to be in the same directory and the file names must only differ in the extension (.aff/.dic)"), and that all the aLocaleNames members share the same set of aLocations ("Thus here we work-around this by adding the same dictionary several times. Once for each of its supported locales"), so that it would appear to be OK to just check once for the existenceof aLocations[0]. (There is a check for if (aDictIt->aLocaleNames.getLength() > 0 && aDictIt->aLocations.getLength() > 0) below, so it might be that these can be empty, or it might just be "defensive programming." Play it safe, and check here that aLocations is not empty.) Change-Id: I82bea6571983e397a9e164b294a5ba656b511a67
2016-02-02Resolves: #i126762# Ignore dictionary not in specified location.Kay Schenk
Damaged "registrymodifications.xcu" causing problems with backups and spell checker (cherry picked from commit 983e71fa37e12fbae29eddc2b855ddaf6280cc0e) Change-Id: I279275e11fb2ee6a223c7905652165d1b7a2e0ac
2016-01-25OSX build fixeNoel Grandin
after my OInterfaceContainer2 change Change-Id: I9ac967ff474fe1a68876d8ffedbdcb94013a8119
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-18loplugin: unused return valuesNoel Grandin
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15loplugin:unusedmethods unused return value in l10ntools,linguisticNoel Grandin
Change-Id: I11571c25e527787a2054bc8106a27c44b8a96116
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-22loplugin:unusedfields in lingu,lotuswordpro,mysqlcNoel Grandin
Change-Id: I5866c8d95e04714e81a45e73bf00a430859a4327
2015-11-24cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Ia93c541ea21be89578789d58f642109184a18685
2015-11-16no need to take a mutex when only dealing with stack-local dataNoel Grandin
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65 Reviewed-on: https://gerrit.libreoffice.org/19979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann
Change-Id: I48e80668c76b7fb94dfa2876ae8ca5e895cea3be
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I1aa63ce279fe3914e0f5153b7d8559880a3fccc3
2015-11-04use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I11822c50fa66d038a3d6f38054ab35c2e613f077