summaryrefslogtreecommitdiff
path: root/lotuswordpro/inc
AgeCommit message (Collapse)Author
2019-04-10clang-tidy: Silence warnings from WIP unhandled-self-assignment checkTamás Zolnai
Where it can be done by removing useless / duplicate code. For XFListStyle I removed the copy operator entirely, because it was bugous and it seems not to be used anyway. Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22 Reviewed-on: https://gerrit.libreoffice.org/70482 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07use unique_ptr in LwpTools::GetSystemDateStyleNoel Grandin
Change-Id: I6ea90be5736982422aaa45c7147beec1cfd5430b Reviewed-on: https://gerrit.libreoffice.org/65918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07use unique_ptr in lotuswordproNoel Grandin
Change-Id: I49ae12639d1a5adab25407115cf65ebcfe3936c9 Reviewed-on: https://gerrit.libreoffice.org/65920 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-18Fix typoAndrea Gelmini
Change-Id: Ifdeeb0b5d8e07af3d38f57a70d6ac334dfc30d37 Reviewed-on: https://gerrit.libreoffice.org/65209 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-12-05loplugin:singlevalfields in lotuswordproNoel Grandin
Change-Id: I1fe56271bfcbbc8aba023047b0888f75dd6ce886 Reviewed-on: https://gerrit.libreoffice.org/64600 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-05loplugin:unnecessaryparen include more assignmentsNoel Grandin
Change-Id: I9fb8366634b31230b732dd38a98f800075529714 Reviewed-on: https://gerrit.libreoffice.org/64510 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-13loplugin singlevalfields improvementNoel Grandin
checking for casting to void* turns out to mask useful stuff, so remove that and just deal with a few extra false+ Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668 Reviewed-on: https://gerrit.libreoffice.org/63145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:unusedmethodsNoel Grandin
Change-Id: I73de303f93b3557881dbb84d6d11d89f193da010 Reviewed-on: https://gerrit.libreoffice.org/61868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16loplugin:singlevalfields in lotuswordproNoel Grandin
Change-Id: Iac507cb050c93367a8d5dd4cc33106f54c5d462f Reviewed-on: https://gerrit.libreoffice.org/61816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-26Fix typoAndrea Gelmini
Not so sure, but anyway, let's see what the gods say. Change-Id: I5abffb27f8d124c34b50a3591de1ffc8c64fa13a Reviewed-on: https://gerrit.libreoffice.org/60994 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-26loplugin:useuniqueptr in XFIndexNoel Grandin
but actually this object should be held by rtl::Reference Change-Id: Iabf068bd909201af5df6f987c6dcdb64679fefbd Reviewed-on: https://gerrit.libreoffice.org/60970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-09loplugin:simplifyconstruct in l10ntools..packageNoel Grandin
Change-Id: I8dba8ef1e7455af1e55bbd6086b49c0606bf4927 Reviewed-on: https://gerrit.libreoffice.org/60212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27lotuswordpro: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc.; and by removing explicitly user- provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non- deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already include, so why bother with non-inline functions.) Change-Id: I725d60235b72e4eec59809e2d09bfab9a2f7c416 Reviewed-on: https://gerrit.libreoffice.org/58097 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-23Fix typosAndrea Gelmini
Change-Id: If6e6df9ac592c77f19e381e50b7eb26fbf429f61 Reviewed-on: https://gerrit.libreoffice.org/57831 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-06-25loplugin:useuniqueptr in XFStyleManagerNoel Grandin
Change-Id: I6fccaef0778ce02fc6d6daaa2fdb31af9ea1c19f Reviewed-on: https://gerrit.libreoffice.org/56334 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25loplugin:useuniqueptr in LwpChangeMgrNoel Grandin
these should be held by rtl::Reference Change-Id: I135352dafc6ba0e274d344aec432fe4eabbafe97 Reviewed-on: https://gerrit.libreoffice.org/56333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-13Fix typosAndrea Gelmini
Change-Id: I9ae4a9d821946591060ceadb45af05c27560668b Reviewed-on: https://gerrit.libreoffice.org/55410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-03loplugin:useuniqueptr in XFStyleContainerNoel Grandin
Change-Id: I0a9765ab4107a534f211e3531f7948516f1a0c02 Reviewed-on: https://gerrit.libreoffice.org/52297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-22ofz#7063 ensure lifecycleCaolán McNamara
Change-Id: I18d62bc3bd409ca65c85ea47e8d5b3930481edf9 Reviewed-on: https://gerrit.libreoffice.org/51731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07Fix typoAndrea Gelmini
Change-Id: Iacb4f5f93f6b2b9a06148844210784045f09d053 Reviewed-on: https://gerrit.libreoffice.org/50850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-06ofz: memory leakCaolán McNamara
Change-Id: Ida561d59f5fbd2b4dff5d0ef355a21a344a2afd2 Reviewed-on: https://gerrit.libreoffice.org/50808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05loplugin:useuniqueptr in XFConfigManagerNoel Grandin
Change-Id: Ia442d2dba8c6fdf577c6cdc950d518cc863d6e0e Reviewed-on: https://gerrit.libreoffice.org/50741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in XFPageMasterNoel Grandin
Change-Id: I0255118c8b94c301e0be50cff358bfc77b84f834 Reviewed-on: https://gerrit.libreoffice.org/50753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in XFFrameStyleNoel Grandin
Change-Id: I812c9fc7ab297e962994265e69feb80f82adc49a Reviewed-on: https://gerrit.libreoffice.org/50752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in XFParaStyleNoel Grandin
Change-Id: I883c54698022d07dbcb72e66b1108178cf27a5ae Reviewed-on: https://gerrit.libreoffice.org/50751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in XFHeaderStyleNoel Grandin
Change-Id: Id1e29fde9d6dfcd3c816967272c80ace85d515cc Reviewed-on: https://gerrit.libreoffice.org/50750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in XFDrawStyleNoel Grandin
Change-Id: I91ade5500596765480940b82807504e5c3fafedb Reviewed-on: https://gerrit.libreoffice.org/50749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in LwpSpacingOverrideNoel Grandin
Change-Id: I1f71c1e35c49b99c9fde1fe43fc9f5717158355e Reviewed-on: https://gerrit.libreoffice.org/50737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in LwpGlobalMgrNoel Grandin
Change-Id: I04651e32dd036bc12ed12097e4ee3bf6e5bf3dcf Reviewed-on: https://gerrit.libreoffice.org/50725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in LwpFontNameManagerNoel Grandin
Change-Id: I900fd3205d8fd451bb587d3da795919a10128ad1 Reviewed-on: https://gerrit.libreoffice.org/50721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05loplugin:useuniqueptr in LwpFontTableNoel Grandin
Change-Id: I91fd833fe42123845cd958b814112c367d964402 Reviewed-on: https://gerrit.libreoffice.org/50720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-12ofz#6208 Indirect-leakCaolán McNamara
Change-Id: I8d6761bd951cc1ddd4a45eabb26428bc40c2271a Reviewed-on: https://gerrit.libreoffice.org/49600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12Fix typosAndrea Gelmini
Change-Id: Ia01f85e87706b02ffb816b3385765e2729dafa02 Reviewed-on: https://gerrit.libreoffice.org/49585 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-01loplugin:datamembershadow in XFCellStyleNoel Grandin
looks like the subclass member is never written to, so I'm going to assume this was a bug Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514 Reviewed-on: https://gerrit.libreoffice.org/49001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-31loplugin:datamembershadow in lotuswordproNoel Grandin
Change-Id: I50f37e09df6c4c7cbe697e3419731e637c980807 Reviewed-on: https://gerrit.libreoffice.org/49000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-21align typesCaolán McNamara
Change-Id: I6080d92ec26f9ee9bf3eb4319a36c10ae38caca2 Reviewed-on: https://gerrit.libreoffice.org/48253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-16ofz#5420 Out-of-memoryCaolán McNamara
Change-Id: I22166a14a03e5e803f8f032034e05a2da501379f Reviewed-on: https://gerrit.libreoffice.org/48008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-12More loplugin:cstylecast: lotuswordproStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idd6bd4f316b916877629579bf187d0f05251263d
2018-01-12ofz#5254 Bad-castCaolán McNamara
Change-Id: I318d441d841dd4c783f87ac2f3f699852e8b1039 Reviewed-on: https://gerrit.libreoffice.org/47796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-06ofz#4976 Integer-overflowCaolán McNamara
Change-Id: Iefba0ea6122bd9b1dde59f33c0c67077fecb7eca
2017-12-31loplugin:passstuffbyref improved return in lotuswordproNoel Grandin
Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682 Reviewed-on: https://gerrit.libreoffice.org/47222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-06loplugin:constparams in various(2)Noel Grandin
Change-Id: I533a7eb724b15e168a28dc92cd5962a39bc96e7c Reviewed-on: https://gerrit.libreoffice.org/44313 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-01loplugin:finalclasses in lotuswordproNoel Grandin
Change-Id: I09a570741f5801980ae07fb90835e543519df046 Reviewed-on: https://gerrit.libreoffice.org/44135 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: lotuswordproStephan Bergmann
Change-Id: I1ff35dd6242accf0a8e71086a14a72e85eef1c5a
2017-10-19Make include files found through -Ilotuswordpro/incStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: I4a666e8cd1cd3b1bf67af697be02879217dbc83a Reviewed-on: https://gerrit.libreoffice.org/43560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19use std::unique_ptr in lotuswordproNoel Grandin
Change-Id: I9f3e8de3284899376c7db55c3ea6f16023acc40f Reviewed-on: https://gerrit.libreoffice.org/43526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17Move lotuswordpro include files to common include directoryStephan Bergmann
...that are included from both lotuswordpro/source/filter and lotuswordpro/source/filter/xfilter. Change done in preparation of loplugin:includeform. Change-Id: I7b65d3232e164af662b7de5bb49d59597803d41c Reviewed-on: https://gerrit.libreoffice.org/43453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>