summaryrefslogtreecommitdiff
path: root/lotuswordpro/inc
AgeCommit message (Collapse)Author
2022-11-24loplugin:unusedfields make some fields privateNoel Grandin
this is one of the secondary analyses this plugin performs Change-Id: I1c496e234513362338600180e51f7e71e605a7cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-23clang-tidy modernize-pass-by-value in lotuswordproNoel Grandin
Change-Id: Ia20d653bdfedf49430f8ba46c8200c2b96734d81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-11new loplugin:trivialdestructorNoel Grandin
look for potentially trivial destructors that can then be elided Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-27Recheck modules [i-l]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I758bb27e93779e3df21c463714e49354748f446f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-16ofz#43689 Null-dereferenceCaolán McNamara
Change-Id: I6edb50b3c281d50187d8965ce9665a9aae0e9098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07ofz#43388 Direct-leakCaolán McNamara
Change-Id: I5d410461d7b4e8466533fc4186ee77ec99fae089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-14Use M_PI instead of defined value; use rad2deg()Hossein
* Replace defined values of PI with M_PI defined in <cmath> * Use M_PI_2 instead of PI / 2.0 * Instances could be found with: git grep 3.14 *.cxx *.hxx|grep define * One instance is ignored: sc/source/core/opencl/opinlinefun_statistical.cxx * Replace *(180 / PI) with basegfx::rad2deg() * Replace 2*PI/360 with basegfx::deg2rad() * Use atan2 instead of atan where it was more appropriate + atan2() handles all 4 quadrants + Extra conditions for different quadrants are removed Change-Id: I083ee2e1427cd36ba0b8c38e4fe5f782d6486075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-07forward decls go after #includeNoel Grandin
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11loplugin:moveparam in lotuswordproNoel Grandin
Change-Id: I122fc96930021dd3127d9c991e7dac3140b612f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-22Extend loplugin:stringviewparam to starts/endsWith: lotuswordproStephan Bergmann
Change-Id: Ia58c031d1157af271c664948946fa5d8d17a2323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I4298dfeafab0fe296a970fce024cc25572e3a2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27Related: ofz#27296 OOM std::map->std::vectorCaolán McNamara
dbgutil massif peak of 3.1G -> 2.7G GB 3.117^ # | :::::::::::::::::::::::# | ::::: # | :@::::: #: | :::@::::: #: | :::::@::::: #: | :::::::@::::: #:: | :::::::::@::::: #:@ | ::::::::::@::::: #:@: | :::::::::::::@::::: #:@: | :::::::::::::::@::::: #:@:: | :::::::::::::::::@::::: #:@:: | ::::::::::::::::::@::::: #:@:: | ::::::::::::::::::::@::::: #:@::@ | @:::::::::::::::::::::@::::: #:@::@ | @::@:::::::::::::::::::::@::::: #:@::@: | ::@::@:::::::::::::::::::::@::::: #:@::@: | @:::@::@:::::::::::::::::::::@::::: #:@::@: | ::@:::@::@:::::::::::::::::::::@::::: #:@::@:: | ::::@:::@::@:::::::::::::::::::::@::::: #:@::@:: 0 +----------------------------------------------------------------------->Gi 0 116.7 ---> GB 2.718^ : | @######: | @@@# ::: | @@@@# :::: | @@@@@@@# ::::: | @@@ @@@@# :::::: | :@@@@ @@@@# ::::::: | @::@@@@ @@@@# :::::::@: | @@@::@@@@ @@@@# :::::::@:: | @@@@::@@@@ @@@@# :::::::@::: | @@@@@@::@@@@ @@@@# :::::::@:::: | ::@@@@@@::@@@@ @@@@# :::::::@:::::: | @::@@@@@@::@@@@ @@@@# :::::::@:::::@: | @@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:: | @@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::: | @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:::: | @@@@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::: | @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@ | :@@@ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@: | @@:@ @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@:: 0 +----------------------------------------------------------------------->Gi 0 34.29 Change-Id: Id56615e554d07a76a6a87476a40cc6190c0555da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27we are going to remove the entire row anywayCaolán McNamara
so don't iterate over the cells explicitly dropping them Change-Id: If0de504ac9711d1e6a757cdd15574f15585ca928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26ofz#35646 Indirect-leakCaolán McNamara
Change-Id: Ie79d9c49b6beef04ab111a63166abc7f093ad36b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-26Revert "ofz#27296 Out-of-memory and ofz#27384 Indirect-leak"Caolán McNamara
This reverts commit c80c8ac4eb58812c1b72aa0b0cef01ebb5337359. it seems blameless after all Change-Id: If0f95da5ee7f91fde0b679c9314e3da07f7779f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-17ofz#27296 Out-of-memory and ofz#27384 Indirect-leakCaolán McNamara
Revert "ofz#27012 detect deletion of XFCell" This reverts commit e40d28d65222ba462c20ede17da5ef54751932e3. and Revert "ofz#26357 Timeout in lwpfuzzer, 12s -> 1.3s" This reverts commit 473c1b05f7a7a5500a2e15b911263b546792b013. Change-Id: Ia4d37148745259a285523b1b45ca9838c4122b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-08update PCHsLuboš Luňák
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-18throw exception in SvStream when reading past end of fileNoel
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-04update pchesCaolán McNamara
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24FindActuralStyleName->FindActualStyleNameNoel
Change-Id: I25e021caeb1c71529350df95099fb344edfd5b81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19tdf#123936 Formatting files in module lotuswordpro with clang-formatPhilipp Hofer
Change-Id: I3110b452b6c81fb7e5c10f6ba98ce521c51c0427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105690 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-06ofz#27012 detect deletion of XFCellCaolán McNamara
Change-Id: I22aabfcbb43c09ab174176a2a2898b4bf0b55afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22long->tools::Long in hwpfilter..ooxNoel
Change-Id: I9ab8876aac7b2f8b488db6dfa9c6fd0cecd2238b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-09improve loplugin:unusedvarsglobalNoel Grandin
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4733e6609ee99bef49c2771c83b450ee89d955b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101804 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typosAndrea Gelmini
Change-Id: I8dc0cdcfe6bd90efc596df28e6c6d968b92618b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101098 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29ofz#24404 row insert attempt in table with same table already in the rowCaolán McNamara
Change-Id: I0f52de029600b182e479af3bdf56da7ea2c2ef01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12update pchesCaolán McNamara
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-21tdf#42949 Fix IWYU warnings in lotuswordpro/source/filter/*hxxGabor Kelemen
Also drop the now unused pass-through header lotuswordpro/inc/lwpheader.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3e2b9c4b5d91651dbefb83d13006f72eb54e62bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92498 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-06tdf#42949 Fix IWYU warnings in lotuswordpro/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6bb0a9d668a2acf64e965bf74823b43f3ec2c8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91733 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-02clang-format lotuswordpro with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I4527dcc9aaabd1fba3363c0aa2bf3217e42ef45e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89776 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-20Resolves: tdf#130093 some lwp file not loadingCaolán McNamara
Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20loplugin:duplicate-definesNoel Grandin
already defined in lwpobjtags.hxx Change-Id: I6ef609c82a38d5b6503dbec2ac3f34def99590f6 Reviewed-on: https://gerrit.libreoffice.org/85552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-26loplugin:constmethod in framework..lotuswordproNoel Grandin
Change-Id: I14a3855a75cf081d86c2a404966db38c617c0256 Reviewed-on: https://gerrit.libreoffice.org/79541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-12Fix typosAndrea Gelmini
Change-Id: I7fdeba2d7407989a00befaad1c186cd6f132cb85 Reviewed-on: https://gerrit.libreoffice.org/78827 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Fix typosAndrea Gelmini
Change-Id: I545154bddfd29194630d744b4aa4f5c385321531 Reviewed-on: https://gerrit.libreoffice.org/77138 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29Fix typosAndrea Gelmini
Change-Id: Ic2fb0772648b3f93c2fdfa4d2f663b6ede2ead51 Reviewed-on: https://gerrit.libreoffice.org/76507 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I1efccb8b926e4aa10e9ccee7e8e36919e38c05fc Reviewed-on: https://gerrit.libreoffice.org/76339 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-25Fix typosAndrea Gelmini
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20Fix typosAndrea Gelmini
Change-Id: Icefd5a9e2a8bd929caa486c4cf3283925237d707 Reviewed-on: https://gerrit.libreoffice.org/75980 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-04-10clang-tidy: Silence warnings from WIP unhandled-self-assignment checkTamás Zolnai
Where it can be done by removing useless / duplicate code. For XFListStyle I removed the copy operator entirely, because it was bugous and it seems not to be used anyway. Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22 Reviewed-on: https://gerrit.libreoffice.org/70482 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-27loplugin:unusedfields look for classes where we can make all the..Noel Grandin
fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07use unique_ptr in LwpTools::GetSystemDateStyleNoel Grandin
Change-Id: I6ea90be5736982422aaa45c7147beec1cfd5430b Reviewed-on: https://gerrit.libreoffice.org/65918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07use unique_ptr in lotuswordproNoel Grandin
Change-Id: I49ae12639d1a5adab25407115cf65ebcfe3936c9 Reviewed-on: https://gerrit.libreoffice.org/65920 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-05 21:29:10 +0000