Age | Commit message (Collapse) | Author |
|
to find places where we are converting stuff to unique_ptr
instead of using std::make_shared.
As a bonus, this tends to find places where we are using shared_ptr
where we can instead be using unique_ptr avoiding the locking overhead.
Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Also drop the now unused pass-through header lotuswordpro/inc/lwpheader.hxx
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I3e2b9c4b5d91651dbefb83d13006f72eb54e62bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92498
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I14a3855a75cf081d86c2a404966db38c617c0256
Reviewed-on: https://gerrit.libreoffice.org/79541
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id9b876e89dd186782c0168229840f721a8b3720c
|
|
Change-Id: I1ff35dd6242accf0a8e71086a14a72e85eef1c5a
|
|
Change-Id: I2ad14fa797c99d26975dc472c1db115d94160eee
Reviewed-on: https://gerrit.libreoffice.org/40615
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2e9df8223d503b813b4c458747e8c44bb8ef8868
Reviewed-on: https://gerrit.libreoffice.org/30661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and ignore URE headers in the plugin
Change-Id: I939df744c1173cf0f67d515f6c3fb4ac4cb25588
|
|
Change-Id: I5866c8d95e04714e81a45e73bf00a430859a4327
|
|
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
|
|
change control, empty documentation tags
Change-Id: Iad06c00ebad7dcb7d7d40040d77dee2d6307c9a5
|
|
Change-Id: I17927d48a75c332f1ddc3853145b14daac17f9c0
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
Change-Id: I017d284a2fbc8d50a9928c9d934ffe710b0c652f
|
|
Change-Id: Ic3e01b5ecfb159d88c7c849a85ff612cdda5b418
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
except moving CGMBitmapDescriptor into filter/source/graphicfilter/icgm/outact.hxx
Change-Id: Ib11d1c907b4c52c6e0f261b20992659b52f4c136
|
|
|
|
|
|
|
|
|
|
|
|
|