summaryrefslogtreecommitdiff
path: root/lotuswordpro/source
AgeCommit message (Collapse)Author
2021-02-16loplugin:referencecasting in hwpfilter..lotuswordproNoel
Change-Id: Ib4a1ae456c44638386425e690a089360e991b26c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-01cppcheck: Clean up signed 32 bit shift by 31Dr. David Alan Gilbert
cppcheck moans about 1<<n where n can be 31; ubsan also complains; they're probably right even if it's unlikely to ever be a problem. Use 1U << 31 Change-Id: Ic83d7d240db4595c2562c1f91116491044d70bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110173 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-28ofz#30005 crash in LwpFribPtr::XFConvertCaolán McNamara
Change-Id: I4f03c1cd8bc12f3fa09c815837b289ff088c91d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-28TopLeft().Y() -> Top() etc.Caolán McNamara
TopLeft().X() -> Left() BottomLeft().X() -> Left() TopRight().X() -> Right() BottomRight().X() -> Right() TopLeft().Y() -> Top() TopRight().Y() -> Top() BottomLeft().Y() -> Bottom() BottomRight().Y() -> Bottom() Change-Id: I5050f619bf92cfc59b6f8dfe7c9f98ef1453c294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-28add string_view variants of methods to O[U]StringBufferNoel
and update the stringview loplugin to detect cases where we can use these new methods. Change-Id: I998efe02e35c8efcb3abfb4d7186165bbe6dfb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Use char16_t string literalsStephan Bergmann
Change-Id: I0a8b577957ac1d4cad5fc1163f244012a8391a77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-18throw exception in SvStream when reading past end of fileNoel
to avoid chasing weird problems where we read past the end of file, which leads to random data in the variable we read into. I expect a couple of possible regressions from this change (1) memory leaks caused by non-exception-safe memory handling. Of which there should not be much because we're pretty good about using smart pointer classes these days. (2) Broken files which used to load, will no longer do so. These will have to be debugged by putting a breakpoint on the SvStreamEOFException constructor, and examining the backtrace to see where we should be catching and ignoring the exception to make the code continue to handle such broken files. Change-Id: I351be031bb083a3484a9a1b650a58892700e6fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24FindActuralStyleName->FindActualStyleNameNoel
Change-Id: I25e021caeb1c71529350df95099fb344edfd5b81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23ofz#27756 null derefCaolán McNamara
Change-Id: Iccbd368a69f86abe7c7c72df8158db98eaf2bc58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106362 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19Improve comment layoutStephan Bergmann
...after 69b12a6eb3616d15035310eeb0c3dbc7aefcb5c1 "tdf#123936 Formatting files in module lotuswordpro with clang-format" Change-Id: I95ce76de02068f1f5480fb32f61d5770e302be84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106120 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-19tdf#123936 Formatting files in module lotuswordpro with clang-formatPhilipp Hofer
Change-Id: I3110b452b6c81fb7e5c10f6ba98ce521c51c0427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105690 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-11Fix 64-bit --disable-pch build on WindowsMike Kaganski
Change-Id: Ieeef0309faa77558fb30fceaed83ad97fb6e26ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-11convert more long -> tools::LongNoel
found by grepping and changed by hand. Change-Id: I3c720859dba430fde3abc76c6c5cb58269efaf4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-06ofz#27012 detect deletion of XFCellCaolán McNamara
Change-Id: I22aabfcbb43c09ab174176a2a2898b4bf0b55afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-02loplugin:reducevarscope in lotuswordproNoel
Change-Id: Ie0aa6b91fe13d24b5cf60abc14cf43c2106b53da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-27ofz#26676 null derefCaolán McNamara
Change-Id: Ic2bd8b49762266ad48263bd68a143b46fb5fd66f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-22long->tools::Long in hwpfilter..ooxNoel
Change-Id: I9ab8876aac7b2f8b488db6dfa9c6fd0cecd2238b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-18ofz#26357 Timeout in lwpfuzzer, 12s -> 1.3sCaolán McNamara
Change-Id: I1f1e2f1727b698d761adaf0d388d731fc80e280f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-10ofz#23505 31 seconds -> 12 secondsCaolán McNamara
Change-Id: Ib26f03bb308e4b96a0647ca3a81288b6cce5a767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104133 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
extend commit 9d1c8e66f7020fa0150b23bd450e514f848bd20b Date: Tue Apr 5 12:35:54 2016 +0200 UBSan: Restrict BorderWidthType values to valid range on input to the other assignment to m_eRightType Change-Id: I712a16974e25d3cc48ecfc223a84264ef4bf1642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-23ofz#25881 use std::vector with bounds checking accessorCaolán McNamara
Change-Id: Ic557e85bce5f3ebe7224b0aa2192a74969f4fce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I4733e6609ee99bef49c2771c83b450ee89d955b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101804 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typosAndrea Gelmini
Change-Id: Ieff77be89ee8505b8241234f6dbb7507256dbc4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101757 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-29Fix typosAndrea Gelmini
Change-Id: I473956d570feac508e52a3e52cc26cc154f4dc56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101627 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-29Directly use OUString(sal_Unicode) ctorStephan Bergmann
Change-Id: I60869118cf163afb2af3790a4a394fd03adcd868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101576 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-23Fix typo in codeAndrea Gelmini
Change-Id: Ie0f3d8b01e0370f0a2e95d46b61be56943d3bd78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101198 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-23Fix typoAndrea Gelmini
Change-Id: I17407c534f95f20bb16b2d5545b92ae293e761ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101218 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-29ofz#24404 row insert attempt in table with same table already in the rowCaolán McNamara
Change-Id: I0f52de029600b182e479af3bdf56da7ea2c2ef01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: lotuswordproStephan Bergmann
Change-Id: I5b68c490b534da933de4f26e01328dfb2976dafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97616 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: lotuswordproStephan Bergmann
Change-Id: If39fbdf78bcac3394927c6a973cd5da36c1b35d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97200 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-12return directlyDavid Tardon
Change-Id: Ia5ebadfd825b0cbd106893f0b7b25e28b878dfeb
2020-06-12return directlyDavid Tardon
Change-Id: I727a34213fef5adefdc6c1a046d47a7f37cfdcd0
2020-06-12use dynamic_castDavid Tardon
Change-Id: Iac420c2dd37be392ae817e0433de68c983546667
2020-06-12drop misleading commentDavid Tardon
Change-Id: I2ae4b9dbcf3134ec5301d14c32d6904817d350fb
2020-06-12rename variableDavid Tardon
Change-Id: I24e0902998420685656a350cb849a19d8c7a8a35
2020-06-12cast to the right typeDavid Tardon
This makes paragraph formatting in LWP documents work again (for the first time since 3.3). Regression from commit d2a1c2d4cfa51b6ee8a7f38baa258633fae9ec6d "fix what there is to fix" Change-Id: I057aeb996837f7c19815de8a5379861ce3c0e8cd
2020-06-11ofz#23300 infinite loopCaolán McNamara
Change-Id: I0ee67e8efefa48942357340cae46bd7ece27e5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-08tdf#42949 Fix IWYU warnings in lotuswordpro/*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b0ba9f0c334b0eccb0f38a3313c60a63eaf7647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95644 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-06ofz#23103 Invalid-enum-valueCaolán McNamara
Change-Id: I2fce04b14110c1da17611334e4912b4277efe389 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: lotuswordproStephan Bergmann
Change-Id: Ica7a05d890d2cd51ed7251e18dd630d1006ba6d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95506 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03ofz#23016 Invalid-enum-valueCaolán McNamara
Change-Id: Ie3a783002b6ad82c6939b567cb53c3d4afbfac7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-29loplugin:simplifybool in hwpfilter..lotuswordproNoel Grandin
Change-Id: Iedfd492c963eb89fe75fdd73cae630e7e1dae119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01improve loplugin:makesharedNoel Grandin
to find places where we are converting stuff to unique_ptr instead of using std::make_shared. As a bonus, this tends to find places where we are using shared_ptr where we can instead be using unique_ptr avoiding the locking overhead. Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-22Add include needed for std::minMike Kaganski
Change-Id: Ia7bb9a99c029d9ad47371b5ae999fd9808c4cbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92537 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-15 12:44:55 +0000