summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-02loplugin:stringviewparam convert methods using compareToNoel Grandin
which converts to compare Change-Id: If03c790ea113a7caedbe89f926b29055c9ec1e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23tdf#147906 Use std::hypot for Pythagorean additionVaibhavMalik4187
Change-Id: I7813b9929771858d33e951e50e6de7893fe19085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131684 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-16tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macropsidiumcode
Change-Id: Ia711e939f769c6a2257bd1fb3607b315f931a0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131634 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-13Fix typo in codeAndrea Gelmini
Change-Id: Id38f846aaf451d94e975e049f6494a6261eb4ae3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131494 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-13ofz#45524 string is presumed to be at least length 1Caolán McNamara
Change-Id: If8a86e399109b414cf53f6e2bffdd3c7c6faa490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11new loplugin:trivialdestructorNoel Grandin
look for potentially trivial destructors that can then be elided Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02Fix typoAndrea Gelmini
Change-Id: Ice5721d480567be4f8a4a79da6e01a6a389bf4bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129318 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-01ensure bounds checkingzhutyra
LIBREOFFICE-SBQ5TJRS Change-Id: I71f35bc120fdd70298685131f29a6bb822d50f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-01read of width/height uses wrong record sizezhutyra
this initially went wrong at: commit b4fb7a437bb0ce987702b12008737756623618ac Date: Mon May 23 21:38:40 2011 +0100 fix up some more endian LIBREOFFICE-SBQ5TJRS Change-Id: Ie418f530f55288351f73f3c0cbab9ac48e6b6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129293 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28ofz: Undefined-ShiftCaolán McNamara
Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27Recheck modules [i-l]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I758bb27e93779e3df21c463714e49354748f446f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-26ofz#44080 throw exception on a negative lengthCaolán McNamara
Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-22ofz#43949 TimeoutCaolán McNamara
Change-Id: Ia1691d30e754924314d39d733135614db4c56834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz#43689 Direct-LeakCaolán McNamara
Change-Id: I09823f30817163b0467b6b96f56956987337b991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ia19985b7c042e6ab9608220343e3b678890f7215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic5f41e4f1f6b20a8cd8887807296f33adb48b728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I77847175d5ad0b2757eb24fcff08a4caf5d77519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib1c3b306573dda073f6ff3d7d0cc17aef39c0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz#43689 Null-dereferenceCaolán McNamara
Change-Id: I6edb50b3c281d50187d8965ce9665a9aae0e9098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15Let loplugin:nullptr look into template instantiationsStephan Bergmann
It missed some occurrences of 0 when only looking into uninstantiated template code, as Clang doesn't model them with an ImplicitCastExpr, even if the target is known to be a (dependent) pointer type. Looking into all template instantiations of course carries the risk that a given use of 0 is meant to be interpreted as a pointer in some and as an integer in other instantiations. But the only case where that happened in the current code base is RegistryValueList::getElement (include/registry/registry.hxx), where {} is arguably a better choice anyway. (And which would presumably also hold for any future such cases.) Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-13ofz#43577 valid reclen must be >= 20Caolán McNamara
Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-12ofz: Direct-leakCaolán McNamara
Change-Id: Iedef8c99f0650750f5cfd808ac36421cc0d5c281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-12ofz#43551 Use-of-uninitialized-valueCaolán McNamara
Change-Id: I2eb139f3bff296cff7d8f0e9a05f19df56b27ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-11ofz#43509 use std::vector and at()Caolán McNamara
Change-Id: Id0c5e4ccc22b41caee95ca5f53f6ae7cf70490f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-10use less SvStream::Flush()Noel Grandin
Flush() turns into a sync() on the device, which is pretty slow. Most of the time all we actually want to do is to flush the internal buffers from the SvStream. So expose the FlushBuffer method and use that where possible. And also means we don't need the mbDontFlushOnClose flag on SvStream any more. Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-10ofz: Use-of-unintialized-valueCaolán McNamara
Change-Id: I6c9a1a22240defbc8d9fa262ad087770445ffc4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-09ofz#43818 delete of uninitialized pointerCaolán McNamara
Change-Id: I91509915c18c3e9b54cb3047462b9dd9a8c7a46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-09ofz#43458 avoid OOMCaolán McNamara
Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-09ofz#43446 Undefined-shiftCaolán McNamara
Change-Id: Ibe3485983ecf764ca8b8e667b470c6b210b6d2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07ofz#43388 Direct-leakCaolán McNamara
Change-Id: I5d410461d7b4e8466533fc4186ee77ec99fae089 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07Objct->ObjectCaolán McNamara
Change-Id: I5a69596e65b300bd57fd539fe696f1c064ce555f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128102 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-07ofz#43376 Null-dereferenceCaolán McNamara
Change-Id: I57f67465e4f8ca6fc6bd47d7b095e9b470d9d2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128101 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-05ofz#42829 TimeoutCaolán McNamara
Change-Id: I7c170fca4601fb0cee8acb28b65ce8bd59595911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-22loplugin:flatten in l10ntools..lotuswordproNoel Grandin
Change-Id: Ie6de142db1987094fdf538148ac5ee33379a3e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-26loplugin:stringliteraldefine in l10ntools..ooxNoel Grandin
Change-Id: Ia19d247f3cf439405c05a53c4cf2c9d0e7344560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23Remove unused header file lwpresource.hxxHossein
* Removed unused header file lwpresource.hxx which contained symbolic constants of type 'const char[]' that were no longer in use - STR_WORDPRO - STR_IMPLEMENTATION_NAME - STR_SERVICE_NAME - STR_WRITER_IMPORTER_NAME Change-Id: I4f1293a83c4058d7d01a98454a673ac88bd35b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125701 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-11-14Use M_PI instead of defined value; use rad2deg()Hossein
* Replace defined values of PI with M_PI defined in <cmath> * Use M_PI_2 instead of PI / 2.0 * Instances could be found with: git grep 3.14 *.cxx *.hxx|grep define * One instance is ignored: sc/source/core/opencl/opinlinefun_statistical.cxx * Replace *(180 / PI) with basegfx::rad2deg() * Replace 2*PI/360 with basegfx::deg2rad() * Use atan2 instead of atan where it was more appropriate + atan2() handles all 4 quadrants + Extra conditions for different quadrants are removed Change-Id: I083ee2e1427cd36ba0b8c38e4fe5f782d6486075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-07forward decls go after #includeNoel Grandin
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-30Prepare for removal of non-const operator[] from Sequence in lotuswordproMike Kaganski
Change-Id: Id71f7a16d5ba0b47676d11136ef327205c370aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-17just do one lookup for loop detectionCaolán McNamara
Change-Id: I2b20c15f2e3ec3c4a23d78f6fab85db763fce033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16ofz#40004 TimeoutCaolán McNamara
Change-Id: I261f6acec53936e4a644bb4b38bbc41fa9ad120c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123702 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-11loplugin:moveparam in lotuswordproNoel Grandin
Change-Id: I122fc96930021dd3127d9c991e7dac3140b612f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11In O[U]StringBuffer, make string_view params replacements for OUString onesStephan Bergmann
...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads. That way, loplugin:bufferadd and loplugin:stringviewparam found many further opportunities for simplification (all addressed here). Some notes: * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer (as that goes via user-defined conversions through string_view now), which was most noticeable in copy initializations like OStringBuffer buf = someStr; that had to be changed to direct initialization, OStringBuffer buf(someStr); But then again, it wasn't too many places that were affected and I think we can live with that. * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to get them in line with their counterparts taking O[U]String. * I added an OUStringBuffer::lastIndexOf string_view overload that was missing (relative to OUStringBuffer::indexOf). * loplugin:stringconstant needed some addition to keep the compilerplugins/clang/test/stringconstant.cxx checks related to OStringBuffer::append and OStringBuffer::insert working. * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea "loplugin:stringviewparam extend to new.." Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-05ofz: detect infinite loopCaolán McNamara
Change-Id: Ifc3134401c4ed7c4b17faf282d191ad2bb778746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-27ofz#39374: avoid infinite loopCaolán McNamara
Change-Id: I0aec664279dea99df865761f34f64aa4fa3d9e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122725 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-25Fix typosAndrea Gelmini
Change-Id: I40b4efb228176891678b8560a7ee4e37e77495e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122596 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-22Extend loplugin:stringviewparam to starts/endsWith: lotuswordproStephan Bergmann
Change-Id: Ia58c031d1157af271c664948946fa5d8d17a2323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-13 23:15:41 +0000