summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2021-10-30Prepare for removal of non-const operator[] from Sequence in lotuswordproMike Kaganski
Change-Id: Id71f7a16d5ba0b47676d11136ef327205c370aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-17just do one lookup for loop detectionCaolán McNamara
Change-Id: I2b20c15f2e3ec3c4a23d78f6fab85db763fce033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16ofz#40004 TimeoutCaolán McNamara
Change-Id: I261f6acec53936e4a644bb4b38bbc41fa9ad120c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123702 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-11loplugin:moveparam in lotuswordproNoel Grandin
Change-Id: I122fc96930021dd3127d9c991e7dac3140b612f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11In O[U]StringBuffer, make string_view params replacements for OUString onesStephan Bergmann
...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads. That way, loplugin:bufferadd and loplugin:stringviewparam found many further opportunities for simplification (all addressed here). Some notes: * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer (as that goes via user-defined conversions through string_view now), which was most noticeable in copy initializations like OStringBuffer buf = someStr; that had to be changed to direct initialization, OStringBuffer buf(someStr); But then again, it wasn't too many places that were affected and I think we can live with that. * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to get them in line with their counterparts taking O[U]String. * I added an OUStringBuffer::lastIndexOf string_view overload that was missing (relative to OUStringBuffer::indexOf). * loplugin:stringconstant needed some addition to keep the compilerplugins/clang/test/stringconstant.cxx checks related to OStringBuffer::append and OStringBuffer::insert working. * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea "loplugin:stringviewparam extend to new.." Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-05ofz: detect infinite loopCaolán McNamara
Change-Id: Ifc3134401c4ed7c4b17faf282d191ad2bb778746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-27ofz#39374: avoid infinite loopCaolán McNamara
Change-Id: I0aec664279dea99df865761f34f64aa4fa3d9e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122725 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-25Fix typosAndrea Gelmini
Change-Id: I40b4efb228176891678b8560a7ee4e37e77495e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122596 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-22Extend loplugin:stringviewparam to starts/endsWith: lotuswordproStephan Bergmann
Change-Id: Ia58c031d1157af271c664948946fa5d8d17a2323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-19ofz: avoid TimeoutCaolán McNamara
Change-Id: I8c5d1e7aaf256e182c2f5dd92bb8fd4ad9bff42a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-18ofz#37911 Avoid timeout when fuzzingCaolán McNamara
Change-Id: I30bdcb3c267ee7e3ee0920df03ee8507d118d009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08ofz#27296 limit row span when fuzzingCaolán McNamara
Change-Id: I3069875f64acaf394cfef7f6478abc974022d536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05cid#1490901 silence Out-of-bounds readCaolán McNamara
Change-Id: I9a2c1fe10fc696d5392cd6c95cff11124b5fdb01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04cid#1490901 silence Out-of-bounds readCaolán McNamara
Change-Id: I4757413c80f6dc71d40c5c5525c484a54b71f676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: If1db8debe4f3b3dc6a8890b03ee8d2d70cc63a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121572 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02cid#1490900 Unchecked return valueCaolán McNamara
Change-Id: I22ab45d8e7bc72c3cf8cf8bb8ddbefef4250fdad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: I78339f1df1f0c55c7edaa552940b07d1ada3aeb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I4298dfeafab0fe296a970fce024cc25572e3a2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8a0a8f0bd9f55c4d0b20281205cf12f2bbcc564f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib1bed182b1b49076a47c7bc2bf29b9a45a21fbbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-28ofz#26357 Infinite loopCaolán McNamara
Change-Id: I914d5c8e53e226567f48b084b1cdb55721a58359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27Related: ofz#27296 OOM std::map->std::vectorCaolán McNamara
dbgutil massif peak of 3.1G -> 2.7G GB 3.117^ # | :::::::::::::::::::::::# | ::::: # | :@::::: #: | :::@::::: #: | :::::@::::: #: | :::::::@::::: #:: | :::::::::@::::: #:@ | ::::::::::@::::: #:@: | :::::::::::::@::::: #:@: | :::::::::::::::@::::: #:@:: | :::::::::::::::::@::::: #:@:: | ::::::::::::::::::@::::: #:@:: | ::::::::::::::::::::@::::: #:@::@ | @:::::::::::::::::::::@::::: #:@::@ | @::@:::::::::::::::::::::@::::: #:@::@: | ::@::@:::::::::::::::::::::@::::: #:@::@: | @:::@::@:::::::::::::::::::::@::::: #:@::@: | ::@:::@::@:::::::::::::::::::::@::::: #:@::@:: | ::::@:::@::@:::::::::::::::::::::@::::: #:@::@:: 0 +----------------------------------------------------------------------->Gi 0 116.7 ---> GB 2.718^ : | @######: | @@@# ::: | @@@@# :::: | @@@@@@@# ::::: | @@@ @@@@# :::::: | :@@@@ @@@@# ::::::: | @::@@@@ @@@@# :::::::@: | @@@::@@@@ @@@@# :::::::@:: | @@@@::@@@@ @@@@# :::::::@::: | @@@@@@::@@@@ @@@@# :::::::@:::: | ::@@@@@@::@@@@ @@@@# :::::::@:::::: | @::@@@@@@::@@@@ @@@@# :::::::@:::::@: | @@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:: | @@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::: | @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:::: | @@@@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::: | @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@ | :@@@ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@: | @@:@ @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@:: 0 +----------------------------------------------------------------------->Gi 0 34.29 Change-Id: Id56615e554d07a76a6a87476a40cc6190c0555da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27we are going to remove the entire row anywayCaolán McNamara
so don't iterate over the cells explicitly dropping them Change-Id: If0de504ac9711d1e6a757cdd15574f15585ca928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27ofz#37660: searching in wrong parent for tableCaolán McNamara
Change-Id: Ifa1b70fa0ccc706cec52b318cdfba59f5da2b4d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26ofz#35646 Indirect-leakCaolán McNamara
Change-Id: Ie79d9c49b6beef04ab111a63166abc7f093ad36b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03Fix typosAndrea Gelmini
Change-Id: Ie4809d5367d15dc155033db034d86aaa75cb5abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119932 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-19Fix typoAndrea Gelmini
Change-Id: I8babf7975eb3b8f3e43f72572e75cbf46f510b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-02no need to allocate these on the heapNoel Grandin
Change-Id: Ie7b8a5ee280da5dfcb15d217a4daccaf485cfbe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03loplugin:stringadd improvement for appending numbersNoel Grandin
I was wrong, the Concat framework already optimised appending numbers by stack-allocating small buffers, so include them in the plugin Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-26Revert "ofz#27296 Out-of-memory and ofz#27384 Indirect-leak"Caolán McNamara
This reverts commit c80c8ac4eb58812c1b72aa0b0cef01ebb5337359. it seems blameless after all Change-Id: If0f95da5ee7f91fde0b679c9314e3da07f7779f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-17ofz#27296 Out-of-memory and ofz#27384 Indirect-leakCaolán McNamara
Revert "ofz#27012 detect deletion of XFCell" This reverts commit e40d28d65222ba462c20ede17da5ef54751932e3. and Revert "ofz#26357 Timeout in lwpfuzzer, 12s -> 1.3s" This reverts commit 473c1b05f7a7a5500a2e15b911263b546792b013. Change-Id: Ia4d37148745259a285523b1b45ca9838c4122b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114234 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-08update PCHsLuboš Luňák
Change-Id: Ia9d04447f927e270a55500e7f35723a729bc01dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113801 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-07Updated README.md files to represent current code / use Markdown formatHossein
Previously, all of the README files have been renamed to README.md and now, the contents of these files were changed to use Markdown format. Other than format inconsistency, some README.md files lacked information about modules, or were out of date. By using LibreOffice / OpenOffice wiki and other documentation websites, these files were updated. Now every README.md file has a title, and some description. The top-level README.md file is changed to add links to the modules. The result of processing the Markdown format README.md files can be seen at: https://docs.libreoffice.org/ Change-Id: Ic3b0c3c064a2498d6a435253b041df010cd7797a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113424 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-26cid#1474321 make it a little more clear that the size *is* checkedCaolán McNamara
Change-Id: I07632cbb9722f409877a426000eedc47822fdc44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-26loplugin:flattenNoel
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-26Drop these definesMike Kaganski
Change-Id: I7ff56d6f016ea90c4b5cdcbbb36141627037c0ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113125 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-24cid#1222240 silence bogus Untrusted divisorCaolán McNamara
Change-Id: Ib828267bdb47414cf4ace0756e5cfd519f679643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113022 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-13add PixelFormat enum that replaces bit count in Bitmap/BitmapExTomaž Vajngerl
Bit count for the image is a numeric value (sal_uInt16) but only a handful of values make sense - namely 1,4,8,24 and 32. This replaces the numeric value with an enum, which only accepts those values and checks the correct values are used at compile time. Change-Id: I0fc137c62bce3b0d021f05019a1648da628521bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-25tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktopMoaz
MacrosTest::loadFromDesktop itself asserts on its return value. Thus, the additional checks in unit tests are redundant, and only create noise unrelated to the tested functionality. Change-Id: If616001b296afdde38f5a23ececee3d44b4a395d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-21expand lotuswordpro README a bitDavid Tardon
Change-Id: Ibe5e5b1bef43049065915f80aae5037a782ed698
2021-02-21lotuswordpro: allow to dump intermediate XML into fileDavid Tardon
If env. variable DBG_LWPIMPORT_DIR= is set to an existing directory, a formatted representation of the intermediate XML format is dumped into a file named lwpimport.xml in that directory. This makes debugging of Lotus Word Pro import a lot easier. Change-Id: I872c388c2b378d55f476973890a073ec932e1b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111283 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2021-02-16loplugin:referencecasting in hwpfilter..lotuswordproNoel
Change-Id: Ib4a1ae456c44638386425e690a089360e991b26c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-01cppcheck: Clean up signed 32 bit shift by 31Dr. David Alan Gilbert
cppcheck moans about 1<<n where n can be 31; ubsan also complains; they're probably right even if it's unlikely to ever be a problem. Use 1U << 31 Change-Id: Ic83d7d240db4595c2562c1f91116491044d70bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110173 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2024-07-07 02:52:09 +0000