summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2020-08-23Fix typo in codeAndrea Gelmini
Change-Id: Ie0f3d8b01e0370f0a2e95d46b61be56943d3bd78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101198 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-23Fix typoAndrea Gelmini
Change-Id: I17407c534f95f20bb16b2d5545b92ae293e761ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101218 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typosAndrea Gelmini
Change-Id: I8dc0cdcfe6bd90efc596df28e6c6d968b92618b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101098 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29ofz#24404 row insert attempt in table with same table already in the rowCaolán McNamara
Change-Id: I0f52de029600b182e479af3bdf56da7ea2c2ef01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-12update pchesCaolán McNamara
Change-Id: I75602277a5a26b012a12f2c4f4b7ff5bb663b0b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10replace usage of blacklist with excludelist for IWYUThorsten Behrens
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 Change-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98182 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: lotuswordproStephan Bergmann
Change-Id: I5b68c490b534da933de4f26e01328dfb2976dafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97616 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Upcoming improved loplugin:elidestringvar: lotuswordproStephan Bergmann
Change-Id: If39fbdf78bcac3394927c6a973cd5da36c1b35d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97200 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-12return directlyDavid Tardon
Change-Id: Ia5ebadfd825b0cbd106893f0b7b25e28b878dfeb
2020-06-12return directlyDavid Tardon
Change-Id: I727a34213fef5adefdc6c1a046d47a7f37cfdcd0
2020-06-12use dynamic_castDavid Tardon
Change-Id: Iac420c2dd37be392ae817e0433de68c983546667
2020-06-12drop misleading commentDavid Tardon
Change-Id: I2ae4b9dbcf3134ec5301d14c32d6904817d350fb
2020-06-12rename variableDavid Tardon
Change-Id: I24e0902998420685656a350cb849a19d8c7a8a35
2020-06-12cast to the right typeDavid Tardon
This makes paragraph formatting in LWP documents work again (for the first time since 3.3). Regression from commit d2a1c2d4cfa51b6ee8a7f38baa258633fae9ec6d "fix what there is to fix" Change-Id: I057aeb996837f7c19815de8a5379861ce3c0e8cd
2020-06-11ofz#23300 infinite loopCaolán McNamara
Change-Id: I0ee67e8efefa48942357340cae46bd7ece27e5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-08tdf#42949 Fix IWYU warnings in lotuswordpro/*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b0ba9f0c334b0eccb0f38a3313c60a63eaf7647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95644 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-06ofz#23103 Invalid-enum-valueCaolán McNamara
Change-Id: I2fce04b14110c1da17611334e4912b4277efe389 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: lotuswordproStephan Bergmann
Change-Id: Ica7a05d890d2cd51ed7251e18dd630d1006ba6d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95506 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03ofz#23016 Invalid-enum-valueCaolán McNamara
Change-Id: Ie3a783002b6ad82c6939b567cb53c3d4afbfac7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-29loplugin:simplifybool in hwpfilter..lotuswordproNoel Grandin
Change-Id: Iedfd492c963eb89fe75fdd73cae630e7e1dae119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01improve loplugin:makesharedNoel Grandin
to find places where we are converting stuff to unique_ptr instead of using std::make_shared. As a bonus, this tends to find places where we are using shared_ptr where we can instead be using unique_ptr avoiding the locking overhead. Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-22Add include needed for std::minMike Kaganski
Change-Id: Ia7bb9a99c029d9ad47371b5ae999fd9808c4cbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92537 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-21tdf#42949 Fix IWYU warnings in lotuswordpro/source/filter/*hxxGabor Kelemen
Also drop the now unused pass-through header lotuswordpro/inc/lwpheader.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3e2b9c4b5d91651dbefb83d13006f72eb54e62bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92498 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-07loplugin:flatten in lotuswordproNoel Grandin
Change-Id: I8b86d54c1c2706fde8b4288bb3349e2ed89d3c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91798 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06ofz#21164 infinite loopCaolán McNamara
Change-Id: Id6838a3e4223885d766839759b711bb345a840f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06tdf#42949 Fix IWYU warnings in lotuswordpro/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6bb0a9d668a2acf64e965bf74823b43f3ec2c8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91733 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-25fix assert when loading id:000059,sig:11,src:000008,op:havoc,rep:2.lwpNoel Grandin
one of caolans test files, which appears to have a row layout which references a non-existent parent. Change-Id: I9322ed430aa9edd47db9967a19938b02e4af6bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-08ofz#20635 infinite loopCaolán McNamara
Change-Id: I7b40df05307e3dd7768e9407040eb4fa285d51e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02clang-format lotuswordpro with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I4527dcc9aaabd1fba3363c0aa2bf3217e42ef45e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89776 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-24workaround GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized] etc. One looks like it might occur in practice. Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-10use color instead of intXisco Fauli
Change-Id: I7a837b61af666b6e13519df43255ff309d54f170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88123 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-08ofz#20504 Indirect-leakCaolán McNamara
lets assume a table should be only assigned to one container Change-Id: I4e33bc3dab37c20ac2337b12ae4ee4efe84cb5aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07ofz#20517 null-dereferenceCaolán McNamara
Change-Id: I443869f848925911ed46e2f547f0dc652b1ff290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07test: move component context from subclasses to BootstrapFixtureMiklos Vajna
To avoid duplication. Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-05LWP: add unittest for char/para propertiesXisco Fauli
Change-Id: I2ef37845a2b7de189667a6ce81e7d061b1b15eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87987 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04tdf#129993: Add unittestXisco Fauli
Change-Id: I30b0583a3e38f0f8a06a7711c9413101dc87cc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87861 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04ofz#20507 infinite table conversionCaolán McNamara
Change-Id: I779ab29d93491a296156fcc14557755754c2afdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-04ofz#20507 hold by referenceCaolán McNamara
Change-Id: Ia684d8f796ed7bf6f82b056c6445c4cd92260504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-01ofz#20456 Null-dereference READCaolán McNamara
this is the first honggfuzz (honggfuzz_asan_libreoffice) report I've seen to date Change-Id: Iac733aa63c7c94d9454b9c8596340dc2286393c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01ofz#20447 Null-dereference READCaolán McNamara
Change-Id: I76c1c815ab5aaf4548c886a69989fcabe3de5248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01std:set->o3tl::sorted_vectorNoel Grandin
which is always a better choice when dealing with pointers, for 2 reasons: way more cache dense, and we very often iterate pointers roughly in-order, which means very little sorting needs to be done Change-Id: Ib38f56018b2fc16414c9af910421cc45f069e1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29tdf#129993 broken tables opening LWP fileNoel Grandin
regression from commit e2080e70fe8b085f18e868e46340454720fa94ca new compilerplugin returnbyref The parts that fix this specific bug are in lwprowlayout.cxx and lwprowlayout.cxx, but fix the other parts I messed up but not understanding the semantics of assigning to reference variables. Change-Id: I064cdd108c5b05da6092da0297dc7bcf487c7702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29Revert "ofz#20267 Indirect-leak"Caolán McNamara
This reverts commit ae01adf0747496e8c36f8f30fc2c1a4a6ef8275e. Reason for revert: intermittent failures Change-Id: I2212154e2c6ca210a2ff19cf73c0578c146dd46d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20267 Indirect-leakCaolán McNamara
Change-Id: I32e4d12e83573eaaaf3a393d8a2d5ba10ccb93ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20361 infinite recursionCaolán McNamara
Change-Id: I2434df7a08ddbc557879404504d3adc30e04d683 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20Resolves: tdf#130093 some lwp file not loadingCaolán McNamara
Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09ofz#19961 Invalid-enum-valueCaolán McNamara
Change-Id: I112d5cd9aa8e7169f7ff7e55ba93487c3d904b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>