summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2020-11-23ofz#27756 null derefCaolán McNamara
Change-Id: Iccbd368a69f86abe7c7c72df8158db98eaf2bc58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106239 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-28ofz#26676 null derefCaolán McNamara
Change-Id: Ic2bd8b49762266ad48263bd68a143b46fb5fd66f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104834 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-24ofz#25881 use std::vector with bounds checking accessorCaolán McNamara
Change-Id: Ic557e85bce5f3ebe7224b0aa2192a74969f4fce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103193 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-13cast to the right typeDavid Tardon
This makes paragraph formatting in LWP documents work again (for the first time since 3.3). Regression from commit d2a1c2d4cfa51b6ee8a7f38baa258633fae9ec6d "fix what there is to fix" Change-Id: I057aeb996837f7c19815de8a5379861ce3c0e8cd (cherry picked from commit 12cb753350f429e39064365b05926a30a008a516) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96235 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-13use dynamic_castDavid Tardon
Change-Id: Iac420c2dd37be392ae817e0433de68c983546667 (cherry picked from commit 06248bbaf21723f505d99c65906e5c6781c54c83) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11ofz#23300 infinite loopCaolán McNamara
Change-Id: I0ee67e8efefa48942357340cae46bd7ece27e5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-01improve loplugin:makesharedNoel Grandin
to find places where we are converting stuff to unique_ptr instead of using std::make_shared. As a bonus, this tends to find places where we are using shared_ptr where we can instead be using unique_ptr avoiding the locking overhead. Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-22Add include needed for std::minMike Kaganski
Change-Id: Ia7bb9a99c029d9ad47371b5ae999fd9808c4cbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92537 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-21tdf#42949 Fix IWYU warnings in lotuswordpro/source/filter/*hxxGabor Kelemen
Also drop the now unused pass-through header lotuswordpro/inc/lwpheader.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3e2b9c4b5d91651dbefb83d13006f72eb54e62bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92498 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-07loplugin:flatten in lotuswordproNoel Grandin
Change-Id: I8b86d54c1c2706fde8b4288bb3349e2ed89d3c95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91798 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06ofz#21164 infinite loopCaolán McNamara
Change-Id: Id6838a3e4223885d766839759b711bb345a840f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06tdf#42949 Fix IWYU warnings in lotuswordpro/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6bb0a9d668a2acf64e965bf74823b43f3ec2c8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91733 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-25fix assert when loading id:000059,sig:11,src:000008,op:havoc,rep:2.lwpNoel Grandin
one of caolans test files, which appears to have a row layout which references a non-existent parent. Change-Id: I9322ed430aa9edd47db9967a19938b02e4af6bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-08ofz#20635 infinite loopCaolán McNamara
Change-Id: I7b40df05307e3dd7768e9407040eb4fa285d51e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02clang-format lotuswordpro with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I4527dcc9aaabd1fba3363c0aa2bf3217e42ef45e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89776 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-24workaround GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized] etc. One looks like it might occur in practice. Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-10use color instead of intXisco Fauli
Change-Id: I7a837b61af666b6e13519df43255ff309d54f170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88123 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-08ofz#20504 Indirect-leakCaolán McNamara
lets assume a table should be only assigned to one container Change-Id: I4e33bc3dab37c20ac2337b12ae4ee4efe84cb5aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07ofz#20517 null-dereferenceCaolán McNamara
Change-Id: I443869f848925911ed46e2f547f0dc652b1ff290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07test: move component context from subclasses to BootstrapFixtureMiklos Vajna
To avoid duplication. Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-05LWP: add unittest for char/para propertiesXisco Fauli
Change-Id: I2ef37845a2b7de189667a6ce81e7d061b1b15eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87987 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04tdf#129993: Add unittestXisco Fauli
Change-Id: I30b0583a3e38f0f8a06a7711c9413101dc87cc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87861 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-04ofz#20507 infinite table conversionCaolán McNamara
Change-Id: I779ab29d93491a296156fcc14557755754c2afdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-04ofz#20507 hold by referenceCaolán McNamara
Change-Id: Ia684d8f796ed7bf6f82b056c6445c4cd92260504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-01ofz#20456 Null-dereference READCaolán McNamara
this is the first honggfuzz (honggfuzz_asan_libreoffice) report I've seen to date Change-Id: Iac733aa63c7c94d9454b9c8596340dc2286393c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01ofz#20447 Null-dereference READCaolán McNamara
Change-Id: I76c1c815ab5aaf4548c886a69989fcabe3de5248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01std:set->o3tl::sorted_vectorNoel Grandin
which is always a better choice when dealing with pointers, for 2 reasons: way more cache dense, and we very often iterate pointers roughly in-order, which means very little sorting needs to be done Change-Id: Ib38f56018b2fc16414c9af910421cc45f069e1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29tdf#129993 broken tables opening LWP fileNoel Grandin
regression from commit e2080e70fe8b085f18e868e46340454720fa94ca new compilerplugin returnbyref The parts that fix this specific bug are in lwprowlayout.cxx and lwprowlayout.cxx, but fix the other parts I messed up but not understanding the semantics of assigning to reference variables. Change-Id: I064cdd108c5b05da6092da0297dc7bcf487c7702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29Revert "ofz#20267 Indirect-leak"Caolán McNamara
This reverts commit ae01adf0747496e8c36f8f30fc2c1a4a6ef8275e. Reason for revert: intermittent failures Change-Id: I2212154e2c6ca210a2ff19cf73c0578c146dd46d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20267 Indirect-leakCaolán McNamara
Change-Id: I32e4d12e83573eaaaf3a393d8a2d5ba10ccb93ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20361 infinite recursionCaolán McNamara
Change-Id: I2434df7a08ddbc557879404504d3adc30e04d683 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-20Resolves: tdf#130093 some lwp file not loadingCaolán McNamara
Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09ofz#19961 Invalid-enum-valueCaolán McNamara
Change-Id: I112d5cd9aa8e7169f7ff7e55ba93487c3d904b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-03ofz#19786 Invalid-enum-valueCaolán McNamara
Change-Id: I9bca61f728877b6f7a741e9d89ad2f7f5ae0eb61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-20loplugin:duplicate-definesNoel Grandin
already defined in lwpobjtags.hxx Change-Id: I6ef609c82a38d5b6503dbec2ac3f34def99590f6 Reviewed-on: https://gerrit.libreoffice.org/85552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-20loplugin:duplicate-definesNoel Grandin
already in lwpstyledef.hxx Change-Id: I693982c50b3eebd47a843840dc01036e269b4e0e Reviewed-on: https://gerrit.libreoffice.org/85555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-19sal_Char->char in lotuswordpro..odkNoel Grandin
Change-Id: I5a7bd149554d24276a67437b654f8ffd2610a276 Reviewed-on: https://gerrit.libreoffice.org/85478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-24cppcheck: performing init in init list (hwpfilter, i., l.)Julien Nabet
Change-Id: Idf5b7be45d48076fbe191fbf1a2fa63c6da71902 Reviewed-on: https://gerrit.libreoffice.org/83617 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28loplugin:stringadd improve detectionNoel Grandin
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Remove some memset callsMike Kaganski
Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-11simplify "a = a +" to "a +="Noel Grandin
mostly so that my stringadd loplugin can point out places to improve Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5 Reviewed-on: https://gerrit.libreoffice.org/80618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04ofz#17675 loop in lwp filterCaolán McNamara
Change-Id: Id0c75e03794a622a9353559453ab5688c31f4b9d Reviewed-on: https://gerrit.libreoffice.org/80238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01loplugin:stringadd in helpcompiler..ooxNoel Grandin
Change-Id: I858870d883de10a673d7ce2798bda8c8f511cee5 Reviewed-on: https://gerrit.libreoffice.org/79889 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26loplugin:constmethod in framework..lotuswordproNoel Grandin
Change-Id: I14a3855a75cf081d86c2a404966db38c617c0256 Reviewed-on: https://gerrit.libreoffice.org/79541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-12Fix typosAndrea Gelmini
Change-Id: I7fdeba2d7407989a00befaad1c186cd6f132cb85 Reviewed-on: https://gerrit.libreoffice.org/78827 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-05-24 23:02:37 +0000