summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I8d978cffe5aec41aa41db8788fe68ad5ae6ab6c4
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I1ba43b13070ccd0f80b63f1b9a29ff70fb02794f
2015-10-13clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: If934445fc597015198486445c9d33ad2994d6fee
2015-10-13clang-analyzer-deadcode.DeadStoresStephan Bergmann
...and reduction of variable scope Change-Id: I1fa14c04646bf9faf35de9e54969589be64ea006
2015-10-13clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since cc316b39d9110c536e1758a4f814738ca209bb02 "Port of Lotus Word Pro filter, by Fong Lin and Noel Power" Change-Id: Ia060ac0fb631d076fefb168ee96d8d2054634fca
2015-10-13Return value of LwpTools::QuickReadUnicode is unusedStephan Bergmann
...since previous commit Change-Id: I439c8d66a826624a3131b56d96ff3fdd030abb28
2015-10-13clang-analyzer-deadcode.DeadStoresStephan Bergmann
...ever since cc316b39d9110c536e1758a4f814738ca209bb02 "Port of Lotus Word Pro filter, by Fong Lin and Noel Power" Change-Id: Ia7eb16a63c53a43f6c57e26aa629f7c9cf7ef089
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-08Resolves: tdf#93818 crash on loading certain lwpCaolán McNamara
Change-Id: I11f523a0936b843155f3b47139d0fc58d4d0342b
2015-10-01Fix typosAndrea Gelmini
Change-Id: I04d1bc3a9f38ff7871d3192563cd1f649fdc6cea Reviewed-on: https://gerrit.libreoffice.org/18960 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-01loplugin:unusedmethodsNoel Grandin
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7 Reviewed-on: https://gerrit.libreoffice.org/18959 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-17boost->stdCaolán McNamara
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-07cppcheck: noExplicitCopyMoveConstructorCaolán McNamara
Change-Id: I8718ddd144bec48541e6412a8c9feb74d9391ecc
2015-09-07cppcheck: operatorEqVarErrorCaolán McNamara
Change-Id: Ie27c7c5d1b0c87a0e440cf57db436c7c46d46788
2015-08-27Help GCCStephan Bergmann
Change-Id: Ibeace7ce7621033cf04e3186c212bbb4a27492a1
2015-08-27Clean up aEmptyStephan Bergmann
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-21add lwp to fftesterCaolán McNamara
Change-Id: I1b31d486de3964a1198fe34e355e9c9542c16c00
2015-08-14loplugin: defaultparamsNoel Grandin
Change-Id: Iabcea466cb23e7a7a432f953cc03aaa1c2dc1d65
2015-08-05improve refcounting loplugin to check SvRef-based classesNoel Grandin
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883 Reviewed-on: https://gerrit.libreoffice.org/17521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I2bf8e7550181aa91e08e5aec84d1972c850ddd4a
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-17remove pointless comments in lotuswordproNoel Grandin
change control, empty documentation tags Change-Id: Iad06c00ebad7dcb7d7d40040d77dee2d6307c9a5
2015-07-17loplugin:unusedmethods lotuswordproNoel Grandin
Change-Id: I17927d48a75c332f1ddc3853145b14daac17f9c0
2015-07-08Fix typosAndrea Gelmini
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-03Fix typosAndrea Gelmini
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510 Reviewed-on: https://gerrit.libreoffice.org/16709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-28Fix typosAndrea Gelmini
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-21Fix typosAndrea Gelmini
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-19Catch inadvertent uses of OUString(sal_Unicode) ctorStephan Bergmann
...with numeric values that are not meant to be characters. Inspired by <https://gerrit.libreoffice.org/#/c/16339/> "OUString: add constructor from single Unicode code point" and ecaf1cb3861c1b519a1495487fc796884cf37b92 "seems to be what was meant." Found e46e8d19458fd64ff20b1013e5eeabd07e62379c "Shall this produce a string representation of a number?" and f2a0e4032734d6be635f14ade3dea499c29ec6c2 "Don't truncate a UTF-32 code point to a UTF-16 code unit." (LIBO_INTERNAL_ONLY mostly because it uses a C++11 delegating ctor for simplicity, but also because it requires mild modifications to client code, see additional changes in this commit and some other recent commits.) Change-Id: I8a156f01d1b772c6052d7afaa088ae13ed234e2b
2015-06-19Remove unnecessary variableStephan Bergmann
Change-Id: Ibec141be604f15d1c6358d3365a7a3e60c135f1f
2015-06-19Use a more straightforward hash functionStephan Bergmann
...instead of assembling a OUString and calling OUString::hashCode. It appears that these hash values are only used in std::unordered_map instantiations, not used as part of a stable file format. Change-Id: Ie3f78b2cc9e162ac9777c7e5f4164a12bc9a62a4
2015-06-19Consistently represent bullet char as OUStringStephan Bergmann
(One difference is that for an XFListLevelBullet for which SetBulletChar has not been called, ToXml will use an empty string now instead of a string containing a single NUL character. But given that initializing m_chBullet to zero in the XFListLevelBullet ctor was only added recently with 72069675955aaf0b72a7842453347e3e7293f56d "coverity#738770: Unitialized scalar field," assume that ToXml is supposed to be only called after SetBulletChar has been called.) Change-Id: I7a5d7496b038cd094ab11ef8cbc1823ffc5bc130
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-13Fix typosAndrea Gelmini
Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-11cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-06-10cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I0081113bf312287fe6e14749a569709ee892d8dd
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I5060e9560f394f872c2338409813dd41f20a2fff
2015-06-07Remove include stdio (part7)Julien Nabet
Change-Id: I7058ac53f4bbf96eff9a36a03279ab0753cc42ba Reviewed-on: https://gerrit.libreoffice.org/16135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-05these types come directly from the file itselfCaolán McNamara
so while invalid they can appear here Change-Id: I36d43958bf578e677f216aea09400ab764ed82ae
2015-06-01loplugin:loopvartoosmallNoel Grandin
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5