Age | Commit message (Collapse) | Author |
|
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.
Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
instead of being randomly embedded somewhere deep inside the CXX code.
Found with:
git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t :
Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a
Reviewed-on: https://gerrit.libreoffice.org/26764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
and add const to LtTm refenrence
Change-Id: I3515db0fa1b79ce73592de6cba0ec79c39a9e9f4
Reviewed-on: https://gerrit.libreoffice.org/26315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and
coverity#1362682 Untrusted loop bound
Change-Id: I97eacad09abed4f91744b36f572761e43a3477fb
|
|
code is actually relying on this clamping behaviour
Change-Id: I7f85679929b2c163dbabe01fc7bb8f1fe2327679
|
|
This patch changes occurences in makefiles
from
$(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \
udkapi \
offapi \
))
to
$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config))
(corrected instead of abandon, jani)
Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e
Reviewed-on: https://gerrit.libreoffice.org/23426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
|
|
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a
Reviewed-on: https://gerrit.libreoffice.org/25972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I224c2d894071d6ec7d0afd5e2780a42b842aa32e
|
|
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d
Reviewed-on: https://gerrit.libreoffice.org/25724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
The build system already defines NDEBUG only if OSL_DEBUG_LEVEL=0 AND
ASSERT_ALWAYS_ABORT=FALSE so the C++ code shouldn't override that.
Change-Id: Ie67a576646cc7e18c3ffac67a3c81b80747ea438
|
|
Change-Id: Ibda82734821f3faa9388f7508e6a3e39e5b5007d
Reviewed-on: https://gerrit.libreoffice.org/25106
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
|
|
Change-Id: I9de983e3c9436ab3a37d3482b0f18f04c7cdaaca
|
|
Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670
|
|
unnecessarily passing primitives by const ref.
Suggested by Tor Lillqvist
Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8e0c2319b2f43b66686fbce372c5df63c75b343a
|
|
Change-Id: I408f630732a10567a3352e0c96f1289a1cf6ca81
Reviewed-on: https://gerrit.libreoffice.org/24534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
this exposes 3 unused private members, detete them.
reorder some initialization to match declaration order.
remove a broken and redundant member initialization
and destruction in xfindex.cxx
(starts loop at 1 and default ctor/dtor do the same)
simplify default ctor in xfframe.cxx
Change-Id: Iaada8849e030d494a9bc7f7b0c3f8f1da3828290
Reviewed-on: https://gerrit.libreoffice.org/24466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I843528327b25d18476f8959cabba16371213a48a
Reviewed-on: https://gerrit.libreoffice.org/24460
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
are actually pointer vars.
Also convert from regex to normal code, so we can enable this
plugin all the time.
Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1
Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I48654972e66b9a298940d800b2e04018cfd5bef8
|
|
check for local variables which follow our member field naming
convention, which is highly confusing
Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
|
|
Change-Id: Ic81341bfb5d2271993451c3bdcf6e94222ac6ec2
|
|
Change-Id: I2bca01e1ac3585674804b94d1cd65c18c41998ac
|
|
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7af6c5f4a14e330924a1ea12ebb6328884b8a565
|
|
Change-Id: I39359389a42e35e0131db1d0451fbd5531843f75
|
|
...lotuswordpro/qa/cppunit/data/fail/null-1.lwp would read 15 into m_eBelowType
Change-Id: Icedcb4c8e2e6309b2e1bd82025feb02bad1ab7da
|
|
Change-Id: I1e53482e722b82f052434f45e37a2fbdb2ea6ffc
|
|
Change-Id: I58025ea906426a7db4079042fa38954f1a3d076b
|
|
Change-Id: Ifbf4312df583724a22328491bea3b6e05b82418f
|
|
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
|
|
Change-Id: I09c2301adb674fbed68a2659f828c7501a90b0c6
|
|
Change-Id: Ief0b70f19630d8d8cc925145848c7a2c8a2813ad
|
|
Change-Id: Ib6008d4b07159acad26c7baeb775702119c12e3b
|
|
Change-Id: I24640971ea6ca89878043966293492a991f01008
|
|
(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)
Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I8f8efa6b01fa0bcab074ac54029d95778cb388ab
|
|
Change-Id: I008591c9d64a99939237e267b9ef6f28b2ef7964
|
|
Change-Id: I639617e41cd9a9a51a3dd3efa32ac1cf2991b9d2
|
|
Change-Id: Ibd17c0f68a9bac92e591fd2c998de45a84b372aa
|
|
to catch calling params with defaults like "= OUSString()"
Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I60a7a6d1b576411bea63f1616f2103ec6f126915
|
|
Change-Id: I45895e9845a9037da207f001fece427452ed499f
|
|
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
|
|
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
18f1eb7b0c3536817572eeb481591418a7eab3da was pushed sooner,
so just few more additions.
Change-Id: If8e8082959fc049947986ca6faf329ea9436062a
|