summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Iad2178f516b4a123175008efcc485fd6812f1027
2015-03-24fix windows buildNoel Grandin
after my commit d7a4135b072a693cb5ebf94c250d34d5beb741e3 "loplugin:constantfunction: lotuswordpro" it appears that Visual Studio does not support this yet Change-Id: Ide04fde905e0991e27ec03c3e216fcbd25b1f10b
2015-03-24loplugin:constantfunction: lotuswordproNoel Grandin
Change-Id: I16fbba302c7330010f9b4c888f48a868ad6b921e
2015-03-23TyposJulien Nabet
Change-Id: Ie08a26a569b83bfe3ef4351dbb7b6e928745b95d
2015-03-19convert SFX_FILTER_ constants to enum classNoel Grandin
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-12TyposJulien Nabet
Change-Id: I55d7440ba5bee16bbce5930c81c604858131b5c7
2015-03-12lotuswordpro: PVS-Studio V674 comparing long to doubleMichael Stahl
Not sure if the GetMRest is supposed to be multiplied with something, but ~nobody knows or uses that format anyway so just suppress the warning. Change-Id: I883d090901cf0be0978579ade24beaed6f6ae5c1
2015-03-11slightly odd stuff hereCaolán McNamara
Change-Id: I715d49722ebe4658c108cb9b7bd6fa3934d973f8
2015-03-08TyposJulien Nabet
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-02-24TyposJulien Nabet
Change-Id: I5f2577dd1f047331a58d33e05684b673e6dbd11e
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-21Various typosJulien Nabet
Change-Id: I61d6a92e5301e07c9180d94dafec23ef1a06e0ef
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: Ic38c44e43d5006626f8673897234f7e11145901e
2015-02-06coverity#1267642 Logically dead codeCaolán McNamara
reviewed the 120+ callers and confirmed it is never NULL Change-Id: I5c029dc35b265d9e11a0a222170dad4d6a55ed2f
2015-02-04coverity#1267665 Logically dead codeCaolán McNamara
inspection shows it can never be null Change-Id: I5160fc1e212996ddea89075d86c6f3a0d0c5da94
2015-02-04coverity#1267650 Logically dead codeCaolán McNamara
inspection shows they can never be null Change-Id: Idffbed313769b232e5476a10ed4df815719606ed
2015-02-04coverity#1267647 Logically dead codeCaolán McNamara
inspection shows its always non null Change-Id: Idc2e0f62a29b635381685f81d0f9f88b3eef659d
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-28Some more loplugin:cstylecast clean-upStephan Bergmann
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-25coverity#1266511 Useless callCaolán McNamara
Change-Id: I0ca967e6e07cc00159612dd8e19648445e0a011a
2015-01-25coverity#1266516 Useless callCaolán McNamara
Change-Id: Icbf0e6ff8bad7e83c596f4e18003a06ba361b5eb
2015-01-24valgrind: uninitialised valueCaolán McNamara
Change-Id: If89368adbecbcf7197afe714fd725497c573b6a9
2015-01-24cppcheck: memset on union containing floating pointer numberCaolán McNamara
Change-Id: I63420f0bae89bae08ae71dc7dedf92dd90ca9728
2015-01-20Some more loplugin:cstylecast: lotuswordproStephan Bergmann
Change-Id: Ic3c08d1f72a61306113520cf2574822c85606689
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018 Reviewed-on: https://gerrit.libreoffice.org/13540 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-18lotuswordpro: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I8cccb8e558aba949d64cf9e7b85316d8e2e15865
2014-12-12callcatcher: remove newly unused codeCaolán McNamara
and rework reads to just return the read value Change-Id: I5d2f01064465c65859ec4ba031ec9dfa16403487
2014-12-11remove LwpSvStream::operator>> methodsNoel Grandin
in favour of ReadXXX methods. Change-Id: Ifa627cf190b22315f4ce294c1ec268c4d1361748
2014-12-10Typo: postion(s)=>position(s)Julien Nabet
Change-Id: Id2957f1cb68fc4b2fef9966abeb6745b548bcb75
2014-12-05loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann
Change-Id: I4a53ebf42add80bbac2d6698ac5d2950c0a6a067
2014-12-03Fix Cannot convert unsigned long* in sal_uLong*David Ostrovsky
Change-Id: I7e44ea91f1202d70ddc4f16aed5890f14f2b2f64 Reviewed-on: https://gerrit.libreoffice.org/13287 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-18tweak for future null deref warningCaolán McNamara
Change-Id: I38590e08a6bd03a2ddfeda466b9cee7128c62aa7
2014-11-17coverity#738972 rework to help coverity outCaolán McNamara
Change-Id: I288eb5ba7a38844af1b517ae7480729c236ebd63
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#738972 Use after freeCaolán McNamara
Change-Id: Iba60fc4ff3b10179ebc700467a3d73e7bc7b64c9
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-07Removed #includes including themselvesAndrea Gelmini
Change-Id: I3fe3227967e07b6b0c82dccf3c9400bfe6e1d729 Reviewed-on: https://gerrit.libreoffice.org/12292 Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-11-01coverity#736401 Resource leakCaolán McNamara
Change-Id: Ice79f5618bb22d2d22d5033a52732da383ff5643
2014-11-01coverity#1250437 : Ressource LeakNorbert Thiebaud
Change-Id: Id1c4885c05c70fedcf85360e3ec7c3e166fa01c6
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23loplugin: cstylecastNoel Grandin
Change-Id: Id4c581724e7e5466ffe46f11f0a8da2527c23dc6
2014-10-18Remove lwpunoheader.hxx.Ruggero Cyrille
Change-Id: I41534baa3cb98fc9af2f12605015a5653e552853
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
generated by cgit (git 2.34.1) at 2025-01-28 11:49:06 +0000