summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2017-03-17Get rid of some unnecessary macrosStephan Bergmann
Change-Id: I872dd72429eae8d183ea1ca8d76fb30b0e8be715 Reviewed-on: https://gerrit.libreoffice.org/35321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-15ofz: avoid oomCaolán McNamara
Change-Id: Ia4b9c46949017a53c80f729af66b99c2e4f05cee
2017-03-15Avoid unnecessary, wrong downcastStephan Bergmann
...causing UBSan failure with the new lotuswordpro/qa/cppunit/data/fail/stack-1.lwp from e68faf7d42179c4f9b90b514f5b3bfcb7f1e9cb0 "ofz#866 crash in LwpFormulaInfo::ReadArguments": > Testing file:///.../lotuswordpro/qa/cppunit/data/fail/stack-1.lwp: > lotuswordpro/source/filter/bencont.cxx:132:11: runtime error: downcast of address 0x60800043af28 which does not point to an object of type 'OpenStormBento::CBenObject' > 0x60800043af28: note: object is of type 'OpenStormBento::CUtListElmt' > 89 7f 00 00 70 94 cc 7f 89 7f 00 00 80 ae 2d 00 70 60 00 00 80 ae 2d 00 70 60 00 00 30 95 cc 7f > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'OpenStormBento::CUtListElmt' > #0 0x7f897ed108f7 in OpenStormBento::LtcBenContainer::RegisterPropertyName(char const*, OpenStormBento::CBenPropertyName**) lotuswordpro/source/filter/bencont.cxx:132:11 > #1 0x7f897ed11df7 in OpenStormBento::LtcBenContainer::FindNextValueStreamWithPropertyName(char const*) lotuswordpro/source/filter/bencont.cxx:227:5 > #2 0x7f897ed12492 in OpenStormBento::LtcBenContainer::FindValueStreamWithPropertyName(char const*) lotuswordpro/source/filter/bencont.cxx:256:12 > #3 0x7f897ef1fc19 in Decompress(SvStream*, SvStream*&) lotuswordpro/source/filter/lwpfilter.cxx:122:72 > #4 0x7f897ef20deb in GetLwpSvStream(SvStream*, LwpSvStream*&) lotuswordpro/source/filter/lwpfilter.cxx:164:14 > #5 0x7f897ef21836 in ReadWordproFile(SvStream&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XDocumentHandler>&) lotuswordpro/source/filter/lwpfilter.cxx:195:13 > #6 0x7f897ed290cd in LotusWordProImportFilter::importImpl(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) lotuswordpro/source/filter/LotusWordProImportFilter.cxx:76:14 > #7 0x7f897ed296fd in LotusWordProImportFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) lotuswordpro/source/filter/LotusWordProImportFilter.cxx:88:12 > #8 0x7f898eb6db9a in (anonymous namespace)::LotusWordProTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) lotuswordpro/qa/cppunit/test_lotuswordpro.cxx:59:27 > #9 0x7f898e3c7901 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:130:20 > #10 0x7f898e3c9fd5 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:158:5 > #11 0x7f898eb6ee58 in (anonymous namespace)::LotusWordProTest::test() lotuswordpro/qa/cppunit/test_lotuswordpro.cxx:64:9 > #12 0x7f898eb7006b in CppUnit::TestCaller<(anonymous namespace)::LotusWordProTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #13 0x7f89d2d74d8b in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #14 0x7f89b944f99f in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14 > #15 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #16 0x7f89c2f440cf in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #17 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #18 0x7f89c6bff2c4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #19 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #20 0x7f89d2cb1350 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #21 0x7f89d2d333ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #22 0x7f89d2d2fe70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 > #23 0x7f89d2def0f5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28 > #24 0x7f89d2d72fa4 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #25 0x7f89d2d777a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #26 0x7f89d2d76819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #27 0x7f89d2d777a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #28 0x7f89d2d76819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #29 0x7f89d2e2d5c9 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #30 0x7f89d2ded40d in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9 > #31 0x7f89d2e2e89b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #32 0x53043c in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20 > #33 0x52c089 in sal_main() sal/cppunittester/cppunittester.cxx:455:20 > #34 0x52a742 in main sal/cppunittester/cppunittester.cxx:362:1 > #35 0x7f89d0fb8400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #36 0x437d49 in _start (workdir/LinkTarget/Executable/cppunittester+0x437d49) Change-Id: I556c3ab6fcc7a08fceac5a7195f81d570fc2a025
2017-03-14ofz#866 crash in LwpFormulaInfo::ReadArgumentsCaolán McNamara
Change-Id: Id301c21c8a4a0556b6326b621171aa62bd939d8d
2017-03-14improve scopingCaolán McNamara
Change-Id: Ie5a5eacddba747d3b9cff6b8252add54473eb3f2
2017-03-14ofz: use std::vector for long buffersCaolán McNamara
and set size of buffer to successfully read data for short reads Change-Id: I8d132446682104f2a4b8c476b7f2bda188bb3cdf
2017-03-13ofz#836 fix leakCaolán McNamara
Change-Id: Ifd818cdf81516bd449db14bb1e84ed508e4b7d96
2017-03-12Fix typosAndrea Gelmini
Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7 Reviewed-on: https://gerrit.libreoffice.org/35055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-11ofz: turn assert into throwCaolán McNamara
cause size arg is controllable by the file data Change-Id: Ia92b56c04271557afbec1ab47620bcb34f1c0e8a
2017-03-10ofz#801 avoid oomCaolán McNamara
Change-Id: Id3167d1eb3f058543ab7596008012d51b3d242b7
2017-03-07loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ifaa80d22852a6806a7a5c267164383a356fa0086
2017-03-04fail on unknown version flagsCaolán McNamara
Change-Id: Icbd2608a3341652b1b40f6bdebb66c4caf6e810a Reviewed-on: https://gerrit.libreoffice.org/34894 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02fix leakCaolán McNamara
Change-Id: Ic91bb15cafa97538a61247660044c1af57b59d84
2017-03-02add lwp fuzzerCaolán McNamara
Change-Id: I72a2d8ce47059f9af65d89fbdcc09d96c40cb79b
2017-03-02avoid recursive register styleCaolán McNamara
Change-Id: I090cec1f311be5e5a34e208d066925b294310e43
2017-03-02Fix typosAndrea Gelmini
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b Reviewed-on: https://gerrit.libreoffice.org/34803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02fix leakCaolán McNamara
Change-Id: I01c7ebf10831a27eaab55c2082cbe0a0f28bda1f
2017-03-02dig out lotuswordpros table limitsCaolán McNamara
Change-Id: Iea7d436a78336de150b3d3ae317b99b554fb8657
2017-03-01build WordProCellsMap much fasterCaolán McNamara
Change-Id: I1fbc1f7ec14c8133fb8fcd3532d5d551dcc7ddfb
2017-03-01ofz: oom on seeks past end of SvMemoryStreamCaolán McNamara
cause it grows to fit if its a resizable stream Change-Id: I28b42becdfc8eb591d19d2512cdc1f1ec32c3bbe
2017-03-01fix leakCaolán McNamara
Change-Id: I61e21619e949fe0dda7c4820e6ddbb8d4d597652
2017-03-01fix leakCaolán McNamara
Change-Id: I985d422f4c0b41937e4df616fb3154bb7cbad28d
2017-03-01fix leakCaolán McNamara
Change-Id: I7f87bf07e50baffd463d4429186928642bdf73b3
2017-03-01fix leakCaolán McNamara
Change-Id: I6e3d1d3b43967f10a151a6b696a863383a7b1776
2017-03-01coverity#1401593 Wrapper object use after freeCaolán McNamara
Change-Id: I7fdaf527ffbe7d3d952c17c62707bb4a22b05f1d
2017-02-28fix leakCaolán McNamara
Change-Id: Ia073517977648a21d7adb5ee4d7bda51b1b7db18
2017-02-28endless loop on corrupt lwpCaolán McNamara
Change-Id: Ie984d396a6c0055fc5175755fd42161749c572be
2017-02-28fix leakCaolán McNamara
Change-Id: I57d1ae4d8f3fed72f024672a9eefb748df83bb93
2017-02-28fix leakCaolán McNamara
Change-Id: Id6171fbaffda1f0a20d33e9137d68e14c59e6aac
2017-02-28fix leakCaolán McNamara
Change-Id: Icce163a695ce5467d943019919de1bb604dd130b
2017-02-28fix leakCaolán McNamara
Change-Id: Id501339e1576277655c53e0cf0d172947640d64e
2017-02-28loplugin:subtlezeroinitCaolán McNamara
Change-Id: I29197c9a4093d904d1f7b990de08fbf8254c168e
2017-02-28fix leakCaolán McNamara
Change-Id: I724c6e50392d70acd847c733e09a959c08c8c790
2017-02-28std::unique_ptr -> rtl::Reference for loplugin:refcountingCaolán McNamara
Change-Id: I83cccff1f4fb172e1b6aa5c1cfda93de2e4be525
2017-02-28fix leakCaolán McNamara
Change-Id: Ic84035f68075733a6777a7447cb2be092f17a189
2017-02-28fix leakCaolán McNamara
Change-Id: I20e665a2b0bfadd44976b1659d85b1828e10311f
2017-02-28fix leakCaolán McNamara
Change-Id: I88e652fa2eab8738d0e1a235cf1a3f9066bfc230
2017-02-28fix leakCaolán McNamara
Change-Id: I195094adfd0a68401d26ef97b6489b105424b99b
2017-02-28fix leakCaolán McNamara
Change-Id: I1c1e861c5608ccd2071baf683f5456c3012a47f6
2017-02-27fix leakCaolán McNamara
Change-Id: If7f710aa62cea43e2c59d91e136daba9650b3912
2017-02-27fix leakCaolán McNamara
Change-Id: I00438178582bd4c78bffeca18067abeb667b8367
2017-02-27fix leakCaolán McNamara
Change-Id: Ie352e9b7fe52d41492141ebba9b5d332960dadd5
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: Icf0e75d0e213c4562f4ee57df0537d394031645b
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I682b4e2750658efded5f4167d4f7026ed5fac8dc
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I7f490335efef71b13aae66e9467cd74429509d7d
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I00e73eabb34ae98088a8e88d0c8677bf236a5e09
2017-02-27ofz: fix leakCaolán McNamara
Change-Id: I631ea0012f8e999f14aa08b42f28d6115a73d084
2017-02-23Better make the zero-initialization more explicitStephan Bergmann
...if initializing offset is necessary at all; a bit hard to tell from the code. Change-Id: Ic1d7c97f174e3ed04b03f4004ca858029e9a258e
2017-02-23Better make the zero-initialization more explicitStephan Bergmann
...if initializing RevisionType is necessary at all; a bit hard to tell from the code. Change-Id: Ic472c8cceb818b7e18d3de348f392f8641d85255
generated by cgit (git 2.34.1) at 2025-01-11 19:18:08 +0000