summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2023-05-02ofz#58529 Null-dereference READCaolán McNamara
Change-Id: I9d8ea7d40429faee94889e4d2d9df7440b18e65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24loplugin:unnecessarygetstr extend to createFromAsciiNoel Grandin
idea from mike kaganski Change-Id: I0ecb9cad091d7a048d2ddae73165bf22748f3872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-10ofz#57800 TimeoutCaolán McNamara
Change-Id: I14b4906ce61b3d8a86cb9a766986c49e0b0e6abc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#143148: Use pragma once instead of include guardsjpuronah
Change-Id: I8369e0bdb6a01838d87e7cddc1cbaed911fe461a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149952 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-06no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I09a0392f8d0b067a3a8e4105568b578ef4795c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-15Merge SvXMLAttributeList to comphelper::AttributeListMike Kaganski
And simplify the latter, to always use "CDATA" type (as the former did). "CDATA" was used in all cases but one, where an empty string was used. Change-Id: I1b3bfae40e29628e4094d9a6e58a69a66865874c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145526 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-12ofz#55034 Stack-buffer-overflow in vcl::bitmap::CreateFromDataCaolán McNamara
since: commit 21734247d58a6e915b058d8fa55ece949d049613 Date: Tue Jan 10 12:56:58 2023 +0200 drop internal support for 1-bit images the input data is still 1 bit here, even if the output will be 8 bit Change-Id: Ib7eb301b2e62ebc61ee61ebb99e6de92c1f4931b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145410 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12drop internal support for 1-bit imagesNoel Grandin
on modern hardware, these are less efficient than regular alpha channels. Also, this greatly simplies the range of stuff that vcl needs to deal with, which will make the upcoming transparency->alpha patch easier to deal with. Enhance vcl::CreateFromData to convert incoming 1-bit data to 8-bit image. Change-Id: I35829da750029fe373d0d2911a669d10bab6ad23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-24loplugin:unusedfields make some fields privateNoel Grandin
this is one of the secondary analyses this plugin performs Change-Id: I1c496e234513362338600180e51f7e71e605a7cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-08UnoApiTest: simplify code by using tempfile memberXisco Fauli
SwModelTestBase does the same. this will help to make SwModelTestBase inherit from UnoApiTest Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-06-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): lotuswordproStephan Bergmann
Change-Id: I6b9707c1f416eb1ab890ff0d783151066cf695d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142329 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-01CppunitTest_lotuswordpro_import_test: inherit from UnoApiTestXisco Fauli
Change-Id: I6287ea3b0ed24a8dca002b95d59120ce302fc2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142100 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-17use more string_viewNoel Grandin
Change-Id: Ie826234aa9064b08b8f0647738b57c47ac0ed91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-09ofz#51149 avoid TimeoutCaolán McNamara
Change-Id: I7709e69154d231e597d364210bc876afca3df4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09rearrange to have a single ConvertTable callCaolán McNamara
Change-Id: Ic48ebac04d6e95df8748f38b1f23a8295fba77b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139718 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-30ofz#50756 Direct-leakCaolán McNamara
Change-Id: I76404a154bcf5b3724970ce546f64c0a3cf2f282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-21Fix typosAndrea Gelmini
Change-Id: I62b11b80e4d3d2a8bd4c461804f39d8da6a58066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137298 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-21tdf33787 lotuswordpro: fix increments of ordered bulletsBartosz Kosiorek
With previous implementation there was an bug which causing missing incrementing ordered bullets. For example: A. Lettered bullet uppercase 1 (A. ) A. Lettered bullet uppercase 2 (B. ) A. Lettered bullet uppercase 3 (C. ) This patch is fixing that, and increments is working correctly: A. Lettered bullet uppercase 1 (A. ) B. Lettered bullet uppercase 2 (B. ) C. Lettered bullet uppercase 3 (C. ) It is also make sure that nested and skipped bullets are working correctly: 1) Numbered bullet w/ bracket one (1) ) Skipped bullet 2) Numbered bullet w/ bracket two (2) ) a) Lettered bullet w/ bracket lowercase 1 (a) ) b) Lettered bullet w/ bracket lowercase 2 (b) ) Change-Id: I1d1ad9ee549039077b418756efefb10bacfa1ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137112 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-07-14tdf#112626 lotuswordpro: switch to constexpr and update documentationBartosz Kosiorek
Change-Id: I566c22285978f7b31961d105d02d99d0696908b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137041 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-06-23clang-tidy modernize-pass-by-value in lotuswordproNoel Grandin
Change-Id: Ia20d653bdfedf49430f8ba46c8200c2b96734d81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-02loplugin:stringviewparam convert methods using compareToNoel Grandin
which converts to compare Change-Id: If03c790ea113a7caedbe89f926b29055c9ec1e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23tdf#147906 Use std::hypot for Pythagorean additionVaibhavMalik4187
Change-Id: I7813b9929771858d33e951e50e6de7893fe19085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131684 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-16tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macropsidiumcode
Change-Id: Ia711e939f769c6a2257bd1fb3607b315f931a0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131634 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-13Fix typo in codeAndrea Gelmini
Change-Id: Id38f846aaf451d94e975e049f6494a6261eb4ae3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131494 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-13ofz#45524 string is presumed to be at least length 1Caolán McNamara
Change-Id: If8a86e399109b414cf53f6e2bffdd3c7c6faa490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11new loplugin:trivialdestructorNoel Grandin
look for potentially trivial destructors that can then be elided Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02Fix typoAndrea Gelmini
Change-Id: Ice5721d480567be4f8a4a79da6e01a6a389bf4bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129318 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-01ensure bounds checkingzhutyra
LIBREOFFICE-SBQ5TJRS Change-Id: I71f35bc120fdd70298685131f29a6bb822d50f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-01read of width/height uses wrong record sizezhutyra
this initially went wrong at: commit b4fb7a437bb0ce987702b12008737756623618ac Date: Mon May 23 21:38:40 2011 +0100 fix up some more endian LIBREOFFICE-SBQ5TJRS Change-Id: Ie418f530f55288351f73f3c0cbab9ac48e6b6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129293 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28ofz: Undefined-ShiftCaolán McNamara
Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27Recheck modules [i-l]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I758bb27e93779e3df21c463714e49354748f446f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-26ofz#44080 throw exception on a negative lengthCaolán McNamara
Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-22ofz#43949 TimeoutCaolán McNamara
Change-Id: Ia1691d30e754924314d39d733135614db4c56834 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz#43689 Direct-LeakCaolán McNamara
Change-Id: I09823f30817163b0467b6b96f56956987337b991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-20ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ia19985b7c042e6ab9608220343e3b678890f7215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic5f41e4f1f6b20a8cd8887807296f33adb48b728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I77847175d5ad0b2757eb24fcff08a4caf5d77519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib1c3b306573dda073f6ff3d7d0cc17aef39c0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-16ofz#43689 Null-dereferenceCaolán McNamara
Change-Id: I6edb50b3c281d50187d8965ce9665a9aae0e9098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-15Let loplugin:nullptr look into template instantiationsStephan Bergmann
It missed some occurrences of 0 when only looking into uninstantiated template code, as Clang doesn't model them with an ImplicitCastExpr, even if the target is known to be a (dependent) pointer type. Looking into all template instantiations of course carries the risk that a given use of 0 is meant to be interpreted as a pointer in some and as an integer in other instantiations. But the only case where that happened in the current code base is RegistryValueList::getElement (include/registry/registry.hxx), where {} is arguably a better choice anyway. (And which would presumably also hold for any future such cases.) Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-01-13ofz#43577 valid reclen must be >= 20Caolán McNamara
Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-12ofz: Direct-leakCaolán McNamara
Change-Id: Iedef8c99f0650750f5cfd808ac36421cc0d5c281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128316 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-12ofz#43551 Use-of-uninitialized-valueCaolán McNamara
Change-Id: I2eb139f3bff296cff7d8f0e9a05f19df56b27ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-11ofz#43509 use std::vector and at()Caolán McNamara
Change-Id: Id0c5e4ccc22b41caee95ca5f53f6ae7cf70490f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128263 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-10use less SvStream::Flush()Noel Grandin
Flush() turns into a sync() on the device, which is pretty slow. Most of the time all we actually want to do is to flush the internal buffers from the SvStream. So expose the FlushBuffer method and use that where possible. And also means we don't need the mbDontFlushOnClose flag on SvStream any more. Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-10ofz: Use-of-unintialized-valueCaolán McNamara
Change-Id: I6c9a1a22240defbc8d9fa262ad087770445ffc4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-09ofz#43818 delete of uninitialized pointerCaolán McNamara
Change-Id: I91509915c18c3e9b54cb3047462b9dd9a8c7a46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-09ofz#43458 avoid OOMCaolán McNamara
Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-31 01:27:03 +0000