summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)Author
2024-05-11cid#1597280 Dereference null return valueCaolán McNamara
Change-Id: I0275c178a478b7143b0cf4ed19f030009b7bd2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167504 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-10loplugin:ostr in lotuswordproNoel Grandin
Change-Id: Ifea660ab9e0663312f9013670c27d3feda314d81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-30tdf#145614 Convert #define to enumNima Mahanloo
Change-Id: I0a360a93775d2c46b7e02009879d7a18315497b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166168 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-04-14Use more o3tl::convert in lotuswordproMike Kaganski
Change-Id: I7ec74dc105f846307f5bf3d3c8cedcc4aebb64a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166058 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-14tdf#141908 - CppUnittests: replace usage of sal_Int32 with colorsRafał Dobrakowski
Conversion of hex/dec colour notation (example entry Color( 255, 255, 255), Color(0xFFFFFF) - COL_WHITE) For the other available colour definitions. Change-Id: I9eed0cd64adcbc8d25e1c22143a000906a457586 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163729 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-02-12tdf#145538 use range based for loopsKeldin Maldonado (KNM)
using range based for loops instead of index based to increase readability in codebase Change-Id: Ib8c3ec3796fce9228cee1d90beb924128b0dea3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162950 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-01-27Drop std::as_const from css::uno::Sequence iterationsMike Kaganski
Obsoleted by commit 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code, 2021-11-05). Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-01-03UnoApiTest::loadFromURL -> UnoApiTest::loadFromFileMike Kaganski
The old name was misleading (it doesn't take an URL, but a filename); also, now it's easier to grep for it - doesn't get mixed with vcl::graphic::loadFromURL. Change-Id: Ib88d2194200a6a54d2326971e0306ba39f0c7025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161578 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-01-02ofz#64860 TimeoutCaolán McNamara
Change-Id: Ib475cbba118f0705b9475dbe61ec1b96a68af47c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-30move IsFuzzing to comphelperCaolán McNamara
and try something a bit more generic Change-Id: I1d8256576cd02f0a589df350ba7b53059dd586a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-17Static map initialization in lotuswordpro/lwpnumericfmtJulien Nabet
Change-Id: I7894e8b7bf9b4d4c25e1c75551cae2b58b26d6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160881 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-12-10cid#1546281 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546278 COPY_INSTEAD_OF_MOVE cid#1546276 COPY_INSTEAD_OF_MOVE cid#1546247 COPY_INSTEAD_OF_MOVE cid#1546244 COPY_INSTEAD_OF_MOVE cid#1546243 COPY_INSTEAD_OF_MOVE cid#1546220 COPY_INSTEAD_OF_MOVE cid#1546209 COPY_INSTEAD_OF_MOVE cid#1546207 COPY_INSTEAD_OF_MOVE cid#1546206 COPY_INSTEAD_OF_MOVE cid#1546205 COPY_INSTEAD_OF_MOVE cid#1546197 COPY_INSTEAD_OF_MOVE cid#1546180 COPY_INSTEAD_OF_MOVE cid#1546172 COPY_INSTEAD_OF_MOVE cid#1546165 COPY_INSTEAD_OF_MOVE cid#1546164 COPY_INSTEAD_OF_MOVE cid#1546158 COPY_INSTEAD_OF_MOVE cid#1546151 COPY_INSTEAD_OF_MOVE cid#1546135 COPY_INSTEAD_OF_MOVE cid#1546132 COPY_INSTEAD_OF_MOVE cid#1546129 COPY_INSTEAD_OF_MOVE cid#1546128 COPY_INSTEAD_OF_MOVE cid#1546122 COPY_INSTEAD_OF_MOVE cid#1546117 COPY_INSTEAD_OF_MOVE cid#1546113 COPY_INSTEAD_OF_MOVE cid#1546106 COPY_INSTEAD_OF_MOVE cid#1546099 COPY_INSTEAD_OF_MOVE cid#1546091 COPY_INSTEAD_OF_MOVE cid#1546085 COPY_INSTEAD_OF_MOVE cid#1546069 COPY_INSTEAD_OF_MOVE cid#1546063 COPY_INSTEAD_OF_MOVE cid#1546062 COPY_INSTEAD_OF_MOVE cid#1546058 COPY_INSTEAD_OF_MOVE cid#1546056 COPY_INSTEAD_OF_MOVE cid#1546051 COPY_INSTEAD_OF_MOVE cid#1546040 COPY_INSTEAD_OF_MOVE cid#1546030 COPY_INSTEAD_OF_MOVE cid#1546028 COPY_INSTEAD_OF_MOVE cid#1546015 COPY_INSTEAD_OF_MOVE cid#1546001 COPY_INSTEAD_OF_MOVE Change-Id: Ib954c92a300fc323b29f27880fdf8bc46ed98862 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160520 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-09cid#1556778 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546474 COPY_INSTEAD_OF_MOVE cid#1546473 COPY_INSTEAD_OF_MOVE cid#1546469 COPY_INSTEAD_OF_MOVE cid#1546467 COPY_INSTEAD_OF_MOVE cid#1546458 COPY_INSTEAD_OF_MOVE cid#1546448 COPY_INSTEAD_OF_MOVE cid#1546446 COPY_INSTEAD_OF_MOVE cid#1546441 COPY_INSTEAD_OF_MOVE cid#1546424 COPY_INSTEAD_OF_MOVE cid#1546377 COPY_INSTEAD_OF_MOVE cid#1546374 COPY_INSTEAD_OF_MOVE cid#1546352 COPY_INSTEAD_OF_MOVE cid#1546334 COPY_INSTEAD_OF_MOVE cid#1546328 COPY_INSTEAD_OF_MOVE cid#1546310 COPY_INSTEAD_OF_MOVE cid#1546303 COPY_INSTEAD_OF_MOVE Change-Id: I8a43fdd574857ba1d3ec416f23c8269a9a08e12f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-24changed sal_uInt8 to BenError (enum)sahil
Change-Id: Ia7cb2f879b7be833d1a5ccf845a8dc8bfb94befd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156900 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-23Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]StringStephan Bergmann
...in include files. This is a mix of automatic rewriting in include files and manual fixups (mostly addressing loplugin:redundantfcast) in source files that include those. Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-07loplugin:ostr: automatic rewriteStephan Bergmann
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-09-12tdf#114441 - Convert sal_uLong to better integer typessahil
Change-Id: Idc6de0c0275ce9913e248548466b77aaef180d7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155873 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-02ofz#58529 Null-dereference READCaolán McNamara
Change-Id: I9d8ea7d40429faee94889e4d2d9df7440b18e65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-24loplugin:unnecessarygetstr extend to createFromAsciiNoel Grandin
idea from mike kaganski Change-Id: I0ecb9cad091d7a048d2ddae73165bf22748f3872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-10ofz#57800 TimeoutCaolán McNamara
Change-Id: I14b4906ce61b3d8a86cb9a766986c49e0b0e6abc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#143148: Use pragma once instead of include guardsjpuronah
Change-Id: I8369e0bdb6a01838d87e7cddc1cbaed911fe461a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149952 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-06no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: I09a0392f8d0b067a3a8e4105568b578ef4795c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-15Merge SvXMLAttributeList to comphelper::AttributeListMike Kaganski
And simplify the latter, to always use "CDATA" type (as the former did). "CDATA" was used in all cases but one, where an empty string was used. Change-Id: I1b3bfae40e29628e4094d9a6e58a69a66865874c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145526 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-12ofz#55034 Stack-buffer-overflow in vcl::bitmap::CreateFromDataCaolán McNamara
since: commit 21734247d58a6e915b058d8fa55ece949d049613 Date: Tue Jan 10 12:56:58 2023 +0200 drop internal support for 1-bit images the input data is still 1 bit here, even if the output will be 8 bit Change-Id: Ib7eb301b2e62ebc61ee61ebb99e6de92c1f4931b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145410 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-12drop internal support for 1-bit imagesNoel Grandin
on modern hardware, these are less efficient than regular alpha channels. Also, this greatly simplies the range of stuff that vcl needs to deal with, which will make the upcoming transparency->alpha patch easier to deal with. Enhance vcl::CreateFromData to convert incoming 1-bit data to 8-bit image. Change-Id: I35829da750029fe373d0d2911a669d10bab6ad23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145321 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-24loplugin:unusedfields make some fields privateNoel Grandin
this is one of the secondary analyses this plugin performs Change-Id: I1c496e234513362338600180e51f7e71e605a7cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-08UnoApiTest: simplify code by using tempfile memberXisco Fauli
SwModelTestBase does the same. this will help to make SwModelTestBase inherit from UnoApiTest Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-06-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): lotuswordproStephan Bergmann
Change-Id: I6b9707c1f416eb1ab890ff0d783151066cf695d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142329 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-01CppunitTest_lotuswordpro_import_test: inherit from UnoApiTestXisco Fauli
Change-Id: I6287ea3b0ed24a8dca002b95d59120ce302fc2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142100 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-17use more string_viewNoel Grandin
Change-Id: Ie826234aa9064b08b8f0647738b57c47ac0ed91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141369 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-09ofz#51149 avoid TimeoutCaolán McNamara
Change-Id: I7709e69154d231e597d364210bc876afca3df4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-09rearrange to have a single ConvertTable callCaolán McNamara
Change-Id: Ic48ebac04d6e95df8748f38b1f23a8295fba77b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139718 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-30ofz#50756 Direct-leakCaolán McNamara
Change-Id: I76404a154bcf5b3724970ce546f64c0a3cf2f282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139015 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-21Fix typosAndrea Gelmini
Change-Id: I62b11b80e4d3d2a8bd4c461804f39d8da6a58066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137298 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-21tdf33787 lotuswordpro: fix increments of ordered bulletsBartosz Kosiorek
With previous implementation there was an bug which causing missing incrementing ordered bullets. For example: A. Lettered bullet uppercase 1 (A. ) A. Lettered bullet uppercase 2 (B. ) A. Lettered bullet uppercase 3 (C. ) This patch is fixing that, and increments is working correctly: A. Lettered bullet uppercase 1 (A. ) B. Lettered bullet uppercase 2 (B. ) C. Lettered bullet uppercase 3 (C. ) It is also make sure that nested and skipped bullets are working correctly: 1) Numbered bullet w/ bracket one (1) ) Skipped bullet 2) Numbered bullet w/ bracket two (2) ) a) Lettered bullet w/ bracket lowercase 1 (a) ) b) Lettered bullet w/ bracket lowercase 2 (b) ) Change-Id: I1d1ad9ee549039077b418756efefb10bacfa1ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137112 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-07-14tdf#112626 lotuswordpro: switch to constexpr and update documentationBartosz Kosiorek
Change-Id: I566c22285978f7b31961d105d02d99d0696908b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137041 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2022-06-23clang-tidy modernize-pass-by-value in lotuswordproNoel Grandin
Change-Id: Ia20d653bdfedf49430f8ba46c8200c2b96734d81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-01use more string_view in variousNoel Grandin
found by examining uses of OUString::copy() for likely places Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-02loplugin:stringviewparam convert methods using compareToNoel Grandin
which converts to compare Change-Id: If03c790ea113a7caedbe89f926b29055c9ec1e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-03-23tdf#147906 Use std::hypot for Pythagorean additionVaibhavMalik4187
Change-Id: I7813b9929771858d33e951e50e6de7893fe19085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131684 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-16tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macropsidiumcode
Change-Id: Ia711e939f769c6a2257bd1fb3607b315f931a0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131634 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-03-13Fix typo in codeAndrea Gelmini
Change-Id: Id38f846aaf451d94e975e049f6494a6261eb4ae3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131494 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-03-13ofz#45524 string is presumed to be at least length 1Caolán McNamara
Change-Id: If8a86e399109b414cf53f6e2bffdd3c7c6faa490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-11new loplugin:trivialdestructorNoel Grandin
look for potentially trivial destructors that can then be elided Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-02Fix typoAndrea Gelmini
Change-Id: Ice5721d480567be4f8a4a79da6e01a6a389bf4bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129318 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-01ensure bounds checkingzhutyra
LIBREOFFICE-SBQ5TJRS Change-Id: I71f35bc120fdd70298685131f29a6bb822d50f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-01read of width/height uses wrong record sizezhutyra
this initially went wrong at: commit b4fb7a437bb0ce987702b12008737756623618ac Date: Mon May 23 21:38:40 2011 +0100 fix up some more endian LIBREOFFICE-SBQ5TJRS Change-Id: Ie418f530f55288351f73f3c0cbab9ac48e6b6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129293 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-28ofz: Undefined-ShiftCaolán McNamara
Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27Recheck modules [i-l]* with IWYUGabor Kelemen
See tdf#42949 for motivation Change-Id: I758bb27e93779e3df21c463714e49354748f446f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-26ofz#44080 throw exception on a negative lengthCaolán McNamara
Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-30 08:05:08 +0000