Age | Commit message (Collapse) | Author |
|
Change-Id: I38590e08a6bd03a2ddfeda466b9cee7128c62aa7
|
|
Change-Id: I288eb5ba7a38844af1b517ae7480729c236ebd63
|
|
Sadly cannot forward declare "struct {...} TimeValue;".
rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...
Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
|
|
Change-Id: Iba60fc4ff3b10179ebc700467a3d73e7bc7b64c9
|
|
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I3fe3227967e07b6b0c82dccf3c9400bfe6e1d729
Reviewed-on: https://gerrit.libreoffice.org/12292
Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Ice79f5618bb22d2d22d5033a52732da383ff5643
|
|
Change-Id: Id1c4885c05c70fedcf85360e3ec7c3e166fa01c6
|
|
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Id4c581724e7e5466ffe46f11f0a8da2527c23dc6
|
|
Change-Id: I41534baa3cb98fc9af2f12605015a5653e552853
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
and
coverity#1242739 Untrusted loop bound
Change-Id: I2cab9b3c531befc42c1522dd0d4beb59df7ae315
|
|
Change-Id: Iba6d6b77fe30e11f50e16c1ee899b71ea4337355
|
|
Change-Id: I8575a43a095165a81417f169463aaf2c4ab337e8
|
|
Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
|
|
...from times when code used std::auto_ptr.
Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
|
|
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I205b84f6dcb996935bd59ac9927313c6a88066b4
|
|
Change-Id: I8a3d2aa6e0a6ee5bdb214f768870dc69d15e513d
|
|
Change-Id: I116d5e14116e6853765bce552b6b8a71c835942e
|
|
Change-Id: Ib04d885fdbf3f46be08c857a28fcea210be1623a
|
|
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
|
|
...CUtList::cDummyElmt is always only of type CUtListElmt, not a derived type.
Change-Id: Ibc372642e2a53c548421b5cfa7cc496986036815
|
|
Change-Id: I94619f2a3274c719366ae947771e10ffc39f70fe
|
|
and
coverity#1222239 Untrusted value as argument
Change-Id: I48bacfd988a34d67ffa542edba7cba1bb9b0b3cc
|
|
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
|
|
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
|
|
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
|
|
Change-Id: I8e6a81b6c1605bd1be33f5f8d75d2472a39361d4
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
and coverity#736886 Unintended sign extension
promote from unsigned short to size_t immediately rather than implicitly to int
and then have the int result widened to size_t
Change-Id: I3156ed9628287a84da35d97caec8d91ce942986d
|
|
Change-Id: Ieceecb849ade05a4f6dcd6c783da6ab53508323d
|
|
Change-Id: I8c94c63230eec13bf22043ff07f9f480a0463111
|
|
Change-Id: Ifdb7c139fa6db7fef2896098f758769cb5284b28
|
|
Change-Id: Id4d5d6aaf537172ad8e1f6c422465c6f84d99dbf
|
|
Change-Id: I11bdee00bd42ef302dbbfe9f52de5824aec985ee
|
|
Change-Id: I08bd15316e7952d05b769326c0a8a1d3493b0eb8
|
|
Change-Id: I727ae1c4a2c1a0c321580a9a8948c48ee9bbfcab
|
|
Change-Id: If83bcfb0e39c0b41ea5323b0ad3832bd65185c6c
|
|
Change-Id: I9db006805bfd457663762e2fd2863d096b2547b4
|
|
after my commit 184a00b96235f6432294ded63ce4a4a318effdb5
"loplugin: inlinesimplememberfunctions"
Change-Id: Ib46d862b90566506c3035a12eeb01892b225ed51
|
|
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
|
|
Change-Id: I32b6475812be6dfd9912f7fc6646b349cdbfbbe1
|
|
Change-Id: I8e182a18e70f230e67f2f452bbfca442e5585212
|
|
Change-Id: I790904fb030d2bfc96cd967b2b4b449e62f8c536
|
|
Change-Id: I1539597cd5bcabcbf0295d1acc320c503ad53604
|
|
(assuming this shall always be little endian, given "Intel" in the function names)
Change-Id: Iff7e1305108dd0f8d9fae762c1f715e2e7b481b3
|