Age | Commit message (Collapse) | Author |
|
NSS is very ABI compatible and part of current LSB 5.0 and so it should
just work to use the one from the system, i'm not aware of a Linux that
doesn't ship it.
There used to be some feature patch in external/nss but this was removed
years ago, now it just contains build fixes.
Problems can occur if a mixture of system and bundled NSS libraries is
loaded, if first an old version .so is loaded and then newer version .so
depends on it but can't find some required symbol.
See for example:
https://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg287043.html
Another issue is that e.g. Fedora ships libnsspem.so in the nss-pem
package, which may cause trouble in ASAN builds, where the internal NSS
is built to call __asan_poison_memory_region but the system
libnss-pem.so doesn't call __asan_unpoison_memory_region so we get:
==2568944==ERROR: AddressSanitizer: use-after-poison on address 0x61d0019afab0
WRITE of size 192 at 0x61d0019afab0 thread T28 (utl::Moderator)
0 in __interceptor_memset.part.0 (instdir/program/soffice.bin+0x466460)
1 (/lib64/libnsspem.so+0x15f3d)
2 (/lib64/libnsspem.so+0x16185)
3 (/lib64/libnsspem.so+0x8a9b)
4 (/lib64/libnsspem.so+0xe13b)
5 in secmod_ModuleInit workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
..
21 in curl_easy_perform workdir/UnpackedTarball/curl/lib/easy.c:715:10
Also, with system NSS, things like p11-kit integration become
responsibility of the OS.
Change-Id: I50caedd46914dd5d6905c5d32d44a599cd78119e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120388
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Since commit 8677e994d37329a28ca8278358a99d18b9cada69 ("Simplify
FONTCONFIG and FREETYPE tests"), these tests adhered to the
${with_system_libs} setting, which might not be desirable.
As a result commit 4e7f3692c9eb42a00797025289782baa69a42cc7
("Make external/freetype use -fPIC") is needed as a linking fix.
This still keeps the possibility to build with internal freetype
and fontconfig. This also adds a new macro option, "test-system",
which follows the $test_system_* variable without additional
configure switches.
Change-Id: Ifed91fdc6e4a77f708a3dbbd784b6069bf2a61b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127878
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: Id912495169b6c83ce9798a13d24e1cf4b9e83a52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127723
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Adds the possibility to have default-disabled externals and
various fixed variants. The reorganized option handling is also
easier to follow. Can't use the newer m4_case, so this uses m4_if
with multiple compares, but the code difference is minimal.
This also swaps the 4th and 5th argument to reflect the precedence
of "enabled" over the "system" handling. And since these now have
multiple values, TRUE was replaces with more sensible strings.
These and the other arguments are now checked, as possible.
I've also thought about dropping the 2nd argument for m4_toupper,
but that changes to much for just a minimal gain.
Change-Id: I22e835d81f9288f22d42be36e939374f7a455599
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127424
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
... and just use *_(CFLAGS|LIBS)_internal variables.
Requires deterministic variable names in configure.ac.
Change-Id: Id3f53ca5e6189e531596265945531f4a789a035c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127638
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
... by expanding libo_CHECK_SYSTEM_MODULE with yet an other
parameter to optionally disable the feature completely and
adding the matching AC_ARG_ENABLE.
As a result, --disable-cmis becomes --disable-libcmis.
Also adds more documentation to m4/libo_externals.m4.
And use simpler help strings, now hopefully correctly escaped.
Change-Id: I8ac67145721d8518cca6f6867bc05738a87ed77a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126771
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Add an additional option to libo_CHECK_SYSTEM_MODULE to select
the default external lookup.
Don't "if" the libo_CHECK_SYSTEM_MODULE, so the AC_SUBST are
always run, but set the test_* flags instead.
Change-Id: Ie0a1204b34d596fdd57a7ee770418f91bf8c5d00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126464
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Automatically adds an ENABLE_* AC_SUBST and test for a disabled
test via test_*, like ENABLE_EPUBGEN and test_libepubgen.
Change-Id: Ifaf27d4d1193f41de6291ab70d973fe151f36b2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126169
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
The goal is to avoid build breakage by pkg-config or whatever helpfully
putting default paths like -L/usr/lib64 into *_LIBS, which is entirely
useless since ld searches there anyway but may override other -L that
occur later on the command line for LO bundled externals.
On a Fedora 22 system, at least these variales were affected:
CLUCENE_LIBS FIREBIRD_LIBS KDE4_LIBS POSTGRESQL_LIB BOOST_LDFLAGS
Change-Id: Ie55f65c3ae29a125f16871d95ad8b716abf5c982
Reviewed-on: https://gerrit.libreoffice.org/19784
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
The assumption that all configure variables had been normalized to
TRUE/<empty> turned out not to hold; convert a bit more in that
direction.
(regression from 4af38b099c741c3676aefeb20c515913aaeed666)
Change-Id: I2127c515e8a833a07c9b26ed9d693ce5a1853fe4
|
|
...to avoid compiler warnings in external headers.
Change-Id: Ibd7fcb0400bfd8ffa49cc8db77956e443551ebb3
|
|
Change-Id: I784823b27108671e6bb549f60725f21abd47451e
|
|
- all in libo_PUBLISH_MODULE is affecting global state, so no need to
separate
- add in AC_ARG_WITH
Change-Id: I609cd03c9208448e6883f5347da3019e0d3aea51
Reviewed-on: https://gerrit.libreoffice.org/2366
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I148941dfbf3c9c75cd07148b08646e85887846e1
|
|
Consistently set WPD_CFLAGS/WPD_LIBS etc. in that case, with luck not
breaking anything else in the process due to newly set FOO_CFLAGS/LIBS.
Change-Id: I56bc6b86821b77c0c376d06b629646ada1ea0339
|
|
This reverts commit 324d2f94749dfd94c7f09d1923310e145bb64deb.
Change-Id: I0c1c3412554de2093c9c94de89ff74a89869fa6d
|
|
Reverting this because it breaks a lot of stuff
This reverts commit a2dbcf1e723e082a76ad1a7ef275f693dab34c98.
|
|
- a >12.000 LOC configure.ac is more than enough for everybody
- removing some 100 lines cant hurt
- the SYSTEM_LIBCDR=$SYSTEM_CDR stuff should be removed in a later step,
by renaming them in the build
Change-Id: I5c065c5c341561258800a124b0fc1f40b3d59211
|