summaryrefslogtreecommitdiff
path: root/mysqlc
AgeCommit message (Collapse)Author
2018-08-24Moving mysqlc into connectivity as a libraryTamas Bunth
Additionally I erased the remains of the old mysql C++ connector. Also update the code where the clang plugins were unhappy after moving the mysqlc module. Remove mysql-cpp-connector external. Change-Id: I771cc7afacf5012fc349afb6b36828fb0fee5a66 Reviewed-on: https://gerrit.libreoffice.org/59200 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-20On macOS Library_mysqlc needs _iconv{,_close,_open}Stephan Bergmann
...presumably since 3478d7453a3d65b3d8d164e8f898a0b79f005c58 "Switch from mysql to MariaDB C API". (And see external/mysql-connector-cpp/Library_mysqlcppconn.mk for a similar case.) Change-Id: I146bf83a71c59a59f7694552a31923eb1e7fe664 Reviewed-on: https://gerrit.libreoffice.org/59336 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-15loplugin:useuniqueptr in OPreparedResultSetNoel Grandin
Change-Id: Ieb536bb2ab7cef378b7279e086b26762f4291c56 Reviewed-on: https://gerrit.libreoffice.org/59014 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-13Fix typosAndrea Gelmini
Change-Id: I0bcdff1d355f374e9922cf3f318a88f01af86f4f Reviewed-on: https://gerrit.libreoffice.org/58929 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-13Various loplugin warnings in mysqlStephan Bergmann
I assume the "0 == " around columnStringValue.equalsIgnoreAsciiCase in ODatabaseMetaData::getSchemas (mysqlc/source/mysqlc_databasemetadata.cxx) was just a thinko, as the latter already returns sal_Bool, not a <0 / 0 / >0 integer value. (Rebased atop ce24919c01d1ab77f962137ff04a31dd5ec944af "loplugin, various in mysqlc", which covered the same warnings, but didn't consider the negated call to equalsIgnoreAsciiCase to be an accident as I do here (see above), and accidentally reversed the logic of OResultSetMetaData::isNullable in mysqlc/source/mysqlc_resultsetmetadata.cxx, I think.) Change-Id: Ie89cc8ef7c7638d28307a4b240930d387d75b8f2 Reviewed-on: https://gerrit.libreoffice.org/58908 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-13loplugin, various in mysqlcNoel Grandin
including redundantcast implicitboolconversion sallogareas after commit 3478d7453a3d65b3d8d164e8f898a0b79f005c58 Date: Sun Jun 17 18:09:43 2018 +0200 Switch from mysql to MariaDB C API Change-Id: Ibbb2fccdc8c7837412d878752f7da780140d678c
2018-08-13fix build (missing #include <sal/log.hxx>'s)Rene Engelhard
Change-Id: Idf0b21d41fa0bac0a49c1b28724c487edd336353
2018-08-12mysqlc: Fix float, double and numeric typesTamas Bunth
Change-Id: I9d0b989735e736c9c35d8acf4ea1b072eddf7437 Reviewed-on: https://gerrit.libreoffice.org/58744 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-12Switch from mysql to MariaDB C APITamas Bunth
In order to get rid of the MySQL C++ Connector, the sdbc driver should be implemented using the MariaDB C connector instead. MariaDB Connector/C is LGPL licensed, so later it can be used in the connectivity module. This way mysqlc won't be an extension, so it could be maintained easier. Change-Id: I99c13ccf154b33b145d34b1e06eec85946dc82a0 Reviewed-on: https://gerrit.libreoffice.org/55960 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-05-05Replace Galaxy icon theme by Colibreheiko tietze
Galaxy goes into an extension, fallback updated Change-Id: I4b6998035857f01368b39d4f16b2639d8a665065 Reviewed-on: https://gerrit.libreoffice.org/53092 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-23loplugin:useuniqueptr in mysqlcNoel Grandin
Change-Id: Ife3a044beae03c7623c1bd3c2ef6ce5595f97cca Reviewed-on: https://gerrit.libreoffice.org/53223 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07Don't link Library_mysqlc against -lnslStephan Bergmann
At least Fedora 28 glibc-2.27-8.fc28 no longer provides the nis development headers and libraries. (It only still contains some binaries for backwards compatibility, in the libnsl sub-package: "This package provides the legacy version of libnsl library, for accessing NIS services.") The -lnsl was present ever since 4946c62f2943dfb3466cc4214a9c8ccd922669b5 "mysqlconnector: initial import from CWS mysqlnative", but appears to not be necessary (at least any more). Change-Id: I10b56cdc1a438fb2978125ae0acde0dbec747e78 Reviewed-on: https://gerrit.libreoffice.org/52536 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-30Use for-range loops in mysqlcJulien Nabet
Change-Id: I3ff3fa5dca6b6b9060b0b38d875e1b7dec1f8245 Reviewed-on: https://gerrit.libreoffice.org/52127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-12loplugin:unusedmethodsNoel Grandin
Change-Id: I027adbe65edd5f07534bb36f9f54c55f30ba516e Reviewed-on: https://gerrit.libreoffice.org/50998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-02remove connectivity OSubComponentNoel Grandin
push the logic that is still necessary down into the subclasses Change-Id: I99424f0b3c654c5652991a4140b17ceb02224e50 Reviewed-on: https://gerrit.libreoffice.org/49087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-12More loplugin:cstylecast: mysqlcStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I4bc61dbaf5d920e75269564cd92b19ae05046ca6
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-01loplugin:finalclasses in mysqlcNoel Grandin
Change-Id: I3f0ae04c30e863c123404c6e99f7ae27bc5715c7 Reviewed-on: https://gerrit.libreoffice.org/44134 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-30loplugin:constmethod in idl,helpcompilerNoel Grandin
Change-Id: I9b328fc0a3ebdd15a646ee6dab800ffbadb1aaef Reviewed-on: https://gerrit.libreoffice.org/44050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: mysqlcStephan Bergmann
Change-Id: I9c234873c47830b364e069cdedc64806ee7724ad
2017-10-06use rtl::Reference in mysqlcNoel Grandin
instead of manual ref-counting Change-Id: I7b7c350613976463620a54757add6061cf383a4c Reviewed-on: https://gerrit.libreoffice.org/43183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01throw more useful uno::Exception'sNoel Grandin
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-24tdf#103685: "Commands out of sync" when connecting to MySQL using directJulien Nabet
Thanks to Lionel for his great help Change-Id: Ifcc1d72cca29c031f31da203cd1e3302ea0ea3e3 Reviewed-on: https://gerrit.libreoffice.org/42688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-09-15consistent naming of externals: mysqlcppconn -> mysql-connector-cppMichael Stahl
Change-Id: Ibfb3aa69895eef6023c38e2ff3b7ae98a05f5820 Reviewed-on: https://gerrit.libreoffice.org/42300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-15consistent naming of externals: libmariadb -> mariadb-connector-cMichael Stahl
The used version is actually named mariadb_client but since 2.1.0 upstream calls it MariaDB Connector/C. Change-Id: I51b12a9be55151919585dec91a5fc802ff4fc86b Reviewed-on: https://gerrit.libreoffice.org/42295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-01Remove unused m_aBatchVector membersStephan Bergmann
Change-Id: I7b7ff3295fa5eb87d113b48dcff0cf3c0b12b4ff Reviewed-on: https://gerrit.libreoffice.org/41780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-31Use vector and replace m_aBatchList by m_aBatchVectorJulien Nabet
Change-Id: I7c2c529eb78679f9733374bf0785773684c728c4 Reviewed-on: https://gerrit.libreoffice.org/41770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-02remove unnecessary use of 'this->'Noel Grandin
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-05new loplugin unnecessaryparenNoel Grandin
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields l10ntools..rscNoel Grandin
Change-Id: I78785eeab436910c9e8733924a7c43fa998ba36f Reviewed-on: https://gerrit.libreoffice.org/39491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25loplugin:oncevar in l10ntools..mysqlcNoel Grandin
Change-Id: Ifd4826f8ba4e10f2e012172fa693794d68bb6b4d Reviewed-on: https://gerrit.libreoffice.org/39188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in jvmfwk..mysqlcNoel Grandin
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08 Reviewed-on: https://gerrit.libreoffice.org/39099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-07Remove redundant 'inline' keyword, Linux reduxStephan Bergmann
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-02Fix typosAndrea Gelmini
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b Reviewed-on: https://gerrit.libreoffice.org/34803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-23With GCC -std=gnu++17, dynamic exception specifications cause an errorStephan Bergmann
...instead of a warning (as with Clang), so this follow-up to e16644fa1c042b56a1301f0476d7ddb71c8765ea "external/mysqlcppconn: Silence -Wdynamic-exception-spec errors" patches the (few) dynamic exception specifications out of external/mysqlcppconn completely Change-Id: I83a42f1c09e60c15fad1564cf7c42eb3370485da
2017-02-16external/mysqlcppconn: Silence -Wdynamic-exception-spec errorsStephan Bergmann
...with Clang in C++17 mode Change-Id: If51c0788439688f6fbd77c1a05cb3295ac6e8cb4
2017-02-03boost::scoped_ptr -> std::unique_ptr in mysqlcNoel Grandin
Change-Id: I4c8d25ed451ab03d2b5d0e9977ab74fd2ea1bb04 Reviewed-on: https://gerrit.libreoffice.org/33870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31Work around GCC 7 -Werror=implicit-fallthrough=Stephan Bergmann
This is in !LIBO_INTERNAL_ONLY code, so cannot use SAL_FALLTHROUGH. And even on current <https://github.com/boostorg/config> master, BOOST_FALLTHROUGH does not yet support [[fallthrough]] for GCC 7. Change-Id: I5306c3949b13c517fe8ef643cf98c2021147617e
2017-01-31Silence GCC 7 warnings in cppconn/exception.hStephan Bergmann
Change-Id: Ia924473d3dba11babee23f4137c645b9f8d86a8b
2017-01-27Remove dynamic exception specifications from !LIBO_INTERNAL_ONLYStephan Bergmann
...only odk/examples/ remains to be clean up Change-Id: I875a1e8d6750b6b007bd75126b8010273e1f32d5
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in framework..salNoel Grandin
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17loplugin:datamembershadowNoel Grandin
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e