t'>WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I37166c03ffd0f8f76ddc03ce556b6e6341a02b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167355
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-08Revert "tdf#150037 Writer: text fieldmark behaviour changed"Justin Luth
This reverts 24.8 commit 96323a10d3a55d212c350886e2a1344c0cd2ba95.
A mouse click selects the fieldmark to be able to overwrite
the field with the next text input.
But I did not revert:
Additionally the EN SPACE (0x2002) character is visualized
by the DEGREE symbol when 'View/Formatting Marks' is active.
The problem was that the field itself was also selected,
so not only was the placeholder text overwritten,
but so was the entire field.
Additionally, it is ONLY placeholder text that should be selected,
but this was also selecting non-placeholder
(i.e. custom user-entered text) that was being pre-selected
which is NOT what happens in MS Word.
The whole point of the patch in the first place was to
emulate MS Word's response to placeholder text,
so we should also be emulating what happens
to non-placeholder text. That would require tracking
whether the field's text was placeholder or not,
which is not currently track in legacy fields.
Change-Id: I0a1a22f82827cd5f9d9abfb52cd562dff4651b29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167139
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
2024-01-17tdf#150037 Writer: text fieldmark behaviour changedOliver Specht
A mouse click selects the fieldmark to be able to overwrite the field
with the next text input. Additionally the EN SPACE (0x2002) character
is visualized by the DEGREE symbol when 'View/Formatting Marks' is
active.
Word's FORMTEXT ist usually filled with EN SPACE.
Change-Id: I82446473d31bc5ea101bd1b94a50a855351d88b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161044
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class.
Convert from/to OUString only when communicating with respective
external APIs.
Removes about 200 conversions from the code.
Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-02introduce SwPosition::GetNodeNoel Grandin
as part of the process of hiding the internals of SwPosition
largely done by doing:
git grep -lF 'nNode.GetNode' | xargs perl -pi -e
's/nNode\.GetNode/GetNode/g'
Change-Id: Id1937df1bd5a54677c2c1bbfb2d693a4e22a7b98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137671
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30tdf#147708 create floating menubutton on demandCaolán McNamara
and destroy when it is fully faded out. Otherwise windows runs out of
gdi handles with document with large number of page breaks
todo: rename some things in a follow up commit after this more easily
backportable commit is merged
Change-Id: Ibbe3cd00d1027ac34915c4bff73e3a330e300f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-03-28Recheck sw/ cxx files with IWYUGabor Kelemen
See tdf#42949 for motivation
Change-Id: I8a8df68946297fad517b753d73e4373203a45ed6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132150
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-03-07sw_redlinehide: more issues with SwEditWin Surrounding functionsMichael Stahl
.. and SwEditWinUIObject.
These need to work with TextFrameIndex. Add some functions to
SwCursorShell to make it possible.
Change-Id: I884c4822a0e7ecf254ea09a893762e1e6d539534
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131042
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-09decompose SwNavigationPIUIObject and use sub components directlyCaolán McNamara
Change-Id: Ia4722972fe579646b4c3f06de339d72a931b05d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23tdf#136578: uitest: add wrapper for PageBreakWinXisco Fauli
Change-Id: I1536f2f03da9ec64627bd1e2e1776cf130717aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108143
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-16uitest: sw: Add missing assertsXisco Fauli
Change-Id: Idacea3eae1124778cbec98af6424f2462b4ef78f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107842
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-24tdf#42949 Fix new IWYU warnings in directory swGabor Kelemen
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I4bb84c3f401aba8a3dede9cec3a7f2187a2ba02a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106473
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-20use tools::Long in swNoel
Change-Id: I44be72b3a9b14823ec37a3c799cffb4fb4d6e1de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03Validate SELECT rangeStephan Bergmann
63049e98a659290229d3356e76d49cea44575011 "Reliably set up controls of hyperlink
dialog in constructor" fixed an issue that could cause Python UITest code to
issue a bogus SELECT request that would fire an assert in
rtl_uString_newFromSubString. Even if that issue is fixed now, it is probably a
good idea to validate the requested range here.
(An alternative would be to validate it in the underlying shell's SelectText,
but that function is also called from internal code (which presumably already
ensures that it is passing valid arguments), so it is probably better to stay
with that function's narrow interface.)
It would probably be nice if this function reported failure (by throwing a
css::lang::IllegalArgumentException, say) instead of silently (modulo SAL_WARN)
clamping the range, but it is called from Scheduler::ProcessTaskScheduling
(vcl/source/app/scheduler.cxx) in a try/catch block that prohibits all
exceptions.
Change-Id: I5b7b4255861766a81a81501e391b1ff4e09b7db6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99933
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-17uitest: Add support for Writer commentsShiko
Change-Id: I88ed2894c3665fb421c5d8ea0f278c54ccd0d0e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96230
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-05-22uitest: Add wait methods for slow elementsXisco Fauli
some elements take some time to be updated, specially
with slow machines or ASan+UBSan builds
Use the same time based approach used for launching the dialogs
also reintroduce 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b
Change-Id: Ia1cca74474ef65578bbc60a53a8a511402a082b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94648
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-21uitest: sw: grab focus before using toggle button in navigatorXisco Fauli
otherwise the focus in on the document
since ada385f1cba427416c1e8517cb6a45b61ceff7b0
Change-Id: Ia8300fdceb4f50f89c6d90f238483a4c785163d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94647
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-22Revert "tdf114724: uitest: make test less time.sleep dependent"Xisco Faulí
This reverts commit 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b.
See https://gerrit.libreoffice.org/c/core/+/92616
Change-Id: I642843ab16450d1a6b15d5e955495efbbfa7822a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92539
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-21tdf114724: uitest: make test less time.sleep dependentXisco Fauli
Instead, check the focus moved to the bottom and back to the
first element
Execution times goes 17.232 from to 5.521 for me
Change-Id: I816c197f44b68a1b9ab8686de191a743cbc78eb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92616
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-24weld writer navigatorCaolán McNamara
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom
toolbar into two toolbars. Rearrange their contents so the layout of each level
visually match.
Notes:
Master documents have two modes, master content tree and the normal content
tree.
You can drag entries from the content tree into the document, drag mode drop
down controls whether its a link or a copy etc that's dropped in.
Documents can be dropped into the content and global trees.
If outline tracking isn't active, then when content changes the tree is cleared
and refilled, typically an effort is made to reselect the same entry that was
previously selected. Additionally, if the amount of content didn't change an
effort is made to scroll back to the location the scrollbar was at before the
clear.
Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): swStephan Bergmann
Change-Id: I135d01abc52ab5e97b4b360763c8a7e3ddaf0d2d
Reviewed-on: https://gerrit.libreoffice.org/76639
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4
Reviewed-on: https://gerrit.libreoffice.org/69481
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-02-02uitest for tdf#114724 headings outline tracking in NavigatorJim Raykowski
Change-Id: I4390c3d33d69ddd93880545f58d0ef81469c960d
Reviewed-on: https://gerrit.libreoffice.org/47865
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-09uibase: consistently use "" and <> in include directivesMike Kaganski
Change-Id: Ib6888045cecb4bd7b3498534605d790324f1b40a
Reviewed-on: https://gerrit.libreoffice.org/43265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-07-19clang-tidy performance-unnecessary-value-param in swStephan Bergmann
Change-Id: I6cd0d28dade01366b087aebff894b6f003d87b31
2016-06-18uitest: loplugin:implicitboolconversionMarkus Mohrhard
Change-Id: Id852960cdfd49331251e89306a6a32eb9e45a666
2016-06-18uitest: support selecting writer textMarkus Mohrhard
Change-Id: I6d1c4e5a05bdcb3299af86a9044d912239659fb9
2016-06-18uitest: add more properties to writer stateMarkus Mohrhard
Change-Id: Iadf223b38d84c1a6fb9892642f39e63dd16c72c8
2016-06-18uitest: provide a way to jump at the beginning of pageMarkus Mohrhard
Note that page numbers in writer are 1-based
Change-Id: I614ff08927b4cb92d3819b557ec6791199da69a4
2016-06-18uitest: provide information about current pageMarkus Mohrhard
Change-Id: Ie0ef65a023e156f65370e11f024fa6349841841e
2016-06-18uitest: forward unhandled actions to the base classMarkus Mohrhard
Change-Id: Iac08e77d9b0e80f2af93c8b229d083603f1d22d4
2016-06-18uitest: add wrapper for writer's main edit windowMarkus Mohrhard
Change-Id: Ibd6ffe85ca95cdc915f5c73b1b566de1d7413ee7