summaryrefslogtreecommitdiff
path: root/nlpsolver/ThirdParty
AgeCommit message (Collapse)Author
2021-08-06cid#1489772 UR: Uninitialized read of field in constructorCaolán McNamara
pass in SearchPoint to initialize pbest_t before it is then passed to setMemPoints setMemPoints sets the pbest_t variable of AbsGTBehavior so calling setPbest on AbsGTBehavior subclasses after calling that doesn't do anything so drop it, and then DEPSAgent.setPbest isn't needed anymore Change-Id: Id4fdc770cefc0f801218dc9bf51a6dc5b1e25d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-02The null pointer bug should be fixed now.Todor Balabanov
Change-Id: I8278bfed8170907a958396839d0997fc127f4b2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119744 Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19AbsGTBehavior should implement ILibEngineJulien Nabet
so we're sure all derivatives will have to Change-Id: I4e62d02f01382dbc95b28ffcb3d278aa31427f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119145 Tested-by: Jenkins Reviewed-by: Todor Balabanov <todor.balabanov@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-18nlpsolver: DEPSAgent doesn't implement ILibEngineJulien Nabet
Fix this error: /home/julien/lo/libreoffice/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java:45: error: DEPSAgent is not abstract and does not override abstract method setLibrary(Library) in ILibEngine public class DEPSAgent implements ILibEngine { ^ 1 error (on pc Debian testing x86-64 with master sources updated today openjdk 11.0.11 2021-04-20 OpenJDK Runtime Environment (build 11.0.11+9-post-Debian-1) OpenJDK 64-Bit Server VM (build 11.0.11+9-post-Debian-1, mixed mode, sharing) ) Change-Id: I1ce2d1a9ddee1020889f1a7a8fcd3387980b241f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119119 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-18Revert "Some lower objects coupling."Noel Grandin
This reverts commit 7b93bae224c7c2c49b105ef97304bb46f8b68da5. Reason for revert: Does not compile /home/tdf/lode/jenkins/workspace/lo_ubsan/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java:45: error: DEPSAgent is not abstract and does not override abstract method setLibrary(Library) in ILibEngine public class DEPSAgent implements ILibEngine { ^ 1 error Change-Id: I72f2a22ab1f4119178f8002c21ba0845c4cd1bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17Some lower objects coupling.Todor Balabanov
Change-Id: I0a7c658d830f82d627d20b9ed7000f3c5b8f1f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-13Object initialization is done via a constructor with parameters.Todor Balabanov
Change-Id: I66e87f7c898efb1f2c6b1d31fbd5654244e3ea82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-12cid#1487032 NP: Null pointer dereferenceCaolán McNamara
and cid#1487033 UwF: Unwritten field since... commit 822f128e734f37ee4de9bf5b62640cbec140701e Date: Wed Jul 7 16:01:19 2021 +0300 Polymorphism is a better approach when there are chains of inheritance. where deGTBehavior and psGTBehavior are no longer stored when set from DEPSSolverImpl.java:146 and DEPSSolverImpl.java:147 Change-Id: If3d228bf6e5f2b1ddd119d75b55bd778bcce8b05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118759 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-08Polymorphism is a better approach when there are chains of inheritance.Todor Balabanov
Change-Id: I2580dafcf8792bf4b11db78988db8c2976e4545c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118569 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-20It is a good practice single source of random numbers to be used.Todor Balabanov
Change-Id: If76e247461288a9ed938b4f6cb592c814b8bbe2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-17A separate function for getting a random search point is a little bit clearer.Todor Balabanov
Change-Id: I2d7471440cdee096b09ce704cbea3d5311f984c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117289 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-15Fewer array reference calls make the code more readable and more efficient.Todor Balabanov
Change-Id: I7416633a735078a4e0e857f050ea7bfaadba310c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117158 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-07-27Fix typosAndrea Gelmini
Change-Id: I380856ca45c835e732fdf080a522caab4534db5b Reviewed-on: https://gerrit.libreoffice.org/76346 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-03Range for DE scaling factor was implemented.Todor Balabanov
Change-Id: I5b8d3cd69a6138d7eebf37c299626019b32d639a Reviewed-on: https://gerrit.libreoffice.org/72373 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-17Some additional manual formatting.Todor Balabanov
Change-Id: Ie5590535d013aa2f747dd034fa2fcd2ae5c3956b Reviewed-on: https://gerrit.libreoffice.org/72226 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-12Formatting - Eclipse IDE Java Conventions with spaces for indentation.Todor Balabanov
Change-Id: I0c3e50ef25bda0bc4ae59665a07848fe75507121 Reviewed-on: https://gerrit.libreoffice.org/72185 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-05-12Generate behavior code simplification and very small speed-up.Todor Balabanov
Change-Id: Ib13080e4c21738affa129d12a07f5380f665e7a4 Reviewed-on: https://gerrit.libreoffice.org/71673 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-10Import of each class is better practice than import of entire library.Todor Balabanov
Change-Id: I13c4916b951d36ea5e83e52c9c6e36df552bdfeb Reviewed-on: https://gerrit.libreoffice.org/71961 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-01Fisher-Yates shuffling algorithm achieves much better randomization.Todor Balabanov
Change-Id: I6d204a7ba0fa19f4c318d1c70f5a0344e0640d6d Reviewed-on: https://gerrit.libreoffice.org/71620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-01Random class is better than Math random function.Todor Balabanov
Change-Id: Ia35e3bb3b4f0323c7fbfc54ae5064afdf2c3f381 Reviewed-on: https://gerrit.libreoffice.org/71539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-01Math pow is too slow in this case.Todor Balabanov
Change-Id: I16149cabf75ec928d96975e4b98622df6951cefc Reviewed-on: https://gerrit.libreoffice.org/71519 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-27Fix typosAndrea Gelmini
Change-Id: I8d5a8251a01af7cdf9832d98d8a6573b907f8532 Reviewed-on: https://gerrit.libreoffice.org/48683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-02-03TyposJulien Nabet
Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-10-14cid#1326608,cid#1326609 CN: Bad implementation of cloneable idiomNoel Grandin
Change-Id: Iac74be96b47720ab105f862e7d1a69f909214294
2015-10-01Fix typosAndrea Gelmini
Change-Id: I4452d4a4a4a61f39cd9c2b5a441c6c2017f15ce8 Reviewed-on: https://gerrit.libreoffice.org/19073 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-01Fix typosAndrea Gelmini
Change-Id: I04d1bc3a9f38ff7871d3192563cd1f649fdc6cea Reviewed-on: https://gerrit.libreoffice.org/18960 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-06-30Fix typosAndrea Gelmini
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-05java: remove some unused fieldsNoel Grandin
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
2014-11-25java: final fields that can be staticNoel Grandin
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18java: fix some javadoc errorsNoel Grandin
Eclipse was flagging this text as "invalid javadoc tags" Change-Id: I09e090c6cc49366191f96d34bd51f6ba68cf18aa Reviewed-on: https://gerrit.libreoffice.org/12524 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-13nlpsolver: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch
Change-Id: I081194d802bd835285bdc37fbef55f229f1185dc Reviewed-on: https://gerrit.libreoffice.org/11940 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-02nlpsolver: fix javadoc error: bad use of '>'rbuj
Change-Id: Ibfaeef155982ce6eeefe8ef51eea9c2bddb12c46 Reviewed-on: https://gerrit.libreoffice.org/11244 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-20remove more unnecessary constructor declarationsNoel Grandin
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20java: remove modifiers implied by the contextNoel Grandin
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-19java: remove unused methodsNoel Grandin
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-14java: remove unused importsNoel Grandin
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14java: remove commented out codeNoel Grandin
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-13remove dead java constantsNoel Grandin
found by UCDetector Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
2014-08-13make some java fields privateNoel Grandin
found by UCDetector Change-Id: Ib4cf18be134c3177cb123191e963bb43b7e6de93
2014-08-13java: remove dead methodsNoel Grandin
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13java: remove unused fieldsNoel Grandin
found by UCDetector Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
generated by cgit (git 2.34.1) at 2025-01-20 06:17:55 +0000