Age | Commit message (Collapse) | Author |
|
As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls"
Pros:
- simple, fast!
- finds some more unused declarations, somehow
- works on non-linux specific parts of the code
- clang-tidy (for me) trips on files with external headers, this does not
Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
Change-Id: Ifb5639369c4af1db27ccb5a93dfad093ce7403b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146819
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
...that 1628005298923ad15cc78dbad63669b701f5fd04 "Trying to remove the stlport
mention from the code" didn't catch
Change-Id: I271d7760d2b2dd25c0fa27489a8ddf455963d970
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147213
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Some examples inside odk/examples/java/Spreadsheet are ported to
Python:
ChartTypeChange.java -> ChartTypeChange.py
EuroAdaption.java -> EuroAdaption.py
SCalc.java -> SCalc.py
Code format is checked with 'pycodestyle':
pycodestyle --ignore=E501,E722 odk/examples/python/Spreadsheet/*.py
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
Change-Id: If0631b5970faab6499cfea3eef559e003fad24d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143810
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: Ifc9748fc33c72ad6e0cb334ca22ebb8b488164c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145710
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I699112a3e554013bab75b82d1eae00098216c886
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144893
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
The examples inside odk/examples/java/Text are ported to Python:
BookmarkInsertion.java -> BookmarkInsertion.py
GraphicsInserter.java -> GraphicsInserter.py
HardFormatting.java -> HardFormatting.py
StyleCreation.java -> StyleCreation.py
SWriter.java -> SWriter.py
StyleInitialization.java -> StyleInitialization.py
TextDocumentStructure.java -> TextDocumentStructure.py
TextReplace.java -> TextReplace.py
WriterSelector.java -> WriterSelector.py
Code format is checked with 'pycodestyle':
pycodestyle --ignore=E501,E722 odk/examples/python/Text/*.py
Some Java methods are merged when ported to Python.
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
Change-Id: Ic903cfa24ef32f8edaafd7e6e2e0c757b4b1be0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141425
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
This port keeps the similarity with Java ones as much as possible.
examples.html is also updated by adding the Python examples.
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
Change-Id: I2af26aaf42f5408bf254a4e0507442200f843661
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139887
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: I9a973141bdefca22dc24ecfaba58803dfc256e15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138239
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
For one, Javadoc (unlike Doxygen) doesn't support @attention, so this caused a
> Generating workdir/CustomTarget/odk/docs/java/ref/help-doc.html...
> Note: Custom tags that could override future standard tags: @attention. To avoid potential overrides, use at least one period character (.) in custom tag names.
> Note: Custom tags that were not seen: @attention
warning during the build. And for another, that paragraph was phrased in poor,
broken English and didn't add much value anyway.
Change-Id: I603170ec262d042e92bdff38ae415dda0bcc28bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137053
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...which were used by ildc, which is gone since
a8485d558fab53291e2530fd9a1be581c1628deb "[API CHANGE] Remove deprecated idlc
and regmerge from the SDK", and have always been ignored as legacy by its
unoidl-write replacement.
This change has been carried out (making use of GNU sed extensions) with
> for i in $(git ls-files \*.idl); do sed -i -z -E -e 's/\n\n((#[^\n]*\n)+\n)*(#[^\n]*\n)+\n?/\n\n/g' -e 's/\n(#[^\n]*\n)+/\n/g' "$i"; done && git checkout extensions/source/activex/so_activex.idl odk/examples/OLE/activex/so_activex.idl
which apparently happened to do the work. (The final two files are not UNOIDL
source files.)
Change-Id: Ic9369e05d46e8f7e8a304ab01740b171b92335cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135683
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Add Makefile for the DevelopersGuide/FirstUnoContact C++ SDK example.
The example now can be built using the same process for other C++
exmaples.
The DevelopersGuide examples will be categorized into several
directories, according to the language:
basic cxx java python
This requires that all examples ported to each of these languages.
Change-Id: I95c5c324fef66664836b5e07bf34c98117e6b478
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134596
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Porting FirstSteps/FirstUnoContact.java to C++ is done. More
information on this example can be found in the DevGuide:
LibreOffice Developer's Guide: Chapter 1 - First Steps - First Contact
https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps
Change-Id: I84b0a60738bfe614158d7eabf8bff3cda1ccca50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132910
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Porting FirstSteps/FirstUnoContact.java to Python is done. More
information on this example can be found in the DevGuide:
LibreOffice Developer's Guide: Chapter 1 - First Steps - First Contact
https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps
Change-Id: I8a97672a0b437177f19ddce029e6ef27e97533ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132914
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: I95c78d1346d354b755aeecaa1e6c9d789be0b693
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132905
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
While cleaning up "LibreOffice DevGuide: Chapter 1 - First Steps" in
the TDF Wiki, I understood that only 3 examples were compiled via the
Makefile, but there were 4 java files. It turned out that the
FirstUnoContact.java and FirstConnection.java are essentially the
same. I removed the second one, as it was not built, and was not
referenced elsewhere.
Change-Id: I7df5dd9dfc3aae15de4484b4a3dd6272066a8683
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132457
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: I9f583937da2cf49fc9013d9e36d63fff312ccb92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131495
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
...after the new types.rdb format that unoidl-write generates has been used
internally since LibreOffice 4.1 in 2013; following up on
6db34b6b33ba8e3b13683efd05df8441b87e9c92 "Directly build UNOIDL .rdb files from
.idl files" and its "The legacy tools idlc, regcompare, regmerge, and regview
are still contained in the URE or SDK for now."
The tools idlc and regmerge are deprecated but still shipped in the SDK for now.
The plan is to drop them completely for LO 7.5.
odk/examples/ and ure/source/uretest/ are adapted to use unoidl-write instead of
idlc and regmerge:
* unoidl-write does not use a C preprocessor and the # directives in .idl files,
it supports reading a single .idl file (containing an arbitrary number of
declarations) or a directory tree where each directory corresponds to a UNOIDL
module of the same name and each .idl file contains the declaration of the
(non-module) UNOIDL entity of the same name. For some of the odk/examples/,
that required moving individual .idl files into sub-directories named after
the respective modules. In odk/settings/std.mk, definitinos of IDL and
REGMERGE have been replaced with a new UNOIDLWRITE.
* unoidl-write always enforces reserved UNOIDL identifier restrictions (see
04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL
identifiers across offapi" and 620179240670bd00f60555f1f5c5b0268492f97c
"Enforce the UNOIDL identifier scheme") (which idlc only enforced optionally
with -cid -we). That required renaming "my_module" in
odk/examples/DevelopersGuide/Components/CppComponent/.
* The new types.rdb format is not compatibly with LibreOffice < 4.1. Clients
generating extensions containing such files are advised to use appropriate
LibreOffice-minimal-version elements.
Change-Id: I1a248fd96e86ecbf407f829bc100d44bfe7f4e7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130533
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Replace the instances of Pi's value as magic number by M_PI
Use M_PI_2 and 2_M_PI instead of calculating these values in code.
Use basegfx functions to convert angle units.
Change-Id: I6cca7cc93704a70ccf3a0571a56a789bc9df51ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129479
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Reviewed-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: I82405059d900b6605075bf5756f3f0fb99e9002e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129451
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169
|
|
* Use <iostream> instead of <stdio.h>
Change-Id: I5cc70613c0b183c24bfa73b779dac3b382b31c93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123328
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Fixing the license statement for the 'Convertor.cxx' and 'Makefile'
according to the '/TEMPLATE.SOURCECODE.HEADER'
This example was added in 83b529d88388c7c8e0563242a030063bd95c4bed
Change-Id: I654d641999aab6951ad21f84fd75e080bb709ec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125128
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Add Convertor.cxx
* Used Makefile from DocumentLoader with some changes
* Updated odk make files
* output.pdf is generated from the input odt file
Change-Id: I3e46f2895443f75b2f3815280b0f793bca5138e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123736
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Remove unncessary C-style cast from DocumentLoader.cxx
* Remove trailing whitespaces from Makefile
Change-Id: I7cff589353d3e40301cf45ce0a76e0c75beddf13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124115
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I62e12aed5bc67119433c39ff333f69b79944dca3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123318
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I15d56d133cf464a3cb6483be785b1259c7f35b43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123120
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I6ebbd0ece563f0d877b03389fa9a96311cd207cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122867
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
|
|
This failed with GWL_WNDPROC being undefined in 64-bit builds. See the note at
<https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setwindowlongptra>:
"To write code that is compatible with both 32-bit and 64-bit versions of
Windows, use SetWindowLongPtr."
Change-Id: I7abcc681b4daf459eb0c0481266949c75ecf4dda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122341
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
(where css.util.Color is a typedef for UNOIDL LONG). This caused issues on
Windows, where in C/C++ sal_Int32 is a typedef for long rather than int.
Change-Id: Ic0407674d06a219210d7f0448100005d7135eb79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122340
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Id10dc2ef13f54a148a800003cc4bd88ca1a0056f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122233
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: Ia70268084603db3329d276533a9351e6c1eebbca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121894
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...introduced with aaebbb0e597bfeb8e1c545130a0d17a55b164228
"INTEGRATION: CWS jsc21" (but which never caused an issue as cppumaker generated
output for all of $(COMP_RDB) anyway when the undefined $(TYPESLIST) didn't
contribute anything to its command line)
Change-Id: Ic6792ad9edc159c02d307ca72500605bc3c38077
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121851
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It had been added together with odk/examples/java/MinimalComponent/Makefile in
ff4c86ff37af5136466d49a9fb394974ee62cb0f "Added an example for a minimal UNO
component", and it apparently is an Ant build script that shall do the same as
the Makefile. However, it is apparently unused: For one, it does not
appear to get referenced from anywhere else in the code or to get mentioned at
<https://wiki.openoffice.org/wiki/Documentation/DevGuide/OpenOffice.org_Developers_Guide>.
And for another, it would apparently only work on Windows (using e.g.
"${ODKPATH}/windows/bin/idlc.exe"), but would typically fail even there with
something like
> > ant -f BuildMinimalComponent.xml
> Buildfile: C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml
>
> init:
>
> unoidl:
>
> BUILD FAILED
> C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml:35: The directory D:\cvs\api\odk\WINexample.out\misc does not exist
due to the hardcoded D:/cvs/api/odk paths.
Change-Id: Idd020bcf1a2383295704b208d3ac2be047f270ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121050
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Instead of just adding a license header,
2b4fd2c89a38ccac13c72f2e94501a8702e7da4b "re-base on ALv2 code" had apparently
erroneously overwritten this file with the content of the completely unrelated
odk/examples/java/MinimalComponent/BuildMinimalComponent.xml.
Change-Id: Iee6dcb528dbb444a132c27e7183b3957319882c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121037
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0a8ce634944df4af5c9e2000af5f6429b4e40b2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119097
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
* Using UNO for Python
* Opening the file in LibreOffice if it is listeing on port 2083
Change-Id: I14b1a38da5d66dd2ee8c859071c148ce08a080d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118142
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
|
|
Change-Id: I809231e7e6ceaa93c2d0b523de8a4b93b07b449c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118841
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
* Created Draw.cxx
* Used Makefile from DocumentLoader with some changes
* Updated examples.html to reflect the addition
* Updated odk make files
Change-Id: I37426d63854222ef8bedb5f61edb420baec4d28a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118034
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
* Removing calls to C functions
* Simplifying string usage
Change-Id: Ia8ca329d7ad586d98e309809e430006eaac9eaaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118131
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
The declared entities have apparently never been referenced ever since the
file's introduction in 9fa09d43d0dc0ec0ac71bad31b85ce7fc302ee90 "INTEGRATION:
CWS sdkinspector2". (And at least xmlreader skips and ignores the content of
such document type declarations anyway.)
Change-Id: I8263200f52bb5f1692090995574619f9c0ec478f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117658
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Idf71c662138c281333a83cc76a9d75cbf086f362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110236
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I7b269fb5bafceba071ebe649a696ef61301c4018
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107366
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
The SDK's <https://wiki.openoffice.org/wiki/Documentation/DevGuide/ProUNO/Java/
Transparent_Use_of_Office_UNO_Components> on all platforms included the Windows-
specific unowinreg.dll in generated jars (so that those jars, when distributed
to a Windows environment, would find a LO installation by inspecting the Windows
registry). That unowinreg.dll was originally built as a 32-bit DLL (though when
building a 64-bit Windows LO, it happened to be built as a 64-bit DLL). For
non-Windows LO builds, it could either be built locally with a MinGW toolchain
(--enable-build-unowinreg) or downloaded from dev-www.libreoffice.org.
However, that had various issues:
For one, unowinreg.dll was not necessarily available in a distributed jar as a
64-bit DLL for use with a 64-bit JRE on Windows. (Theoretically, running such a
jar with a 32-bit JRE to access a 64-bit LO installation's URE jars could have
worked. But practically, those URE jars in turn require native DLLs, which
would then not have been available as 32-bit DLLs for use in the 32-bit JRE.)
For another, at least the unowinreg.dll resulting from --enable-build-unowinreg
on Fedora 33 would have had a dependency on libgcc_s_dw2-1.dll that would
generally not have been available in a target Windows environment.
There appears to be no pure Java way to read the Windows registry, but instead
of using a native code DLL for that, it appears to work just as well to call out
to reg.exe and parse its output.
This removes the --enable-build-unowinreg and --with-mingw-cross-compiler
configuration options. (The sole use of the MinGW toolchain in LO was for
building unowinreg.dll.)
Change-Id: I3283ea38c884d3221a205e5ab6ec99a2691ef474
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107140
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I427263ee98206c00cd2b3392fc9f2f55ad1ded5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105692
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
|
|
ImageShrink.oxt is created in the org/openoffice/comp/test sub-make, and
CustomTarget_odk/build-examples_java had once failed for me with
> make[2]: *** No rule to make target '~/lo/core/workdir/CustomTarget/odk/build-examples_java/out/sdk/LINUXexample.out/bin/ImageShrink.oxt', needed by 'ComponentsThumbsExample'. Stop.
Change-Id: I926d0691e7eee3506d4afe2eda1a2fc873422e18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103502
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia0a24bf32290ecb6b6153ba412d5e282f56d92f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102693
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This is broken since commit 5c39b28a87060f80404079ab77604f664addb063
("tdf#96059 Replaced imageproducer with CommandInfoProvider") but so
far no one complained (maybe because the usefulness of such internal
images from extensions is questionable at least). Given also that
the whole ImageIdentifier feature (even its still working part) is
obsolete since OOo 2.0.3 (according to the OOo dev guide), and that
the availability of a particular image from an internal hardcoded
image list by a particular numerical id is more an implementation
detail, let's just remove the broken code instead of fixing it.
In the meantime, the code was also copied into the newly introduced
notebookbar addon code, so I handled it there too.
There are also the registry schema and a sdk example that mention this
feature, and need to be adjusted. Interesting that the particular
example used there - private:image/3216 is actually broken since 2011
with commit 2559cab126f81375197051fb5b07ba6abb9efc77
("FDO#42454 - EasyHack: remove code associated with unused icons").
Change-Id: I968b4fb8c5b207654476dd92c57d8db0815520ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101529
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Id1a6b4fc6e156f67550458b4b7e4b1ffe32f812a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101691
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|