summaryrefslogtreecommitdiff
path: root/odk
AgeCommit message (Collapse)Author
2019-11-17cid#706181 Use of untrusted string valueCaolán McNamara
use an annotation here and add one to the windows equivalent Change-Id: Ife54949c2e89ae606d7931be82807db4bbb132dc Reviewed-on: https://gerrit.libreoffice.org/83024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01odk: fix for change directory in complextoolbarcontrols sampleVasily Melenchuk
On Windows classical "cd" command does not change drive automatically. So if OO_SDK_OUT folder located on another drive than SDK_HOME we will receive confusing buid errors. To avoid this for Windows configuration we should use "cd /d". Change-Id: I22908d49fc915d3a834972357934349ba82bbec5 Reviewed-on: https://gerrit.libreoffice.org/80827 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-23ODK: cleanup windows linker debug argsThorsten Behrens
This was a somehow confused & partially commented-out setup Change-Id: Iad5ef6721cda6f85ded3296650ee9a7df9ec59fd Reviewed-on: https://gerrit.libreoffice.org/81333 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-19Fix typo and dotsAndrea Gelmini
Change-Id: Ia34130dbab42d61074a73a2b16e03360b5b123b6 Reviewed-on: https://gerrit.libreoffice.org/81086 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-10-12rtl/stringconcat.hxx is not part of the URE interfaceStephan Bergmann
(and #include's of it in include/rtl/*.hxx are already guarded with LIBO_INTERNAL_ONLY) Change-Id: I9224f71a244a69ef69406ea3a5879b66b3cae3a3 Reviewed-on: https://gerrit.libreoffice.org/80666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-11simplify "a = a +" to "a +="Noel Grandin
mostly so that my stringadd loplugin can point out places to improve Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5 Reviewed-on: https://gerrit.libreoffice.org/80618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-09Make odk build-examples work on macOS 10.15Stephan Bergmann
...which apparently got even stricter with unsetting DYLD_LIBRARY_PATH when starting a shell, so the old workaround from 9ac2aad4c1cd0f8d513c02a897da90c42f2fa961 "OSX fix ODK example builds with enabled SIP" no longer worked for me (and CustomTarget_odk/build-examples_java failed with > dyld: Library not loaded: @__VIA_LIBRARY_PATH__/libreglo.dylib > Referenced from: /Users/stephan/Software/lo/core/instdir/LibreOffice6.4_SDK/bin/idlc > Reason: image not found ). Building on macOS 10.15 now requires to build a shell from upstream sources and pass it into toplevel make as a SHELL=... command line argument (but which I at least already needed to do anyway, to preserve a global DYLD_LIBRARY_PATH pointing at a nonstandard libc++, when building external/firebird). Change-Id: I00ec0649fafa1842bed3f2a1258e3184d6bcfdd1 Reviewed-on: https://gerrit.libreoffice.org/80532 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-10Fix typosAndrea Gelmini
Change-Id: Ibc1b7393a8e65bf23c78fdb9da78c6b73b544cf3 Reviewed-on: https://gerrit.libreoffice.org/78793 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06Fixing '....' and '..'Andrea Gelmini
Change-Id: I926069d6c1f2712e5020d930f7ff6c62fd00e912 Reviewed-on: https://gerrit.libreoffice.org/78667 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-01Fix '..'Andrea Gelmini
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-29Fix typoAndrea Gelmini
Change-Id: I46650797efa70d6b416356a3e5ed57d26d8e69be Reviewed-on: https://gerrit.libreoffice.org/78252 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-21odk: fixed typos in generated manifestsVasily Melenchuk
Change-Id: I85766d1ba3598b37e3a776605628402ca5795bc5 Reviewed-on: https://gerrit.libreoffice.org/77809 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-20Fix EXTENSION_PLATFORM for Windows x86_64Stephan Bergmann
Change-Id: I7fbe1963aff666205dbc9405e94d6093fb9a5a48 Reviewed-on: https://gerrit.libreoffice.org/77804 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-19Fix typosAndrea Gelmini
To complete https://gerrit.libreoffice.org/#/c/77567/ Change-Id: I9f56eb308ff9b23c4259a0abae60ac2f97038393 Reviewed-on: https://gerrit.libreoffice.org/77589 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-19Fix typosAndrea Gelmini
Change-Id: I0b5182a3cec87ee44b7467d6e8e3d1c21ce93ac2 Reviewed-on: https://gerrit.libreoffice.org/77680 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini
Change-Id: I5d0776d5f90f44ebbeeb5916cbbf6e87406adcad Reviewed-on: https://gerrit.libreoffice.org/77609 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
Change-Id: I62b669b85e2380df2a6efa05764f21405e7eb2ae Reviewed-on: https://gerrit.libreoffice.org/77318 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typoAndrea Gelmini
"an one" Change-Id: Ic12d139acfdb32aaf0089c60609feaa653fd686b Reviewed-on: https://gerrit.libreoffice.org/77259 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-11Fixed "OfficeDocument"Matthias Seidel
(cherry picked from commit 856d28801b59d45cf4d32602adc57a08cd618b6d) Change-Id: Ie915588bda5930dc51a1484f20d0bbd9d955ec29 Reviewed-on: https://gerrit.libreoffice.org/77269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-09Fix typosAndrea Gelmini
Change-Id: I994f656b0828c9c7ea1463b86cd692f847d01e7e Reviewed-on: https://gerrit.libreoffice.org/77126 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-24Fix typo 'a SDK'Andrea Gelmini
Partial revert of: https://gerrit.libreoffice.org/#/c/76028/4 Change-Id: I94173556f1dff21ff47245f8b632411fc8be1ff6 Reviewed-on: https://gerrit.libreoffice.org/76200 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-20Fix typosAndrea Gelmini
Change-Id: Ib361243332b7219c0073c787c378c648e44705f2 Reviewed-on: https://gerrit.libreoffice.org/75487 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20Fix typos in codeAndrea Gelmini
Extracted from https://gerrit.libreoffice.org/#/c/75487/1 Change-Id: I80f9247c5c961a33c0d2c8354ea0524820b33409 Reviewed-on: https://gerrit.libreoffice.org/76028 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09par command does not allow n command in its first line(title)Tomoyuki Kubota
Doxygen used to allow this but there was a regression, which is apparently not being fixed: https://github.com/doxygen/doxygen/issues/6304 Change-Id: I7602236522a56c30a2249bd8065796b3c6458704 Reviewed-on: https://gerrit.libreoffice.org/70377 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-04-16fix usage of successful/successfully in commentsNoel Grandin
Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b Reviewed-on: https://gerrit.libreoffice.org/70813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-04odk: Add hint to test this in instdir/sdkSamuel Mehrbrodt
Change-Id: I8881f33a024cb5b9e36d4a6a668d8a32aea2ed1a Reviewed-on: https://gerrit.libreoffice.org/70189 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-03Fix typosJens Carl
Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-01(blind) fix of 'ERROR: Source for LICENSE.html not found!' on macOSAndras Timar
Change-Id: I0f87d96691281e773b48ab11380c0dfa3a65ebba Reviewed-on: https://gerrit.libreoffice.org/70083 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-19single source file for licensing info with conditional textTamas Bunth
... for easier maintenance. This commit only introduces the framework. Follow up commits will update the license file. Advantages: * single source, multiple outputs (html, txt) * conditional text, i.e. output will not include license terms of components that are not configured in the build Change-Id: I0ffad41119228a0a26fd1b6ce19930ca6085adb2 Reviewed-on: https://gerrit.libreoffice.org/69396 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-02-15Adopt odk configure to new java 6 baselineSamuel Mehrbrodt
Change-Id: I015f439b04ddbc337a1c0b000fa708686d1f83bb Reviewed-on: https://gerrit.libreoffice.org/67751 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-01-29odk: CustomTarget_build-examples hard-codes on "gcc" and "g++"Michael Stahl
... so it fails if these aren't available; instead use the C++ compiler of the LO build system. Change-Id: I8a95d1865c481dc0a790d6fec6ff9fae8284d76d Reviewed-on: https://gerrit.libreoffice.org/67078 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-01-24Fix build with recent jdk 11.0.2Fridrich Štrba
Change-Id: I0ee68e087e3973b6a148f9bfefc16581606d6568
2019-01-01Bump copyright year to 2019Adolfo Jayme Barrientos
Change-Id: I0d49ec7db57a0f7d18489dad61e86cbfdf4418cd
2018-11-29Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-18Fix typosAndrea Gelmini
Change-Id: I2a7877dc341e9bcbea231f5ce9edb1236f97df1c Reviewed-on: https://gerrit.libreoffice.org/63505 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-05Fix typosAndrea Gelmini
Change-Id: Id5489f3e8f1d3ced3d57b56f8d3a7a4818af0fca Reviewed-on: https://gerrit.libreoffice.org/62377 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-21Java 11 no longer synthesizes DocumentView$1.classStephan Bergmann
...so, for simplicity, just include whatever generated DocumentView$*.class by wildcard Change-Id: I779e2709c8ef2859d68233300302dd62dbe2455f Reviewed-on: https://gerrit.libreoffice.org/62073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11Restore explicit _WIN32_WINVER in the ODK exampleJan-Marek Glogowski
Change-Id: I01855c37955dcae13dbb3c6f028d4030dc48945a Reviewed-on: https://gerrit.libreoffice.org/61657 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-10-11Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski
Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-02Add some colour to a sample odt fileTor Lillqvist
Change-Id: If4dc6458d9c5fb3b574c1bb55196a5086aff3365
2018-09-28Fix toogle->toggleAndrea Gelmini
It passed "make check" on Linux Change-Id: Id25a7893e536a579cef58f63e8ec7ce240ad16fb Reviewed-on: https://gerrit.libreoffice.org/60633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-21Get rid of redundant odk/source/unowinreg/win/unowinreg.defStephan Bergmann
...similar to 28b4f4aeaf160c7721dfecf5bd2445d7dbc6f01c "Get rid of Windows .def files in setup_native, use __declspec(dllexport)". And JNIEXPORT (with which the listed functions are decorated in odk/source/unowinreg/win/unowinreg.cxx) already implies __declspec(dllexport). Change-Id: I45fd1d50cd3b072d124002e469c70eb1d6ed7610 Reviewed-on: https://gerrit.libreoffice.org/60819 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-17New loplugin:externalStephan Bergmann
...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-15SDK: fix image URLs in docsAndras Timar
Change-Id: I2cac00a6da5602e4edbf9f6ca440f3a350e8dea7 Reviewed-on: https://gerrit.libreoffice.org/60540 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-28 20:20:38 +0000