Age | Commit message (Collapse) | Author |
|
...of interfaces for which such a forward declaration has already been emitted.
Update the reference rdbs accordingly with
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-7.0.0.3/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-7.0.0.3/instdir/program/types.rdb \
.../libreoffice-7.0.0.3/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
Change-Id: I7448ae44d479a8c622f6f534abe6087ce8a8ea32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100896
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \
/data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \
/data/sbergman/lo-7.0/core/instdir/program/types.rdb \
>/data/sbergman/lo-clang/core/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \
/data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \
/data/sbergman/lo-7.0/core/instdir/program/types.rdb \
/data/sbergman/lo-7.0/core/instdir/program/types/offapi.rdb \
>/data/sbergman/lo-clang/core/offapi/type_reference/offapi.idl
* (XDcoumentHandler getting moved around now is a consequence of this being the
first fully-automated generation of the file again after the manual
modifications done by the preceding 214e6caf2c503d817c47ebcc419e4f7e33b336ac
"[API CHANGE] remove BasicImport UNO interfaces" and
ebb66ee09b6041cbf755f24e54f2d1a510bbc3d3 "Fixed update of the reference rdbs
to libreoffice-6.4.0.3-buildfix1".)
Change-Id: I841b6b5a059c78750fa7f02f9276c6b6f86c9afd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
19746d24aa976cc409e58fe452b6ab5b039d0525 "Update the reference rdbs to
libreoffice-6.4.0.3-buildfix1" had erroneously labeled
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6.4.0.3-buildfix1/instdir/program/types.rdb \
.../libreoffice-6.4.0.3-buildfix1/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
as "no changes", so I redid that part correctly now:
* plus manual fixup by re-applying offapi/type_reference/offapi.idl part of
214e6caf2c503d817c47ebcc419e4f7e33b336ac "[API CHANGE] remove BasicImport UNO
interfaces"
Change-Id: If58251331c1b379a04bf0c60dfffc2ffb0f6bc6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89565
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
which are unused since
commit 4e97fa0f4e73acdf522643aeec486b1395e63727
Date: Thu Feb 20 13:09:32 2020 +0200
use fast-parser APIs for embedded script parsing
and highly unlikely to be externally used since they parse document
internal script code.
Change-Id: I2e0e237fb31bba85f1ef63c88f3a6959eedf2ca7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89104
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Mainly fixing '..' and '....'
Change-Id: Ied226ed148c571d278ae65b3f468bd329f557fa9
Reviewed-on: https://gerrit.libreoffice.org/78669
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6.3.0.4/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6.3.0.4/instdir/program/types.rdb \
.../libreoffice-6.3.0.4/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
Change-Id: Ifb44c536c87c711e46c5881fe0918a0c4c6e472b
Reviewed-on: https://gerrit.libreoffice.org/77784
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ic981076f76c92fb3112932bb7b5d97d6ec3d3c67
Reviewed-on: https://gerrit.libreoffice.org/77307
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6.2.0.3/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6.2.0.3/instdir/program/types.rdb \
.../libreoffice-6.2.0.3/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
Change-Id: I16c8cc9edafa81570f43197a1f1e78ff1eaee1ee
Reviewed-on: https://gerrit.libreoffice.org/68141
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6-1-0/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6-1-0/instdir/program/types.rdb \
.../libreoffice-6-1-0/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
* all the interim modifications to offapi/type_reference/offapi.idl were done in
error and had already been reverted again (i.e., `git diff
76f30450577bcecf0423833884e3e5215decdd07..5b0ceb86c342754d8f4e83408c7ae0da0e3931d3^
-- offapi/type_reference/offapi.idl` is empty)
Change-Id: Ibac6d00f9b6fa3fa4d4ac491af66ea4938b36b87
Reviewed-on: https://gerrit.libreoffice.org/63424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This reverts the reordering of properties and adds new properties
to the end and marks them as optional so we break API as little as
possible.
Change-Id: I422d882d1d1c721dd3ff7ad289329a9df58beb42
Reviewed-on: https://gerrit.libreoffice.org/54322
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Had been added as part of 7a8ed362eb163ac15a000ba1cfc74b58315800a1 "[API CHANGE]
revert and deprecate *BackGraphicURL add *BackGraphic", for no apparent reason.
(Will eventually be added with a "Update the reference rdbs to
libreoffice-6-1-0" commit.)
Change-Id: If6c0405df91accc52a67ad62d7ee7dfb49a4c569
Reviewed-on: https://gerrit.libreoffice.org/53981
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
*BackGraphicURL include the following properties:
- BackGraphicURL
- FooterBackGraphicURL
- HeaderBackGraphicURL
- ParaBackGraphicURL
This were removed, but for backwards compatibility this commit
adds them back again and depreactes them in the UNO API. The
behaviour also changes as internal vnd.sun.star.GraphicObject
scheme URLs aren't supported so this properties can only be set
and only if a external URL is provided. If getting such a property
then a RuntimeException will be thrown.
[ Miklos Vajna: fixed up sw/qa and writerfilter bits. ]
Change-Id: If60011837da96197b576bfe2671ecafccad736c7
Reviewed-on: https://gerrit.libreoffice.org/53511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Use Migration warn dialog directly in library dba instead of popping up
window in dbu and passing down the information through XDataSource.
Change-Id: I6b8d2b55408a741662052d4af316b0c662d799f0
Reviewed-on: https://gerrit.libreoffice.org/53363
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
Revert the state of GraphicURL property so it supports setting a
external URL, but getting throws and exception.
Modify the Graphic property, so it reflects what was used with
GraphicURL before.
Change-Id: Ia05b8ea37997b5ed8c75215557cce9979630c898
Reviewed-on: https://gerrit.libreoffice.org/53509
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Warn user with a pop-up dialog before migration.
To do that we have to know the database URL at UI level. In order to get
that I updated XDataSource interface with getConnectionURL().
The dialog offers two options: proceed with or without migration. If the
user choose "yes", we store that information in XDataSource. The
migration itself will be made in buildLowConnection().
Change-Id: I1f0d03da6352f7a0a8d989da79c4b2fe60a03ca1
Reviewed-on: https://gerrit.libreoffice.org/52876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6-0-0/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6-0-0/instdir/program/types.rdb \
.../libreoffice-6-0-0/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
Change-Id: I5419f81757ba43664aefb60f081bf52612b8afc4
Reviewed-on: https://gerrit.libreoffice.org/50762
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-5-4-0/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-5-4-0/instdir/program/types.rdb \
.../libreoffice-5-4-0/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
* plus manual fixup for now by re-applying offapi/type_reference/offapi.idl part
of 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext"
Change-Id: Iecebe43043ee2518a371b60795737436bbcb0941
|
|
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
* all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
* ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
MODULE .mo files
* UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
goes from l10n target to normal one, so the res/lang.zips of UI files go away
* translation via Translation::get(hrc-define-key, imbued-std::locale)
* python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
to keep finding the .hrc file uniform) so magic numbers can go away there
* java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
mechanism
* en-US res files go away, their strings are now the .hrc keys in the source code
* remaining .res files are replaced by .mo files
* in .res/.ui-lang-zip files, the old scheme missing translations of strings
results in inserting the english original so something can be found, now the
standard fallback of using the english original from the source key is used, so
partial translations shrink dramatically in size
* extract .hrc strings with hrcex which backs onto
xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
* extract .ui strings with uiex which backs onto
xgettext --add-comments --no-wrap
* qtz for gettext translations is generated at runtime as ascii-ified crc32 of
content + "|" + msgid
* [API CHANGE] remove deprecated binary .res resouce loader related uno apis
com::sun::star::resource::OfficeResourceLoader
com::sun::star::resource::XResourceBundleLoader
com::sun::star::resource::XResourceBundle
when translating strings via uno apis
com.sun.star.resource.StringResourceWithLocation
can continue to be used
Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
|
|
This reverts commit 795d56dfd55a78a240cef79c822ba958c4f18006. The Gerrit UI had
fooled me into pushing the "Submit" button in error.
|
|
+ keep "persistant" for compatibility reasons
but put it as deprecated
Change-Id: I7ef8efb9f376eadfdac876d142840aab5a0b4416
Reviewed-on: https://gerrit.libreoffice.org/37042
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-5-3/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-5-3/instdir/program/types.rdb \
.../libreoffice-5-3/instdir/program/types/offapi.rdb
>.../master/offapi/type_reference/offapi.idl
* plus manual fixup for now by re-applying offapi/type_reference/offapi.idl part
of 8913353a8fd2a1d281c2d8a33ca795d97201b7bc "enum spelling: throught ->
through"
Change-Id: I705dd8b33034f01d333bf80f1211022f5395609e
|
|
To complete commit 0ef94e2b559547bc4e906e7f24e57ff5d642e108
and f12096272e684ddcd8ffa4e34dcb0a680cc594c2
Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03
Reviewed-on: https://gerrit.libreoffice.org/37199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
git grep -l "[ _\.]THROUGHT" | xargs sed -i 's/THROUGHT/THROUGH/g'
git grep -l -i "[ _\.]THROUGHT" | xargs sed -i 's/throught/through/g'
In ENUMs: THROUGHT = THROUGH (preserved as valid alternate spelling)
In ooxmlexport8 - unit test confirms THROUGH = THROUGHT
Change-Id: Iae0fef9a8adcb96761989f38903a24ffb1b91e77
Reviewed-on: https://gerrit.libreoffice.org/35998
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b
Reviewed-on: https://gerrit.libreoffice.org/34803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Quick solution before 5-3 branch off without reverting everything related.
This will need a new constant value type for API instead of the enum and an
internal mapping from/to the enum.
Kept the GeneralFunction_MEDIAN at all places in uing code so it can be
easily grep'ed for.
Change-Id: I95256649f16ded08e467003d2924be0ff5efb87f
|
|
(This deliberately leaves out the published
css.mozilla.XRemoteServiceManagerProvider originally manually removed from
offapi/type_reference/offapi.idl with 4c18af27bf95b332ee2006cfc0bbf469fb1a84d4
"tdf#96398 kill remaining NPAPI support for plugins _inside_ LO" and now fully
removed with b5589970125ae4b8c0a091cfc12d058ca42ce2ab "[API CHANGE] Remove
tdf#96398 leftover XRemoteServiceManagerProvider".)
Change-Id: I75d4cd82ba306099e2563a44739bfb3867a265e9
|
|
Change-Id: Ie6f2c6f53b354552b855264faea1ae9f5cb2b76d
Reviewed-on: https://gerrit.libreoffice.org/31041
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I675e81b5c13832ac0ff893a6e080241e6f1c8fd5
|
|
Change-Id: Ie098b41440f97395893f4200128a2016cd1103d4
|
|
Change-Id: I6c2ee67d9e62a0159a36a1905f29deeee23a3587
|
|
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
- probably out of date
- links against Gtk2 and thus causes a GTk2 dependency in core packages
- the only serious usecase (Flash) is doomed anyway
Change-Id: I7264ab5eb04c2f4b6c31a815e45b9818209e5ae2
Reviewed-on: https://gerrit.libreoffice.org/20658
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I013414cf10e25acd5216643855aaa230258a1b5f
Reviewed-on: https://gerrit.libreoffice.org/18962
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
In order to use GetSelectedFiles (in XFilePicker2) instead of GetFiles (in XFilePicker),
here are some api changes
before:
XFilePicker3 inherits from XFilePicker
XFilePicker2 is not a published interface
after:
XFilePicker3 inherits from XFilePicker2
XFilePicker2 is a published interface
+ adapt Uno Implementations
Change-Id: If44afaa7236f08bc2b814f91eda5bfad333dd799
Reviewed-on: https://gerrit.libreoffice.org/17068
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
..in 9ed1dd01be8afa0961e388a79e9ff4c1235820c2 "tdf#90839: support for wrapped
text in data labels and for centered data value" by moving the additional
optional property to the end; also, add missing @since tags
Change-Id: I6f8a6cb22d29ba27a109089892b8df009d1043db
|
|
Now in a pie chart the text of a label can be wrapped, the wrapping is
automatic and the maximum text width is fixed to almost half the pie
radius. This feature is used to import correctly the relative text
wrapping property provided by MSO.
Moreover the data value and percent value of a label are now centered
horizontally, respect with the label text.
Conflicts:
chart2/qa/extras/xshape/chart2xshape.cxx
Change-Id: Ie10d6184365436f763cd9693a5bbefcfa9b3862b
Reviewed-on: https://gerrit.libreoffice.org/17193
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
...re 2c346d669648bdecbe4be0e6013af14abef2526a "tdf#39080 Hide Whitespace UI
option added to the View menu."
Change-Id: Ib2f364dba7a50854a11f004b42c7ee22ee10e48b
|
|
Change-Id: I1f9ba9ef489159ca54db802393d958d7fd6ac8ff
Reviewed-on: https://gerrit.libreoffice.org/17280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510
Reviewed-on: https://gerrit.libreoffice.org/16709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
Change-Id: Ib1108763ebf556d2e812f077676914c4e64ddaf2
|
|
Change-Id: I33953f96630d6269ffdbf83f9fc9f747178e87d2
|
|
Change-Id: I434be0034b26ac4719590238817538ecd90b8923
|
|
...from 9835bb562cfe3a5d386c24d86176ba7bb5ab26d2 "MM: export the SwDocShell mail
merge via UNO." It shall only be edited manually when deliberately going
incompatible.
Change-Id: I19c82dca3b6537631a155629d6072b516b32ded5
|
|
This saves the loading time for large document. Use it if you
want to present the generated document to the user or write a
mail merge unit tests.
This includes:
* renaming "only" to "shell" at multiple occurences
* dropping the DBMGR_MERGE_SINGLE_FILE special type for the mail
merge wizard in favour of an additional SwMergeDescriptor
boolean
* cleanup and renaming of the internal merge type enums, so these
actually match the diffferent merge targets: printer, email,
file and shell
Change-Id: I33c6773972195193687ba9c3e12b562310d330c1
|
|
This reverts the part of 4452ac23224cc6fc9c575f1b128dd71f79e12d88 "Fix hungarian
prefix for calendars" that needlessly changed a method parameter name in
published UNO API, which is, strictly speaking, incompatible.
Change-Id: Icd1ee34d200ebab01010d5dd35a1b19c47bfc05a
|
|
Change-Id: I78b3c0a8d32610e86e09ab5ad6da6cc4e0395926
Reviewed-on: https://gerrit.libreoffice.org/9566
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
...incl. some /** @deprecated */ that had inadvertently been missing from the
original unoidl-read output, and re-apply the fix from
09f9a79b112aae36d54520568962d84a931f6491 "[API CHANGE] fix endCDATA to allow
throwing css::xml::sax::SAXException."
Change-Id: I5f9001e0cf05ec6cd950011ab307b71811f1a2e1
|
|
...for better diff-ability in the future.
Change-Id: Ic3a374ca8ffff4e88e9ccc9e858e82035dc43695
|
|
coverity#1158397 Uncaught exception
Change-Id: Iabf0b1f0500cb4218d8cb3aff372777471e8f287
|
|
...and the hack to locally introduce a bogus pupblished forward declaration of
XFormOperations with which this has been worked around in
cf5c36912390b2f6018f57f79085ab1fa88a08d6 "INTEGRATION: CWS dba23b: work around
idlc limitation, which does not allow to refer unpublished interfaces as
optional entities in published services" no longer works in
offapi/type_reference/offapi.idl.
So given FormController is a (deprecated, even) old-style service (i.e., little
more than glorified commentary), the best fix probably is to demote the
problematic optional property to a comment.
Change-Id: Ia38483c817dc1762ba73315abcd4f9f063db3093
|