Age | Commit message (Collapse) | Author |
|
As found out in 98c0b20864af965c3bb99a32f8ea57be7402e534 "Make Firebird the
(unconditional) default for new databases": "(Curiously,
ODsnTypeCollection::getEmbeddedDatabase would read a DefaultEmbeddedDatabase
value from the configuration before resorting to the hardcoded default, but
`git log -SDefaultEmbeddedDatabase` makes it look like there has never been any
code to actually write that setting.)"
Digging deeper, the story appears to be as follows: First, "INTEGRATION: CWS
hsqldb" commits in 2004 had addded the EmbeddedDatabases group (and accompanying
templates) to officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs
(ee11cb6373f6bbb28b1cdf57daa73465d030fda5), corresponding values (for HSQLDB)
to officecfg/registry/data/org/openoffice/Office/DataAccess.xcu
(60c5f0af740265ab81b620208205fe9e74be452f), and code to read those values
(lcl_getEmbeddedDatabase in dbaccess/source/ui/misc/dsntypes.cxx;
ODsnTypeCollection::getEmbeddedDatabaseURL et al in
dbaccess/source/ui/misc/dsntypes.cxx; all
a68938bc908c8f852912f3310d2f4bec779a3cea). This looks like it actually worked.
Then, "INTEGRATION: CWS dba24b" commits in 2007 removed the EmbeddedDatabases
configuration data from
officecfg/registry/data/org/openoffice/Office/DataAccess.xcu
(473a3ccf63cc36ac3fa992dcb72d581496cb1bbf, "during #i80930#: The approach to
read the concrete type of the embedded DB from the configuration does not work,
there are enough places where we silently assume 'embedded == embedded HSQLDB'")
and removed the code reading it (79bbd382beb13a8f4031cc9b61332d0794878699), but
left the EmbeddedDatabases schema data in
officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs untouched.
Then, b88a62cc97613e5dc00c806f59982cb57f9d1dc8 "CWS-TOOLING: integrate CWS
dbaperf2" in 2009 reintroduced code that attempts to read the configuration data
as ODsnTypeCollection::getEmbeddedDatabase
(dbaccess/source/core/misc/dsntypes.cxx). The reason for that may be
"2009-05-06 14:22:21 +0200 oj r271589 : #i101587# use config for the drivers"
as listed in the commit message. The code added as
ODsnTypeCollection::getEmbeddedDatabase back then remained effectively unchanged
until today, but looks fundamentally broken: It starts out with trying to read
an /org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase/
Value property that can never be present per the schema (an
/org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase
property could be); so no data is ever actually read from the configuration by
ODsnTypeCollection::getEmbeddedDatabase. (And the commit also didn't add back
any configuration data to
officecfg/registry/data/org/openoffice/Office/DataAccess.xcu that could have
been read in the first place, nor any code to generate such data
programmatically.)
So remove the broken code to read configuration data from
ODsnTypeCollection::getEmbeddedDatabase (which means it can be a static member
function now) and also remove the obviously unused EmbeddedDatabases group (and
accompanying templates) from
officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs.
Change-Id: Icc9b34075b9b7e960df6c236d3595b7fabe71f9d
Reviewed-on: https://gerrit.libreoffice.org/67494
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
it now looks old-fashioned hyphenated
Change-Id: I5b2b905277356c1b986f97de29f82ac1c21b1709
Reviewed-on: https://gerrit.libreoffice.org/66796
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Ibbd2569e150994dbab233b4244c63657ef4b66e3
Reviewed-on: https://gerrit.libreoffice.org/67345
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I16ff0d5ff896d896cd2e261ea86a8df8d9b45f3b
Reviewed-on: https://gerrit.libreoffice.org/66974
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
* Add a new parameter IsRedactMode (SID_IS_REDACT_MODE) to .uno:ExportDirectToPDF
* Make sure the new param makes it into PDFExport as part of FilterData
* Hijack the metafile before being sent to ImplExportPage(), convert to bitmap, and replace the original
* Add a new entry to GenericCommands.xcu to make our button with param visible
* Nitpick: For things to be included in the bitmap conversion,
they need to be added to the metafile before the conversion
in PDFExport::ExportSelection(). Things added after that point
(inside ImplExportPage() for example) will not be bitmapped/pixelized
Change-Id: Iec7020917da920a968ea969b98e53f17eadaa275
Reviewed-on: https://gerrit.libreoffice.org/67108
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
...instead of never (as there is no handling of
org/openoffice/Office/ProtocolHandler-start.xcu in
officecfg/Configuration_officecfg.mk). That install:module="start" included in
d930cefbe65d8b7f21100fcbf2ddcd977dd15cb1 "Startcenter: Refresh RecentDocsView
when select 'Clear list' menu option" was probably misguided cargo-cult-copying
from (meaningful) install:module="impress" that were already present in
officecfg/registry/data/org/openoffice/Office/ProtocolHandler.xcu.
Change-Id: I03ed0cf84b576597a7b88ee6627a12cedbca4960
Reviewed-on: https://gerrit.libreoffice.org/67224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I3d6bc2adb91fbe16da008797b7b7e5189726c500
Reviewed-on: https://gerrit.libreoffice.org/66968
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Support HK variant that are newly added to Adobe Source Han Sans
2.0 and Google Noto CJK Sans 2.0 and add missing TC, SC, HW, etc.
in English font names.
Change-Id: I3edccecfd0926d8c11a30bbb5be0debc0f8edf5a
Reviewed-on: https://gerrit.libreoffice.org/66955
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
* Consists of .uno:Rect, .uno:LineToolbox, and .uno:ExportDirectToPDF
* Automatically shown when we are in the redaction process
* Customizes the rectangle tool for our needs
Also:
* Adds new parameters to the SID_DRAW_RECT (.uno:Rect)
to be able to set transparancy, fill color, and line/border style,
and to make our button sticky/permanent
Known problem: Button's icon is not shown after adding the parameters
Change-Id: I7928264415769f7e0a4ded171b864adb99aed442
Reviewed-on: https://gerrit.libreoffice.org/66706
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
and ..
Change-Id: I8c4f48d8644d7d3775fe693aa5f8b96a6ca41ef5
Reviewed-on: https://gerrit.libreoffice.org/66175
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Options in menus concerning Pivot Table changed to reflect their functionality as requested by Yousuf Philips (jay) in the comments.
Menu: Data > Pivot Table > Create... -> Insert or Edit...
Toolbar Tooltip: Insert Pivot Table -> Insert or Edit Pivot Table
Context Menu: Edit Layout... -> Properties...
Change-Id: I77c909a5de1606fab9e23e3e3614fcae440aa586
Reviewed-on: https://gerrit.libreoffice.org/66032
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins
|
|
Change menu Item "Slide->Master Slide" to "Slide->Change Slide Master"
Change dialog name "Slide Design" to "Available Master Slides"
Change dialog name "Load Slide Design" to "Load Master Slide"
Change-Id: I98fab31cdce2e8ddf43f0c8b8519a95e15c13de5
Reviewed-on: https://gerrit.libreoffice.org/65860
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Turns out this was a wrong solution to the problem, also
causing printout mixups on busy printers for the users
This reverts commit 37c3e57c788fb5ad931126ea233093d87ac3dbc3.
Change-Id: I8a456f4c90f48854c1f5e92dc39ed4ec8a17cf75
Reviewed-on: https://gerrit.libreoffice.org/65993
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Current background color function only sets table cell background when
multiple table cells are selected. Paragraph background is otherwise
set. This gives expected results for use in sidebar Paragraph panel when
multiple table cells are not selected but unexpected results when
multiple table cells are selected. For background setting from the table
tool bar unexpected paragraph background color is set when multiple
cells are not selected.
This fix creates a table cell background color uno command specific for
setting table cell background color.
Change-Id: Ic56723b635252415d932c5499f996c3e46eee13b
Reviewed-on: https://gerrit.libreoffice.org/65591
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
- Add an uno command to create an empty draw document
- Create a meta file from the first page of a Writer document
- Insert meta file to the draw page
- Doesn't work with normal/default view on big/high-res screens
because of a bug in the MapModes. Manually setting zoom level to %200
or "Page Width" (to get rid of the extra space around the actual page)
works for now as workaround.
Change-Id: I05a987617efdda6690400ef550b81b58b21aa27e
Reviewed-on: https://gerrit.libreoffice.org/64858
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: I36a70995ef66048d730db135aafd30f917393ce6
Reviewed-on: https://gerrit.libreoffice.org/65603
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: I6b86894cf9e14b0231bd68f2c162636488e8212c
Reviewed-on: https://gerrit.libreoffice.org/65605
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
since...
commit 08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1
Date: Sat Oct 28 02:28:18 2017 +0200
related: tdf#103884 remove gltf/collada feature
Change-Id: I7671746f2b33f8d4eae207448267d0284a3f9804
Reviewed-on: https://gerrit.libreoffice.org/65336
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I788e97ce1f6422ba95a478fb1618773c850764f5
Reviewed-on: https://gerrit.libreoffice.org/65262
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Id5ec45290a0829d15a0d88a68d2ed891b9dae195
Reviewed-on: https://gerrit.libreoffice.org/65041
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
If minimizer is used on current presentation without making
a copy and it has local modification we should suggest user
to save it before, since not all minimization opearions could
be reverted later.
Change-Id: I12600c9a818698418f3ec957d43b13c6044609d2
Reviewed-on: https://gerrit.libreoffice.org/64261
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
for writer, calc, impress and draw
Change-Id: I7eadf5645788548357d5fb980b8cc938a6a47912
Reviewed-on: https://gerrit.libreoffice.org/64925
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Now this list is used also in rules for capitalizing first letter of
every sentence, and for correcting accidental use of Caps Lock key.
Change-Id: I4fbdbccbae32743d5e9a6757344361eefd88e167
Reviewed-on: https://gerrit.libreoffice.org/64759
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I3f63ecc13e830ae9a0062b34256f3c3f73ef7e5e
Reviewed-on: https://gerrit.libreoffice.org/64377
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: Ia103201667c3469071f19450589bd22faf3ae80e
Reviewed-on: https://gerrit.libreoffice.org/63883
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: I995be37ded721d64ef018a9ec16fdc439293d386
Reviewed-on: https://gerrit.libreoffice.org/64380
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Iafe1261dc3415121aa08f1ad4dad0cd9cc008ac8
Reviewed-on: https://gerrit.libreoffice.org/64379
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Both of these are trivial and quite common mathematical operations.
Unary minus is a bit complicated in that unary '-' is the same symbol
as binary '-' and so there needs to be a hack to expand the '-'
from the list to both of the opcodes ocSub and ocNegSub.
Change-Id: I556e20e161c22dc89919afffbf904c1ef1d552ff
Reviewed-on: https://gerrit.libreoffice.org/64362
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Locking files on WebDAV shares was implemented in tdf#82744,
in particular:
commit 26e6d4b05ab444e6a7529ffcac7fbe592fc94833
tdf#82744: fix WebDAV lock/unlock behaviour - part 1
commit bc9a8ddbb7081f79e915c841e56fd1c40f0df6f9
tdf#82744: fix WebDAV lock/unlock behaviour - part 2
commit b4576f3da4d90139fc5140962d13cb91dab98797
tdf#82744: fix WebDAV lock/unlock behaviour - part 3
commit fed2984281a85a5a2f308841ec810f218c75f2ab
tdf#82744: fix WebDAV lock/unlock behaviour - part 4
Before that, files on WebDAV shares were accessed w/o locking since
the beginning of [OOo] time. This option allows to revert to
the old behaviour i.e. non-locking WebDAV access.
For concurrent read-write WebDAV access by multiple users it is
recommended to keep UseWebDAVFileLocking at default value (true)
Change-Id: Id92177631d4854d6c7bf412164acbd9740db9592
Reviewed-on: https://gerrit.libreoffice.org/64116
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642
Reviewed-on: https://gerrit.libreoffice.org/64283
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
add missing colibre icons
improve layout for large icons
Change-Id: Id9d003b945654f958ec43d530083e2070d4b580e
Reviewed-on: https://gerrit.libreoffice.org/64159
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I6b071365ee1531c3ddba70a25e36d6bd98561ffc
Reviewed-on: https://gerrit.libreoffice.org/64135
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
PathSettings::impl_storePath wants to be able to nil the Dictionaries
path in the old copy of properties
Change-Id: Id579914cfa8b459efce962d304e2f9d6185bd55f
Reviewed-on: https://gerrit.libreoffice.org/64115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia3d035d827c0f1b510f9ff3be8652f5bac69cead
Reviewed-on: https://gerrit.libreoffice.org/64136
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
and document in the registry that the SubstFontsPS is unused
Change-Id: I66a9e0b4353f17b34cffb02823726c9887b7bdd3
Reviewed-on: https://gerrit.libreoffice.org/64065
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia96c0bbb030e6404a18e08556c33ecb40378f843
Reviewed-on: https://gerrit.libreoffice.org/63968
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I9e3a071b9b5792a627a3c5b478ba16f0de386487
Reviewed-on: https://gerrit.libreoffice.org/63630
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: I442c4bf9acbd85f340371014c20be3292a016beb
Reviewed-on: https://gerrit.libreoffice.org/63613
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
for writer, calc, impress and draw
Change-Id: If595fef7f6bfb8d583533b8f7b152d424b814724
Reviewed-on: https://gerrit.libreoffice.org/62959
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I22cbbafb0ed4fe361d88aa791adfdc9c7fe0fca4
Reviewed-on: https://gerrit.libreoffice.org/63140
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Ia59ecb8f7912157aee23a6f2b5ea4aa178dd20fa
Reviewed-on: https://gerrit.libreoffice.org/63051
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: If524e701ab295c83b485376fd4139540d3f28d7b
Reviewed-on: https://gerrit.libreoffice.org/62961
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I13309fa47130455a0f58b027b7815e3c24019d40
Reviewed-on: https://gerrit.libreoffice.org/62982
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
|
|
Change-Id: Ie6a61a5193b7b6d216f924f1abc8627ab605f2a4
Reviewed-on: https://gerrit.libreoffice.org/62931
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
According to code, it is expected that minimized copy of
presentation is proposed with ".mini" suffix as default,
but this does not works right now. As a solution a new
localized prefix "(minimized)" is added to filename.
Change-Id: If869c70a5885a9c917fc7254aa8b0d164a6f5a50
Reviewed-on: https://gerrit.libreoffice.org/62781
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Insead of custom error dialogs try to use standard LO error
reporting & localization
Change-Id: I199c7770dd884a6c5d9b22075d22ab9a9f2037a8
Reviewed-on: https://gerrit.libreoffice.org/62779
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad8
Reviewed-on: https://gerrit.libreoffice.org/62801
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I66cde29f8b64c5212f748930b5575763f54e59be
Reviewed-on: https://gerrit.libreoffice.org/62793
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad9
Reviewed-on: https://gerrit.libreoffice.org/62772
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Although these commands were available in context menus,
there was no main menu access to these commands.
Also:
-cleanup unused context/popup labels related to table items.
Change-Id: Ia574c3783bb279e869c2b8c716f6fb394aa21873
Reviewed-on: https://gerrit.libreoffice.org/61715
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|