summaryrefslogtreecommitdiff
path: root/officecfg
AgeCommit message (Collapse)Author
2019-08-15embeddedobj: allow controlling if PDF documents are converted to Draw or notMiklos Vajna
This is a bit custom, since it's not a Microsoft filter. At the moment this affects only Insert -> Object -> OLE Object -> from file. Change-Id: If79602742a533db1b04e11a90890f8768186046d Reviewed-on: https://gerrit.libreoffice.org/77520 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-15embeddedobj: allow controlling if Visio documents are converted to Draw or notMiklos Vajna
At the moment this affects only Insert -> Object -> OLE Object -> from file. Change-Id: I8d1c6456481610491916e3be3766b0bb04dfa296 Reviewed-on: https://gerrit.libreoffice.org/77489 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-08Resolves tdf#126608 - Unclear page formattingHeiko Tietze
Page entry moved into the next section and renamed to Page Style to make the difference to direct formatting more clear Change-Id: I1e75f9c82d459e35329231b06fa695651564f0c2 Reviewed-on: https://gerrit.libreoffice.org/77148 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-08Context menu should display "Insert Comment" instead of just "Comment"Samuel Mehrbrodt
Change-Id: I8e6ee73cd1d7504e86770334e9afc31c0bb434b1 Reviewed-on: https://gerrit.libreoffice.org/77145 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-08tdf#119228 Add 'Resolved Comments' option to the View menu.Scott Clarke
Change-Id: Ib4554b77857992959a386c71e99e424579196ded Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75862 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-07tdf#103703 Print automatically inserted blank pages by defaultGabor Kelemen
This reverts tdf#42099 as that is believed to be a misunderstood report. Change-Id: I01984ffcb200c2d7d780c740f92f956dd9fdc363 Reviewed-on: https://gerrit.libreoffice.org/75944 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-07tdf#119228 Add UI elements to resolve and unresolve commentsScott Clarke
Change-Id: I22403299d034a638724077744070b3add64cacf2 Co-authored-by: Jim MacArthur <jim.macarthur@codethink.co.uk> Reviewed-on: https://gerrit.libreoffice.org/75861 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Move CopyHyperlinkLocation to svxSamuel Mehrbrodt
so that it can be used by other modules too Change-Id: I43d197320f85a3ec06b6b0b832f7bb5647800076 Reviewed-on: https://gerrit.libreoffice.org/77012 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06tdf#107471 Add checkbox to enable/disable sending crash reports to TDFGabor Kelemen
Also hide it when compiled with --disable-breakpad i.e. most Linux distributions Change-Id: I5d392e22410614550aa9602d0c30b0b81ec22ea0 Reviewed-on: https://gerrit.libreoffice.org/76771 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-24"Basic macros" instead of "$Productname Basic macros"Samuel Mehrbrodt
This might lead to confusion as if there were different macro types depending on the current downstream package name. E.g. "LibreOffice Basic macros" might become "LibreOffice Vendor XY basic macros". Remove that confusion by using just "Basic macro" in the UI. Change-Id: Ifc2543bb151e94fc6c6e47d878720dd99294f596 Reviewed-on: https://gerrit.libreoffice.org/76216 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-22tdf#118370 Draw: add option to consolidate multiple textObjsJustin Luth
This gives the user a tool to consolidate multiple textboxes into a single textbox. First the user selects a group of textframes, and then runs the consolidate text function. This will REPLACE the marked textframes with a single textbox combining all of the text. The function inspects the text fragments to see if they end in sentence-ending punctuation. If not, then the next textbox's content is appended to it instead of starting a new pargraph. It is the user's responsibility to afterwards fix up paragraphing, and set paragraph properties. The rational for this patch is to simplify making major text changes on PDFs imported into Draw, since each paragraph is currently broken into tiny character-property textbox fragments. Copy/paste from the PDF itself doesn't keep character attributes, so it is hard for a user to re-create the text. This is related to tdf#32249, but as a comment says, a better solution would be to write an entire text-focused PDF import, rather than just pick up the pieces. And I agree, but considering this simple patch took me a couple of weeks of frustration, I'm obviously not the person to do that. And since the bug has been open for 9 years, likely no one else will either. Thus, this pick-up-the-pieces tool to help the end user. This initial patch works only with textFrames, but can easily be adjusted to consolidate other HasText() SdrObjects. However, that tended to produce unexpected results, so everything other than OBJ_TEXT is explicitly excluded. (Thus general shapes with text, callouts, text-along-path etc are ignored.) Change-Id: I68a9a5b187bf320a8e671414c5cb22b07725fd52 Reviewed-on: https://gerrit.libreoffice.org/75043 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-07-19Addons(extension) support is extended for NotebookBarSumit Chauhan
This patch adds the schema for the extensions to be available in Notebookbar. We will adding items in addons.xcs in future if needed. Change-Id: I0a3831983b9758fac0a6fa32213ad6da20d6a97f Reviewed-on: https://gerrit.libreoffice.org/75134 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-07-17vcl: make "Reduce Transparency" parameter tweakableVasily Melenchuk
"Reduce transparency" feature previously was using hardcoded value of 0.25. If current object area to whole printing area ratio exceeds this value, object is being written without any extra transparency layers in order to reduce metafile size. Right now this value can be adjusted in "Expert Configuration". Parameter is called "ReduceTransparencyMinArea". Change-Id: I43d5801a1dff6241de214f7b24425626dc06b4fb Reviewed-on: https://gerrit.libreoffice.org/75471 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-15tdf#125783 - .uno:WhatsNew command lacks name and tooltipHeiko Tietze
Label and tooltip added to GenericCommands Change-Id: I292c377aed146196f1a9c3cc92f122b9b14c9b70 Reviewed-on: https://gerrit.libreoffice.org/75632 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-15Deduplicate EditHyperlink commandSamuel Mehrbrodt
Change-Id: I23f0c276c5c1229aeb4ea468c6b858e36c120bd9 Reviewed-on: https://gerrit.libreoffice.org/75480 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-12MSForms: Insert text-based date field from MS compatible Forms menuTamás Zolnai
Change-Id: I2f08fa806dc55a185adf67ca616af8d81bb23bda Reviewed-on: https://gerrit.libreoffice.org/75438 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-09NB add contextual single support for impressandreas kainz
Change-Id: Ie51bfcc81843ef21d83042dbaf409e6dab99b3c2 Reviewed-on: https://gerrit.libreoffice.org/75247 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-05Related tdf#98575 Add "Edit Hyperlink" to context menu in sdSamuel Mehrbrodt
Change-Id: I121373fae5122e779614a53ac73b4b9d058908d2 Reviewed-on: https://gerrit.libreoffice.org/75126 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-05Colibre, Breeze, elementary, KJ: tdf#107144, Breeze: tdf#126233rizmut
- Add Impress transition, 3D related icons - Add many 32 px size for Calc and Draw specific icons - Fix blurred icons - Add more missing menu items Change-Id: I915e31aee51e84c88dd99e1fa3f6d5a4c7ca50d0 Reviewed-on: https://gerrit.libreoffice.org/75106 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-07-04tdf#125939 Correct tooltips for tools on Drawing toolbar in DrawRoman Kuznetsov
Change-Id: Ibde6c07ab44a9eefe0c02d177497f201a53b5130 Reviewed-on: https://gerrit.libreoffice.org/75030 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-07-01tdf#126088 Display InternalPaths in UISamuel Mehrbrodt
Change-Id: Ib729be9ff79a3e43d7ec838646b530be8beff2d8 Reviewed-on: https://gerrit.libreoffice.org/74952 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-28tdf#125748 Add context menu entry to execute interactionSamuel Mehrbrodt
This is a follow-up to commit 5f795576d45988d20aa9. This reintroduces the possibility to execute an interaction in edit mode by adding a context menu entry for it as discussed in the bug report. Change-Id: Ibc26c227b592b888129baa2b68590178fdadee98 Reviewed-on: https://gerrit.libreoffice.org/74731 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-25NB impress add tabbed compact layoutandreas kainz
Change-Id: Ia1aab531967644ac6f7cd21210a87a30082de42a Reviewed-on: https://gerrit.libreoffice.org/74660 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-23Fix typosAndrea Gelmini
Change-Id: Id805595850125de5d791f016649b660a7fedba8a Reviewed-on: https://gerrit.libreoffice.org/73779 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-18tdf#111707 Add 'Remove Hyperlink' to context menu in ImpressSamuel Mehrbrodt
"Clear formatting" no longer removes the hyperlink, as now there is a dedicated context menu entry for this. Change-Id: Ic47795b9ecb238470f853da527c648f6edb94c09 Reviewed-on: https://gerrit.libreoffice.org/74272 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-14tdf#88287 Change toolbars attributes in DrawRoman Kuznetsov
The tooltip for .uno:LineToolbox changed to 'Curves and Polygons' The toolbar title of linesbar.xml changed to 'Curves and Polygons' The Arrows toolbar (arrowsbar.xml) removed from View > Toolbars The toolbar title of arrowsbar.xml changed to 'Lines and Arrows' Change-Id: Ic97c7a11f071a4f424a341e297423dba2ddc345a Reviewed-on: https://gerrit.libreoffice.org/69335 Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com> Tested-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-06-13Make .uno:Objects3DToolbox item work in menusMaxim Monastirsky
Similar to the other insert shape group commands. Change-Id: I67524c1d521246b76d953ed9a8aff506535bf550 Reviewed-on: https://gerrit.libreoffice.org/73970 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-06-13Item syntax changed to explicit - Custom Notebookbar TabSumit Chauhan
Related Patch : https://gerrit.libreoffice.org/#/c/72698/ Change-Id: I87984289ab180d10cecf382320b391192f6ca71e Reviewed-on: https://gerrit.libreoffice.org/73890 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-06-11tdf#120844 Remove tabletext.xml from sdraw and from simpressRoman Kuznetsov
Change-Id: Ide91a0eb3776322e5adb4dbd0acc697dbb41b500 Reviewed-on: https://gerrit.libreoffice.org/73337 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-06-10Using registrymodifications.xcu for storing customized uiitem dataSumit Chauhan
This patch store and render the GtkToolButton/GtkMenuButton of notebookbar*.ui show/hide property in registrymodifications.xcu. The patch also gives a solution to copy the notebookbar*.ui file in user directory from share directory provided file is absent in user directory.The patch also uses libxml2 library and write i.e change the property of uiitem(GtkToolButton/GtkMenuButton) in notebookbar*.ui files present in user directory. Change-Id: I518f37fc858250a04fafd2a4475e3ed03185f6ff Reviewed-on: https://gerrit.libreoffice.org/72698 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-06-08tdf#125481 changed font order for Korean localeDaeHyun Sung
- Set Noto Sans CJK KR as the 1st priority. - Set Nanum-series font as the 2nd priority, Such as NanumGothic(나눔고딕),NanumMyeongjo(나눔명조) - Set KoPub-series font that Korea Publisher Society(한국출판인회의) and Ministry of Culture, Sports and Tourism, Republic of Korea(문화체육관광부) are released - for Windows vista and later versions, Add default Korean font, Malgun Gothic(맑은고딕) - for Mac OSX, add default Korean font Apple SD Gothic Neo(Korean: 애플 SD 산돌고딕 Neo) - for Mac OSX, Also add Mac OSX fonts Apple Gothic(애플고딕),AppleMyungjo(애플명조) - remove Sun-style fonts(Maybe Sun StarOffice's legacy) - remove Hy(한양)-series fonts(Hancom HWP package's font, proprietary font-series) Modern Linux distribution's default Korean font-families are Noto Sans&Noto Serif-family Before Noto Sans font released, UnFont-family was Linux distribition default Korean font. Early Linux distribution's default Korean font: Baekmuk-family. Sun-series font rarely use in Korean Linux distribution. ps. Noto Fonts(Modern Korean All OS default fonts) https://www.google.co.kr/get/noto/ Source Han Sans https://fonts.adobe.com/fonts/source-han-sans-korean Source Han Serif https://source.typekit.com/source-han-serif/kr/ Nanum-series font https://hangeul.naver.com/font KoPub-series font http://www.kopus.org/biz/electronic/font.aspx UnFont(Many of Linux distribution's default Korean font) http://kldp.net/unfonts/release/ Baekmuk Font(Early Linux distribution's Korean default font http://kldp.net/baekmuk/ Change-Id: If5bbcf549cbe96240250e44396dce1ff714c88b8 Reviewed-on: https://gerrit.libreoffice.org/73307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-08Auto redaction dialog first iterationMuhammet Kara
* Add the uno command .uno:AutoRedact with the name 'Auto-Redact' * Add the dialog SfxAutoRedactDialog * Implement the basic functionality to show up when clicked on the menu/toolbar item. * Add the class TargetsTable to control the weld::TreeView which is used to list the targets * Add the struct RedactionTarget to keep info for individual targets Change-Id: Ic02dfb009590c0928a2ea7b0f8b19b4febca221a Reviewed-on: https://gerrit.libreoffice.org/72254 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-07notebookbar_compact updateandreas kainz
Change-Id: I256c2ec3934d728b5b68fbca8b7ba99a50a840ff Reviewed-on: https://gerrit.libreoffice.org/73661 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-07Remove .uno:ToolsMacroEdit commandJens Carl
A search with git grep ".uno:ToolsMacroEdit" showed that the entry isn't used anywhere (also .uno:BasicIDEAppear provides a similar functionality). Change-Id: Ib97f4ebd6707d82f9077dd2f4e6c05e537f8154d Reviewed-on: https://gerrit.libreoffice.org/73582 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-06KJ & elementary: +/^ svx dir, elementary: ^ bezier & mimerizmut
Change-Id: Ieaff18277743da93393667c946ed2e95c98921b0 Reviewed-on: https://gerrit.libreoffice.org/73466 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-05-28NB: add tabbed_compact and contextual NB to Drawandreas kainz
Change-Id: Ibdca2026f29483948c2fafaf499a82d2a4acf08b Reviewed-on: https://gerrit.libreoffice.org/73095 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-28tdf#120905 Remove temporary uno command.Gülşah Köse
Change-Id: Id12838cf08a2e5b74b53bd0036804b886b41098f Reviewed-on: https://gerrit.libreoffice.org/73041 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-05-27sw HTML import: add an option to ignore comments by defaultMiklos Vajna
No function change, default behavior is still mapping them to postits. Change-Id: I55041452909e9f0b83d6c5d113af3067b3c0afdb Reviewed-on: https://gerrit.libreoffice.org/73021 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-23Revert "tdf#113241 better default for number recognition options in Writer ↵Cor Nouws
tables" This reverts commit 2b0cb3cf4ac35dbe29b203d24adf5604a860cde5. As per tdf#125371 there are changes in existing documents in cells that are re-calculated on file-open. IMO this needs to be fixed before this patch can be re-applied. As such there is no question on the changed settings in the Options. Change-Id: Ib748cc520d4d475097cd5fd7e5500456b34f0789 Reviewed-on: https://gerrit.libreoffice.org/72860 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-23Resolves: tdf#125128 set Tables as "above" by defaultCaolán McNamara
see also tdf#40457, tdf#115032 Change-Id: I505c3dfaf8f0a23e525db015f52a881b22016d11 Reviewed-on: https://gerrit.libreoffice.org/72846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23Add new customize and position merged dialogGülşah Köse
Change-Id: I898fb0830a9f53da4a7917cb5900f082e3a9d6b7 Reviewed-on: https://gerrit.libreoffice.org/71944 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-20tdf#90180 Add option to show errors as rectangles in diagrams with error bars.Winfried Donkers
The option is saved in registrymodifications.xcu, not yet in the document. (cherry picked from commit 0fc471e8218b53b8b9e505d2af3e015abf3910f3) Change-Id: I6facc8d6e456046003f2c38ce79a1fcfc712d027 Reviewed-on: https://gerrit.libreoffice.org/67280 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-19Fix nillability of ooSetupLastVersionStephan Bergmann
...that had been introduced with 5187d3ae495a07373a12fd5980c9269bc8ce3f8f "Resolves: tdf#69042 - Add a 'What's New' infobar": * Make the default value nil instead of an empty string. * A nilable prop can't reuse the legacy utl::ConfigManager framework to obtain string prop values, so drop it from there and directly use the direct-access functionality in SfxViewFrame::Notify. Change-Id: I5fc67a3d7e0fcb44a218889ecf8c69e81661567e Reviewed-on: https://gerrit.libreoffice.org/72485 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-17Remove spurious trailing whitespaceStephan Bergmann
...introduced with 5187d3ae495a07373a12fd5980c9269bc8ce3f8f "Resolves: tdf#69042 - Add a 'What's New' infobar" Change-Id: I7ffa28e996838e681d1ecc317b9c3af56f74bc5a Reviewed-on: https://gerrit.libreoffice.org/72454 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-17Resolves tdf#87965 - Make 'Search Results' dialog optionalheiko tietze
* Option introduced at Tools > Options > Calc > View (Windows) * Convenience checkbox added to the dialog Change-Id: Ic30fb302e61e77b0eefacd504f61f955bcf6e595 Reviewed-on: https://gerrit.libreoffice.org/71910 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-17Resolves: tdf#69042 - Add a "What's New" infobarheiko tietze
Shows an infobar with a link to the respective wiki page Adds a button to the About dialog Replaces If6eb1542d2ad310226f76850f480f2f99070b803 Change-Id: I1eeb504994a6364feb90cfa447029875e0ec1969 Reviewed-on: https://gerrit.libreoffice.org/72218 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-14SmartArt: regenerate diagram commandGrzegorz Araminowicz
It removes diagram content and rebuilds shape tree from diagram markup. Diagram should appear unchanged - editing will be added in future commits. Change-Id: I6bfc21956a1a23e55d3c7a74384db71d957d690d Reviewed-on: https://gerrit.libreoffice.org/71584 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-10an uno -> a unoCaolán McNamara
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>