summaryrefslogtreecommitdiff
path: root/oox/source/docprop
AgeCommit message (Collapse)Author
2017-03-30remove type decorations on char literalsJochen Nitschke
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24use rtl::Reference in FastParserNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: I6b67a6098a3ccdce7e29ee8d601c743897032eaf
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ooxStephan Bergmann
Change-Id: I83c6995e4f15d6a042e57bac4d71874124402547
2016-10-13tdf#103143 Fix importing number of characters from docx filesBartosz Kosiorek
Change-Id: I45429626f7299f84fda2969dd6000c8aa8d23982 Reviewed-on: https://gerrit.libreoffice.org/29721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-06-21simplifyNoel Grandin
Change-Id: I67de532443cbb9e64bed67fe28ee94fef38f5eae
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-22loplugin:unusedfields in oox,packageNoel Grandin
Change-Id: I8f8c3ff9ded455a09f3df81c501da17cca0b2310
2015-11-30oox: better warning message on unhandled element in docprophandlerMiklos Vajna
Change-Id: I7ddd5290134ae3cc3b9f7427055537e79919b480
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23com::sun::star->css in lotuswordpro,mysqlc,ooxNoel Grandin
Change-Id: Id99ff87c4eb3f1b36702261ce63d5d2793ea35d7
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-04tdf#93097 oox: fix import of metadata from non-relative stream pathsMiklos Vajna
Commit ef2668bad976f1fbb70759887cafd35ea7833655 (PPTX import: fix missing document metadata, 2014-08-28) implemented metadata import for the PPTX filter, but in case the metadata stream is not an existing one, then OHierarchyHolder_Impl::GetListPathFromString() invoked by OStorage::openStreamElementByHierarchicalName() throws. The bugdoc is generated by a 3rd-party tool that always starts the stream path with a slash, and MSO seems to just ignore that: so let's do the same to be able to open the document. Change-Id: I6c0715adeb19b9055669f6a45055415dd2c44e28
2015-08-23oox: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I8a82df7ea24874d8e246dc983418d872f1943c8e Reviewed-on: https://gerrit.libreoffice.org/17919 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04tdf#91378: sax, oox: avoid sending empty strings to character callbacksMichael Stahl
This reverts the changes in FastSaxParserImpl from commit 16e8ffbd5ec1fe7b81835ea6584547669d55d751 and instead fixes the problem of inserting string properties with empty value locally in OOXMLDocPropHandler. This change was not wrong in any obvious way, but it turns out there is one doc rhbz583386-4.docx that, when imported with this change and exported to DOCX again, results in a non-well-formed document because of some weird SDT stuff. That problem is rather baffling, but unfortunately the DocxAttributeOutput usage of FastSaxSerializer::mark() makes the DOCX export rather un-debuggable, so avoid that problem by reverting the import change for now. Change-Id: I0d874cbfe82d4f15d58b50116dda152341bdf7b0
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: I384a5e60f4b7b2f479c89ef97630519059ab720f
2015-04-30tdf#38693: Document property TotalTime misinterpreted as secondsRavindra_Vidhate
Problem Description : The xlsx file has the extended document property <TotalTime>#n</TotalTime> in /docProps/app.xml LibreOffice appears to read this as a a total editing time of in second_ but according to ECMA-376 2nd edition: 22.2.2.27 TotalTime (Total Edit Time Metadata Element) Total time that a document has been edited. The default time unit is minutes. (ECMA-376 1st edition has the same statement in 7.2.2.27) XML difference: None After RT : None Solution : As LO uses the TotalTime in seconds, while importing the TotalTime, the TotalTime mentioned in the app.xml [which is in minutes] converted it to seconds. TODO: Writing a UT seems to be tricky for this change. Need to analyze and will raise the UT in separate CL. Change-Id: Icbe998b9881ac241a9147628573bab6ef63582c4 Reviewed-on: https://gerrit.libreoffice.org/15479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-01-30chisel off some more unused codeCaolán McNamara
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2014-12-18oox: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I63db342676e1116c2ed1eef4e27599add0a318c9
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-09-26Resolves: fdo#84261 unexpected exception -> clang builds terminateCaolán McNamara
Change-Id: I545ed112b54fb3d81e67b0f42230811cd48de626
2014-06-25remove whitespacesMarkus Mohrhard
Change-Id: Ie14ba3dcb97f20479a04538748ef2c1c9e6c5dac
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-04-23oox: sal_Bool->boolNoel Grandin
Change-Id: Icddec34e91305cfc3f9d852472bb86eab4d8cb26
2014-04-14Clean up function declarations and some unused functionsStephan Bergmann
Change-Id: I2f5b3144e8d4ce3e497a030aa102985c3bc81645
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-02make more places aware of OOXML strict relationsMarkus Mohrhard
Change-Id: I292217537eb592cbad9af11f87402baa9f4cc442
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from ooxAlexander Wilms
Change-Id: Ie25838f20f00dc32d9d22959308c118cef688e94 Reviewed-on: https://gerrit.libreoffice.org/8288 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-23fixincludeguards.sh: ooxThomas Arnhold
Change-Id: Ibc1fb5c149461d6030749a974c6d37aa11ad0e16
2013-10-17fdo#54938: Adapt svtools and comphelper module ...Marcos Paulo de Souza
to use cppu::supportsService and other pieces. Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-11-Werror,-Wunused-variableStephan Bergmann
Change-Id: I7f4f232475339d524eed7ba578e22b53991bd123
2013-08-09Fix timezone && fractional second handling of GetDateTimeFromW3CDTFLionel Elie Mamane
1) The timezone correction was inverted. Imagine we are parsing "2004-03-02T14:18:20+02". Before correction, aOslDTime contains "2004-03-02 14:18:20". According to the comment, we want to convert that to UTC time, so we have to *subtract* 2 hours, not *add* two hours. From http://www.w3.org/TR/NOTE-datetime: A time zone offset of "+hh:mm" indicates (...) a local time zone which is "hh" hours and "mm" minutes *ahead* of UTC. So if it is 14:18:20 in the timezone two hours ahead of UTC, it is two hours *earlier* in UTC, namely 12:18:20, and we need to *subtract* two hours, not *add* two hours. 2) Handling of fractions of a second was buggy: It reads only one digit after the dot. This could be a valid implementation decision to handle only deciseconds. However: 1) It then multiplies that by 10^9 (10e8 == 10*10^8, not 10^8!), and sticks that in the NanoSeconds field... That is 10 times too big: 0.3s == 3*10^8 ns 2) If there were additional digits, it then looks for the timezone offset specificator (beginning with '+' or '-') at these additional digits; it does not skip them: nOptTime is set to 0+3+2, i.e. to 5. Change-Id: I4738dc069e37f29c8bbd9e689689a933027af840 Reviewed-on: https://gerrit.libreoffice.org/4743 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-07-15i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.Michael Stahl
Add IsUTC member to: com.sun.star.util.DateTime com.sun.star.util.DateTimeRange com.sun.star.util.Time Add new stucts with explicit time zones: com.sun.star.util.DateTimeWithTimezone com.sun.star.util.DateWithTimezone com.sun.star.util.TimeWithTimezone Adapt the sax::Converter to read/write timezones, and fix the unit test. Everything else just uses default (no time zone), this commit is just to fix the API. STRUCT: /UCR/com/sun/star/util/DateTime nFields1 = 7 != nFields2 = 8 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/DateTimeRange nFields1 = 14 != nFields2 = 15 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/Time nFields1 = 4 != nFields2 = 5 Registry2 contains 1 more fields Conflicts: sc/source/filter/oox/unitconverter.cxx Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18 Reviewed-on: https://gerrit.libreoffice.org/4833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-07-13use static LanguageTag::convertTo...() for standalone conversionsEike Rathke
If no LanguageTag instance is at hand use the static methods to convert between BCP 47 string, Locale and MS-LangID instead of creating temporary instances. Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
2013-07-05API change: oslDateTime signed yearLionel Elie Mamane
Change-Id: Ic4f1e424b130fd2ccca379adbe0a66836b6cac41
2013-07-05fixup nanosecond precisionLionel Elie Mamane
Change-Id: Ia33b811d56fe5ad5e7e844b3e1c1c25ece0b5396
2013-07-04use LanguageTag instead of mouth-painted implementationEike Rathke
Change-Id: Idd84ce9740de179c399702f896b7d39ab321f6f7
2013-06-15fix fdo#63053 ampersand in document title causes corrupt docxabdulmajeed ahmed
FILESAVE, FILEOPEN: ampersand in document title causes corrupt docx when saving; truncates title when loading
2013-05-30Fix tinderbox failures due to missing includeFridrich Štrba
Change-Id: Ied4c829bbe3038e483524669a85a0a7eaa055eb9
2013-05-30Fix crash with fdo60063-1.docxFridrich Štrba
Compared to the original version, this one tries hard not to produce empty keywords. Change-Id: I11d036c2d54cde2d3c311a77c115011246f38d0a Reviewed-on: https://gerrit.libreoffice.org/4091 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-06fdo#60724 change spelling error REMOVEABLE -> REMOVABLEKenneth Beck
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments. All other instances of the misspelling have remained the same. Example: AF_REMOVEABLE Change-Id: I391f4101bbc3e06689318235a37d616065bc1686 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-14 07:44:55 +0000