summaryrefslogtreecommitdiff
path: root/oox/source/drawingml
AgeCommit message (Collapse)Author
2015-04-04I wonder if I make this less obscure if coverity will grok itCaolán McNamara
Change-Id: Ie3494fe4cee904d8eec65aa5cad861ab1916e8d9
2015-04-04cppcheck: Prefer prefix ++/-- operators for non-primitive typesJulien Nabet
Change-Id: I17dfb0a818838b00d9148ee1c6328ef094eab99b
2015-04-04don't import data labels border properties for noFill bordersMarkus Mohrhard
They are not shown anyway and just confuse us internally as they contain a width but no color and produce invalid documents during export. Change-Id: Ibe20a27b0172ece86dbb1f734df567b903465ebf
2015-04-04fix OOXML vs MSO2007 in chart import in one more placeMarkus Mohrhard
Change-Id: I96bafad0cc73b27c2a08b5205a35b10b4901afb9
2015-04-03tdf#90403 PPTX import: use real table sizeAndras Timar
PowerPoint ignores a:ext cx and cy value of p:xfrm, and uses real table width and height. PowerPoint 2010 saves files where cx and cy contains good values, but I found files in the wild whose cx and cy values did not match to actual table width and height, and there was a visible difference between rendering of Impress and PowerPoint. Change-Id: I3f80c0cea4cac46763d449f918bb78dca1a6562d Reviewed-on: https://gerrit.libreoffice.org/15123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-03-31bnc#910045 wrong cell fill color defined by table styleZolnai Tamás
Problems were with those table styles which used color themes to define cell fill color. Change-Id: Ibde90df81ff253ba65618dde4038093d1caabfe8 Reviewed-on: https://gerrit.libreoffice.org/15089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-03-30bnc#902652 OOXML: fix import of insets when shape and/or shape text is rotatedAndras Timar
5ac575ee3e109 did not get it right, the vert attribute (i.e. the rotation of text) is relevant, not the rotation of the shape. In that case both text and shape rotation were 270 degrees. I checked that the bugdoc of bnc#773048 looked good after this. Change-Id: I6e0401cd138a82040df82d7da1a47311db7771e4 Reviewed-on: https://gerrit.libreoffice.org/15076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: Ib1c4fd60ba029704112dd9e279e4dd4c6bb7416c
2015-03-26tdf#57950: Replace chained O(U)StringBuffer::append() with operator+Austin Chen
Change-Id: Iae8e50864dbd90ff49a4fcc31a06b2158eab4afc Reviewed-on: https://gerrit.libreoffice.org/14998 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-20tdf#83889:FILEOPEN:PPTX bullet point is followed by spurious symbolPriyankaGaikwad
If we have first numeric bullet and then insert any symbol bullet on same level then suffix of numeric bullet continues with symbol bullet as well. Solution : Reset suffix to none if it is symbol bullet. Change-Id: I06dddec55c6f3d8cc1545d30f7228ca08cb81396 Reviewed-on: https://gerrit.libreoffice.org/14890 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-03-19loplugin:constantfunction: ooxNoel Grandin
Change-Id: Iec2bc991821aed8da4427c6efc4ec8df72554923
2015-03-19mbOwnTblStyle->bOwnTblStyle, its not a memberCaolán McNamara
Change-Id: I3611a1873463cd5dc6d336ffa22c244eaeb6d824
2015-03-18CppCheck cleaning : unnecessary affectationMichaël Lefèvre
Change-Id: Ia86b49cb5f643673fd631fb6c654ee587072b123 Reviewed-on: https://gerrit.libreoffice.org/14853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-16handle one more place with MSO 2007 vs OOXML spec for chartsMarkus Mohrhard
Change-Id: I7dbc3017f2bba7b186174be2e4fd8c9ce7005d34
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...in preparation of enabling the __attribute__((format(...))) in sal_detail_logFormat (include/sal/detail/log.h) Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
2015-03-10handle MSO 2007 vs OOXML in auto title chart importMarkus Mohrhard
Change-Id: Id884a4c90c24b38a1dd22a41d271dcc551b59adc
2015-03-09V801: Decreased performanceCaolán McNamara
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
2015-03-01mark more places where we changed the default value in the pastMarkus Mohrhard
Change-Id: I4860fff43f106f3d734ba58f046364c201775eb7
2015-02-19boost->stdCaolán McNamara
Change-Id: Icae6b6f07ad8dbd287fdfc689739187883a07775
2015-02-19document one more place where MSO 2007 export wrong valuesMarkus Mohrhard
Change-Id: Ic35f1188e66cf89f203b34f354a2c4b11f1f65a2
2015-02-19this should be [-90, 90] and not (-90, 90), tdf#89454Markus Mohrhard
Change-Id: I943be2cf660d2dc77eebd776208af96c0b5f67a4
2015-02-19start documenting problems around OOXML specMarkus Mohrhard
We implement in many places wrong default values based on how MSO 2007 behaves. Newer MSO versions produce correct files so our import is wrong. Instead of changing the default value we need to be able to use default values based on the document producer. Change-Id: I6a2a0b30885ebccc384d17f896709ecdd475d786
2015-02-18no need for that anymoreMarkus Mohrhard
Change-Id: I53002c0b97da66c44429b5ace0fc709b5e8a325f
2015-02-18better way to set default for chart area fill style, related tdf#89451Markus Mohrhard
Change-Id: Iee7fea0f55cf54d43a349b6cc0ffa25995069e40
2015-02-18implement fill based on style also for chart area, tdf#89451Markus Mohrhard
Change-Id: I7b488e222cd44e75d1e0ff7f8e545e9399f418b5
2015-02-17fix indentationMarkus Mohrhard
Change-Id: Ifab81cb6e54e177aaf31aceeddc1b6cd3c0cc888 Reviewed-on: https://gerrit.libreoffice.org/14513 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-02oox: 89 DPI is not such a great defaultMiklos Vajna
Using the DPI from Application::GetDefaultDevice() is a much better idea, especially that now oox::GraphicHelper::GraphicHelper() and oox::drawingml::DrawingML::WriteSrcRect() are in sync. Should fix the testCropPixel() failure in CppunitTest_sw_ooxmlexport that appears on HiDPI systems. Also, fix all the rounding problems that now became visible when the DPI is the same for both import and export. Change-Id: Iceb34a8a5a1eaa8ce0824491521ad6b4d2f6949c Reviewed-on: https://gerrit.libreoffice.org/14280 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-21fdo#87488 Wrong text rotation inside a preset shape from docxGary Houston
Preset shape text rotation values are read in a few places and stored in moRotation. With these changes, moRotation is always read unchanged, but multiplied by -1 when it's used. Change-Id: I633d665c21daa69e15fa828a43300f10d2bf2054 Reviewed-on: https://gerrit.libreoffice.org/13561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-22bnc#862510: PPTX import: Wrong text vertical adjustment inside shape.Zolnai Tamás
When alignment is not specified, it should be set to the default "left" value just on time, when properties are pushed to the property set, otherwise uninitialized value is better. Change-Id: Ic294c5d7cc477f7515aea1c071ad9b67275c012d
2014-12-22bnc#862510: PPTX import: Wrong text color inside shapeZolnai Tamás
When theme index is 0, it means it's unset so we should not apply that. Change-Id: I62a9cd2a9b4c19f5acffc334d5e8263fe24fc8fd
2014-12-18oox: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I63db342676e1116c2ed1eef4e27599add0a318c9
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15Resolves: fdo#87281 Crash on importing diagram in .docx fileGary Houston
Change-Id: Ic2c7326ab83258e2e9dcbac88aa9f76f771a9b12
2014-12-15no point checking for null before deleteCaolán McNamara
Change-Id: I58cbb075a56518d71874137180ad92ae764ec4bf
2014-12-15oox: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I55ee581c9d3fc0a17639833a6a034e2addf768d1
2014-12-05fdo#38835 strip out OString globalsNoel Grandin
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
2014-11-30PPTX import: shape effect properties defined by themeZolnai Tamás
Effect import is so poor by now that this changes does not seem to have any effect, but later it can be helpful. See also: 81cd386facedfbb15be6dffc10351262abf733f3 and 664a56b3c81503bdf199edf1806676f0a35b956f Change-Id: I4e6a9952aa138959ab273db0494ef0cf76d8fc24
2014-11-30PPTX import: fix import of shape line properties defined by themeZolnai Tamás
See also: 81cd386facedfbb15be6dffc10351262abf733f3 Change-Id: Ibb21d3e5b52a4d4996202acd4a989910fa223632
2014-11-30bnc#904423: Text(box) is rendered white on white when it is notZolnai Tamás
The problem was that the background color defined by theme was not imported correctly, because the different fill style comes from different sources (master slide, theme, direct formatting) were applied on the shape in wrong order. To solve this we need to store master slide defined fill style in a different variable so theme style can be applied after master slide defined style but before direct formatting. Change-Id: I99ea981858b9fa391915570187c8ddfdf2be1f7a
2014-11-27fix higher debug level buildCaolán McNamara
Change-Id: Id35efda5e4df820cda2afd7b65b5f890fec03f2f
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-15oox: these are expected to be UTF-8Miklos Vajna
Change-Id: I2e9cb96948d7f990dd8be5f4505f00306fa62f8f
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-11build fixCaolán McNamara
Change-Id: I9d4dc8a165bc042a674eb472162292a486f3761c
2014-11-11coverity#1187643 Unchecked return valueCaolán McNamara
Change-Id: I2ba56fbff1ae05d1185d08d4fbd0285954fed38b
generated by cgit (git 2.34.1) at 2025-03-22 00:10:49 +0000