Age | Commit message (Collapse) | Author |
|
To prevent deadlock during threaded sheet stream parsing. It now
deadlocks at a different place.
Change-Id: I0ba0f2c9a257e71b0a340ab14e369b06d5fd8829
|
|
Change-Id: I576a184ebc8422d760800c670f8d9070f66e9e78
|
|
Change-Id: I2639a51c2faa19373a335c28b160862435cd6dbe
|
|
Change-Id: I847e0df4f160e4b5078961a0e77c1e1e3fff9bd4
|
|
Change-Id: I661eeb167a95540a223ce72aac51789daf3767dc
|
|
Change-Id: Ie4d4d7740ae002422f73a3bfc57e1fe1ad67e50f
|
|
No need to fetch string size with this change.
Change-Id: Iae5f6c60430fc57985a0fec5bfec59727e5a8f0f
|
|
Change-Id: I66b16e9767369fd54611f92d66cd1b43f4e8c5a8
|
|
operator== with OUString and literal internally does a reverse-compare
(via OUString::equalsAsciiL) anyway, so no need to keep explicit calls
to OUString::reverseCompareTo with literal argument
Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
|
|
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.
Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
|
|
A proper textframe is created, but the text on the shape is still
outside the frame.
Change-Id: I042295cfdd61ce9c0ee52cdf5e8700d8d2b1b1c5
|
|
Change-Id: I627d5f151e5bf1ae4604e32763ef5afeb66a0cfa
|
|
DOCX drawingML shapes had wrong position if they had their
CustomShapeGeometry set (e.g. flipped). This wasn't a problem for VML
shapes, as there the shape knows its position, and position was always
set in oox as well, not in writerfilter. However, in case of WPS shapes,
oox created the shape, and previously writerfilter set the position
after-the-fact. This leads to incorrect results if CustomShapeGeometry
is involved. Fix this by passing the position from writerfilter to oox,
and call setPosition() after creation, but before CustomShapeGeometry is
set.
The other problem was that normally writerfilter learns the position of
the shape when relevant token in GraphicImport::lcl_sprm() arrives, but
this happens after OOXMLFastContextHandlerShape::sendShape() needs that
information. Work around this by accessing the PositionHandler directly.
Change-Id: Iced35dc9467ef77c41f1897f124729f686bd045e
|
|
Convert code like this:
OUString aStrSpacing(OUString::createFromAscii("spacing"));
to:
OUString aStrSpacing("spacing");
Change-Id: Ia2b7d6b42f35d33cfe587a0d6668030f3537fa6d
|
|
In SheetDataContext::importCell().
Change-Id: I52db64219f672ea5fbbda17686bf1173ceac5926
|
|
Change-Id: I596bbc723558f04588d9e767d64732164524e57a
|
|
Change-Id: I4d7a962e01f5a41c3ea629f73433416195f2259c
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
Which would be a simple rect instead of the
complicated shape.
|
|
There was a wrong 'if' statement, that checked if the focus was over 75%
and also if the angle was less than 180. If so - it compensated for that
by adding 180 degrees to the angle (and losing the 'focus' attribute).
But it should do that even if the angle is more than 180 degrees, so
this was fixed.
Reviewed on:
https://gerrit.libreoffice.org/6647
Change-Id: Ib2dc8a61359e656721c5c6c99587d4d547eed835
|
|
When importing bitmaps coming from VML code, we were mistakenly ignoring
rotation information: we have just added it to the existing XShape object.
In the case of bitmaps expressed in DrawingML, the code was transforming
them into SwXTextGraphicObjects which don't have rotation information.
We are now preventing that transformation when rotation value differs from
zero, leaving the XShape object that was built in the first pass through
the document.
Added a unit test.
Conflicts:
sw/qa/extras/ooxmlimport/ooxmlimport.cxx
Reviewed on:
https://gerrit.libreoffice.org/6484
Change-Id: I40100f8919894e48c005f8ed445bb5cad4f58d8b
|
|
We were saving the size of the rotated shape bounding box in the docx file
but that size was being interpreted as the size of the original, unrotated
shape.
Now VMLExport::Commit will use the dimensions of the rectangle received as
a parameter to save to the file instead of those returned by SdrAttrObject
->GetSnapRect
Change-Id: I53670db77f5e5320a87579dcd56617d5ccf1851a
Reviewed-on: https://gerrit.libreoffice.org/6432
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
...so it will be able to use SvtSecurityOptions internally.
Change-Id: Id7433247e8fc53651935578510bedbcca5aa2ac9
|
|
Change-Id: I645d554c7ce592d93ca0696fa7e6068ce40c9058
|
|
Change-Id: I2b9f26cb500a9e56f5860bd1b483ed284b84f50d
|
|
|
|
We import something that's visible, but the shape is always inline, even
when it has to be anchored.
Change-Id: I6e20aa1a208f06731098ad21bb51c1ca840213d0
|
|
The plan is that once these are here, the writerfilter ooxml tokenizer
can refer to them. And then the writerfilter will call back to oox to do
the real drawingml import.
Change-Id: I1f860d1ade21cde767ad259d46b8d38ff167662f
|
|
- Handled exporting of image for all type of format in vmlexport.
- fixed issue - .rels file was not getting exported for vmlexport.
- Not handled for .wmf image (will work on it)
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
Reviewed on:
https://gerrit.libreoffice.org/6369
Change-Id: I9ccf7a36ae316a658f06d1074caa4e4b2f5d271f
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Convert code like
if( ! aStr.compareToAscii("XXX") )
to
if( aStr.equalsAscii("XXX") )
which is both clearer and faster.
Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
|
|
Change-Id: I10f3dbd9513052b3bbe30ddc6523cd231f26ded3
|
|
Change-Id: I5ff79c55446bd9f3e350fb128793ffef51be843f
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
Change-Id: I0985d28289e31969cb9b048b221abfae1572025d
|
|
Change-Id: Ibc1fb5c149461d6030749a974c6d37aa11ad0e16
|
|
Change-Id: I315e6d2d75ec15655f0c926339b5af0e50a1190f
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
|
|
This was because there is no explicit category
in the chart - while libreoffice expects it.
|
|
regression since ed338bc212725f422f0def21aafc82f05e350646
Change-Id: Ia5dfe7a551abe244c313d3bdb2b90196fc0c6ba2
|
|
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
|
|
Change-Id: I58a810cc6062d5b42558dd5c0f37426a8a210f40
|
|
to use cppu::supportsService and other pieces.
Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
"logical not is only applied to the left hand side of this comparison"
Change-Id: I015befe47ea9f40f83217b259e07eb01edb7d820
|
|
Added the possibility of rendering the basic shapes generated for a
Smart-Art into a bitmap and replacing them with it in order to not
letting to edit the Smart-Art. This possibility is controlled using a
configuration parameter located at Options -> Load/Save -> MS Office
-> SmartArt to LibreOffice shapes or reverse.
Made the "oox" library to depend on the "drawinglayer" and "svx"
libraries.
Made the "ooxmlexport" C++ unit tests in the "sw" module to depend on
the "drawinglayer" and "svx" components.
Fixed to set to diagram type a new "oox::drawingml::Shape"
representing a Smart-Art in the "getShape" method of the
"oox::shape::ShapeContextHandler" class.
Added the "keepDiagramCompatibilityInfo" and "renderDiagramToGraphic"
protected methods to the "oox::drawingml::Shape"
class. "keepDiagramCompatibilityInfo" is now called after an instance
of type "FRAMETYPE_DIAGRAM" has added all its children in the
"addShape" method and the proper setting is in place.
"keepDiagramCompatibilityInfo" substitutes previous similar code in
the "createAndInsert" method and also calls "renderDiagramToGraphic".
The "renderDiagramToGraphic" renders the basic shapes in a Smart-Art
into a PNG image and replaces these basic shapes with a new
"GraphicObjectShape" filled with the new PNG image. It also sets the
"MoveProtect" and "SizeProtect" properties of the
"GraphicObjectShape".
Change-Id: Ie4002238ff5fae758a5881b03735bf1f0721ed5b
Reviewed-on: https://gerrit.libreoffice.org/6059
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I475bee35ca5d24903d85e7f2427fab0e47d8db4d
|
|
Chart file gets corrupted, if we save file in Libreoffice and open in MS office.
MS Office gives error, file is Corrupt.
Following charts get fixed
1. Radar chart
2. Area chart without data labels
3. Line chart
4. Bubble chart
Area chart with data label file gets courrputed after roundtrip in Libreoffice.
Change-Id: Ib03ad49aae268b53aa18bdc21c723e2a7777eb45
|
|
Change-Id: I7f4f232475339d524eed7ba578e22b53991bd123
|
|
Change-Id: I74a17da384499fb18f13d5caa04c356dfee71eff
|