summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2015-08-06cid#1315264 incorrect expressionMiklos Vajna
Change-Id: I33457a2e1a213c6eb172ab188272e9688cd2ccad
2015-08-04sal,rsc,oox: inline some use-once typedefsNoel Grandin
Change-Id: I91bebe06c5c5f3ebe5fbeec83dcf3f5bdf563201
2015-08-03inline some use-once typedefsNoel Grandin
Change-Id: I55cc82c8e180cce371c996690608090b1bfdfda4 Reviewed-on: https://gerrit.libreoffice.org/17494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03tdf#87924 DOCX import: rot=90 and vert=vert270 means no text rotationMiklos Vajna
If the shape is rotated 90 degrees clockwise and the text is further rotated 270 degrees clockwise that means we shouldn't do anything with the text and the result will be correct. Change-Id: I7c65319258136288520bd24fa2bf8e3c598b0878
2015-08-03new loplugin: refcountingNoel Grandin
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-25tdf#92256: Make OOXML filter CONV_A1_XL_A1 aware tooKatarina Behrens
+ don't write string ref syntax if it hasn't been read or explicitly changed Change-Id: Id3788a71a4a3d0672283a4770c7d7a9608beb06f Reviewed-on: https://gerrit.libreoffice.org/17326 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-23tdf#92256: OOXML save/load syntax for string referenceKatarina Behrens
+ introduce a separate LibO namespace for that Change-Id: Ie62da0746e81ea0d861680863beb03094649d41c Reviewed-on: https://gerrit.libreoffice.org/17216 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-21loplugin:unusedmethods ooxNoel Grandin
Change-Id: I5381e0da0efc1f951e248cfcfb35fc680ace94e4 Reviewed-on: https://gerrit.libreoffice.org/17225 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-18sax: convert MergeMarksEnum to enum classMichael Stahl
This should detect if a MergeMarks value is erroneously passed as tag. Change-Id: I7b855a661f182136824cf25f2174a9bcce8ff3d1
2015-07-18sax, sw: try to make that maMarkStack easier to understandMichael Stahl
In DocxAttributeOutput it's not at all obvious which mark() is supposed to be ended by which mergeTopMarks(), so add an extra parameter to the FastSaxSerializer functions and verify with an assertion that a LIFO order is maintained. Change-Id: I5a421e2fb11f15343147417fe0b9b23642c70721
2015-07-16oox: fix invalid mime type "image/tif"Michael Stahl
(regression from ccfc02f7691848284403d339ee17054169fbff1d) Change-Id: I29a366228bf08f29edfa4a8e963889e34aa3d2ea
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: I5e87ac88a2e0f20892ef89f36ccf8cac0bdc90c4
2015-07-15tdf#87539 map MSO washout filter to LO's watermark colormodeJoren De Cuyper
Change-Id: Id28e301a74a729245b20ba6cd2adecf203633f0e Reviewed-on: https://gerrit.libreoffice.org/16048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-10do not include boost/utility.hppMichael Stahl
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-06oox: sort output in generated oox-drawingml-adj-namesMiklos Vajna
So generated data don't unnecessarily differ after each build. Change-Id: I143fa189a653266fadf9dd34ce2ed42b9b9b1548
2015-07-06improve the returnbyref lopluginNoel Grandin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04coverity#1309263 Improper use of negative valueCaolán McNamara
and coverity#1309264 Improper use of negative value Change-Id: I496e92211b9ca0a7a27a7f00d17cff428cb3b42b
2015-07-04tdf#91378: sax, oox: avoid sending empty strings to character callbacksMichael Stahl
This reverts the changes in FastSaxParserImpl from commit 16e8ffbd5ec1fe7b81835ea6584547669d55d751 and instead fixes the problem of inserting string properties with empty value locally in OOXMLDocPropHandler. This change was not wrong in any obvious way, but it turns out there is one doc rhbz583386-4.docx that, when imported with this change and exported to DOCX again, results in a non-well-formed document because of some weird SDT stuff. That problem is rather baffling, but unfortunately the DocxAttributeOutput usage of FastSaxSerializer::mark() makes the DOCX export rather un-debuggable, so avoid that problem by reverting the import change for now. Change-Id: I0d874cbfe82d4f15d58b50116dda152341bdf7b0
2015-07-03Fix typosAndrea Gelmini
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510 Reviewed-on: https://gerrit.libreoffice.org/16709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-02tdf#87348 implement mso-next-textbox vml-style textbox chaining importJustin Luth
Change-Id: Ic62769cf5bb1589dd4de3a66b3d7dd896e5b5711 Reviewed-on: https://gerrit.libreoffice.org/16366 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-25tdf#91378-Empty Custom Properties are lost while saving in .pptx formatHeena Gupta
Conflicts: sd/qa/unit/export-tests.cxx Reviewed on: https://gerrit.libreoffice.org/15966 Change-Id: Ibc24ab9633b51fe41ad483121646cc391319fe6f
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I5bb3493e3d27bd348f58cd4f858f34becf761cd0
2015-06-23Drop duplicate #includesTakeshi Abe
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18drop unused sequenceasvector.hxx (see sequence.hxx)Caolán McNamara
Change-Id: Ib6d91f1ee427d5f94eed75e478f0809346f38e05
2015-06-16Fix typosAndrea Gelmini
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-13no need to check for pShape hereAndras Timar
Change-Id: I6de2da7d2f17a14ddbe7e70651a416a01f49164b
2015-06-13amend commentAndras Timar
Change-Id: I45a452a7dbab35ab96c04336b35857f58a0af0c5
2015-06-13tdf#92000 save rectangle to DrawingML as a preset shapeAndras Timar
Change-Id: I8b39a210490759e9f548c195e516a26b94a8b3cb
2015-06-12tdf#92001 'Handles' contains array of PropertyValuesAndras Timar
Change-Id: I17ea45f2b1dd46a7f1c0f3ce8c680bef9ec533fa Reviewed-on: https://gerrit.libreoffice.org/16249 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-10Prop_pSegmentInfo is totally misunderstood apparentlyCaolán McNamara
digging into the crash on export of kde216114-1.odt reveals various horrors Change-Id: I0d24fe303d561a00a08098b306d10fd8273af928
2015-06-10similarly fix fatal export of kde216114-1.odt to docxCaolán McNamara
Change-Id: I78478de91473681fd8d836293dabe7b790dda516
2015-06-10fix fatal attempt to export kde302504-1.odt to docxCaolán McNamara
the enhanced-path contains decimal points so the last element is a double not an integer Change-Id: I90be76a2d4cb90ee7a904aa72fe65770c675fc53
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Ia702fa56c6ed17b26817e1c0d1720cb26199a6da
2015-06-05WaE: ‘nLocalAttachedAxis’ may be used uninitialized in this functionTor Lillqvist
Change-Id: I74f4c4507bbe6abe7618ca41764715b3b5c68b5b
2015-06-02that special case was a really stupid idea, tdf#91685Markus Mohrhard
The default value is context depending and not 0. So always export the rotation value. Change-Id: I36162459757c58846f3ecea7dcbcb58b6ef3d1f6
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann
Change-Id: I4373b1698ed81cd84dc5f319fde003f9b8c301fb
2015-05-30another DrawingML export crash fixAndras Timar
Change-Id: I0386b4a768a9ac51cb86ac1c3edb17c41caf821a Reviewed-on: https://gerrit.libreoffice.org/15993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-05-29loplugin:loopvartoosmallNoel Grandin
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-28DrawingML export crash fixAndras Timar
Change-Id: I777c6734a7f63240e9021152ecff0a86f530ff8f Reviewed-on: https://gerrit.libreoffice.org/15951 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-05-27disable more annoying log outputMarkus Mohrhard
Change-Id: I9f50b991defe7e241a66a0d52af24c9912508d26
2015-05-27transform calc URLs to OOXML format, related tdf#91334Markus Mohrhard
Change-Id: I497a6600e155200e913ed386a539f284a5c86320
2015-05-27fix indentationMarkus Mohrhard
Change-Id: Ib686c76e024cccd33614f812e80ad6c16b5287e4
2015-05-27silence annoying log outputMarkus Mohrhard
Change-Id: Ia2f55b85a649e0286573477511016f36bf29a9d5
2015-05-27tdf#90338 related: ignore empty shape handles structAndras Timar
Change-Id: I486564a124cfb0d13a8b20e89cf13e752ccb7237 Reviewed-on: https://gerrit.libreoffice.org/15923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-05-27tdf#90338 tdf#84254 DrawingML export fixAndras Timar
Change-Id: I610d8099f057a2a34a1f9573d8ac16b5b8da9fc7 Reviewed-on: https://gerrit.libreoffice.org/15918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>