summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2017-04-10loplugin:inlinefields in oox::vml::VMLExportNoel Grandin
Change-Id: Ia6880212503b2945953ca4c3d62d3ddb1d159c7b Reviewed-on: https://gerrit.libreoffice.org/36351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: ooxStephan Bergmann
Change-Id: I5febd0b28bc3e8beca1034ca151406af1e2034d9
2017-04-06loplugin:singlevalfieldsNoel Grandin
Change-Id: Ia681765aa1da5c80a3dbe91b7376af841a9c9ec1 Reviewed-on: https://gerrit.libreoffice.org/36145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:redundantcast find cstyle double castsNoel Grandin
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8 Reviewed-on: https://gerrit.libreoffice.org/36187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05add a clearDocumentHandler for null document handler caseCaolán McNamara
Change-Id: I661a2fd5381013056c69b379792560aed7121214
2017-04-05loplugin:constantparam part2Noel Grandin
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04oox: -Werror=formatMichael Stahl
Change-Id: I9036335c812992946e3164e517cbe7296b98759b
2017-03-31use actual UNO enums in ooxNoel Grandin
Change-Id: I7fbb3619287acde0c397ff9b4015271ec785cc46 Reviewed-on: https://gerrit.libreoffice.org/35958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30remove type decorations on char literalsJochen Nitschke
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30convert ApiTransparencyMode to scoped enumNoel Grandin
and drop unused API_TRANSPARENCY_PAINTTRANSPARENT enumerator Change-Id: I7abd0f15d1c9a1dc4aeff47e5b3c782d5e8c08e1 Reviewed-on: https://gerrit.libreoffice.org/35843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30loplugin:unusedenumconstantsNoel Grandin
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c Reviewed-on: https://gerrit.libreoffice.org/35854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29oox: remove redundant virtuals, implied by overrideMiklos Vajna
Change-Id: Ia72aa17e82ccdf78b0581228b84ffafc1f6be4ba Reviewed-on: https://gerrit.libreoffice.org/35824 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-25There should be no need to distinguish between I32S and I64SStephan Bergmann
...after 64b993e046f23baaacaff1572b7d2a816588b5ef "finish deprecation of O(U)String::valueOf()" replaced OString::valueOf with OString::number in their bodies. (Change done in preparation of teaching loplugin:redundantcast about C-style casts in macro bodies.) Change-Id: Ifbb4725c496eed18a926fbabeaf4691ac98d9c5e Reviewed-on: https://gerrit.libreoffice.org/35678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I14dca0d55c09187690dc1d94936c40b890ca5cea Reviewed-on: https://gerrit.libreoffice.org/35637 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22crashtesting: these should be opened readonlyCaolán McNamara
Change-Id: I99f6e06955d05688aba95a6f1246078b3ecd7772
2017-03-21Does this actually want to check for alphabetic characters?Stephan Bergmann
...instead of for non-alphabetic ones, as it does ever since 14620c3b33cf0315a9b746a0a2418b78d6154821 "support import of key shortcut for macro ( Excel only )"? Things that suggest that that was a typo: * The preceding comment. * The fact that ooo::vba::parseKeyEvent will throw an exception for most input of the form '^' followed by a non-alphabetic character (see parseChar in filter/source/msfilter/msvbahelper.cxx). (Found when auditing uses of <ctype.h> is* functions. See d8ce3f60bad3ebaa0888b35f85ab1a211714bb14 "Fix ooo::vba::parseKeyEvent" for replacing isalpha with rtl::isAsciiAlpha here.) Change-Id: I6b133c51da64192ec6aef712579ad6f55aae3b1a
2017-03-21New loplugin:unicodetocharStephan Bergmann
Change-Id: I279fe1dec196b6e1e551b4f6aba77f24e3f76ab7
2017-03-20tdf#99617 convert powerpoint angle to degreeRegina Henschel
1 powerpoint angle unit = 1/60000 degree Roundtrip test not yet possible because of tdf#106002. Change-Id: I5854c4f9f013f1a2db7e9536fc9cf5198c7a02ed Reviewed-on: https://gerrit.libreoffice.org/34279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-11Passing shaperect to addShape function is uselessTamás Zolnai
Shaperect is ignored by createAndInsert() so it has no effect at all. Also when this parameter is set the size and position is set using the same shaperect, so don't need to pass it also as a parameter. Change-Id: I35a7953f3eda1bdd19af6f3e77c55b5c7e1f7161 Reviewed-on: https://gerrit.libreoffice.org/35073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-11Use the converted shape rectanle hereTamás Zolnai
Change-Id: I38092b9ca0de2c73a639588d441eff56eb88e33e
2017-03-11tdf#106217: Wrong size and position of a shape inside chartTamás Zolnai
Same code which was added to the method DrawingFragment::onEndElement() in d178d7bef193565a7d6aacbc37a58dfc4bd7b316 A shape's size and position inside a chart object are primarily defined by <cdr:from> and <cdr:to> tags in drawing.xml, but in the same file we also have an <a:xfrm> tag which is used for the same thing (defining size and postion) in general. Testing with MSO it seems it ignores what values are set to <a:xfrm> and uses only the <cdr:from> and <cdr:to> values. The test document showing this problem must be created an earlier version of MSO, becuase <a:xfrm> is set to some random values. Editing the chart and saving it with MSO 2013 the <a:xfrm> values are set consistently with <cdr:from> and <cdr:to> pair. Change-Id: Icbaff78e5a6fcea36678c3b3755c97f57976b626 Reviewed-on: https://gerrit.libreoffice.org/35069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-03-07loplugin:loopvartoosmallStephan Bergmann
Change-Id: Id9ac335bcb365afdae66ec7836d6b3bfb6de8577
2017-03-04tdf#106304: Don't unnecessarily use bogus default char size for a:endParaRPrTor Lillqvist
Instead use the size last used for an a:rPr below the same WriteText() call. I am not exactly sure about how this hangs together, but this has the desired effect on the exported .pptx. Change-Id: Ie03dcd0b31c15cff8488b22d7423c9f9ad1e2d68
2017-03-04tdf#106304: Output <a:br> instead of &#10; for hard newlinesTor Lillqvist
This fixes the problem that the line before the hard newline in the .pptx export is not centred. The fix for the sd_export_ooxml1 test is a bit hacky, but then so is the code in question. Change-Id: I4f89e9d0177ab3b16e8ec624a99fce9e2f8ef730
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03drop SvxNumType and rename SvxExtNumType->SvxNumTypeNoel Grandin
Both of them are abstractions over the css::style::NumberingType constants. SvxNumType serves no useful purpose, since it's just a typedef to sal_Int16. At least SvxExtNumType wraps up the css::style::NumberingType constants in a nice enum. Change-Id: I7b3f97cd42b0aa23aff7a4db4930da86149d4f4e Reviewed-on: https://gerrit.libreoffice.org/34816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03use SvxExtNumType in SvxNumberTypeNoel Grandin
and follow the rabbit trail, fixing various other types in the process Change-Id: I8fc7df3b585df21578ffb28fdd7e5e427b3bfd9d Reviewed-on: https://gerrit.libreoffice.org/34814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02Align columns in output harderTor Lillqvist
If we are going to use printf anyway, why not use its field width and left-adjustment features and actually achieve the columnar output we presumably wanted? Change-Id: I95dbd2aaa01d06c69d23d74fa249fd3419afa8d6
2017-03-02Fix typosAndrea Gelmini
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b Reviewed-on: https://gerrit.libreoffice.org/34803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01Remove clearly outdated stuffTor Lillqvist
Change-Id: I23ca8cc512a0bd433474c12d06461597d0bd35ee
2017-03-01cid#1401592: bFlipX and bFlipY won't both be trueStephan Bergmann
Change-Id: If5ab5d340166b5eedb97773a9907eee1b188027e
2017-02-28Fix incorrect function name in SAL_INFOTor Lillqvist
Change-Id: I75ee5f1a20fadef7c20103278bc03abd41b815cf
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27Rename misleadingly named include file fillpropertiesgroupcontext.hxxTor Lillqvist
There is nothing called FillPropertiesGroupContext. Rename the file to "misccontexts.hxx" as I could not come up with some more specific name that would describe the collection of classes defined in it. Rename the corresponding cxx file, too. Change-Id: I44db1db8c63c8e897774597b46a237a214aacedf
2017-02-27There is nothing called FillPropertiesGroupContext since 2009Tor Lillqvist
So bin two pointless and misleading comments that consist of just that identifier. Change-Id: I14724b21d43283dbda1856ab28c56ae44512c3cc
2017-02-27Clean up a few SAL_INFOs a bit and add useful note about the ==cscode== etcTor Lillqvist
I dislike OSL_THIS_FUNC, it is too verbose, at least with Clang on Linux. Just use the Class::Name without parameters and namespaces. Change-Id: Ic8722a131463762ab70ff35d64ae7040c67bf595
2017-02-27Probably better to restrict the sequence sizeStephan Bergmann
...to any elements actually written. Was like that ever since the code's introduction in d3ffe3ed3fa1b80c7e54439673029e105940db80 "fdo#67737 : fix for flip not being imported & rendered correctly". Change-Id: I460c1c7c578bd7e53cc2e868da0b7aeb5f19194f
2017-02-26cppcheck: unreadVariableJulien Nabet
Change-Id: Id9d2fbe9b2d4040cc73c401f5558999604acf259 Reviewed-on: https://gerrit.libreoffice.org/34657 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-23Better make the zero-initialization more explicitStephan Bergmann
...if initializing these members is necessary at all; a bit hard to tell from the code. Change-Id: If15fb11b601ba3b8b5d3fdbe5c3dac01b095fb05
2017-02-22Bin pointless once used typedefTor Lillqvist
Change-Id: I12f51748dd190f6d50ed7ae738d7eedeb32f0af8
2017-02-22loplugin:unusedfieldsNoel Grandin
Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: ooxStephan Bergmann
Change-Id: I8a1b6baba6191b20264f32cbf73f5d75bc50235b
2017-02-17tdf#90407: Export Text AutoFit to .pptxTor Lillqvist
Change-Id: I2120f13fff58d4736ab55071236e0c2f80ba2eb0
2017-02-16Try harder to fix Android tinderboxTor Lillqvist
Change-Id: I4f3f112d4cd301d3ee1806cd2d26564ac3852723
2017-02-15no std::lround on androidCaolán McNamara
Change-Id: I910a0a81a925ce4578f3b9b3a51987fbbd91aa13
2017-02-15tdf#106026: Export paragraph top and bottom margin to DrawingMLTor Lillqvist
Change-Id: I8c60f86a1debe135c9172ff639aa5af93f03b99b
generated by cgit (git 2.34.1) at 2025-02-22 21:54:39 +0000