summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2018-01-04loplugin:unusedfieldsNoel Grandin
fix the ReturnStmt check Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8 Reviewed-on: https://gerrit.libreoffice.org/47309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-03ofz#4929 ensure min input len for openssl ciphersCaolán McNamara
openssl is not the default backend Change-Id: Id7bd77c1a12a15c0ebb4e7d758362c7778bfc2fd Reviewed-on: https://gerrit.libreoffice.org/47349 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-02RID_* can be extern global variablesNoel Grandin
no need to access them via methods Change-Id: If0d1a65d6f56ce2fc585749d974ba13c9f2749b2 Reviewed-on: https://gerrit.libreoffice.org/47245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-31try to fix android buildCaolán McNamara
Change-Id: I80c01fbf839c6980bc8dab40267d1407ca8e1398
2017-12-30tdf#90626 PPTX: Fix image bullet position in PPTPaul Trojahn
Scaled bullet points aren't centered in PPT, so padding needs to be added to get them to the correct position. Change-Id: I61509dd43ef9cd697dcbc3cabbf58a21d625ddec Reviewed-on: https://gerrit.libreoffice.org/46994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-30tdf#113788 ActiveX controls' text color is not exported to DOCXBán Róbert
The convertFromProperties function does not set the text color. Background color is a similar property and it is handled similarly. Change-Id: I2c1bff6198640b9a30f70d9db641425166ced992 Reviewed-on: https://gerrit.libreoffice.org/47185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-29loplugin:passstuffbyref improved return in variousNoel Grandin
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560 Reviewed-on: https://gerrit.libreoffice.org/47173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29export explosion property for pie chart property, tdf#114182Markus Mohrhard
Change-Id: I02b46929db1bfbff32e7b1228186079b868e7971 Reviewed-on: https://gerrit.libreoffice.org/47154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-25various coverity exception warningsCaolán McNamara
Change-Id: I7b3588ad42e17f2f363b6a247e318f23c95e578e Reviewed-on: https://gerrit.libreoffice.org/46961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-23tdf#111790: Shadow imported from a PPTX file is not overridenmartinb214
by the settings while saving back to PPTX Change-Id: I958f1987d0123bcf89ef37b13807f407781f3c15 Reviewed-on: https://gerrit.libreoffice.org/45989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-22tdf#42949 Fix some Include What You Use warningsMiklos Vajna
Change-Id: I30121764303579a7cb4ded0f0f48cc1f8fff6c33 Reviewed-on: https://gerrit.libreoffice.org/46946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22also export basic chart structure for empty chartsMarkus Mohrhard
Change-Id: I545be33e5e093d5bd3fda4236213a413a6cc9ce7 Reviewed-on: https://gerrit.libreoffice.org/46939 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-21tdf#114613: Repair function does not work after opening PPTX fileTamás Zolnai
We need to disable undo handling during file import. Same is done for other file formats (e.g. PPT, XLSX). Change-Id: I1969c17b4a25b59b0d216ee847b3664e9c2207ca Reviewed-on: https://gerrit.libreoffice.org/46882 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-20coverity#1426744 Uninitialized scalar variableCaolán McNamara
Change-Id: I2043f4d3c393d39eb9d3936ba5dbcbf27c54ce48
2017-12-20tdf#105517: overwrite existing scheme colors in vectorAron Budea
Theme overrides stopped working once ClrScheme::maClrScheme was changed to vector, and colors were always appended to it. Regression from f3121049828596b369e3ea844355d61666e49795. Change-Id: Iae850dcabf57b12d8a564e84acf38d9988cfe963 Reviewed-on: https://gerrit.libreoffice.org/44242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-19wrap scoped enum around css::util::NumberFormatNoel Grandin
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa Reviewed-on: https://gerrit.libreoffice.org/46339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19don't export category info to bubble charts, tdf#103988Markus Mohrhard
Change-Id: Ic2ecd959841172db3f4016b4a1ba667238c6c508 Reviewed-on: https://gerrit.libreoffice.org/46749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19fix validation error in lineChart export, related tdf#57832Markus Mohrhard
Change-Id: I282a6f476830d688837a9731234aaba37a13de16 Reviewed-on: https://gerrit.libreoffice.org/46673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-18oox: fix Android buildMiklos Vajna
Change-Id: Iad0d51311ba0e74e1fbc33ee3fb09c8c9a89b0c0
2017-12-18oox: try to fix Android build, no std::lround thereMichael Stahl
Change-Id: I47e1df5d27e788ef5aa48c3a09daf9888c33f920
2017-12-18tdf#90626 PPTX: Fix image bullet sizePaul Trojahn
This solution comes with a few limitations. The bullet isn't centered in Powerpoint and has to be between 25% and 400% of the size of the first character in the paragraph. This isn't optimal, but should produce acceptable results under most circumstances. Change-Id: I6c37169282aa351b81d78e06678424203b78f6d7 Reviewed-on: https://gerrit.libreoffice.org/44911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-17fix searched attribute for 3D chart shape, tdf114169Markus Mohrhard
Change-Id: Ic0642d4b223db121bdf5968af73811af8571bd72 Reviewed-on: https://gerrit.libreoffice.org/46614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-16tdf#97648 ooxmlimport: horizontal line's horiOrientJustin Luth
Although LO won't visually do anything with this property (because o:hr is improperly imported AS_CHAR), at least import and assign the property so that it is there for the future if o:hr is changed from AS_CHAR to AT_*. The unit test just adds a test for the existing status - to highlight what still needs to be fixed. o:hr probably ought to be AT_CHAR, with no wrapping. However, simply doing that wraps text the wrong way (always underneath) which seems to be a LO limitation of not putting preceeding chars above an AT_CHAR fly. So that's why I'm not implementing a change to AT_CHAR. Change-Id: I4aec99d3976c6d461715dba304cdf9ad98ab12b6 Reviewed-on: https://gerrit.libreoffice.org/42440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-12-12Move generateGUIDString to comphelperSamuel Mehrbrodt
and remove duplicate method Change-Id: Ic513a780f3b9b526c3abd0f273ad9c230ffbb373 Reviewed-on: https://gerrit.libreoffice.org/46233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-11tdf#111785 Save hatch background color in pptx format.geri1245
When exporting to pptx from LO, the background color of the hatching is preserved. The default background, when no hatch background is set is transparent. Change-Id: Ie44c89a9ce54eef49100b3e7b376c27c1a952fcf Reviewed-on: https://gerrit.libreoffice.org/46098 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10ofz#4576 Integer-overflowCaolán McNamara
Change-Id: I8042170ca2c3e66887374a94aa7d335e4445be69 Reviewed-on: https://gerrit.libreoffice.org/46182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-10remove unused osl/time.h includes ..Jochen Nitschke
and some more in base64.cxx Change-Id: I31c9f23d3bd11f5482774e976a7c40025ffcfb86 Reviewed-on: https://gerrit.libreoffice.org/46157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08tdf#114308 Export Watermark size as isSzymon Kłos
* refactoring * removed size hack * export/import "trim" attribute * DOC: export set of parameters to fit shape & frame Change-Id: Ib00654626ae1e10ac5110d22eada7528e03357e7 Reviewed-on: https://gerrit.libreoffice.org/46036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-08rtlRandomPool: remove pointless seeding with system timeThorsten Behrens
Change-Id: I88647a66a72d092303560a4348ce3dc55ee6c321 Reviewed-on: https://gerrit.libreoffice.org/46055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-08tdf#68759 PPTX: Export IsMirroredPaul Trojahn
Change-Id: I6bab00f79f1cb122344e4bb9fd62eb4c48a1838b Reviewed-on: https://gerrit.libreoffice.org/45808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-07tdf#97648 ooxmlimport: horizontal lines have no marginsJustin Luth
Change-Id: I170ab7a742f8e9d8029512592abda9fc54edda18 Reviewed-on: https://gerrit.libreoffice.org/42437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-04ofz#4526 Null-reference READ with openssl crypto backendCaolán McNamara
which is not the default backend Change-Id: I982e1b61c10efbe3312d68d90d48292a9b6cca0d Reviewed-on: https://gerrit.libreoffice.org/45794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02tdf#113037 Unify Watermark in DOC & DOCXSzymon Kłos
* use correct font for calculations Change-Id: Idd370678c000bf22c460c3323bd55cd827ba7153 Reviewed-on: https://gerrit.libreoffice.org/45698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-01ofz: check col/row boundsCaolán McNamara
Change-Id: Idaa38f400873372330dd06c14800c4a5018c79db Reviewed-on: https://gerrit.libreoffice.org/45639 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30ofz: handle empty Gradient StopsCaolán McNamara
Change-Id: I7e719b21bd21085ffdd0226a4a25d406a4e69351 Reviewed-on: https://gerrit.libreoffice.org/45617 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30ofz: handle empty paragraphs caseCaolán McNamara
Change-Id: I4c928f55881c1f9147eec1018381b3d3064c58ee Reviewed-on: https://gerrit.libreoffice.org/45592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30size() cannot be < 0 so just == 0 -> empty()Caolán McNamara
Change-Id: Ie56cc70ba5d60ded64d011f9d8e8fa9895789a38 Reviewed-on: https://gerrit.libreoffice.org/45591 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30coverity#1424321 Dereference after null checkCaolán McNamara
Change-Id: Ieadf71b99180418a875914094c4769c9df9f1db2
2017-11-30coverity#1424322 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4314ed8ecbfaf1435bc22688e9afb7b0b3bcbfd0
2017-11-30ofz#4481: move Path2DContext body to onEndElementCaolán McNamara
Change-Id: Ic06fb71c679e87069afda391e598d360b4b59cc2 Reviewed-on: https://gerrit.libreoffice.org/45516 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29ofz: handle bad key len and subsequent PK11_ImportSymKey failureCaolán McNamara
Change-Id: Ied93745f924cbcbc674b5c9a78545aa1f79fc61e Reviewed-on: https://gerrit.libreoffice.org/45513 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29ofz: avoid invalid short hashValuesCaolán McNamara
Change-Id: Ib7cd63351f4e5ed053e55fe9c5875ad92c81d762 Reviewed-on: https://gerrit.libreoffice.org/45490 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz: ensure aCoordList has required elementsCaolán McNamara
Change-Id: I6687f7e499907f2f44ade2b05b35e40570dabc6b Reviewed-on: https://gerrit.libreoffice.org/45389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28tdf#83877 Unit test for OOXML SignatureLine RoundtripSamuel Mehrbrodt
Change-Id: I40c116f28c0e8efe81e33e48fa05098d1dd76731 Reviewed-on: https://gerrit.libreoffice.org/45152 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28tdf#83877 OOXML Roundtrip of SignatureLine propertiesSamuel Mehrbrodt
Change-Id: I521e5f35663c5ab3c2702f1416fcec872f2f5e3f Reviewed-on: https://gerrit.libreoffice.org/44683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24ubsan: runtime error: signed integer overflowCaolán McNamara
Change-Id: I357717d1f7c33842367179a76b2f3b840c8ef758 Reviewed-on: https://gerrit.libreoffice.org/45217 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>