summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2022-12-05tdf#152211 PPTX import: fix connector position based on line widthTibor Nagy
Thick shape line changed the connector, e.g. direction of its arrow head. Follow-up to commit d8c89fb920af747ec51ce966b5d7b65e9340afbd "tdf#151891 PPTX import: fix regression of connector position" Regression from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 "tdf#89449 PPTX import: fix line connectors". Change-Id: I99d22409ec65e10609b1e371cc4d301fd73c7c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143467 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-29tdf#152152 DOCX export: fix lost WDP images in artistic effectsTünde Tóth
Handling of WDP image counter was incorrect if the document contains embedded documents, overwriting WDP images with the other ones. See also commit 55b1d635350cb76ee3e19e90c938eedd38ac3342 "tdf#152153 DOCX export: fix lost images at embedded documents" and commit cf2dc247ff5f726238856e9b46a4926a30430e14 "DOCX export: image deduplication and clean up" and commit b5f6a5cfc517ecd8aa6ba96471d854b07b92ebaa "ooxml: Do not repeat wdp files in artistic effects". Change-Id: Ia26784519f6d514ee8c90c7a91a367feeba140b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143235 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-26crashtesting: failure to export various docs to xlsx/docxCaolán McNamara
e.g. ooo74880-2.ods since: commit 3f70375cf160841b6140f5f1b2b79af3652897f8 Date: Fri Nov 18 12:06:59 2022 +0100 tdf#152069 tdf#108356 PPTX export: fix missing tile properties bodge a workaround to not crash at least Change-Id: I23e0fc4e0f7a2c6d0b182945e252470f2338da09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-26tdf#147906 used std::hypot for Pythagorean additionBogdan B
Change-Id: I530174e97d9e90318a770b2611354c07dcc9be58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143169 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-24tdf#152199: Don't crop twiceJan Holesovsky
We have a "GraphicCrop" property that is supposed to roundtrip the cropping in OOXML, but there is no core feature backing it (ie. the image is not shown cropped when this is imported and set). Instead, to show the image "cropped", we crop the image physically on import (throw away pixels that are 'outside' of the cropped area). But - the "GraphicCrop" is then saved on export, together with the image already physically cropped, which leads to garbled DOCX on re-import. Given that the core feature to show image cropped when the "GraphicCrop" is set, let's avoid setting it when we physically crop the image. Change-Id: Ia1090ea9c6d22e60c77d52bf65281f6588d07d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143216 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2022-11-24tdf#152069 tdf#108356 PPTX export: fix missing tile propertiesTibor Nagy
of background image patterns defined by a:tile. Note: factor "3.6" comes from EMU. Change-Id: I5da532ff9ad63fd6c236a58933a31dcd96cf5156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142913 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-24Remove some unused includesMiklos Vajna
Mostly com/sun/star/frame/Desktop.hpp is unused after inheriting from UnoApiTest. Change-Id: Ifba307353a11a14e033a230a291314bee86b51c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143190 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-11-24loplugin:unusedfields make some fields privateNoel Grandin
this is one of the secondary analyses this plugin performs Change-Id: I6fac8c926b53f1d909c5b183304744126549f2bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-23tdf#152153 DOCX export: fix lost images at embedded documentsTünde Tóth
Handling of image counter was incorrect if the document contains embedded documents, overwriting images with the other ones. See also commit cf2dc247ff5f726238856e9b46a4926a30430e14 "DOCX export: image deduplication and clean up" and commit 3f6df3835fec71ea61894f9a3bbfe5e4a06a5495 "DOCX export: fix image counters for multiple documents". Change-Id: I3ce3e370f96fa8b9feca3bc73f06ddca933215d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143036 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-21tdf#149803 tdf#128150 PPTX: export UseBgFill of custom shapesTibor Nagy
Fixing tdf#128150 the UseBgFill property of shapes can be saved to PPTX, but not in the case of custom shapes. Follow-up to commits c4cf2e82e8d0aaef9b1daedc033d6edf647e5284 (tdf#128150 Add OOXML import/export for "use background fill"), commit 50394abcc36a73c0205e6cb69d925c66c25f81f2, (tdf#128150 Implement/add SlideBackgroundFill visualization") and commit 9c2c48f14535e58cad0453fef584400ee703aecc "tdf#128150 xmloff: ODF import/export of fill-use-slide-background". Change-Id: Ib88f236d2533ef71ea66718d380e83d9a0685c3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142489 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-18rename IsStarSymbol to IsOpenSymbolCaolán McNamara
Change-Id: If525ba9826f5bc2d860233cbabf58d1d290be054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-14tdf#151891 PPTX import: fix regression of connector positionTibor Nagy
If the connector shape is connected to the glue point which there is inside the bounding box, then the position of connector appear incorrectly, for example different direction of the arrow head. Regression likely from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8 "tdf#89449 PPTX import: fix line connectors", as tdf#148926. Follow-up to commit eec48130271188cab63665acedbabf1ff5e850a2 "tdf#148926 tdf#151678 PPTX import: position of standard connector - part1". Change-Id: I5671bc70e663a979c43bad1b786118a6a9e92972 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142293 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2022-11-14Revert "Revert "tdf#151622 PPTX: fix export of show as icon option""Xisco Fauli
This reverts commit b652ebda7fa4e6c8db2f934bf4c8d2927f5c2332. Adapt unittest to UnoApiTest Change-Id: I6a1e42d4b445efdb48dab35f0bd5110aa52b0d74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142156 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-14tdf#142291 PPTX export: fix table border stylesTibor Nagy
Export border style subset used by the PPTX import, ::table::BorderLineStyle::SOLID, DOTTED, DASHED, DASH_DOT and DASH_DOT_DOT. See also tablecell.cxx:applyLineAttributes(). Change-Id: I5e4d631f7ca410beb76155579ea5b21a6eb66350 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142240 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-12tdf#125085 PPTX WordArt import: get shape font from runRegina Henschel
PPTX uses the settings at the run for the text in a WordArt shape. LO uses the settings of the shape. The patch copies the run font and language properties to the shape. In addition I have split the old method lcl_createPresetShape and renamed the parts. Now the method lcl_putCustomShapeIntoTextPathMode contains the geometry changes to put a CustomShape into text path mode and to adapt the OOXML values to the values needed for our preset Fontwork shapes, which are based on binary MS Office. MS Office has the style of the characters of a WordArt as properties of the run. LibreOffice ignores most of the properties specified in the style of a span element, when the text is displayed as Fontwork. Instead LO uses the properties defined for the shape for styling the text. Copying the text properties to the shape is now done in method lcl_copyCharPropsToShape. The values in testTdf125573_FontWorkScaleX depend on the used Font. Since on creation time wrong Fonts were used and now correct Fonts are imported, the values have to be updated. Import of fill and stroke of the characters is still missing, only a rudimentary import of color for solid fill exists. Change-Id: I6f31fe07fb0656b2ce8581e7123265fa598ac9c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142421 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-11-11move password handling from SwModelTestBase to UnoApiTestXisco Fauli
so other places inheriting from UnoApiTest can also import/export protected documents Change-Id: I0e2716204dbb171c9e17e3939b266977e1b96dda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142592 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-09UnoApiTest: factor out common codeXisco Fauli
Change-Id: I1d84d8c1e371016a4f4f068af1e9c76635f28cf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142490 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-08UnoApiTest: simplify code by using tempfile memberXisco Fauli
SwModelTestBase does the same. this will help to make SwModelTestBase inherit from UnoApiTest Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-07tdf#141908 - CppUnittests: replace usage of sal_Int32 with colorsNalini Prasad Dash
Change-Id: Icdf2a5e7c0bd738f2cffbc0b7e99b1bd90a6dcce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141685 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-11-03UnoApiTest: make mbSkipValidation privateXisco Fauli
Change-Id: Icc292b40b3295e7890f81d448bb4907725f46970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142245 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03Fix typoAndrea Gelmini
Change-Id: I73fec7b8634704a8ceedf7a1be6eacd4dafc06e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142249 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-03tdf#150966 oox export avoid bottom above top for text areaRegina Henschel
If bottom and top insets set so that the bottom edge of the resulting text area is above the top edge, then LO and MS Office behave different in how this is rendered. With commit e2169886 insets are converted on import to make rendering in LO similar to MS Office, but the implemented export has some problems, see analysis in bug report. LibreOffice normalizes the resulting text area in case bottom edge is above top edge. So this patch exports the insets so, that MS Office gets a normalized resulting text area and will not apply its special rules. A roundtrip starting with pptx will not regenerate the old values but will produce inset values, which give same rendering in MS Office than in LO. Because the method is different now, the inset values have changed and test testTextDistancesOOXML_Export is adapted. When you compare the result with the screenshot on slide 2, you see that the new method works as well. The old method did not work for exporting an odp file. That is covered by the new unit test. The docx unit test file covers the case, that the export tweak was erroneously triggered. Change-Id: I0091f284d9bdd635dd87ddb9e9b0e415cc0cc51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142185 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-11-03UnoApiXmlTest: add new wrapper for XmlTestTools testsXisco Fauli
Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-03swmodeltestbase: remove duplicated codeXisco Fauli
parseExportStream is already in MacrosTest Change-Id: Ibde88b176db1521966b6877bda90e06c278c397d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142218 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-02tdf#54857 elide more dynamic_castNoel Grandin
Change-Id: I42bef355eeef15e3733a5ee57b0569887cfa5e84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-02Revert "tdf#151622 PPTX: fix export of show as icon option"László Németh
This reverts commit ea62cacd129f03813d7d3d214bf9aa2ae60bbef4. Reason for revert: not declared macros ODP & PPTX in unit test Change-Id: Ic2c3a39ff36401f49f3d759eb60645ed239b1d4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142142 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-02tdf#151622 PPTX: fix export of show as icon optionTünde Tóth
Embedded OLE object wasn't look like an icon after its opening because of missing showAsIcon="1" of p:oleObj. Change-Id: I21dbd1e31f7e1de78d8bf548ca6f3619eb3e4a10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141505 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-10-31tdf#113187 exclude angle conversion from count of maGuideListRegina Henschel
The ooxml import uses the special viewBox value '0 0 0 0' to indicate that the point coordinates are relative to shape size and not to viewBox and need special treatment. To detect this case the number of guides in maGuideList was used. But that number might be larger than the guides in ooxml because each arcTo command introduces two additional guides for the conversion from 1/60000 degree in ooxml to degree in LibreOffice. The patch excludes these guides from count. Thus now a path which has no references in its points will get a viewBox with non-zero width and height in all cases and is rendered now. Change-Id: I410638a1fe02f692fd46313c88b5ea518f1d094f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142050 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-10-28tdf#54095 docx SmartArt import, apply theme text colorRegina Henschel
PPTShapeGroupContext uses method applyFontRefColor in importExtDrawings to bring the theme text color to the shape text. The patch copies this way to ShapeContextHandler, which is used for SmartArt in docx. Change-Id: Ie0c0453d6a1fd73fbd4b65246aed9570646dc6f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141992 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-10-27tdf#151767 PPTX import: fix table border widthTibor Nagy
There is a "Clear Table" function in PP. In this case, the table uses the default border value of MSO, which was imported as missing table border. (Note: commit ff0387e726b59e374029d2f635ce00308d99eff6 "tdf#135843: sd_export_tests-ooxml3: Add unittest for the export part" If attachment from tdf#106011 is opened in PowerPoint, the table is visible it, but was not in LO. This patch fixed that. Therefore the borders of table are not missing after export.) Change-Id: I92dfe2e42f5f58b15af23cc24e931fb12d7c2794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141880 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-10-27tdf#148926 tdf#151678 PPTX import: position of standard connector - part1Tibor Nagy
Connectors are typically connected to connection dots, which exist on shapes. If both or one of the two shapes are missing, it will be drawn the default type of a standard connector in LO. In this case, there is an adjustment point which is used to modify positions and shapes of the connectors. This patch fixes the position of the connector by calculating and setting the adjustment value. Change-Id: Iee384d2a92a22ff95d7b17ba0b4f09698176bc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141723 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-10-27tdf#151492 PPTX export: fix connection points regressionTibor Nagy
caused by commit 4d153517183193f468dee9148c94fe9d874bacb3 (tdf#149697 PPTX export: fix changing place of connection points). Change-Id: I6134f18f3c32182a2f5d7295e2511da192dd20c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141427 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-10-27related tdf#149961 pptx export: scale indents for autofitted textboxesSarper Akdemir
For autofitted textboxes, Impress scales the indents with the text size while PowerPoint doesn't. Try to compensate for this by scaling exported indents proportionally to the font scale on autofitted textboxes. Change-Id: Ib0f967e923d23553b4cdbd1bbe2e137d97b1b2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141758 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-27tdf#149961 pptx import: fix indents for autofitted texboxesSarper Akdemir
For autofitted textboxes, Impress scales the indents with the text size while PowerPoint doesn't. Scale the indents inversely propotional to autofit font scale so that the visual appearance on import is similar to PowerPoint. Change-Id: I7876b35a1f4221789564fcf23ccbe3fe21db3d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141717 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-26CppunitTest_oox_vml: Inherit from UnoApiTestXisco Fauli
Change-Id: I8c9fe639c448f1fb84449e065dfa05bd1c37ea34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141861 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26CppunitTest_oox_mathml: inherit from UnoApiTestXisco Fauli
Change-Id: I163fd8d635a18c1dd03eaa50720d10d4fe78d4cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141857 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26CppunitTest_oox_shape: inherit from UnoApiTestXisco Fauli
Change-Id: I2f8465713c3a2b57faea62d6022e4735d50eb950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141858 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26tdf#83671 SmartArt: preserve pos and size for metafileRegina Henschel
Import of a SmartArt creates a group with a background shape and then the SmartArt shapes. The background shape determines the position and size of the group. The method Shape::convertSmartArtToMetafile() replaces the existing SmartArt shapes with a metafile object and thereby throws away the background shape. Thus the group takes it size from the metafile object, which has default size 100x100 (Hmm) and position 0|0. The patch remembers the original size and position from the background shape and applies it then to the metafile shape. Change-Id: Id7b1ccd20b2597c5e2adca7294a994fd2e0e066f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141830 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-10-25CppunitTest_oox_export: inherit from UnoApiTestXisco Fauli
Change-Id: I46ae3ce5b1fdf6ef5c9d9a22cd589ed04d08ca2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141802 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-25CppunitTest_oox_drawingml: inherit from UnoApiTestXisco Fauli
Change-Id: I1bfea3ac8f07cd5a13ee78ce94fb04bfe55fa5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141799 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-24tdf#151547 pptx import: workaround for COL_AUTO collisionSarper Akdemir
In the current implementation of ::Color, it is not possible to have fully transparent white text (since it collides with COL_AUTO and gets interpreted as Automatic Color). Implement a workaround for import of fully transparent white text color so that it isn't interpreted as the magic value COL_AUTO (i.e. instead of fully transparent #FFFFFF import as fully transparent #FFFFFE). Change-Id: Ide750093ef8a89f1424ddd8f4e9ee1e18209f2ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141439 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-24tdf#83671 make SmartArt visible in import of xlsxRegina Henschel
Problem is, that Excel writes a zero size in xdr:xfrm for the SmartArt. With that the import generates a background size with zero width and height and no shapes at all in the SmartArt group. The diagram DOM is imported correctly. The actual size is not known until the row and column values of the anchor are evaluated. The idea of this patch is to correct the background size directly and to repeat the import of drawing.xml when the actual size is known. I noticed that in import of SmartArt in docx there is a similar problem that the SmartArt shapes are missing at some point, as can be seen in ShapeContextHandler::getShape(), about line 428. It uses ShapeDrawingFragmentHandler to import the shapes. To be able to use that handler too, I have moved its header file to include. The solution for docx uses a loop over the vector getExtDrawings(). But I have not seen a SmartArt case, where more then one element exists in it. Whether the shape is a diagram, is indirectly tested currently. The shape has yet no direct method for it. Change-Id: I9d705ed5bfb2894e9ce740ebf8589e06b4870bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141571 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-18tdf#151518 Do not tweak text area distances in WriterRegina Henschel
The fix for tdf#148321 has introduced tweaks to the upper and lower text distances for the case, that their sum is larger than the text area height. That works well in import from PowerPoint but conflicts with import of SmartArt shapes from Word. Reason of the problem is not only the missing Twip to Hmm conversion in TextBodyProperties::readjustTextDistances(). But I have not found which detail in the tweak produces the wrong text location. For now I have disabled the tweak for import from Word. Maybe someone finds a better solution in future. Because the user cannot insert such large distances in Word and SmartArt shapes do not use such distances anyway, I think it does not harm to disable the method for text documents. Import from Excel cannot be tested because of tdf#83671. Change-Id: I2e133f6864bba4419ad96e94d88aec86fe97d0fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141414 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2022-10-14Fix typo in codeAndrea Gelmini
Change-Id: If4cf1a77490650902d77705761b5168bdf5cece8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-10-13tdf#149840 Use actual outer size for SmartArt in WriterRegina Henschel
SmartArt import needs the outer size of the diagram for to define a background shape in the correct size and calculate the size of the diagram shapes relative to the outer size. The patch passes the values read from wp:extent in writerfilter to DiagramGraphicDataContext in oox. Change-Id: Ib39227bc645ac353336bab2c558d041974188f6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141223 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-12crashtesting: exception during dtorCaolán McNamara
Change-Id: I9874778ba79540cfde32bf59c3a63ebb72889dc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141215 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-11vml whitespace-check mangled Částečně to ste nCaolán McNamara
Change-Id: Ib77ca39a5e17c7fb27c8d5204120fb261b885f16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141228 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-11Deduplicate O(U)StringConcatenationMike Kaganski
And use an overloaded helper function with a better (?) unified name to show that the result is not an O(U)String. Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-09-29split utl::TempFile into fast and named variantsNoel Grandin
which makes it easier to know what each variant requires to stay on it's happy path Change-Id: I3275a2543573367714bc78092e882f6535507285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-29oox: avoid else after return in WpgContextMiklos Vajna
It's less code and does the same. Change-Id: I9b08f5b5c982bbf3740d7d5d04156ae01d878705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140718 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-11 05:50:21 +0000