summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-27Rename misleadingly named include file fillpropertiesgroupcontext.hxxTor Lillqvist
There is nothing called FillPropertiesGroupContext. Rename the file to "misccontexts.hxx" as I could not come up with some more specific name that would describe the collection of classes defined in it. Rename the corresponding cxx file, too. Change-Id: I44db1db8c63c8e897774597b46a237a214aacedf
2017-02-27There is nothing called FillPropertiesGroupContext since 2009Tor Lillqvist
So bin two pointless and misleading comments that consist of just that identifier. Change-Id: I14724b21d43283dbda1856ab28c56ae44512c3cc
2017-02-27Clean up a few SAL_INFOs a bit and add useful note about the ==cscode== etcTor Lillqvist
I dislike OSL_THIS_FUNC, it is too verbose, at least with Clang on Linux. Just use the Class::Name without parameters and namespaces. Change-Id: Ic8722a131463762ab70ff35d64ae7040c67bf595
2017-02-27Probably better to restrict the sequence sizeStephan Bergmann
...to any elements actually written. Was like that ever since the code's introduction in d3ffe3ed3fa1b80c7e54439673029e105940db80 "fdo#67737 : fix for flip not being imported & rendered correctly". Change-Id: I460c1c7c578bd7e53cc2e868da0b7aeb5f19194f
2017-02-26cppcheck: unreadVariableJulien Nabet
Change-Id: Id9d2fbe9b2d4040cc73c401f5558999604acf259 Reviewed-on: https://gerrit.libreoffice.org/34657 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-23Better make the zero-initialization more explicitStephan Bergmann
...if initializing these members is necessary at all; a bit hard to tell from the code. Change-Id: If15fb11b601ba3b8b5d3fdbe5c3dac01b095fb05
2017-02-22Bin pointless once used typedefTor Lillqvist
Change-Id: I12f51748dd190f6d50ed7ae738d7eedeb32f0af8
2017-02-22loplugin:unusedfieldsNoel Grandin
Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: ooxStephan Bergmann
Change-Id: I8a1b6baba6191b20264f32cbf73f5d75bc50235b
2017-02-17tdf#90407: Export Text AutoFit to .pptxTor Lillqvist
Change-Id: I2120f13fff58d4736ab55071236e0c2f80ba2eb0
2017-02-16Try harder to fix Android tinderboxTor Lillqvist
Change-Id: I4f3f112d4cd301d3ee1806cd2d26564ac3852723
2017-02-15no std::lround on androidCaolán McNamara
Change-Id: I910a0a81a925ce4578f3b9b3a51987fbbd91aa13
2017-02-15tdf#106026: Export paragraph top and bottom margin to DrawingMLTor Lillqvist
Change-Id: I8c60f86a1debe135c9172ff639aa5af93f03b99b
2017-02-13Fix typosAndrea Gelmini
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-13Related: tdf#105707 PPTX import: decode document name from URLAndras Timar
Change-Id: Ic4825549c6fef1a609a753a10f6224cbcd69b7fc Reviewed-on: https://gerrit.libreoffice.org/34135 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-10Related: tdf#105707 PPTX import: warn on empty SmartArt fallbackMiklos Vajna
This second related situation is about when there is drawingML fallback for the SmartArt, but it's ampty shape tree, which is never created with MSO2010+ (those shape trees always have at least one element). This is as bad as the missing drawingML fallback, so warn on it. Change-Id: I539d05154a4d1fcd5871dfc29616f77eb9945454 Reviewed-on: https://gerrit.libreoffice.org/34131 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10Related: tdf#105707 PPTX import: warn on invalid SmartArt fallback relidMiklos Vajna
We already warn when the SmartArt doesn't have a drawingML fallback, but having a reference to a fallback that is not a valid one (so resolves to an empty fragment path) is also unusable. So warn in that case as well. Change-Id: I03b2325003b4eb38b1347a88899799c6d5c33606 Reviewed-on: https://gerrit.libreoffice.org/34129 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10coverity#736181 Out-of-bounds readCaolán McNamara
it should be fine, as we rely on there being at least one password char, this is the same as, commit 2d3ed7ebb592401de214eaeee68c656afbefbe05 Author: Michael Meeks <michael.meeks@collabora.com> Date: Tue Feb 25 22:48:48 2014 +0000 cid#736173 - increase default fill chars buffer size. which is another impl of this Change-Id: I5e1e07af37bea0398153ede300beed67d37d5e12
2017-02-08oox, sfx2: can use std::move() hereMiklos Vajna
Change-Id: I0add196f79045e8cb7280b2b7d1d8620e4ec669e Reviewed-on: https://gerrit.libreoffice.org/34013 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-07remove CREATE_OSTRING macroJochen Nitschke
Change-Id: I7d5e1570918adc3b0cf2063d9735414233011a81 Reviewed-on: https://gerrit.libreoffice.org/34009 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06loplugin:unusedenumconstants in ooxNoel Grandin
Convert FragmentHandler2::MCE_STATE to scoped enum and drop MCE_UNUSED constant Change-Id: Id0b3a81e61d77af5d3837527b008e196835f57cd Reviewed-on: https://gerrit.libreoffice.org/33954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-05tdf#31488: Background fill changes its color when saving a PPTX file to ODPTamás Zolnai
For a gradient fill we need to generate a name because ODP export works with this name. In case of shapes it works because when fill attribute changes some internal name generation is triggered. The same thing doesn't work for slide background so generate this name explicitely in oox code. Change-Id: Ic6ebf37ef3d66a9c274747ca04653363b1fe6d02 Reviewed-on: https://gerrit.libreoffice.org/33937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-03tdf#105707 PPTX import: warn when SmartArt is missing DrawingML fallbackMiklos Vajna
By the time DiagramGraphicDataContext::onCreateContext() completes, we know if there will be a DrawingML fallback for the SmartArt (called ExtDrawing in the code) or not. Warn about this case once at the end of the import when in interactive mode. Headless mode silently ignores the warning as expected. Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d Reviewed-on: https://gerrit.libreoffice.org/33866 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-02loplugin:stringconstantStephan Bergmann
Change-Id: I14ac842fa7b8a8ec8c6eb7554d136a68fe727ed7
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30oox: clean-up crypto classes, use c++11 featuresTomaž Vajngerl
- remove "using namespace std;" - &vector[0] to vector.data() - use nullptr in OPENSSL Change-Id: Ib4067b0256801f94d448bc8d3faf5a2902d694e5 Reviewed-on: https://gerrit.libreoffice.org/33629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor oox..saxNoel Grandin
Change-Id: Ie12bfabc92bce04d702f3e77aa5896366e49245e Reviewed-on: https://gerrit.libreoffice.org/33509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24Move two include files to oox/inc as they are used only in ooxTor Lillqvist
Change-Id: Ie13614c1977f45aa8086f4db65ca86b7d9212735
2017-01-24Drop incorrect "artistic" prefix from some token namesTor Lillqvist
Apparently copy/paste mistakes in the 642a252cf1a2f1d08c4bbfcae15527bb82c7664d and 21d4cfe19e2796ebf89c408e292c4473924b2bc4 commits from 2014; most of the picture effect type tokens added in that commit do have names that start with "artistic" but not all. Does not break any unit test. (Does not fix the bug I am investigating either, though.) Change-Id: I2c3bb7243e1feaa3fa949b58d3acf34825d6987b
2017-01-24use rtl::Reference in FastParserNoel Grandin
instead of storing both a raw pointer and a uno::Reference Change-Id: I6b67a6098a3ccdce7e29ee8d601c743897032eaf
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ooxStephan Bergmann
Change-Id: I83c6995e4f15d6a042e57bac4d71874124402547
2017-01-18update approximate install location in READMECaolán McNamara
Change-Id: I6a139d5be193c968c2bf3373b415baa25dc32595
2017-01-17new loplugin: useuniqueptr: jvmfwk..saxNoel Grandin
Change-Id: I732e2e22c6f953f0982fbc8833453e7c23cf9d49 Reviewed-on: https://gerrit.libreoffice.org/33166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14tdf#97597: Ensure that each parsing thread has its own buffer.Kohei Yoshida
Change-Id: I93077f954a49b3922930e4fc86c80228be0f4dd2 Reviewed-on: https://gerrit.libreoffice.org/33069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-12add -mlong-jump-table-offsets for m68k also for ooxRene Engelhard
Change-Id: Ibfba6c7c808ca5212884032c17546e95fa16353a
2017-01-12tdf#104414: don't stop on exception from SwXFrame::setPositionMike Kaganski
Change-Id: Ib6d4e398d546d6fe250b9c1efe099ae8eef2d580 Reviewed-on: https://gerrit.libreoffice.org/32978 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10New loplugin:conststringvar: ooxStephan Bergmann
Change-Id: Id27e8c51fe87cbe7fa45a68cbaa8196767473b93
2017-01-06tdf#105150 PPTX import: try harder to handle <p:sp useBgFill="1">Miklos Vajna
The bugdoc has two shapes. The red rectangle is supposed to be covered by the other shape, but it wasn't as the fill style was set to none. The reason for that was we ignored useBgFill, unless the slide had an explicit fill style. Assume that in that case a white solid fill is the default. Change-Id: Iea20e216e44e13db68887f285c10bc1a8feacf0a Reviewed-on: https://gerrit.libreoffice.org/32786 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06tdf#105127 VML import: handle <v:shape style="flip:..." path="...">Miklos Vajna
I don't see an easy way to implement this via UNO, so use the internal API. As to the internal API usage, SdrEditView::MirrorMarkedObjVertical() (for UI) and SvxMSDffManager::ImportShape() (for WW8 import) are example client code. Change-Id: I9bf27788db32fd35d6b56e0f1a240c4b7abc5604
2017-01-05No need to check isEmpty() before clearingStephan Bergmann
Change-Id: Ie32a4ee915d57618d2a6a661febf39fd0d55dd80
2017-01-05getLength -> isEmptyStephan Bergmann
Change-Id: I5a8c2911851d1a798d8c6f3c25b08cb0469f07a0
2017-01-05oox: rename misleadingly prefixed m_pShapeStyleMichael Stahl
Change-Id: I07fdc4fff2dd05b57d1a0635d0bed8d1afd6dc58
2017-01-05No need for heap-allocated OUStringBufferStephan Bergmann
Change-Id: Id2dbe3ecce9eba2eefab90f43b9a2a6894839cfb
2017-01-05Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-04replace namespace URL strings with function calls...Rosemary Sebastian
Change-Id: I0b8b265df487aaeb76238013bc93c78e49a9e1a6 Reviewed-on: https://gerrit.libreoffice.org/32723 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2025-01-13 04:36:17 +0000