summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2017-12-02tdf#113037 Unify Watermark in DOC & DOCXSzymon Kłos
* use correct font for calculations Change-Id: Idd370678c000bf22c460c3323bd55cd827ba7153 Reviewed-on: https://gerrit.libreoffice.org/45698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-01ofz: check col/row boundsCaolán McNamara
Change-Id: Idaa38f400873372330dd06c14800c4a5018c79db Reviewed-on: https://gerrit.libreoffice.org/45639 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30ofz: handle empty Gradient StopsCaolán McNamara
Change-Id: I7e719b21bd21085ffdd0226a4a25d406a4e69351 Reviewed-on: https://gerrit.libreoffice.org/45617 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30ofz: handle empty paragraphs caseCaolán McNamara
Change-Id: I4c928f55881c1f9147eec1018381b3d3064c58ee Reviewed-on: https://gerrit.libreoffice.org/45592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30size() cannot be < 0 so just == 0 -> empty()Caolán McNamara
Change-Id: Ie56cc70ba5d60ded64d011f9d8e8fa9895789a38 Reviewed-on: https://gerrit.libreoffice.org/45591 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30coverity#1424321 Dereference after null checkCaolán McNamara
Change-Id: Ieadf71b99180418a875914094c4769c9df9f1db2
2017-11-30coverity#1424322 Uninitialized scalar fieldCaolán McNamara
Change-Id: I4314ed8ecbfaf1435bc22688e9afb7b0b3bcbfd0
2017-11-30ofz#4481: move Path2DContext body to onEndElementCaolán McNamara
Change-Id: Ic06fb71c679e87069afda391e598d360b4b59cc2 Reviewed-on: https://gerrit.libreoffice.org/45516 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29ofz: handle bad key len and subsequent PK11_ImportSymKey failureCaolán McNamara
Change-Id: Ied93745f924cbcbc674b5c9a78545aa1f79fc61e Reviewed-on: https://gerrit.libreoffice.org/45513 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29ofz: avoid invalid short hashValuesCaolán McNamara
Change-Id: Ib7cd63351f4e5ed053e55fe9c5875ad92c81d762 Reviewed-on: https://gerrit.libreoffice.org/45490 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28ofz: ensure aCoordList has required elementsCaolán McNamara
Change-Id: I6687f7e499907f2f44ade2b05b35e40570dabc6b Reviewed-on: https://gerrit.libreoffice.org/45389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-28tdf#83877 Unit test for OOXML SignatureLine RoundtripSamuel Mehrbrodt
Change-Id: I40c116f28c0e8efe81e33e48fa05098d1dd76731 Reviewed-on: https://gerrit.libreoffice.org/45152 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-28tdf#83877 OOXML Roundtrip of SignatureLine propertiesSamuel Mehrbrodt
Change-Id: I521e5f35663c5ab3c2702f1416fcec872f2f5e3f Reviewed-on: https://gerrit.libreoffice.org/44683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-24ubsan: runtime error: signed integer overflowCaolán McNamara
Change-Id: I357717d1f7c33842367179a76b2f3b840c8ef758 Reviewed-on: https://gerrit.libreoffice.org/45217 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-24Fix typosAndrea Gelmini
Change-Id: I384be98fc5336d48e6855a0ed0fe436b63712152 Reviewed-on: https://gerrit.libreoffice.org/45143 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-23Convert fprintf to SAL_WARN / SAL_INFOSamuel Mehrbrodt
Change-Id: Ibdc67eb7af83c9ffa29531a20f68efce578f3e47 Reviewed-on: https://gerrit.libreoffice.org/45082 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20TypedWhichId for SDRATTR* constants (1)Noel Grandin
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d Reviewed-on: https://gerrit.libreoffice.org/44943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15Don't pollute /tmp with vba_debug* filesStephan Bergmann
...put them at workdir/CppunitTest/oox_vba_compression.test.user/debug/ instead. Change-Id: I067a82c05e2f91969d70cb582d69c4c1de13951c
2017-11-14tdf#113037 DOCX Watermark correct ratioSzymon Kłos
Import and export Watermark with padding like MSO does. Shape is scaled to save correct ratio. Change-Id: Iebd8eb5f168e0030320406d4fd6b287e451267bd Reviewed-on: https://gerrit.libreoffice.org/44319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-09loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I5696c853daa16c9e55ff046d67102ba3042bfea8 Reviewed-on: https://gerrit.libreoffice.org/44459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-04loplugin:constparams in various(1)Noel Grandin
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b Reviewed-on: https://gerrit.libreoffice.org/44261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03[API CHANGE] tdf#65393 Import signature line images from ooxmlSamuel Mehrbrodt
showing whether the signature behind the signature line is valid or not. Change-Id: Ia6cca62812019f26d55d234cac767a9b4b7c8175 Reviewed-on: https://gerrit.libreoffice.org/40980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-02sw: ODF import: default as-char shapes to vertical-pos="top"Michael Stahl
The problem is that we don't render ShapesWithWrapping.odt the same as Word does: https://beta.opendocumentformat.org/rendercompare/upload/223/86/191/1 The first shape in the file is anchored "as-char" and has no style:vertical-rel or style:vertical-pos attribute affecting it. If Word would write either style:vertical-rel="baseline" or style:vertical-pos="top" explicitly, the rendering in LO would be the same. So the problem is that, for drawing shapes (note, text frames are images, embedded objects handled differently), LO's default vertical alignment is different, it is hard-coded in SwShapeDescriptor_Impl::GetVOrient() as SwFormatVertOrient(0, text::VertOrientation::NONE, text::RelOrientation::FRAME) This effectively positions as-char shapes *below* the baseline, which, while technically allowed, isn't really a good default. So fix this by making the default alignment dependent on the anchor type, so that as-char shapes sit on top of the baseline. The ODF filter sets the anchor type before inserting the shape in XMLTextShapeImportHelper::addShape(), however as it turns out the various MSO filters insert the shape before setting the anchor, which means the new default in SwXShape has an unwanted effect on them, as inserting the shape causes the default to be created. This requires changes to VML import to always set the VertOrient property, and to RTF import to set the anchor type before inserting. The DrawingML import is unaffected as it already sets VertOrient for every non-as-char shape. The testDmlTextshape "dml-textshape.docx" test still fails, but it turns out that the change in alignment for this test document is a bugfix, as it now has the same vertical alignment as in Word, so adapt the test. Change-Id: Ifcabd96a037515f7803f5474ec995f968b3b4de1
2017-11-01loplugin:finalclasses in ooxNoel Grandin
Change-Id: I12c274877a0975971863456e9abdcb811ee2bd80 Reviewed-on: https://gerrit.libreoffice.org/44133 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-31loplugin:constantparam in oox,registry,reportdesignNoel Grandin
Change-Id: I914fa6c6ef2f660eb6b8570c9c5f86cef477be80 Reviewed-on: https://gerrit.libreoffice.org/44093 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26Add a comment in CreateTableStyle() related to the AOO fix for #i120723#Tor Lillqvist
Change-Id: Ic2eadf1942927efb6a6b209db591e869b61362f4
2017-10-26Don't abbreviate "First" as "Fst"Tor Lillqvist
Change-Id: I16726fbc8bf4f67fe1018d54437d59b715738bfe
2017-10-26PPTX export: correct position of rotated groupsSzymon Kłos
* added testcase for tdf#113263 Change-Id: I7abf68d8fb4ffd8b883cfbf4d69916912add8182 Reviewed-on: https://gerrit.libreoffice.org/43794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-23loplugin:includeform: ooxStephan Bergmann
Change-Id: I9f1cc9940f5b31370394f789ebfaddfd6d30ca61
2017-10-23chmod 0755 -> 0644 for some source filesStephan Bergmann
Change-Id: Ibe5b5e03374419c2c23cd6559ab213d2dc2fcc66
2017-10-23tdf#113263 Revert "PPTX export: correct position for shape in group"Szymon Kłos
This reverts commit fd3383556881d6a9d73e1a3027c079cf9bfddecb. Change-Id: Ia9befead3b45975d91215cea584b32afadb5bd52 Reviewed-on: https://gerrit.libreoffice.org/43711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21loplugin:redundantcast handle dynamic_castNoel Grandin
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb Reviewed-on: https://gerrit.libreoffice.org/43621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19PPTX export: remember color schemes in themeSzymon Kłos
Remember color scheme from loaded pptx file or use default values. Change-Id: Icb69c51603afc5f332c20c75e4ed5f659f4b5614 Reviewed-on: https://gerrit.libreoffice.org/43470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-19Fix typosAndrea Gelmini
Change-Id: I101357736813bfd47fb15d347fd2c0a33133de56 Reviewed-on: https://gerrit.libreoffice.org/43506 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-18Replace lists by vectors in ooxJulien Nabet
Change-Id: I951466552fd1cdb3b8f1cbfc07e64f5e0424552e Reviewed-on: https://gerrit.libreoffice.org/43469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17PPTX export: correct position for shape in groupSzymon Kłos
Change-Id: I5c0c5d2c2b246337b78a2e1fbee97032701fb640 Reviewed-on: https://gerrit.libreoffice.org/43435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-16tdf#112633 oox: Save backup images to proper path in documentJacobo Aragunde Pérez
Artistic effects on bitmap images in OOXML files create a backup file with the original image. These were not being saved into the proper path for PPTX files because the `/word` directory was hardcoded in the export code. The path saved to the relations file was incorrect too because it was not taking into account that the relations file is saved to a subdir in PPTX and XLSX documents. Finally, added a unit test. Change-Id: I3e880ce763dc10dbc86ccf0e00871be5d36f6d88 Reviewed-on: https://gerrit.libreoffice.org/43338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-13SmartArt: export text rotation in the PPTXSzymon Kłos
Change-Id: I74bfc172fe7434d14de468ecfd3412636e53780c Reviewed-on: https://gerrit.libreoffice.org/43202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-09oox, implement HAVE_FEATURE_AVMEDIAjan Iversen
iOS does not support avmedia, therefore HAVE_FEATURE_AVMEDIA is set, however not all sources test for it. Change-Id: Ia58fb8d7ab524b9763fd9fa3a7d3fa111cb85bb4
2017-10-09tdf#100491: Reduce DOCX shapes arrow line ending size multiplierVasily Melenchuk
Older arrow line endings are quite big comparing to other DOCX line ending and same arrows in MS Word. Change-Id: I9617aa283a7e3fcc8f413c999352d7e33f05c187 Reviewed-on: https://gerrit.libreoffice.org/43119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-05tdf#100065 RefactoringPaul Trojahn
Change-Id: I842f90b655ccf195185bf8bae2d93b5b187954aa Reviewed-on: https://gerrit.libreoffice.org/43137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-28Blind fix for Clang 3.8 "must explicitly initialize the const member" errorStephan Bergmann
...as seen at <https://ci.libreoffice.org/job/lo_ubsan/681/console> Change-Id: I428b6e2fe55023fde5b77f7ff0bd1dba16bae2ed
2017-09-27SmartArt: correct behaviour of if/else nodesGrzegorz Araminowicz
else block is taken only if none of conditions in 'choose' was satisfied Change-Id: Ie668f15c665327098e8e63b2c92cd291711e4567 Reviewed-on: https://gerrit.libreoffice.org/41533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-09-27readonly mnFadeColor in SlideTransitionNoel Grandin
since commit c714b43b0137ad253f51e1c65417c9874b8509e5 Date: Mon Jul 20 13:12:31 2015 +0200 loplugin:unusedmethods oox Change-Id: Ibece5543b2012bd5a18d82058faa8554ed155777 Reviewed-on: https://gerrit.libreoffice.org/42835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-27loplugin:unusedmethodsNoel Grandin
Change-Id: I5d75baa2af046f377b49e967783fb06cd9e885ef Reviewed-on: https://gerrit.libreoffice.org/42841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-31 08:46:56 +0000