summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2014-02-11coverity#736026 Invalid iterator comparisonCaolán McNamara
Change-Id: If0a501cd19955d472c85341772385afbfe8768ca
2014-02-11Add tokens for 'table row' redlines (future patch)Adam Co
This patch adds 2 tokens for future patche's use of table row redline preservation. Change-Id: I20e6d1dd84a07f515076aaa3cd5b32c492ec476d Reviewed-on: https://gerrit.libreoffice.org/7801 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-02-11fix crash during file format detection, related #i101863#Markus Mohrhard
Change-Id: I2aec2e95f49ab70a9e94c5d52f70855f4381a24e
2014-02-10Werror=maybe-uninitialized in drawingml exportTomaž Vajngerl
Change-Id: Ib04a464483c43a999db82bfaa539193c526d5041
2014-02-10coverity#1079288 Uninitialized scalar fieldCaolán McNamara
Change-Id: I0fb9e547b73b563725eb8014f68224706df3c39d
2014-02-08oox: whitespace fix in WpsContextMiklos Vajna
Just make sure that these two new lines match the style of the rest of the file, which was so far consistent. Change-Id: I6113753157fec7fd0e0dc988885b36b477c301b2
2014-02-08drawingML: remove code duplication: use GetRelativeRect()Zolnai Tamás
Change-Id: I7368ad15292c82e5320deb9ab60e04f70d0c92b8
2014-02-08drawingML: remove code duplication: use WriteStretch()Zolnai Tamás
Change-Id: I0d589da01bf6afed86b5811d6b27f72f6e1bb160
2014-02-08drawingML export/import: text frames with vertical alignmentZolnai Tamás
Change-Id: I469da0a8234dd2979facfed3d66907aad1a138ab
2014-02-07oox: make sure debug output appears on stderrMiklos Vajna
So that profiling unit tests (finding out the largets test documents based on the CSV output on stdout) is possible again. Change-Id: Ib870d6f424c3219f37715daef5400a0181867be7
2014-02-06typo fixes in commentsAndras Timar
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06DOCX export: register wp14 namespaceMiklos Vajna
Change-Id: I4ce857bd2e48372da4ed7252a2849ad37c73b6b9
2014-02-06fdo#54938 Convert oox, sc, vcl, svtools... to cppu::supportsServiceAlexandre Vicenzi
Change-Id: I6268bc57417d53b9810c81071fbcd604e2a19507 Reviewed-on: https://gerrit.libreoffice.org/7886 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-06rhbz#1017379 do not remove too much from the pathDavid Tardon
Change-Id: Ibffa7f2fbe91be9b95217ce36999e286ef444a37
2014-02-05drawingML import: paragraph adjustment inside group shapeZolnai Tamás
Change-Id: I875cb1f12c9f81d329d7fe9cd3aa32a4cd818573
2014-02-05drawingML import: capitalization inside group shapeZolnai Tamás
There are two types of capitalization in DOCX: -uppercase: <w:caps> -smallcaps: <w:smallCaps> Change-Id: I6a5d238bed68aa3fd3478a77cf1942f009480eb6
2014-02-05WaE: statement aligned as ... [loplugin:bodynotinblock]Tor Lillqvist
Change-Id: I4e3078ab29ff6ad2d89f68ef6413d2f3fb1fcb80
2014-02-05Trivial syntax fixJacobo Aragunde Pérez
Change-Id: Icfcea4a4e86a85d67786d0a87d8d2eb665860e0e
2014-02-05drawingML: do not write empty schemeClr tagsJacobo Aragunde Pérez
Change-Id: I8508f00f6af218605d1d43d3efcefbf545387ab8
2014-02-05ooxml: preserve gradient shape fillJacobo Aragunde Pérez
LibreOffice is unable to properly import the custom gradient fills defined in ooxml documents. To prevent data loss, we save the original gradient fill definition in the shape interopgrabbag and we write it back to the document on export. In case the user has changed the fill properties of a shape, the original fill will be discarded in favor of the new fill. We have added a new ooxmlexport unit test to test this feature. We have also added some missing transformations to the methods getColorTransformationName and getColorTransformationToken in Color class, and refactored some code in class DrawingML to the method WriteColor( OUString, Sequence ). Change-Id: Ie71f89eaa20313561aa9180ea33b76f3fb5e5df6
2014-02-04fdo#54938 Convert oox and scaddins to cppu::supportsServiceAlexandre Vicenzi
Change-Id: If75e6e96887d63a555094a2a9c73ca8a157fe964 Reviewed-on: https://gerrit.libreoffice.org/7836 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-03drawingML export: custom geometry with cubic bezier curvesZolnai Tamás
When the custom shape is not a preset shape then construct a PolyPolygon and use DrawingML::WritePolyPolygon() to export it. Change-Id: I6598976a475bfcb92305338af9016e09df4c9456
2014-02-01oox: clear the saved shape when the shape really endsMiklos Vajna
Change-Id: Id0d644407bf1f5672e654082328434b9464c140a
2014-01-31CID#1103719: fix memory leakMarkus Mohrhard
2014-01-31don't generate invalid xml filesMarkus Mohrhard
VmlCommentExporter::StartShape already adds a XML_type to the attribute list, so we would be exporting the same attribute twice which makes the xml file invalid. This file could therefore not be imported again. Change-Id: I2aed2805ea59c15b1f7e60ab9cab10f7a8e81412 Reviewed-on: https://gerrit.libreoffice.org/6980 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-30drawingML: complete the fix of nAlpha param in DrawingMLJacobo Aragunde Pérez
Change-Id: I1aec870ee52180d1b1b96762f69fab94370acbde
2014-01-30drawingML: fix transparency of shape solid fillJacobo Aragunde Pérez
The empty value for transparency in drawingML is 100% and not 0. Change-Id: I5f34f03b9b72cc20e92e32f9c9bc1bdfae73ff55
2014-01-30drawingML export: transparency of solid filled shapeZolnai Tamás
Change-Id: I97968dd5f5233e17870bdfdf2864ae8ce9179080
2014-01-28bool improvementsStephan Bergmann
Change-Id: I171212bbfc2f54a16b5669ab4401a3168e7f0552
2014-01-28ooxml: Small code refactorJacobo Aragunde Pérez
* Use PUT_PROPS macro in all cases. * Added putPropertyToGrabBag( OUString, Any ) to avoid the explicit creation of a PropertyValue object every time. Change-Id: If098dd3a94d1843c4c5dbc3a507b05754d9d59c7
2014-01-28ooxml: Preserve shape style effect attributesJacobo Aragunde Pérez
Preserve <a:effectRef> tag and its contents from inside shape style properties tag <wps:style>. Added some lines to existing unit tests to check for the preservation of these attributes. Change-Id: I6e47b228dcc9788a4a2dfe87bd1186d2f04dbeea
2014-01-28ooxml: Preserve shape style and theme attributes for lineJacobo Aragunde Pérez
Line style and color can be defined by the shape style attributes or can be directly assigned by the user (and even using a theme color in the case of color attribute). This patch aims to preserve the relevant attributes of this feature after a roundtrip. For style attributes (wps:style/a:lnRef), they are kept and preserved in the "StyleLnRef" property of the shape InteropGrabBag. To be able to access to some of them, the methods getLineStyle, getLineJoint and getLineWidth were added to LineProperties object. For the line theme color (a:ln/a:solidFill/a:schemeClr), the original line color and the theme color name are preserved in the properties "OriginalLnSolidFillClr" and "SpPrLnSolidFillSchemeClr"of the Shape InteropGrabBag. On export time, we must check if the user has changed any properties of the shape line, this is done comparing the new shape attributes with the original values coming from the style and theme definitions. In case some of the attributes is different, the new attribute must be saved overwriting the old one. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Besides, an existing unit test in ooxmlexport was modified to include checks for the preservation of line style, line theme color and custom line style that override the style attributes. Change-Id: Iabb0cef9e3cc433676c201bc296fb7b373839a3f
2014-01-28ooxml: Preserve color transformations in shape style definitionsJacobo Aragunde Pérez
Color tags like <a:schemeClr> can have children tags that modify the specified color. These modifications were applied on import time in the Color object, but they were not preserved. We added a member to Color object to preserve the unaltered list of transformations. The method getTransformations() returns that member, and the methods getColorTransformationName and getColorTransformationToken were added to transform the tokens into strings that can be added to an InteropGrabBag and viceversa. The transformations are added to the Shape InteropGrabBag in the method Shape::createAndInsert, and they are written back on export time at DrawingML::WriteStyleProperties. The data files for some /sd/qa/ unit tests were updated to reflect the new properties inside the Shape InteropGrabBag. Change-Id: Ieb164268c3b79f2d9b7ed3a4954b5de3b7a5811c
2014-01-27ooxml: fix import of custDash shape line attributeJacobo Aragunde Pérez
A LineProperties object can contain some preset dash defined by the shape style and some custom dash defined by the shape properties. In that case, the custom dash must be used. The existing code only used the custom dash if no preset dash was present. Change-Id: I6254d95184312360e8782dba7329d5ec2f5441fa
2014-01-27cp#1000025: Import casemaps from pptx.Muthu Subramanian
Note: This only imports it and it may not be even possible to export (even to othe formats). Change-Id: I8e104f1bc3a95c42ac932b6ab58365dc113fb2e0
2014-01-25OOXML validation fix for chartsMarkus Mohrhard
smooth entry was written too early Change-Id: I200f67dd70c8efa0f46fbe177add36b6c80a96f4
2014-01-25drawingML import: parse shape text run inside w:sdt and s:sdtContentZolnai Tamás
Change-Id: I6dc5939ae66967785cdc5dab318024b8cb17d1cd
2014-01-24oox: add wp14 tokensMiklos Vajna
Change-Id: Iec9cfa1fd12c45cdab5ef97ab4eb2573577c412b
2014-01-24oox: tokenize wp14 namespaceMiklos Vajna
Change-Id: I6562cf7f9f090edf94ede2935233966d9dc4066f
2014-01-24fdo#69616: Fix for VML part missing for group.Rohit Deshmukh
Cause: - In altenrate content, Fallback contains only group tag. Implementation: - Added export logic in Vml export. - Added unit test case for vml group. Change-Id: Ia1c9834950528dc892caea1cb675a7f42165d9ba Reviewed-on: https://gerrit.libreoffice.org/7276 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-01-23drawingML export: fix position of shape in case rotation is 180 degreesMiklos Vajna
This is the other case when position shouldn't be adjusted. Change-Id: I9265bf1c762fd519e3a12e97d767b5d213644e6d
2014-01-22VML import: parse shape text run inside w:smartTagMiklos Vajna
Change-Id: I26c2f9e3f5e560f22d3de0a7378c5cd7d0413184
2014-01-21WaE: C4701: potentially uninitialized local variable 'nIdx' usedTor Lillqvist
Change-Id: If05dd971ad62b059499c50bfc0b82b28e19fee4a
2014-01-21drawingML export: fix position of wrapped shapes in DOCXMiklos Vajna
In case of DOCX, the DOCX wrapper around the drawingML fragment already contains the real position of the shape (which talks about paragraphs and other concepts which are unavailable in a spreadsheet / presentation), and the inner position should be 0, otherwise the shape is shifted towards the bottom right corner. Note that this only affects drawinglayer shapes in DOCX, Writer pictures are handled in sw, and those always had a 0,0 position in the inner drawingML fragment. Change-Id: I582b1ae64387b50ffb051e1f5017eab0e5d5ab34
2014-01-21fdo#63154 Removed unused solar.h reference in ooxAlexandre Vicenzi
Change-Id: I224bc31af9ecb77ad42357550e016b000ebf4837 Reviewed-on: https://gerrit.libreoffice.org/7519 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-20drawingML export: zero rotation shouldn't alter the shape positionMiklos Vajna
I'm not exactly sure why existing code didn't do this implicitly, but at least this improves the situation. Change-Id: Id2bb169c513827b7ef48640dc88fad90a83d2bee
2014-01-20drawingML export: write TextShape outline propertiesMiklos Vajna
Change-Id: I3742c960016bbe1d82b58a16d464b329d2612c10
2014-01-20drawingML export: fix TextShape width for DOCXMiklos Vajna
Change-Id: Ibaf29ed746076fa6ec0bad013cac26debdb2b165
2014-01-20drawingML export: write TextShape fill propertiesMiklos Vajna
Change-Id: Ibe89e86b19d7633e9a0669ff0574173ac4b633c5
2014-01-19WaE: variable is used uninitialized whenever 'for' loop exitsTor Lillqvist
Change-Id: I5e3db7eaf284718a1e313401b18ee6665d2837a1