summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)Author
2015-02-07coverity#1268301 Dereference null return valueCaolán McNamara
Change-Id: I487009503866b6910049824efab987066dd72023
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I37eb6c976779aeec829d312920ab1d18884c0f2f
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-06Make OUStringLiteral more usefulStephan Bergmann
...don't dare make it non-explicit, yet. Along the way, introduce SAL_CONSTEXPR. Change-Id: Ia3179d0d5e001fd7aa92237c97437e9b74366ee1
2015-02-06static const to avoid re-init all the time + c++11.Jan Holesovsky
Change-Id: I24ac6405f03e2d55f832d1ffe0c71e575883c5c8
2015-02-06bnc#637947 improve DrawingML export of custom shapesAndras Timar
Change-Id: Iaa880528cf3c899ce66e4349c6d989dfbe5cbeb6 Reviewed-on: https://gerrit.libreoffice.org/14346 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-02oox: 89 DPI is not such a great defaultMiklos Vajna
Using the DPI from Application::GetDefaultDevice() is a much better idea, especially that now oox::GraphicHelper::GraphicHelper() and oox::drawingml::DrawingML::WriteSrcRect() are in sync. Should fix the testCropPixel() failure in CppunitTest_sw_ooxmlexport that appears on HiDPI systems. Also, fix all the rounding problems that now became visible when the DPI is the same for both import and export. Change-Id: Iceb34a8a5a1eaa8ce0824491521ad6b4d2f6949c Reviewed-on: https://gerrit.libreoffice.org/14280 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-02fdo#88826: replace MM100toEMU() by convertHmmToEmu()Juan Picca
Change-Id: I9ca79dfa0c214e3f58b7f45a78ad0877d4c7d10a Reviewed-on: https://gerrit.libreoffice.org/14266 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-30chisel off some more unused codeCaolán McNamara
Change-Id: I62cafc8e10e9c9dab3fde1785b826ba8ff68569f
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-24coverity#1265791 Unchecked return valueCaolán McNamara
Change-Id: I6577fe7a9eeeaadd42db5fe667d0418af9899978
2015-01-21fdo#87488 Wrong text rotation inside a preset shape from docxGary Houston
Preset shape text rotation values are read in a few places and stored in moRotation. With these changes, moRotation is always read unchanged, but multiplied by -1 when it's used. Change-Id: I633d665c21daa69e15fa828a43300f10d2bf2054 Reviewed-on: https://gerrit.libreoffice.org/13561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-01-20Some more loplugin:cstylecast: ooxStephan Bergmann
Change-Id: If2f8b9ff2577f2c8e9f15d1f174d50e5254fe7d8
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-03fdo#83058 File corrupt due to data label position is invalid in chart.xmlPriyankaGaikwad
- File getting corrupted after RT due to data label position is invalid in chart.xml - LO must not export invalid label position property if chart type doesn't support that positioning in MS Office. - For clusterd bar chart XML Difference chart1.xml Original file <c:barChart> <c:grouping val="clustered" /> <c:ser> <c:dLbls> ... <c:dLbl> <c:dLblPos val="outEnd" /> </c:dLbl> ... </c:dLbls> </c:ser> </c:barChart> Roundtrip file <c:barChart> <c:grouping val="clustered" /> <c:ser> <c:dLbls> ... <c:dLbl> <c:dLblPos val="r" /> </c:dLbl> ... </c:dLbls> </c:ser> </c:barChart> Change-Id: I9cae11b8d198aaa70fb05cb3bf329cd898519170 Reviewed-on: https://gerrit.libreoffice.org/11141 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-22ERROR: Invalid content was found starting with element 'p:pic'.Miklos Vajna
Again, as pointed out by CppunitTest_sd_export_tests. Sadly it seems that the spec and PowerPoint is not in sync here, so just do what makes both happy. This fixes the --with-export-validation build. Change-Id: I49e22d154d30106f91f1c972012f99a863784d23
2014-12-22ERROR: Attribute 'spid' must appear on element 'p:oleObj'.Miklos Vajna
As pointed out by CppunitTest_sd_export_tests. Change-Id: I8ecbc3ef4ea9dc84ebf88506967d02de04ded852
2014-12-22bnc#862510: PPTX import: Wrong text vertical adjustment inside shape.Zolnai Tamás
When alignment is not specified, it should be set to the default "left" value just on time, when properties are pushed to the property set, otherwise uninitialized value is better. Change-Id: Ic294c5d7cc477f7515aea1c071ad9b67275c012d
2014-12-22bnc#862510: PPTX import: Wrong text color inside shapeZolnai Tamás
When theme index is 0, it means it's unset so we should not apply that. Change-Id: I62a9cd2a9b4c19f5acffc334d5e8263fe24fc8fd
2014-12-22bnc#822341: PPTX export of embedded text documentsZolnai Tamás
-Make embedded text documents exported by analogy with spreadsheet embedded documents. -Convert MS ole objects to LO sepcific objecst to allow exporting those ole objects too. Plus use gb_CppunitTest_use_rdb instead of wasting time on finding out which missing components cause test failing. Especcially when we have platform dependent components (e.g. related to embedded object) Change-Id: Ic76d659b51274777a1669c215344a1169ebcba81
2014-12-22Refactor building perfect hash tabels for tokensDaniel Sikeler
moved the defines to be usable in more modules moved perl-script to be usable in more modules Change-Id: If893e4b7e9dc670646bdf097cb6fa5710e45f1ac
2014-12-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018 Reviewed-on: https://gerrit.libreoffice.org/13540 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-19WaE: variable 'nModuleCount' set but not usedTor Lillqvist
Change-Id: If7893fcfbac978710c664cfd013910ece77cda59
2014-12-19defining a macro for two lines of code introduces more noiseNoel Grandin
.. than it solve Change-Id: Ic60021aa428289fffb26bc349425e9b8be520d0a
2014-12-19remove operator>> and operator<< methodsNoel Grandin
in favour of ReadXXX/WriteXXX methods Change-Id: I75fcb04cb9e2981a10146a96de27916ca7f6bc57
2014-12-19remove operator>> and operator<< methodsNoel Grandin
in favour of ReadXXX/WriteXXX methods Change-Id: I849fd10c689fb9834ae9974e430dc337adc68755
2014-12-18cppcheck: Same expression on both sides of '||'Julien Nabet
Change-Id: Ibdadac46483ca3b17a12e3d1ae31f75a869b8dbc
2014-12-18oox: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I63db342676e1116c2ed1eef4e27599add0a318c9
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15Resolves: fdo#87281 Crash on importing diagram in .docx fileGary Houston
Change-Id: Ic2c7326ab83258e2e9dcbac88aa9f76f771a9b12
2014-12-15no point checking for null before deleteCaolán McNamara
Change-Id: I58cbb075a56518d71874137180ad92ae764ec4bf
2014-12-15oox: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I55ee581c9d3fc0a17639833a6a034e2addf768d1
2014-12-12fix commitNoel Grandin
fix my commit aa2f02a4dc8a05f49e679a26f2beebb9d66b232 "remove operator>> and operator<< methods" I incorrectly inverted the conditional Change-Id: Iade05b88bdedb7e5b0cff25a80d3b88ff4a0235f
2014-12-12remove operator>> and operator<< methodsNoel Grandin
in favour of ReadXXX/WriteXXX methods Change-Id: I69eebee3a8ce5b40301db7940a1d85915c0bf6f4
2014-12-05fdo#38835 strip out OString globalsNoel Grandin
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
2014-12-02Resolves: fdo#70157 fix crash on loadingCaolán McNamara
Change-Id: I0d248a195852c14cd95d4e337823076dd2fbc19d
2014-11-30PPTX import: shape effect properties defined by themeZolnai Tamás
Effect import is so poor by now that this changes does not seem to have any effect, but later it can be helpful. See also: 81cd386facedfbb15be6dffc10351262abf733f3 and 664a56b3c81503bdf199edf1806676f0a35b956f Change-Id: I4e6a9952aa138959ab273db0494ef0cf76d8fc24
2014-11-30PPTX import: fix import of shape line properties defined by themeZolnai Tamás
See also: 81cd386facedfbb15be6dffc10351262abf733f3 Change-Id: Ibb21d3e5b52a4d4996202acd4a989910fa223632
2014-11-30bnc#904423: Text(box) is rendered white on white when it is notZolnai Tamás
The problem was that the background color defined by theme was not imported correctly, because the different fill style comes from different sources (master slide, theme, direct formatting) were applied on the shape in wrong order. To solve this we need to store master slide defined fill style in a different variable so theme style can be applied after master slide defined style but before direct formatting. Change-Id: I99ea981858b9fa391915570187c8ddfdf2be1f7a
2014-11-27fix higher debug level buildCaolán McNamara
Change-Id: Id35efda5e4df820cda2afd7b65b5f890fec03f2f
2014-11-22small cosmetic clean-upMarkus Mohrhard
Change-Id: Idce2856f656576dc58e137800e11da0178eb5201
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17Add rtl::OUString::toUtf8()Miklos Vajna
There is rtl::OUStringToOString() already to do OUString to OString conversion using UTF-8 encoding on a best effort basis. However multiple modules have code where we assume that such a conversion is perfect. Add a new method that asserts such an expected success instead of duplicating it at multiple places. Change-Id: I0e55b53f558df82b67af6a463c8144655cf0ca74
2014-11-15oox: these are expected to be UTF-8Miklos Vajna
Change-Id: I2e9cb96948d7f990dd8be5f4505f00306fa62f8f
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-01 05:42:36 +0000