summaryrefslogtreecommitdiff
path: root/postprocess/qa
AgeCommit message (Collapse)Author
2024-05-20loplugin:ostr in variousNoel Grandin
Change-Id: I9f399b3752da9df930e0647536ffcd4e82beb1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-07move using the vcl file dialog in headless mode to the point of creationCaolán McNamara
instead of setting and unsetting the config option at start and exit because a document that crashes in headless mode leaves my config in an unwanted built-in file dialog state. Change-Id: Ib5fcc5994a08c78bffdf57cb5b252dc469167ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-14Fix typoAndrea Gelmini
Change-Id: Iebbecfbd395aa001d82dc00c7ef9b9587b4755fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134048 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-09-01use a dummy clipboard when running unit testsNoel Grandin
so the multiple unit tests don't stomp on each other. This fixes a couple of things in my earlier attempt (*) actually set the env variable on Windows (*) don't use a global variable to test the env var, because that variable might be initialised BEFORE the env var is actually set Change-Id: Id43a1dd2fbd324691e0b6578c9026b8a523012e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-11Adapt the remaining OUString functions to std string_viewStephan Bergmann
...for LIBO_INTERNAL_ONLY. These had been missed by 1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take std::u16string_view parameters" because they did not match the multi-overload pattern that was addressed there, but they nevertheless benefit from being changed just as well (witness e.g. the various resulting changes from copy() to subView()). This showed a conversion from OStringChar to std::string_view to be missing (while the corresponding conversion form OUStringChar to std::u16string_view was already present). The improvement to loplugin:stringadd became necessary to fix > [CPT] compilerplugins/clang/test/stringadd.cxx > error: 'error' diagnostics expected but not seen: > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd] > File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd] > 2 errors generated. Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-30terminate XDesktop properly in unit testsNoel Grandin
So that the UNO constructor work can continue - where we need the desktop to be disposed properly so that all UNO constructors objects have their dispose() called, and they can clean up their global state. We detect this case by changing a SAL_WARN to an assert in Desktop::disposing() (*) in ~ScTabViewShell, don't call EnterHandler, because that tries to create EditEngine's and other stuff, which crashes (*) Need a fake singleton so that the servicemanager calls dispose() on the AnalysAddIn and we can clear the global variable there. Change-Id: Id13b51e17afc16fcbbc65d64281cdf847e4a58cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-10replace usage of blacklist with denylistThorsten Behrens
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-12Revert "loplugin:constfields in package..registry"Noel Grandin
This reverts commit 31138ff7729cbf179079a5e635d3a823e2971f08. Now that we know that making fields has negative side effects like disabling assignment operator generation. Change-Id: I3f1ae65532f441c8be5ebca5866b8a1e1c69318c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90363 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-17Simplify Sequence iterations in postprocess..saxArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: If738d8f4e792c4686870183b0c0fdfbb61fd3351 Reviewed-on: https://gerrit.libreoffice.org/77245 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-15loplugin:sequenceloop in postprocess..reportdesignNoel Grandin
Change-Id: I86b9174c37e4a347a3a8ac6c2707052167e6fdc0 Reviewed-on: https://gerrit.libreoffice.org/77522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-13loplugin:constfields in package..registryNoel Grandin
Change-Id: Ie139490f2b008bf294910d002af711f8f41fe76d Reviewed-on: https://gerrit.libreoffice.org/61727 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23[API CHANGE] Fix typo in prop implemented by stardiv.UnoControls.FrameControlStephan Bergmann
There is exactly one implementation of css.frame.FrameControl (which demands a property named "ComponentUrl" not "ComponentURL"), and exactly one place where that property is used. So switch those two places to use the spelling of the property name as documented in the UNOIDL service. (Even though that can be considered an incompatible change, in the unlikely case that 3rd party code expects to be able to access the given implementation's property with the mis- spelled name.) Change-Id: I4fa3f21851b61079c09deea1a24aac22bc96f36f Reviewed-on: https://gerrit.libreoffice.org/51766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23blacklist should have been staticStephan Bergmann
Change-Id: I2f9172ba9d9724b39ce00f0e5a24a5d4032789a9 Reviewed-on: https://gerrit.libreoffice.org/51765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21CppunitTest_services: check service impls support properties as advertisedStephan Bergmann
...blacklisting existing violations for now (to be cleaned up) Change-Id: Ie94de44d44e04ed45c0ae10d518157da76332bda Reviewed-on: https://gerrit.libreoffice.org/51654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-29Fix typosAndrea Gelmini
Change-Id: Iedd82d035454c940d76a94c7e910c81827c1389c Reviewed-on: https://gerrit.libreoffice.org/48828 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-27Better fix for CppunitTest_servicesStephan Bergmann
...than 25313923b08018bd837cfe3fc99a5e141602cafc "Fix CppunitTest_services for constructor-based implementations..." (which this commit reverts again). My claim that "the 'factory' would be the object itself" is nonsense, it would rather be an ImplementationWrapper (but one that was freshly created for each ServiceManager::createContentEnumeration). Change-Id: I85c683cff6f9ba78d0f8567a53f8fcbc56fe55cf
2017-10-26Fix CppunitTest_services for constructor-based implementations...Stephan Bergmann
(i.e., using constructor="..." in the .component file) that implement multiple services, but are not implemented as single-instance objects (i.e., always return different objects from that constructor function). In that case, the "factory" would be the object itself, and would thus be different for different instantiations of that implementation. erAck ran into such a case with new code he's writing. Change-Id: Ib134a4c6d1400b43a7df3cf6a115f8206fb80c93
2017-09-12clang-tidy modernize-use-emplace in package..saxNoel Grandin
Change-Id: Ibc0258fd79df987a0e295552bcc5bf89ee12007a Reviewed-on: https://gerrit.libreoffice.org/42173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-20sw: fix remaining loplugin:cppunitassertequals warningsMiklos Vajna
Now only subsequentchecks are remaining, as far as I see. Change-Id: Id5e5a874f8de08c0fd3722aecdc02967ae5d421f Reviewed-on: https://gerrit.libreoffice.org/33346 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13tdf#92668: Revert some implementation names, for backwards compatibilityStephan Bergmann
These implementation names of Calc, Draw, Impress, and Writer documents are the most likely to be checked by existing third-party code, so revert the corresponding parts of 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 "Fix various XServiceInfo implementations" (and instead add fixups in CppunitTest_serives). Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe
2015-03-25Revert "give this a copy ctor"Stephan Bergmann
This reverts commit da42d1100832aae524c2e6b0ba738623df775a3d, problem is fixed now with fc56579e9d3ef0be4912ff48e38d057d5d608ee5 "Keep GCC 4.6 happy" Conflicts: postprocess/qa/services.cxx Change-Id: If819749d322a0887c1668fbbe563d14e0402ac78
2015-03-25Keep GCC 4.6 happyStephan Bergmann
Change-Id: Iaaab55a9ac1ba8e0550f9cb35ed13489e4e4d851
2015-03-24give this a copy ctorCaolán McNamara
Change-Id: I144679e93e61f1bc19319ebf8893529c164ae0ee
2015-03-24CppunitTest_services: Check that XServiceInfo and .component data matchesStephan Bergmann
Change-Id: I660c261a90d0ce7ace045f97e28808bc924fefd9
2015-02-12Fill in bug IDStephan Bergmann
Change-Id: I9aef1c4e74f296fa06bee98781462dd8138eebe4
2015-02-12Make CppunitTest_services instantiate even more servicesStephan Bergmann
Change-Id: Id9bfb3886e4a9cbc15a7bf7ef3aefa73bd160e3b
2015-02-11add log message about untested servicesMarkus Mohrhard
Change-Id: I3e8da0ae510ce40421767de2bd106d39ec254a17
2014-06-24ReportDefinition is the one that is failing for me under Linux tooCaolán McNamara
Change-Id: I00480813d8c3703039a55a7a706937d33e8e8463
2014-06-12Fix CppunitTest_services on WindowsStephan Bergmann
...by blacklisting the problematic service Change-Id: I524a7c7af2cb374911db7b204021c3d2bcd1fdd6
2014-06-12Avoid Solar Mutex deadlocks when disposing servicesStephan Bergmann
...as test code using gb_CppunitTest_use_vcl is implicitly run with Solar Mutex locked Change-Id: I480b4bcce7c6a94922019679099b0883b3ee1030
2014-06-09Revert "Revert "Make sure to dispose services supporting the XComponent ↵Markus Mohrhard
protocol"" This reverts commit 044be7107a97169e80360c79a9d07bec263ac818. It only works sometimes. Still a deadlock based on a race condition.
2014-06-07Revert "Make sure to dispose services supporting the XComponent protocol"Markus Mohrhard
This reverts commit 4cacc6080e61374fd573fffb3bc2a54968c1b61a.
2014-05-15Make sure to dispose services supporting the XComponent protocolStephan Bergmann
...to e.g. avoid leftover temp files from instantiating com.sun.star.comp.report.OReportDefinition. But dispose all instances only at the very end, to avoid disposing some single-instance services too early. Change-Id: I71fc50e80f4b5d1a1ca16e392725903b079ce2d1
2014-05-08various: sal_Bool->boolNoel Grandin
Change-Id: I30fa5227f30373f95060148f269450d2945c1bb9
2014-04-04Make service unit test easier to debugChris Sherlock
It's sort of hard to break into this function with gdb. Seperating it out makes it a lot easier to work out where things are breaking. Change-Id: If99effd44fe677452ac3c1012b99da7da80c720e Reviewed-on: https://gerrit.libreoffice.org/8844 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-01-14Add more logging so that we have the info even in case of weird crashes.Jan Holesovsky
Change-Id: I5888fb3e1ffa1bfdf9b91c06087ef5b7ccbb82ec
2013-12-19Improve CppunitTest_servicesStephan Bergmann
Change-Id: I4b22ce7e5fa91d5008f72e1f351d25063065ba43
2013-12-18Add a unit test trying to create every available service with default ctor.Matúš Kukan
Change-Id: I79e70aeabdb816eaf7a719d2094034d78d11c90b
generated by cgit (git 2.34.1) at 2025-01-23 21:18:15 +0000