Age | Commit message (Collapse) | Author |
|
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ied831cb5d6645e2696ff2d3d57843fc7a1f82f7e
Reviewed-on: https://gerrit.libreoffice.org/12137
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
|
|
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
|
|
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty()
Change-Id: I9a8f4feab9120d2d9fbf845f305380cda9b263bb
Reviewed-on: https://gerrit.libreoffice.org/11968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
so that it is at least marginally legible
Change-Id: I20882ad77d6488bb1f2b9dc9e91dc47458596b4a
|
|
Change-Id: Id38a9e0bddbf3c9038abbc5de7137ee5d3f39db6
Reviewed-on: https://gerrit.libreoffice.org/11924
Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>
|
|
http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
Change-Id: I5ecefd3e5bf84fea2a8735a44236ed4c86b440c4
Reviewed-on: https://gerrit.libreoffice.org/11950
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9
Reviewed-on: https://gerrit.libreoffice.org/11955
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
JLS, Section 15.18.1.1:
If the reference is null, it is converted to the string "null".
http://docs.oracle.com/javase/specs/jls/se5.0/html/expressions.html#15.18.1.1
Change-Id: Idae09c02b24da38ec6f3475fd0af35ef48a2405b
Reviewed-on: https://gerrit.libreoffice.org/11930
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I4aeb7f58034f8808325639d07aa2dc55959d97a8
Reviewed-on: https://gerrit.libreoffice.org/11932
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iedad24dfbdd60a05a09888f699f2467960f5cbe9
Reviewed-on: https://gerrit.libreoffice.org/11933
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iea1e672e5468b66fd1ba5389bd781f03d0c7f419
Reviewed-on: https://gerrit.libreoffice.org/11931
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
|
|
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
|
|
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
|
|
the instanceof check returns false when passed a null value
Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
|
|
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed
Reviewed-on: https://gerrit.libreoffice.org/11648
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
so that we get a nice complete stacktrace when it hits the final
handler
Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
|
|
Change-Id: I5cdd1fb4fe77c7fc9614f2a6de8995d98d60b551
Reviewed-on: https://gerrit.libreoffice.org/11368
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1a840346e75a3d7dd0de761660a0ea95c7ee034b
Reviewed-on: https://gerrit.libreoffice.org/11370
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I6d3e592de64c63e66bb788b112e188ef217e7bf7
Reviewed-on: https://gerrit.libreoffice.org/11367
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
|
|
found by PMD
Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
|
|
found by PMD
Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
|
|
i.e. stuff like "x == true"
Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
|
|
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
|
|
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
|
|
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
|
|
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
|
|
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
|
|
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
|
|
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
|
|
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
|
|
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
|
|
- remove unused fields
- make all external code go through the get(XXX)
methods instead of also using the default values
- remove default values
declarations and inline them, since they are now unnecessary.
Change-Id: Idc875fbd133de90044647f3e3b1feb225d81a643
|
|
found by UCDetector
Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
|
|
found by UCDetector
Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
|
|
found by UCDetector
Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
|
|
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
|
|
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
|
|
found by UCDetector
Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
|
|
found by UCDetector
Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
|
|
that are not conveying any useful information
Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
|
|
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
|
|
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
|
|
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
|
|
.. actually thrown
Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
|