Age | Commit message (Collapse) | Author |
|
Change-Id: I9f0f98c989cb7ecf6227154e1d81d49abade66c2
|
|
Change-Id: I447c46cc3d66c7f482314626826dd708bf1c01c4
|
|
and adjust/cleanup calling instances
Change-Id: I6b7be34fe6fce0a6fdbf2227f3e565b2f434c88c
Reviewed-on: https://gerrit.libreoffice.org/29221
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I78d207a4be9eeb9ddf1782ed2488c928d9d1744a
Reviewed-on: https://gerrit.libreoffice.org/29222
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Iad1091f3c4363940e956219e1723e159c35ea280
Reviewed-on: https://gerrit.libreoffice.org/29220
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b
Reviewed-on: https://gerrit.libreoffice.org/26202
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
so that we get nice stack traces in our test error logs instead of just
the title of the exception
Change-Id: I47f30d80b9efbc7dbeff7f4456755e416e577b5a
Reviewed-on: https://gerrit.libreoffice.org/25510
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266
Reviewed-on: https://gerrit.libreoffice.org/25420
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and lets see if anyone complains
Change-Id: I0ec236006476064e67cda9869ab45c1860ed351b
|
|
found by UCDetector
Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
|
|
Change-Id: I08955a20e0566f56701bef85a4a9d4de79ca7b1f
|
|
Change-Id: I520235178bc1eaea5e5bc0497ab8824bf2775456
|
|
null pointer dereferencing, added null check
Change-Id: I78f3ee1eb5d5bd4ebe7b3a6775db4884859dbcf6
Reviewed-on: https://gerrit.libreoffice.org/21712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
Change-Id: Ifad565e1548a9564196bfcd7b77d81ebb97231f6
|
|
Change-Id: I150d3df8926a547b8ecf4324303dc4520ee2e899
|
|
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
Change-Id: I1e87d33d12b246aa071d28af3eec69bf79c7bf6f
|
|
Change-Id: Iddf881369ff8a177fba9ebe9a673291a9b8ed431
|
|
Change-Id: I91ae690e26a05dbe4424b7f2ac3bd9ad029ebf5c
|
|
Change-Id: I4bcde379701e8f3542f8e54e59b529466213d72e
|
|
Change-Id: Ia8cff25ac8eb9539b81bdebe2aa52c324d70b357
|
|
and
coverity#1326954 RV: Bad use of return value
coverity#1326955 RV: Bad use of return value
coverity#1326956 RV: Bad use of return value
coverity#1326957 RV: Bad use of return value
coverity#1326958 RV: Bad use of return value
coverity#1326959 RV: Bad use of return value
coverity#1326960 RV: Bad use of return value
coverity#1326961 RV: Bad use of return value
coverity#1326962 RV: Bad use of return value
Change-Id: I02c2f7a5214e348f06a12b78a9400d8501b00e57
|
|
and
coverity#1326611 DE: Dropped or ignored exception
coverity#1326612 DE: Dropped or ignored exception
coverity#1326613 DE: Dropped or ignored exception
coverity#1326614 DE: Dropped or ignored exception
coverity#1326615 DE: Dropped or ignored exception
coverity#1326617 DE: Dropped or ignored exception
coverity#1326618 DE: Dropped or ignored exception
coverity#1326619 DE: Dropped or ignored exception
coverity#1326620 DE: Dropped or ignored exception
coverity#1326621 DE: Dropped or ignored exception
coverity#1326622 DE: Dropped or ignored exception
coverity#1326623 DE: Dropped or ignored exception
coverity#1326624 DE: Dropped or ignored exception
coverity#1326625 DE: Dropped or ignored exception
coverity#1326626 DE: Dropped or ignored exception
coverity#1326627 DE: Dropped or ignored exception
Change-Id: I921a5434a6a116db5033cb2c90a59008c13f1bb2
|
|
Change-Id: I3889453be48aaffc8015fbbb5672d34e904c3770
|
|
...instead of being removed, a9824e8e05bddbf8ec417c7e5447914dd22cb8e5
"cid#1326591, cid#1326590 useless call"
Change-Id: Ia71abff8fb821cb4904794e1f9cbeb320e17c629
|
|
The call does not do anything, removed.
Change-Id: I24e37ec47551f7dc47a4be6f717f95800624500f
Reviewed-on: https://gerrit.libreoffice.org/20392
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and
coverity#1326179 Dereference after null check
Change-Id: I65099a52d8b275655c2de29848f364de0be06161
|
|
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
|
|
the compiler will do it for you
Change-Id: I770670e70a43664a87ce28b48fc822d891d8fb41
|
|
FindBugs' FE.FE_FLOATING_POINT_EQUALITY is about double value inaccuracies, not
about NaN or negative zero (which is the topic of java.lang.Double.equals vs.
==).
Reuse existing qa.TestCaseOldAPI.approxEqual method, moved to util.utils.
Change-Id: I65f7bb1faf921e1c4035bb96aeff1eaf2cfb3153
|
|
When the property type is e.g. a UNO sequence or struct type, !equals would
trivially be always true (as the UNO bridge creates fresh instances of such
value types on the fly), masking failures where the tested code didn't change
the property value at all.
And one such masked failure was
sw.CharacterStyle::com::sun::star::style::CharacterProperties in
JunitTest_sw_unoapi_1 not changing any of the CharLeft/Right/Bottom/TopBorder
properties, as SvxBorderLine::GuessLinesWidths
(editeng/source/items/borderline.cxx) appears to only work properly if nStyle is
DOUBLE, so work around that for now by explicitly setting that BorderLineStyle
in the ValueChanger for BorderLine2.
Change-Id: If9536822c5db04cbd01e6d760b5b63da04c4cf5b
|
|
...lcl_SetTableSeparators (sw/source/core/unocore/unotbl.cxx) when trying to
change the TableColumnSeparators property of
sw.SwXTextTable::com::sun::star::text::TextTable in JunitTest_sw_unoapi_4
Change-Id: I314e3f08eae0b1df6d5c60340e33f34477daf76e
|
|
Change-Id: Ib585408c26e14b83e896861c2793ff3229dba7d1
|
|
...so test code can later reliably check that a newly obtained value is
different from oldValue. (Use copyStruct instead of new, in case the type of
oldValue is derived from the type determined with instanceof.)
Change-Id: I3bcf406e0ca06a710f5d43bd75c0e96ff68dbde4
|
|
...that always have a static UNOTYPEINFO field
Change-Id: Ie70632c47e03897e79c3ddf7087e51c1e67cf086
|
|
Change-Id: I3981037c8383aff65c8b78eb4752c11ddeffc8fd
|
|
Change-Id: Id49af9bc1c767126a365d85589fb4f2a99e5bcdd
|
|
Change-Id: Ied3798a1643c0fa2ca86c9d76fef2dcc270f5b2d
|
|
Change-Id: I9606abbbf92c052a1265957cbb4e2d73070540c5
|
|
Change-Id: I06d167e1f6aebeb6629cbbc7fb90ffed8cec837d
|
|
Change-Id: I120b6cd6908ab4263a3ec3f8318aff8e507ab62b
|
|
Change-Id: Ifa0ffa779aa3dd79f4b41065e33f5cdbf3a89bc9
|
|
Change-Id: Ia8d7ab83caa55920428448e67f95a340add658e7
|
|
Change-Id: I7e78b77642e70a13dcfa71e71f541bed31a4f47a
|
|
Change-Id: I1fdb8b0740c947feced9aec6399313231007dcf8
|
|
Change-Id: I0ecbd7c8b16af7dbd81d9420dfab2edc7ca73493
|
|
Change-Id: I4a443ce900252b171bd028e945971818fb2cc7ef
|
|
Change-Id: I104c778e107259904fa4a830d3685a6506250fbb
|
|
Change-Id: If4bf5978fca921860d44421e17dd4f3d772d1c22
|
|
Change-Id: I1847457bccaa7bd074127395367b080f0b376b12
|