summaryrefslogtreecommitdiff
path: root/qadevOOo/runner
AgeCommit message (Collapse)Author
2015-04-20java: remove some unused codeNoel Grandin
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
2015-04-20java: some random small cleanupsNoel Grandin
Change-Id: I22a5b9fa29d465a21e682279e6e88d37bd8adf93
2015-02-24TyposJulien Nabet
Change-Id: I5f2577dd1f047331a58d33e05684b673e6dbd11e
2015-02-09Fix of a few typosAndrea Gelmini
Change-Id: Ib2a311f0341d165a8f9d3f7a11ec36378fd69519 Reviewed-on: https://gerrit.libreoffice.org/14373 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-01-14LinkUpdateMode property values must be in the range 0--2 or 0--3Stephan Bergmann
...avoid setting bad values from generic qadevOOo property set tests, and throw an IllegalArgumentException if bad values do get set. Found via -fsanitize=enum. The TODO about ScLkUpdMode vs. LinkUpdateModes mismatch looks worrying. Change-Id: Ibc01845e7e3179dc693fe8c59c1f1ffad5282420
2015-01-13css.form.component.{CheckBox,RadioButton} DefaultState property valuesStephan Bergmann
...must be in the range 0--2; avoid setting bad values from generic qadevOOo property set tests, and throw an IllegalArgumentException if bad values do get set. Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
2015-01-13java: inline some test propertiesNoel Grandin
Change-Id: I8be2ee13652ed7223e41765811db577ecc1c85d6
2015-01-13java: nothing is passing in a "ComplexIni" parameterNoel Grandin
Change-Id: Iae7530a52eda020f9074a6de0ef9e4b9779593f6
2015-01-13java: nothing is passing a "-ini" parameter into the RunnerServiceNoel Grandin
Change-Id: Ic8dffc4ed757c74ce383b3dcf204d1c899a0c4f5
2015-01-13java: move DEFAULT_SHORT_WAIT_MS to util.utilsNoel Grandin
so I can turn PopertyNames into an enum Change-Id: I939a83c0962813302a3653e75976147b2300cb18
2015-01-13java: NO_CWS_ATTACH parameter is unusedNoel Grandin
Change-Id: I3e465987ef3dd502faecaf3c5ce151013a5bf314
2015-01-13java: DONT_BACKUP_USERLAYER parameter is unusedNoel Grandin
Change-Id: I2e66a6acfd50b929d43ffdb3e468042875b6b23d
2015-01-12java: simplify command-line parameter parsing in ClParserNoel Grandin
Change-Id: I37790675619b2dde3fe303ba3adc527fc1dfdcf5
2015-01-12java: APP_KILL_COMMAND is unusedNoel Grandin
Change-Id: I4bc4208a80a41a43f9a1145a2e674f37d1333424
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-12java: no need to instantiate the AccessibilityTools objectNoel Grandin
since all of it's methods and fields are static. Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-05java: static fields that should be instance fieldsNoel Grandin
found by FindBugs. Change-Id: I4f457cd8f6f28f0429fc50529c8d38d80b80c560
2015-01-05java: these fields can become local variablesNoel Grandin
found by PMD Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: unused importNoel Grandin
Change-Id: I5e753737a0dfd024da4ce076645a4ddc2e7550e0
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-19java: dead codeNoel Grandin
Change-Id: Ief2bf7d3e98186a2268b873c4c5f7114057bd10f
2014-12-19java: synching on an interned String object not goodNoel Grandin
Just remove this field altogether, it was not being used for anything other than synchronisation. Change-Id: I982385f9eb7aed3fff0adf85d2a37bfe003d937b
2014-12-19java: these fields can be converted to local variablesNoel Grandin
Change-Id: Ifefb5de196a3e5cbaa8945759da42886c69daacf
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12java: remove dead code in qadevOOoNoel Grandin
found by running UCDetector over the code many times, like peeling an onion Change-Id: I54d5147eb1b5c921ad236331bc4c1f765b13ca83 Reviewed-on: https://gerrit.libreoffice.org/13445 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: remove some unnecessary interfacesNoel Grandin
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8 Reviewed-on: https://gerrit.libreoffice.org/13435 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove comment noiseNoel Grandin
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6 Reviewed-on: https://gerrit.libreoffice.org/13408 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some comment noiseNoel Grandin
Change-Id: I51118fecf9de27407b4c5a66cd6577574939e001
2014-11-25java: remove some comment noiseNoel Grandin
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25java: final fields that can be staticNoel Grandin
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24java,qadev: remove unused parameters and local varsNoel Grandin
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873 Reviewed-on: https://gerrit.libreoffice.org/13097 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18java: rather use @Deprecated annotationNoel Grandin
than an empty @deprecated tag Change-Id: I1646ce1c0c8823ac5be0153aeb8eb2b830e7ebfa Reviewed-on: https://gerrit.libreoffice.org/12525 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30java: calling ready() on a BufferedReader is a dodgy way..Noel Grandin
..to detect end-of-file Change-Id: I3b1d5eca3a7424d72b5e3ab741f7407ad7e65193
2014-10-30java: Questionable use of non-short-circuit logicRobert Antoni Buj i Gelonch
Change-Id: Ied831cb5d6645e2696ff2d3d57843fc7a1f82f7e Reviewed-on: https://gerrit.libreoffice.org/12137 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30runner: Dereference of the result of readLine() without nullcheckRobert Antoni Buj i Gelonch
Change-Id: I3d02436446a79137ce42b1a190c9e3985fbb9246 Reviewed-on: https://gerrit.libreoffice.org/12135 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25java: prevent overflow by using 'long int' arithmetic in multiplicationRobert Antoni Buj i Gelonch
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998 Reviewed-on: https://gerrit.libreoffice.org/12001 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19runner: Iterate over each Entry in a MapRobert Antoni Buj i Gelonch
Change-Id: I48de54ea88e7fd9f2d903c172eb2b6e1a5b73edd Reviewed-on: https://gerrit.libreoffice.org/11918 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18java: loss of precissionRobert Antoni Buj i Gelonch
Change-Id: I0563a76b1d2c838e6301bf7a9ed154c77a98c0d9 Reviewed-on: https://gerrit.libreoffice.org/12000 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: when rethrowing exceptions, store the originalNoel Grandin
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
2014-10-16runner: if .. else if .. elseRobert Antoni Buj i Gelonch
Change-Id: If9c07074b60b14d0f4e947754d4bf34e4f2f9676 Reviewed-on: https://gerrit.libreoffice.org/11990 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
generated by cgit (git 2.34.1) at 2025-01-21 09:24:39 +0000