summaryrefslogtreecommitdiff
path: root/qadevOOo/tests/java
AgeCommit message (Collapse)Author
2022-09-02[API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bitMichael Weghorn
With 16k column support in Calc enabled by default in commit 4c5f8ccf0a2320432b8fe91add1dcadf54d9fd58 Date: Tue Mar 8 12:44:49 2022 +0100 change default Calc number of columns to 16384 (tdf#50916) , the number of Calc cells in a spreadsheet is larger than SAL_MAX_INT32, meaning that a 32-bit a11y child index is no more enough and using it resulted in integer overflows in methods handling corresponding Calc cells in the a11y layer. This e.g. had the effect of the Orca and NVDA screen readers not announcing focused or selected cells properly when their a11y child index was out of the 32-bit integer range. Switch the internal a11y child indices to 64 bit to be able to handle this properly internally. Since the platform APIs (at least AT-SPI on Linux and IAccessible2 on Windows; from what I can see LO's macOS a11y bridge doesn't directly expose the child index) are still restricted to 32 bit, larger child indices still cannot be exposed via the platform APIs. As a consequence, use of the the IAccessible2 and AT-SPI methods that use the child index remains problematic in those cases where the child index is larger. However, as an alternative to using the AT-SPI Table interface and the IAccessibleTable/ IAccessibleTable2 interfaces with the child index to retrieve information about a specific cell, both AT-SPI and IAccessible2 also provide interfaces to retrieve that information directly from the cell object (TableCell interface for AT-SPI, IAccessibleTableCell for IAccessible2). Those interfaces are already implemented/exposed for winaccessibility (s. `CAccTable`) and the qt5/qt6/kf5 VCL plugins (s. the `QAccessibleTableCellInterface` methods implemented in `QtAccessibleInterface`). With the switch to 64-bit internal a11y child indices, these now behave correctly for cells with a child index that doesn't fit into 32 bit as well. NVDA on Windows already uses the IAccessibleTableCell interface and thus announcing focused cells works fine with this change in place. Orca on Linux currently doesn't make use of the AT-SPI TableCell interface yet, but with a suggested change to do so [1], announcement of selected cells works with the qt6 VCL plugin with a current qtbase dev branch as well - when combined with the suggested changes to implement support for the AT-SPI TableCell interface in Qt [2] [3] and the LO change based on that [4] and a fix for a nullptr dereference [5]. The gtk3 VCL plugin doesn't expose the AT-SPI TableCell interface yet, but once it does so (via `AtkTableCell`), it also works with the suggested Orca change [1] in place. (Adding that is planned for an upcoming change, works with a local WIP patch.) For handling return values that are larger than what platform APIs support, the following approach has been chosen for now: 1) When the return value is for the count of (selected) children, the maximum value N supported by the platform API is returned. (This is what `ScAccessibleTableBase::getAccessibleChildCount` did previously.) The first N elements can be accessed by their actual (selection) indices. 2) When the return value is the child/cell index, -2 is returned for objects whose index is greater than the maximum value supported by the platform API. Using a non-negative value would mean that the index would refer to *another* actually existing child. A child index of -1 on the other hand tends to be interpreted as "child is invalid" or "object isn't actually a child of its (previous) parent any more)". For the Orca case, this would result in objects with a child index of -1 not being announced, as they are considered "zombies" [6]. What's still somewhat problematic is the case where more than 2^31 children are *selected*, since access to those children still happens by the index into the selection in the platform APIs, and not all selected items are accessible this way. (Screen readers usually just retrieve the first and last element from the selection and announce those.) Orca already seems to apply different handling for the case for fully selected rows and columns, so "All cells selected" or "Columns ... to ... selected" is announced just fine even if more than 2^31 cells are selected. (Side note: While Microsoft User Interface Automation - UIA - also uses 32-bit indices, it also has specific methods in the ISelectionProvider2 interface that allow to explicitly retrieve the first and last selected item, `ISelectionProvider2::get_FirstSelectedItem` and `ISelectionProvider2::get_LastSelectedItem`, but we currently don't support UIA on Windows.) Bound checks at the beginning of the methods from the `XAccessibleContext`, `XAccessibleSelection` and `XAccessibleTable` interfaces that take a child index (or in helper methods called by those) should generally already prevent too large indices from being passed to the methods in the lower layer code that take smaller integer types. Such bound checking has been been added in various places where it wasn't present yet. If there any remaining issues of this kind that show after this commit, they can probably be solved in a similar way (s.e.g. the change to `AccessibleBrowseBox::getAccessibleChild` in this commit). A few asserts were also added at places where my understanding is that values shouldn't be larger than what is supported by a called method anyway. A test case will be added in a following change. [1] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/131 [2] https://codereview.qt-project.org/c/qt/qtbase/+/428566 [3] https://codereview.qt-project.org/c/qt/qtbase/+/428567 [4] https://gerrit.libreoffice.org/c/core/+/138750 [5] https://codereview.qt-project.org/c/qt/qtbase/+/430157 [6] https://gitlab.gnome.org/GNOME/orca/-/blob/82c8542002e36e0d3d918088d583162d25136143/src/orca/script_utilities.py#L5155 Change-Id: I3af590c988b0e6754fc72545918412f39e8fea07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139258 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-27cid#1509234 DCN: Don't Catch NullPointer ExceptionCaolán McNamara
and cid#1509229 DCN: Don't Catch NullPointer Exception Change-Id: I113de964ff07fc771ac64acb8583341cd518d0e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-26cid#1509239 DCN: Don't Catch NullPointer ExceptionCaolán McNamara
and cid#1509234 DCN: Don't Catch NullPointer Exception cid#1509229 DCN: Don't Catch NullPointer Exception cid#1509219 DCN: Don't Catch NullPointer Exception cid#1509216 DCN: Don't Catch NullPointer Exception Change-Id: Iab1512b4e5ecd632104a58b1fc09ef150825f498 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509396 Explicit null dereferencedCaolán McNamara
and cid#1509395 Explicit null dereferenced Change-Id: Ifd8dffe2ff2432ee2f0ef18bb2a480c2f042910b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-18cid#1327197 UwF: Unwritten fieldCaolán McNamara
Change-Id: Ib132101078a67803d21393c875e55f7a7bf8d225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-12Fix typosAndrea Gelmini
Change-Id: I67e6e34265342b56bb922d2d9fc3a3385c8990d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138182 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-08[API CHANGE] Drop css::accessibility::XAccessibleStateSetNoel Grandin
which is internal API, unused (as far as I can tell) by external users. This state is purely a bitset (as implemented by utl::AccessibleStateSetHelper) so we can just return it as a 64-bit value. This shaves significant time off the performance profiles of code that loads very complex shapes, because this state is frequently used, and we no longer need to allocate a return value on the heap for every call. Change-Id: Icf1b3bd367c256646ae9015f9127025f59459c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136786 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-10qa: Fix occlusion check coordinates in _XAccessibleComponent.javaColomban Wendling
This could erroneously skip a check because the child was erroneously deemed obscured by another object. Change-Id: I67d76ea272874671ae328266bdbdeb037c0dc625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133842 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-03-04tdf#45904: Remove ScHeaderFieldObj Java testJens Carl
The ScHeaderFieldObj Java tests are implemented in ScEditFieldObj_Header. Change-Id: I45d3b17bd244090c491c85475f20bc06eb92908f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130953 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2022-03-01tdf#45904 Move XComponent Java test to C++Jens Carl
Move XComponent Jave tests to C++ for ScCellFieldObj_Cell and ScCellFieldObj_Header (formerly ScCellFieldObj). Change-Id: Ibf293a72801720fee49acdda5a3a463e9202bb58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130742 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2022-02-28tdf#45904 Move XElementAccess Java test to C++Jens Carl
Move XElementAccess Java test to C++ for ScHeaderFieldsObj. Change-Id: I1bc29be9f17d117edecfd889b4f9784ffbd74d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130660 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2021-10-11cid#1492820 WMI: Inefficient Map IteratorCaolán McNamara
Change-Id: I2a220d5f8178dc96bb930600d51884c245128324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-09Typo: *adress* -> *address* (except from not translated German parts)Julien Nabet
Change-Id: I62e12aed5bc67119433c39ff333f69b79944dca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123318 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-09Typos in qadevOOo/_NumberingLevel.javaJulien Nabet
Change-Id: Id4ea4b27c527c34f9d4b6b4658486b189f9089c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-09Typo *ropertie -> *ropertyJulien Nabet
Change-Id: Id5ae03140ac4fd67bf4940569ac5cd2f15716749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-17tdf#143550 - use the term "gluepoints" consistentlyrocso
Change-Id: Id10dc2ef13f54a148a800003cc4bd88ca1a0056f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-08-19Fix typosAndrea Gelmini
Change-Id: I45243c6312545d51409574447e27f5320d4da79c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120493 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-05-17split OutputDevice from WindowNoel Grandin
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-19weld SmEditTextWindowCaolán McNamara
reuse the WeldEditAccessible a11y impl and remove the then unused starmath equivalent. Change-Id: I2dc1e0436ffcd0b295e204c21bfcd365dae08bff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-26Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I8945fc73085afb6e4cdfe5083f3732191341a1d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103459 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-26Fix typoAndrea Gelmini
It passed "make check" Change-Id: Ifdea79506b69c316869fff4b78e496a090f77c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103466 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-25remove unused importsNoel Grandin
Change-Id: Ib4a334ad929a410d6a19d1f832b202d61cd29336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-18xmloff: remove dead com.sun.star.comp.Draw.XMLSettingsExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: I2152f32fd798b7a7df7086b125e77fe804185157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102973 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-11xmloff: remove dead com.sun.star.comp.Draw.XMLContentExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisContentExporter instead in JunitTest_xmloff_unoapi. Change-Id: I22bf816d08bcd04b277e461a5055883b730811b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102401 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-04xmloff: remove dead com.sun.star.comp.Draw.XMLStylesExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: I04eb38aad193dfbfde5df42f3e367aa47dfd12ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102019 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-30Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id837205b0e6a7efa091a5b9ead75d767ceddcefa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101598 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-30Fix typosAndrea Gelmini
Change-Id: I041e65166eab9fc497742635fe59e11f63d55c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-30Fix typo in codeAndrea Gelmini
Change-Id: I84b15806a01b7a7ce6c10274ee066b4256a2e7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-23Fix typo in codeAndrea Gelmini
Change-Id: I9a81d265a99aee896a71c14e3a3ee6ba863b4d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101199 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I88f0562699c99730c29e269845d5b5e5e31953a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101121 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typosAndrea Gelmini
Change-Id: I8dc0cdcfe6bd90efc596df28e6c6d968b92618b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101098 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I6e3b4ca90b88e192e8fde29c578d29fdd42093f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101122 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I9762e33948af64067f25add657f4a64cd19bd467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101120 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-14xmloff: remove dead com.sun.star.comp.Draw.XMLMetaExporterMiklos Vajna
And test com.sun.star.comp.Draw.XMLOasisMetaExporter instead in JunitTest_xmloff_unoapi. Change-Id: I1cd485378097b094e6773a7c37798b9aadf3070f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100687 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-07xmloff: remove dead com.sun.star.comp.Impress.XMLSettingsExporterMiklos Vajna
And test com.sun.star.comp.Impress.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Impress.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: Ibca21fddc051253adef40df6f1da584c23b4423d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100269 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-24xmloff: remove dead com.sun.star.comp.Impress.XMLContentExporterMiklos Vajna
And test com.sun.star.comp.Impress.XMLOasisContentExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Impress.XMLContentExporter line, but let's not regress even more in that code. Change-Id: I5bbffaf512ea803c9265050cbe587f2e9743f09b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99336 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-17xmloff: remove dead com.sun.star.comp.Impress.XMLStylesExporterMiklos Vajna
And test com.sun.star.comp.Impress.XMLOasisStylesExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Impress.XMLStylesExporter line, but let's not regress even more in that code. Change-Id: I7912ce45421b9a2d5209696c6ec4074b15111f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98930 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-26xmloff: remove dead com.sun.star.comp.Impress.XMLMetaExporterMiklos Vajna
And test com.sun.star.comp.Impress.XMLOasisMetaExporter instead in JunitTest_xmloff_unoapi. Change-Id: Iec2da56b569c283686de1bd4aad5fb7ebebfbc2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97183 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-22Fix typosAndrea Gelmini
Change-Id: I49d7dc8a2cbcba5413d05d97559321e672ed413a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92655 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-27tdf#45904 Move XNameContainer Java tests to C++Jens Carl
Move missing XNameContainer Java tests to C++ for ScTableSheetsObj. Change-Id: I63a91487ab2e50b97c937edae929c43261553db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89614 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-17Fix typoAndrea Gelmini
Change-Id: I74b65394367a11a07d104bfbab6afbfe49919b3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88336 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-09Fix typoAndrea Gelmini
Change-Id: I0e9155804a79e0eb97b86f4cfe930e4a0185dd61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88337 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-09Fix typoAndrea Gelmini
Change-Id: I0a56f044b24158e2b44bb3550a97ea6bc21d3feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88317 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-06cid#1458159 Dereference after null checkCaolán McNamara
Change-Id: I5ec0f9571f3b551e716899cc86a57c2c91369641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06cid#1458158 Dereference before null checkCaolán McNamara
Change-Id: I6fbcbce28cbd472a48556ba107e604a09c8cbe30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06cid#1458157 Dereference before null checkCaolán McNamara
Change-Id: I36317f40a789cfb5915bd92cca75c01e4e53a782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19Fix typoAndrea Gelmini
Change-Id: Ic6ec67b7a13506c6242b2863360b065724844c5a Reviewed-on: https://gerrit.libreoffice.org/85520 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-05Fix typoAndrea Gelmini
Change-Id: Ibd0595eafc364b6e7ebc9a90e7c4a79d8a15d9d8 Reviewed-on: https://gerrit.libreoffice.org/84487 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-17Fix typoAndrea Gelmini
Change-Id: I59877df3c75d8423ae81a7d877b3144e65526253 Reviewed-on: https://gerrit.libreoffice.org/83007 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-16cid#1448447 silence RV: Bad use of return valueCaolán McNamara
Change-Id: If24d5fffb4ecf86fa6a43d824b5e40fcef29a691 Reviewed-on: https://gerrit.libreoffice.org/82995 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-21 00:50:54 +0000