summaryrefslogtreecommitdiff
path: root/qadevOOo
AgeCommit message (Collapse)Author
2017-01-24AccStatisticsObject is apparently dead codeStephan Bergmann
Change-Id: I4e04b13538d1242ea38d1400df0ced813171bc5e
2017-01-21coverity#1399435 Unused valueCaolán McNamara
and coverity#1399438 Unused value coverity#1399439 Unused value its all ok as it was, but doesn't hurt to skip the exception test if the previous test failed anyway Change-Id: I110ac062d72514c51d415944a2250c3095584531
2017-01-21coverity#1399443 UrF: Unread fieldCaolán McNamara
fix like... commit b9d63d49be66ed1bfc4a76924f1c52ec3630adc8 Date: Tue Jan 12 15:27:41 2016 +0200 remove some unused Java code found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df Change-Id: I5ce651905edbba3f23ebb421ebc0acadd54f39cf Reviewed-on: https://gerrit.libreoffice.org/33379 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21coverity#1399442 UPM: Private method is never calledCaolán McNamara
since commit 10cb59eb914ba722c203242272de244d795a51e8 Date: Mon Jan 16 16:41:53 2017 +0200 remove some unused Java code Change-Id: I00c0b1b22f29165fea73b39b4bf946af453186a3 Reviewed-on: https://gerrit.libreoffice.org/33378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21coverity#1399444 UwF: Unwritten fieldCaolán McNamara
and coverity#1399441 NP: Null pointer dereference since commit 10cb59eb914ba722c203242272de244d795a51e8 Date: Mon Jan 16 16:41:53 2017 +0200 remove some unused Java code Change-Id: Ieab0325c8685cdc89458570ac8e4d3292af84dff Reviewed-on: https://gerrit.libreoffice.org/33377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21this.cmdLine assigned twiceCaolán McNamara
Change-Id: Icbc2393ac623d76c3ca5ae74525705f784b99c1c
2017-01-17cid#1398822: java.util.Properties.getProperty already returns StringStephan Bergmann
Change-Id: I056bffbdd0e3280bfbcfbb82aff73fb5bab8a0b7
2017-01-17remove some unused Java codeNoel Grandin
Change-Id: Ia1663256fc0b92c343ea4ba55a821c969077a0aa Reviewed-on: https://gerrit.libreoffice.org/33174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-16qadevOOo: remove silly exception catching from util.FormToolsMichael Stahl
What's the point of catching an exception and then continuing onwards in a unit test? Change-Id: I100dfcaa9a4fdd5398cf4ac38426ec4397451b8e
2017-01-16forms,qadevOOo: dispatch of .uno:SwitchControlDesignMode is asyncMichael Stahl
Follow-up to e19cdeaf7ddbcf39da47d9685d8e79e775dde7f4. Change-Id: Ic4f8f0373199a4237fa30a830fc89a263eb40d62
2017-01-16boil down the use of OPERATING_SYSTEM to its unorc/uno.ini useCaolán McNamara
Change-Id: I9f0f98c989cb7ecf6227154e1d81d49abade66c2
2017-01-04SwXAutoTextEntry needs a disposal protocolStephan Bergmann
SwXAutoTextEntry::GetBodyText calls SwGlossaries::EditGroupDoc to create a Sw[Web]GlosDocShell (which it then stores in xDocSh), and there must be a call to that shell's DoClose to clean up its resources. However, if a reference to the SwXAutoTextEntry is still held during XDesktop::terminate (as can happen in JunitTest_sw_unoapi_1, where such a reference is held from Java, thus arbitrarily delaying destruction of the SwXAutoTextEntry until the JVM does GC), SwXAutoTextEntry::Notify's PrepareCloseDoc case will release xDocSh without calling DoClose, so an eventual ~SwXAutoTextEntry will not call DoClose either. (And calling DoClose from withing SwXAutoTextEntry::Notify would cause a crash, as it would destroy the SwGlosDocShell recursively from within its SfxBroadcaster::Broadcast call.) So introduce a disposal protocol for XAutoTextEntry and call it at least in the place that caused the resource leak in JunitTest_sw_unoapi_1. For lack of a better inerface, reuse css.lang.XComponent for that protocol, even though this scenario doesn't involve breaking cyclic references among UNO objects caused by listener patterns. Change-Id: Id6501b84e562950e40b83e0b1afd1b3184807856
2016-12-31Dispose XWindow when doneStephan Bergmann
Change-Id: Ia71b4f1c9963ab3aa52f05dd98e9215d69b5402e
2016-12-12update png locations for various imagelist unwindingsCaolán McNamara
Change-Id: Ib0106c3b88cf54e54aaf784bb526480a1c745a1f
2016-12-07Fix typo in comments: et -> edTakeshi Abe
Change-Id: I447c46cc3d66c7f482314626826dd708bf1c01c4
2016-10-27Add link to bug describing such a raceStephan Bergmann
Change-Id: Idd3e325c1240905649e04333fadcde9ac4a4ad0f
2016-10-27untabifyStephan Bergmann
Change-Id: I090f63d93166de9bee2527e0e75248916204be5a
2016-10-10Remove no longer relevant qadevOOo/qaSamuel Mehrbrodt
Change-Id: Ic1cee9e61d31a6ee8f248c7e976c5eca8e0d86bd Reviewed-on: https://gerrit.libreoffice.org/29233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I9701cc93a9f4315e71c133237fdd96ef6964c8ff Reviewed-on: https://gerrit.libreoffice.org/29438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29tdf#95386 Remove remaining mentions of Help AgentGabor Kelemen
Replace it with the Help on Help command Change-Id: Ia454a2f6a123b4fb68fda1eae1e07e99ba81487f Reviewed-on: https://gerrit.libreoffice.org/29381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-09-23qadevOOo: Remove unused importsSamuel Mehrbrodt
Change-Id: I5295ba9af550d14f56f218765d43ce01a8177247 Reviewed-on: https://gerrit.libreoffice.org/29223 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23Make createDesktop return XDesktop, not ObjectSamuel Mehrbrodt
and adjust/cleanup calling instances Change-Id: I6b7be34fe6fce0a6fdbf2227f3e565b2f434c88c Reviewed-on: https://gerrit.libreoffice.org/29221 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23Handle exceptionSamuel Mehrbrodt
Change-Id: If295d9a6106c0d03313c80464134e060da72bf53 Reviewed-on: https://gerrit.libreoffice.org/29224 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23Remove duplicate commentSamuel Mehrbrodt
Change-Id: I78d207a4be9eeb9ddf1782ed2488c928d9d1744a Reviewed-on: https://gerrit.libreoffice.org/29222 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23Remove nonsense commentsSamuel Mehrbrodt
Change-Id: Iad1091f3c4363940e956219e1723e159c35ea280 Reviewed-on: https://gerrit.libreoffice.org/29220 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-17Fix JUnit test case for AccessibleFixedTextLuke Deller
This test case was failing on platforms where the default font does not fit inside the default size of a fixed text control (hard coded to be 12px high in UnoFixedTextControl's constructor) - Adjust the test case to explicitly set the text control's size to its preferred size. - Re-enable this checking on Mac OS X, where it had been disabled in 2013 due to this issue Change-Id: I469a733f0a2719c60564d61c89bb64ab3ab622ba Reviewed-on: https://gerrit.libreoffice.org/28961 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-08-19coverity#1371338 Dereference null return valueCaolán McNamara
Change-Id: Id03176fc5d7870e257f2a7c48bea56d8e80035a6
2016-08-19coverity#1371454 DE: Dropped or ignored exceptionCaolán McNamara
Change-Id: I324fe2b2cb2b5874b183fa9685d969708c345b39
2016-08-19Resolves: coverity#1371451 Useless callCaolán McNamara
seems to be broken since... commit 74bd852583566fdfc7e2e35f8f9bd0ad1c821ecb Author: Stephan Wunderlich <sw@openoffice.org> Date: Fri Jan 31 13:48:01 2003 +0000 CHG: using AnyConverter instead of simple cast Change-Id: I005618f32ac50d3601e9ad0b790f37c08ba073ce
2016-08-10tdf#67647 getStructuredFilter returns operatorFabio Buso
Change-Id: I010ea3c24b4d5411711a93e35d4b173f5bde9e55 Reviewed-on: https://gerrit.libreoffice.org/28000 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-07-20add test for css::sheet::SpreadsheetDocumentSettings Wildcards propertyEike Rathke
Though many other optional properties since OOo3 are also missing, is adding this even worth it? Change-Id: I72eeb3e55c6464b0e46e484177a773b2188846b0
2016-07-11Fix typosAndrea Gelmini
Change-Id: I81671c9a8e7e5b878e605ac0ed6c3d8ef5c5b689 Reviewed-on: https://gerrit.libreoffice.org/27088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-07-04typo: emtpy → emptyChristian Lohmaier
Change-Id: I60cdcdc7fc38c175243c071f34295efa8739b717
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-13Fix typosAndrea Gelmini
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-06remove unused imports in java codeNoel Grandin
Change-Id: I95041f49dd22ba9a15da3598b04a010eecf761a8
2016-05-27improve exception throwing in java class util.utilsNoel Grandin
so that we get nice stack traces in our test error logs instead of just the title of the exception Change-Id: I47f30d80b9efbc7dbeff7f4456755e416e577b5a Reviewed-on: https://gerrit.libreoffice.org/25510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Fix typosAndrea Gelmini
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-01Fix typos in codeAndrea Gelmini
Change-Id: I24f7b812fe625f3d91a49fb57701a36a8c68eb36 Reviewed-on: https://gerrit.libreoffice.org/24542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typosAndrea Gelmini
Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256 Reviewed-on: https://gerrit.libreoffice.org/24543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-15remove the office close timeout in subsequentcheckNoel Grandin
and lets see if anyone complains Change-Id: I0ec236006476064e67cda9869ab45c1860ed351b
2016-03-14remove some unused Java codeNoel Grandin
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-06coverity#1326576 Useless callCaolán McNamara
Change-Id: I1d51b96042f229de42ed26d90ecc2a070eb5b3a6
2016-03-04cid#1327083 SWL: Sleep with lock heldStephan Bergmann
It's unclear to me why the disposeOffice method was marked "synchronized" in the first place with fbd72be142ed23b3b526c8d0c3e002f15ca7ec74 "INTEGRATION: CWS qadev16: #114831#." Maybe just some cluelessness? Lets see whether we ever run into any problems after removing it. Change-Id: I1f262b6b4b4f4e8911754a6b3fa3d61f5df0aeae
2016-03-01coverity#1327140 UrF: Unread fieldCaolán McNamara
Change-Id: Iab2d56eae3d068db7347a486e848a1bedb917034
2016-02-20coverity#1326436 Dereference null return valueCaolán McNamara
Change-Id: I40f73b48757e81ac4e1b5374bef4fea334ca8d0a
2016-02-16coverity#1327140 UrF: Unread fieldCaolán McNamara
Change-Id: Ide851a6d015a61603b6bff90e52a20d43bf98198
generated by cgit (git 2.34.1) at 2024-08-04 00:34:11 +0000