summaryrefslogtreecommitdiff
path: root/qadevOOo
AgeCommit message (Collapse)Author
2015-11-05java: combine nested if statementsNoel Grandin
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-05java:no need to explicitly create these constructorsNoel Grandin
the compiler will do it for you Change-Id: I770670e70a43664a87ce28b48fc822d891d8fb41
2015-11-05java:avoid empty if statementsNoel Grandin
Change-Id: I9c66dd5331f422d8d6271157fece2b346d8b3756
2015-11-05coverity#1326925 silence Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: I4d71640baa3c169fba069ca1328273fb78964541
2015-11-05coverity#1326578 Useless callCaolán McNamara
Change-Id: Ib6f7463d97e9c835b2c9d64fa498efd546360645
2015-11-05coverity#1326577 Useless callCaolán McNamara
Change-Id: I3f9742cafdcdce3302c925a2227da1f7839c80c3
2015-11-05coverity#1326879 FE: Test for floating point equalityCaolán McNamara
and coverity#1326880 FE: Test for floating point equality coverity#1326881 FE: Test for floating point equality coverity#1326882 FE: Test for floating point equality coverity#1326883 FE: Test for floating point equality coverity#1326884 FE: Test for floating point equality coverity#1326885 FE: Test for floating point equality coverity#1326886 FE: Test for floating point equality coverity#1326887 FE: Test for floating point equality coverity#1326888 FE: Test for floating point equality Change-Id: I04a00035d541ea7a253a37d2a87c4dc407228346
2015-11-04Proper fix for coverity#1326893Stephan Bergmann
FindBugs' FE.FE_FLOATING_POINT_EQUALITY is about double value inaccuracies, not about NaN or negative zero (which is the topic of java.lang.Double.equals vs. ==). Reuse existing qa.TestCaseOldAPI.approxEqual method, moved to util.utils. Change-Id: I65f7bb1faf921e1c4035bb96aeff1eaf2cfb3153
2015-11-04coverity#1326893 silence FE: Test for floating point equalityCaolán McNamara
Change-Id: I8a0b657942cbe3de559a6b115fad2229490f8985
2015-11-04coverity#1326592 Useless callCaolán McNamara
Change-Id: I82350eab9ccfa331ada54a26f257d22bfcf6c8d8
2015-11-04coverity#1326554 Dereference before null checkCaolán McNamara
Change-Id: Ib17eb78f4790880945a82ecff54d94528993bb22
2015-11-04coverity#1326555 Dereference before null checkCaolán McNamara
Change-Id: If684189efc0ebba70c283f18ee8bd95b63be3557
2015-11-04coverity#1326227 Dereference after null checkCaolán McNamara
Change-Id: I9cf946c24ad867ce5f2a2a476dbd1d9df473c1aa
2015-11-04coverity#1326220 Dereference after null checkCaolán McNamara
Change-Id: I85d82f2c0a1c0ef8c123d9ba1a197e06cd76b92c
2015-11-04coverity#1326219 Dereference after null checkCaolán McNamara
Change-Id: I76bb111d01cfbb72b707cedc3706d02922991dc7
2015-11-04coverity#1326557 Dereference before null checkCaolán McNamara
Change-Id: I6923585dae30fb1fb2b0a7ce1a2d9d104b42ebc7
2015-11-04coverity#1326556 Dereference before null checkCaolán McNamara
Change-Id: I250a03387dd714d844019b363e3be1f2e2ed6a20
2015-11-04coverity#1326264 Dereference after null checkCaolán McNamara
Change-Id: I0623ecb8e9737e117f3db183d5aee7be5a405abf
2015-11-04coverity#1326301 Explicit null dereferencedCaolán McNamara
and coverity#1326561 Dereference before null check Change-Id: I53d1e99ee05dd8d32a7fadc870344391647f3b9d
2015-11-04coverity#1326296 Dereference after null checkCaolán McNamara
Change-Id: I0438dba50a9842e67ebeef872e27e6006871020f
2015-11-04coverity#1326558 Dereference before null checkCaolán McNamara
Change-Id: Id0ed896b36293703c39d61cad6d74871ef16a806
2015-11-04coverity#1326580 Useless callCaolán McNamara
Change-Id: I85a469a482ab0d7c1f897dd8f9fb809f1e55a7c2
2015-11-04coverity#1327152 UrF: Unread fieldCaolán McNamara
Change-Id: I8a5418907570a53c2aaf88fc20458559b5bbf40e
2015-11-04coverity#1326546 Dereference before null checkCaolán McNamara
Change-Id: I2f91ca0876e52a2480a2d6a3098f570b32e7d07a
2015-11-04coverity#1328489 SIC: Inner class could be made staticCaolán McNamara
Change-Id: Icca5032f27a25e3e67e821aa338c428687249ba2
2015-11-04coverity#1327066 SIC: Inner class could be made staticCaolán McNamara
Change-Id: I26d5a42cd52b442cc5ba9947b39508f4695adffa
2015-11-041327065 SIC: Inner class could be made staticCaolán McNamara
Change-Id: I05e24d706679ae8e17fb382837e4edfe69e3b96d
2015-11-04coverity#1327111 UrF: Unread fieldCaolán McNamara
Change-Id: I8013eb660ab0d2cd159a8a30277be6552089e428
2015-11-04coverity#1327106 UrF: Unread fieldCaolán McNamara
Change-Id: I36ccf3fdf17e409c15e0e75ac4964d31781699a3
2015-11-04coverity#1327103 UrF: Unread fieldCaolán McNamara
Change-Id: I0b0d71f86343b45fafdc8c2648f4667456e6bcd4
2015-11-04coverity#1327103 UrF: Unread fieldCaolán McNamara
Change-Id: I31fdf38a9a62c4bf92286509c973fe4e7273b643
2015-11-04coverity#1327096 UrF: Unread fieldCaolán McNamara
Change-Id: I5d6fb9c9bbec5b17e764677b34cfa4a9e2f4ceb6
2015-11-04coverity#1327095 UrF: Unread fieldCaolán McNamara
Change-Id: I297f4495a64d0fb32c7a07841668006c4f3f5ed6
2015-11-04coverity#1327093 UrF: Unread fieldCaolán McNamara
Change-Id: Ia6d9fbc90f526603f8dc1aff72d5cba9ed9a2d76
2015-10-30coverity#1326573 Unused valueCaolán McNamara
Change-Id: I72f70f8f0e01cdd59c2086244f328a007563adbd
2015-10-30coverity#1326230 Dereference after null checkCaolán McNamara
Change-Id: I463ad43a31b870e6e67720089514337336e6015e
2015-10-30coverity#1327153 UrF: Unread fieldCaolán McNamara
Change-Id: Ia5d4957b7b47ec103e2af0136ea8d40f21a0a4cf
2015-10-30coverity#1326927 silence Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: I2973ab6cd021e4a36f11ae97d926faca77ea42be
2015-10-28coverity#1326106 Missing call to superclassCaolán McNamara
Change-Id: I546d3a1be35c627b4fe36972620eefd4ee099e7f
2015-10-28coverity#1326926 NS: Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: Iceccb42d7e65abe012411fd61b3c69145d91f17a
2015-10-28coverity#1326924 NS: Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: I99aba91939af31837923d2e2e3ca4814178449dc
2015-10-25coverity#1326137 Logically dead codeCaolán McNamara
Change-Id: Ib0dcae05793927ecca4e8031e66b6ca1bf4721f7
2015-10-25coverity#1326136 Logically dead codeCaolán McNamara
Change-Id: I17c0f7e22e63823c16ebcdc1db1e4f618aad22a1
2015-10-25coverity#1328719 SIC: Inner class could be made staticCaolán McNamara
Change-Id: I88188482af59bb94f1869a1ad4fb3c72c71789b7
2015-10-25Remove Seamonkey based address book driverDavid Ostrovsky
Seamonkey based address book driver is based on pre-compiled libraries and is only used on Windows 32 bit. Remove it in favor of mork driver. Given that Seamonkey based mozab driver also provides Outlook and Outlook Express address book integration, that Windows-32-bit--only feature is lost for now. If necessary, support for that feature could be rewritten from scratch, in a way that would also work for Windows 64 bit. Change-Id: Ie1c125e692598bda999767c328c9e2262a2b82af Reviewed-on: https://gerrit.libreoffice.org/19560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-22coverity#1326738 Dm: Dubious method usedCaolán McNamara
Change-Id: Ia266e5c1b66e35fdb4c6fdd5816f3b35d54ae1bd
2015-10-22These places apparently want to unbox a value boxed as an AnyStephan Bergmann
...same as 8fb3808f555ad5b5c66cb894f9402647ca9ba341 Change-Id: If21d6bbf5f88b8ca5ed5387d98b2dd9c74f0e32c
2015-10-22No need to check for non-null hereStephan Bergmann
...as null values are handled just fine by compare() Change-Id: Ifd17b96187ad3d13be99b107d3c3fa47e51b586e
2015-10-22Fix the test for resValue != oldValueStephan Bergmann
When the property type is e.g. a UNO sequence or struct type, !equals would trivially be always true (as the UNO bridge creates fresh instances of such value types on the fly), masking failures where the tested code didn't change the property value at all. And one such masked failure was sw.CharacterStyle::com::sun::star::style::CharacterProperties in JunitTest_sw_unoapi_1 not changing any of the CharLeft/Right/Bottom/TopBorder properties, as SvxBorderLine::GuessLinesWidths (editeng/source/items/borderline.cxx) appears to only work properly if nStyle is DOUBLE, so work around that for now by explicitly setting that BorderLineStyle in the ValueChanger for BorderLine2. Change-Id: If9536822c5db04cbd01e6d760b5b63da04c4cf5b
2015-10-22Change TableColumnSeparator in a way that makes it successfully pass...Stephan Bergmann
...lcl_SetTableSeparators (sw/source/core/unocore/unotbl.cxx) when trying to change the TableColumnSeparators property of sw.SwXTextTable::com::sun::star::text::TextTable in JunitTest_sw_unoapi_4 Change-Id: I314e3f08eae0b1df6d5c60340e33f34477daf76e