summaryrefslogtreecommitdiff
path: root/qadevOOo
AgeCommit message (Collapse)Author
2015-12-30coverity#1326985 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I05d12ace635cc780e59a02d79265ac057cb07c0f
2015-12-30coverity#1326986 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: Id41f84e66a3f1b85f5003a7f3aa58c88f74158a7
2015-12-30coverity#1326987 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: Ic84808388bf0b606ac0eb82f33b10ccfe334e7dc
2015-12-30coverity#1326988 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: Ic960361b04e76c610a0302ada6a7f606afeae798
2015-12-30coverity#1326889 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: Ie572d3f8aab49de491b54c206de8dda01fc1fcaa
2015-12-30coverity#1326990 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I401d93ac2527409e44f908984632232768b1e4c0
2015-12-30coverity#1326991 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: I0b81716a1bdd2ef91bbc7280c92713afe0fbab18
2015-12-30coverity#1326992 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: Ia36048489c3e8ac131c7e20701f5b18270156c2a
2015-12-30coverity#1326993 SBSC: String concatenation in loop using + operatorCaolán McNamara
Change-Id: Ie29933018d22b6a936a429b2fd38b05b3959d8e9
2015-12-21coverity#1326924 NS: Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: I2450cdd6e74e1ebab13c61f3a88668df412f6a61
2015-12-21coverity#1326926 NS: Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: I16c0d0b19290d59089a11eb660aa23fa8b03535c
2015-12-19coverity#1326953 RV: Bad use of return valueCaolán McNamara
and coverity#1326954 RV: Bad use of return value coverity#1326955 RV: Bad use of return value coverity#1326956 RV: Bad use of return value coverity#1326957 RV: Bad use of return value coverity#1326958 RV: Bad use of return value coverity#1326959 RV: Bad use of return value coverity#1326960 RV: Bad use of return value coverity#1326961 RV: Bad use of return value coverity#1326962 RV: Bad use of return value Change-Id: I02c2f7a5214e348f06a12b78a9400d8501b00e57
2015-12-14coverity#1327144 UrF: Unread fieldCaolán McNamara
since commit 7650a60b577f0f4f439d94cd73779e5f5915a2cf Author: Stephan Wunderlich <sw@openoffice.org> Date: Mon Feb 3 15:42:43 2003 +0000 CHG: removed obsolete lines Change-Id: Ic03a2619a974005bbd2a60326a3dddb8cc394f83
2015-12-14coverity#1327146 UrF: Unread fieldCaolán McNamara
Change-Id: Ie840cc41ed2c57da3793bdf370ed828242febceb
2015-12-14coverity#1327150 UrF: Unread fieldCaolán McNamara
Change-Id: I70e241933b899b00bc4a3a959c900f284e6ec1ac
2015-12-14coverity#1327151 UrF: Unread fieldCaolán McNamara
Change-Id: Iea1398d6c261659843d060fb0128f7a404beafb7
2015-12-14coverity#1327160 UrF: Unread fieldCaolán McNamara
Change-Id: Ieef22ee987d486a8d7f994900a1f5fd61b0d8cce
2015-12-14coverity#1327161 UrF: Unread fieldCaolán McNamara
since commit 6eda3212ab539c2b5b37accf3a96ab100a79156a Author: Vladimir Glazounov <vg@openoffice.org> Date: Tue Nov 21 13:12:59 2006 +0000 INTEGRATION: CWS qadev27 (1.5.20); FILE MERGED 2006/06/26 07:05:08 cn 1.5.20.1: #i66737# enhancements on property 'NumberingRuels'. Now the test checks also of correct XIndexReplace values Change-Id: I7e4a59e9b6d7cce044269af37f47fe75b65c56f7
2015-12-11cid#1326581-8 useless calls. jan iversen
Rebuild the type check to one set of "or" and a throw Change-Id: I99bf688bdf60c357be4cc5dcd9b7be2532b6fbdb Reviewed-on: https://gerrit.libreoffice.org/20491 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2015-12-11cid#1326589 useless call jan iversen
Removed function call, the function changes nothing or controls anything Change-Id: Ia243c31134ee5a32d50140faf8e64f55b30c218f Reviewed-on: https://gerrit.libreoffice.org/20493 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2015-12-10coverity#1326610 DE: Dropped or ignored exceptionCaolán McNamara
and coverity#1326611 DE: Dropped or ignored exception coverity#1326612 DE: Dropped or ignored exception coverity#1326613 DE: Dropped or ignored exception coverity#1326614 DE: Dropped or ignored exception coverity#1326615 DE: Dropped or ignored exception coverity#1326617 DE: Dropped or ignored exception coverity#1326618 DE: Dropped or ignored exception coverity#1326619 DE: Dropped or ignored exception coverity#1326620 DE: Dropped or ignored exception coverity#1326621 DE: Dropped or ignored exception coverity#1326622 DE: Dropped or ignored exception coverity#1326623 DE: Dropped or ignored exception coverity#1326624 DE: Dropped or ignored exception coverity#1326625 DE: Dropped or ignored exception coverity#1326626 DE: Dropped or ignored exception coverity#1326627 DE: Dropped or ignored exception Change-Id: I921a5434a6a116db5033cb2c90a59008c13f1bb2
2015-12-08Clean up compareObjectsStephan Bergmann
Change-Id: I3889453be48aaffc8015fbbb5672d34e904c3770
2015-12-08These compare* calls shall most likely update resultStephan Bergmann
...instead of being removed, a9824e8e05bddbf8ec417c7e5447914dd22cb8e5 "cid#1326591, cid#1326590 useless call" Change-Id: Ia71abff8fb821cb4904794e1f9cbeb320e17c629
2015-12-08cid#1326591, cid#1326590 useless calljan iversen
The call does not do anything, removed. Change-Id: I24e37ec47551f7dc47a4be6f717f95800624500f Reviewed-on: https://gerrit.libreoffice.org/20392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-24coverity#1327143 UrF: Unread fieldCaolán McNamara
Change-Id: Iff1a546cca83fed6fc81836e447bc30d68969274
2015-11-24coverity#1326596 Useless callCaolán McNamara
Change-Id: I9aff17d367ba48609067abdb2a5fb5111daee38c
2015-11-24coverity#1326597 Useless callCaolán McNamara
Change-Id: I4f51d49a18adf76a741d55d67ed3ba2a7a2cc439
2015-11-24coverity#1326892 FE: Test for floating point equalityCaolán McNamara
Change-Id: I47b9ccf2685bd0f37ee2722e93fad9ed668c3b81
2015-11-24coverity#1326891 FE: Test for floating point equalityCaolán McNamara
Change-Id: I5cf13dfb5e085684b333c47d6bee73f92b758e81
2015-11-24coverity#1326890 FE: Test for floating point equalityCaolán McNamara
Change-Id: I767df959a9b8d9845cb56a34538707c599f82849
2015-11-19qadevOOo: sadly XToolkit::processEventsToIdle doesn't fix...Michael Stahl
... the ScAccessiblePreviewTable test, somehow the event still doesn't fire in time, let's add an arbitrary sleep too. Change-Id: I97ab658e61b33455e8623ba0fd861e2018aa3af6
2015-11-17qadevOOo: fix race in the ScAccessiblePreviewTable event testMichael Stahl
XAccessibleEventBroadcaster::addAccessibleEventListener test calls the fireEvent() and the problem is that the event is triggered not on the print preview itself, but some toolbar button. This then causes an accessible event to be broadcast from the print preview too, but only after doAccessibleAction() returns, some time later from VCL main-loop. If the test checks the flag in the listener before the main thread sends the event, the test fails; try to fix that with XToolkit::processEventsToIdle(). Change-Id: Ia52bdf99cdc349ffb0a03536fba271b792caae0f
2015-11-17remove vestigial Adabas D references in tests etc.Michael Stahl
Adabas D connector was removed in 8256eb0205fcddb79a67be13d6507b2653ff5e08 Change-Id: Ie142763ac32728c1596c196d919cbe84e6735c96
2015-11-12coverity#1326178 Dereference after null checkCaolán McNamara
and coverity#1326179 Dereference after null check Change-Id: I65099a52d8b275655c2de29848f364de0be06161
2015-11-09cid#1326599, cid#1326598: added throw (status generation)jan iversen
Status.failed( ... ); is prepended with a throw added import and removed the return; Change-Id: I73bc971e054c8726e45db0d5a37613c871691eab Reviewed-on: https://gerrit.libreoffice.org/19793 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-06coverity#1326268 Dereference after null checkCaolán McNamara
Change-Id: I3b744c5141a3217822cf4617a30d4f6368e76dd9
2015-11-06coverity#1326298 Dereference after null checkCaolán McNamara
Change-Id: Ia260697264fbb087ca827b409dea800ca2514c6e
2015-11-06coverity#1326563 Dereference before null checkCaolán McNamara
Change-Id: I198f6a0ee1070b5aec475d55de437d7c9f5b281c
2015-11-06coverity#1326562 Dereference before null checkCaolán McNamara
Change-Id: I3f24c355e57fddf36e5af141bf10d43e72257f4f
2015-11-06coverity#1326560 Dereference before null checkCaolán McNamara
Change-Id: Id4892ad9cfe53f00d8b20babd34ae46807ce833b
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: combine nested if statementsNoel Grandin
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-05java:no need to explicitly create these constructorsNoel Grandin
the compiler will do it for you Change-Id: I770670e70a43664a87ce28b48fc822d891d8fb41
2015-11-05java:avoid empty if statementsNoel Grandin
Change-Id: I9c66dd5331f422d8d6271157fece2b346d8b3756
2015-11-05coverity#1326925 silence Suspicious use of non-short-circuit boolean operatorCaolán McNamara
Change-Id: I4d71640baa3c169fba069ca1328273fb78964541
2015-11-05coverity#1326578 Useless callCaolán McNamara
Change-Id: Ib6f7463d97e9c835b2c9d64fa498efd546360645
2015-11-05coverity#1326577 Useless callCaolán McNamara
Change-Id: I3f9742cafdcdce3302c925a2227da1f7839c80c3
2015-11-05coverity#1326879 FE: Test for floating point equalityCaolán McNamara
and coverity#1326880 FE: Test for floating point equality coverity#1326881 FE: Test for floating point equality coverity#1326882 FE: Test for floating point equality coverity#1326883 FE: Test for floating point equality coverity#1326884 FE: Test for floating point equality coverity#1326885 FE: Test for floating point equality coverity#1326886 FE: Test for floating point equality coverity#1326887 FE: Test for floating point equality coverity#1326888 FE: Test for floating point equality Change-Id: I04a00035d541ea7a253a37d2a87c4dc407228346
2015-11-04Proper fix for coverity#1326893Stephan Bergmann
FindBugs' FE.FE_FLOATING_POINT_EQUALITY is about double value inaccuracies, not about NaN or negative zero (which is the topic of java.lang.Double.equals vs. ==). Reuse existing qa.TestCaseOldAPI.approxEqual method, moved to util.utils. Change-Id: I65f7bb1faf921e1c4035bb96aeff1eaf2cfb3153
2015-11-04coverity#1326893 silence FE: Test for floating point equalityCaolán McNamara
Change-Id: I8a0b657942cbe3de559a6b115fad2229490f8985