summaryrefslogtreecommitdiff
path: root/qadevOOo
AgeCommit message (Collapse)Author
2024-01-03cid#1545822 SSD: Do not use an instance lock to protect shared static dataCaolán McNamara
Change-Id: I269e4cd52673ebe7c3e30670b2dfe29acbd48af3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161548 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-18[API CHANGE] tdf#158041 Remove unused reverse printing option from swSamuel Mehrbrodt
Change-Id: I8b4597dbafc78e881fe556de8ce8221e50a673bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160777 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-18[API CHANGE] tdf#158041 Remove unused table printing option from swSamuel Mehrbrodt
"for now it was decided that tables should always be printed" -> make this decision from 2015 permanent Change-Id: Ica5958a74ec6766040ab59f2c91224b75df4d807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160766 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-04Disallow crash reporting in UITestsMike Kaganski
Otherwise, after one crash, the next UITest starts with the crash report dialog, and hangs, creating the noise in results. Seen when running UITests on Windows with parallelism. Crash reporting is unaffected by '--norestore', and handled separately in Desktop::OpenClients (desktop/source/app/app.cxx). Change-Id: I00b9bca3aa34c603bfdb54389437ce3ec4de6274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160312 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-14Dispose some test componentsStephan Bergmann
Otherwise, JunitTest_forms_unoapi_2 left behind two instances of frm::OGridControlModel. Change-Id: Idaf7bae26b18e20821968ebf52e7864043963e03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159422 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-09tdf#146386 curl,ucb: remove FTP UCPMichael Stahl
FTP support has been deprecated since LO 7.4. The UCP currently doesn't even support TLS connections. Also disable FTP protocol in libcurl. Also remove JunitTest_ucb_complex: turns out the only test in it, checkWrongFtpConnection, fails on Linux because now GIO UCP handles ftp:// URLs and it throws InteractiveAugmentedIOException instead of expected ones, and on other platforms it would fail differently because there is no GIO. Change-Id: I4631d124371fef390f105fb16bf09aaa59e739e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159065 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-09enable unchecked lint for our java codeNoel Grandin
and annotate where necessary, mostly just suppressing the warnings Change-Id: I8e39d797cde6c7c3f4e3e1bd93a128965ecec81d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159205 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Character' is deprecated in JavaNoel Grandin
replace with Character.valueOf Change-Id: I9938db0fce6490eba6f4900efc3c139a1b71d120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158786 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Double' is deprecated in JavaNoel Grandin
replace with Double.valueOf Change-Id: If5be8e500e31ebf9d5fb20ea7dd474677d7c74ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Float' is deprecated in JavaNoel Grandin
replace with Float.valueOf Change-Id: Ib6408b24dac2953789d0ec67e73b8be8aefca252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-25tdf#146150 Use dispatch cmd for the corresponding SIDapurvapriyadarshi
Change-Id: I0d987a8b10f2c69192d080b534a1d6aa71a6cf4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157105 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-09-12starmath: Keep focus on math widget when inline editing is enabledKhaled Hosny
Since originally all editing happened in the edit window, it was made to grab focus instead of the math widget, but we don’t want that anymore when inline editing is enable as we want to edit everything in the math widget. This also removes ancient test that is now failing. We will eventually drop the edit window altogether. Change-Id: Ia1628a454bbbdd923ff582564eca1ab4ec830f38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156579 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-30Fix typoAndrea Gelmini
Change-Id: I33bf9779387529da4340af340744386f89320000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156264 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-08-27tdf#45904: Move _Footnote Java tests to C++anfanite396
Change-Id: I1e69267a72296f55fac12326ec69d3c29e63561a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156055 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-27tdf#45904: Remove old SwXReferenceMarks Java testanfanite396
Change-Id: I8830e54fdba98d3cfd1e2844e7faf02e55e7d0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156044 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-26tdf#45904: Move _XFootnote Java tests to C++anfanite396
Change-Id: Ibdc28ab8818860b9c94abeac33713607dbcf8df4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155635 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-26tdf#45904: Move _DocumentIndexMark Java tests to C++anfanite396
Change-Id: I144d06ab3abb47134060d554a4016009246aa739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155163 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-26tdf#45904: Remove old SwXAutoTextContainer Java testanfanite396
Change-Id: Idcb3c17e328894bbd64939f2e3ad076204b35bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156113 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Remove old SwXParagraphEnumeration Java testanfanite396
Change-Id: Ia8b639e016971e389d24d4468492af902d1dc35b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156042 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Remove old SwXFootnotes Java testanfanite396
Change-Id: I7444b8521b560c91d2908d14330a3c6d6ff420cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156041 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Remove old SwXFieldEnumeration Java testanfanite396
Change-Id: I5bbefc7c1c5ac9ebd88669ac328bba28183b76ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156033 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Remove old SwXDocumentIndexes Java testanfanite396
Change-Id: I93556b3c56887b424dd8720d752986563a0fa807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156032 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Remove old SwXStyleFamilies Java testanfanite396
Change-Id: I3057e4a2fcf1b057d35050bfeb7c22fbad19325b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156045 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Move SwXTextField Java tests to C++anfanite396
Change-Id: I11052e68289507778767df0d69cc8924f394b4f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156047 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Move SwXTextEmbeddedObjects Java tests to C++anfanite396
Change-Id: I05ad9e264162e3fb97ebea814f59ed44bf23056a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156050 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Move _XTextRangeCompare Java tests to C++anfanite396
Change-Id: I40390a8b05f0e685a9408f0c486f6129633bc5b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155634 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Remove old SwXReferenceMark Java testanfanite396
Change-Id: I81acf617726b7e7e5b5510b0d6d7677c7d08aba5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156043 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Move SwXTextFieldMasters Java tests to C++anfanite396
Change-Id: Ifa185b24fe49f2c88e4d3687a09ebce5987503a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156051 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Move _XAutoTextContainer Java tests to C++anfanite396
Change-Id: Ie6ebc43c52204984cb6196f539c735701d13dc22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155627 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904: Move _BaseIndexMark Java tests to C++anfanite396
Change-Id: Ie6c09c0cfedbad8168281af354590ab7c9dd374e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155162 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-25tdf#45904 Move _NumberingRules Java tests to C++anfanite396
Change-Id: I86d559767204e1e8e1fd232db63f26a5c1ce67da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155089 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23tdf#45904: Remove old SwXBookmark Java testanfanite396
Change-Id: If17818329b805a03b975e105ea97f7c6cc16d1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155767 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23tdf#45904: Remove old SwXDocumentIndex Java testanfanite396
Change-Id: Idca41ac1aed35552a749eb62e886c06cec94b3e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155790 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23tdf#45904: Move SwXTextTables Java tests to C++anfanite396
Change-Id: I3946e68ce5c8a9611c243e427bc94c277c0a5456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155810 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-23tdf#45904: Move SwXTextSections Java tests to C++anfanite396
Change-Id: I24f7098f71a126790a177715a85fcea2724cb4aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155808 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-21Move SwXTextFieldTypes Java tests to C++anfanite396
Change-Id: I77ca9bc6cd0db626df826e2084514d34becf39bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154208 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-21tdf#45904: Remove old SwXBookmarks Java testanfanite396
Change-Id: Ie8d66b74192d1741922a7728934317859821fa00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155745 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-28Fix typoAndrea Gelmini
Change-Id: I0b4abdb362b86a3e1f622a04411e9f9ea0062295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153674 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Remove remnant commented code concerning recently dropped "XAccessibleStateSet"Julien Nabet
Change-Id: Ib11e37dbc6bf9bfc7ba8cdf3b5cb28d5a11f31a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151847 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-11-30Add some more failure informationStephan Bergmann
...which will hopefully give more of a clue than when <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/40847/> recently failed JunitTest_starmath_unoapi with just > checking: [sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent] is iface: [com.sun.star.accessibility.XAccessibleComponent] testcode: [...] > LOG> Execute: getAccessibleAtPoint() > LOG> Checking child with bounds (0,0),(2,18): 41,(Paragraph: 0 ): > LOG> StateType containsPoint SHOWING: true > LOG> finding the point which lies on the component > LOG> Child found at point (1,9) - OK > LOG> The children found is not the same > LOG> Expected: > LOG> Description: Paragraph: 0 sum hat a > LOG> Found: > LOG> Description: Paragraph: 0 sum hat a > LOG> ... FAILED > LOG> No children found at point (-1,-1) - OK > Method getAccessibleAtPoint() finished with state FAILED > LOG> getAccessibleAtPoint(): COMPLETED.FAILED [...] > ***** State for sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent ****** > [sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent::getAccessibleAtPoint()] is testcode: [getAccessibleAtPoint()] - COMPLETED.FAILED > > Whole interface: COMPLETED.FAILED Change-Id: I5015e7a9d94bb838c6331ff9e74a6aec858d148a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143496 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-13Fix typosAndrea Gelmini
Change-Id: Ic1fb0ea483954f2994a87e05f33b320da3795227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142661 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-06cid#1509284 DMI: Dubious method invocationCaolán McNamara
Change-Id: I1fd1f710ae2a6b8ebc9506a56d522006509fc935 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-02[API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bitMichael Weghorn
With 16k column support in Calc enabled by default in commit 4c5f8ccf0a2320432b8fe91add1dcadf54d9fd58 Date: Tue Mar 8 12:44:49 2022 +0100 change default Calc number of columns to 16384 (tdf#50916) , the number of Calc cells in a spreadsheet is larger than SAL_MAX_INT32, meaning that a 32-bit a11y child index is no more enough and using it resulted in integer overflows in methods handling corresponding Calc cells in the a11y layer. This e.g. had the effect of the Orca and NVDA screen readers not announcing focused or selected cells properly when their a11y child index was out of the 32-bit integer range. Switch the internal a11y child indices to 64 bit to be able to handle this properly internally. Since the platform APIs (at least AT-SPI on Linux and IAccessible2 on Windows; from what I can see LO's macOS a11y bridge doesn't directly expose the child index) are still restricted to 32 bit, larger child indices still cannot be exposed via the platform APIs. As a consequence, use of the the IAccessible2 and AT-SPI methods that use the child index remains problematic in those cases where the child index is larger. However, as an alternative to using the AT-SPI Table interface and the IAccessibleTable/ IAccessibleTable2 interfaces with the child index to retrieve information about a specific cell, both AT-SPI and IAccessible2 also provide interfaces to retrieve that information directly from the cell object (TableCell interface for AT-SPI, IAccessibleTableCell for IAccessible2). Those interfaces are already implemented/exposed for winaccessibility (s. `CAccTable`) and the qt5/qt6/kf5 VCL plugins (s. the `QAccessibleTableCellInterface` methods implemented in `QtAccessibleInterface`). With the switch to 64-bit internal a11y child indices, these now behave correctly for cells with a child index that doesn't fit into 32 bit as well. NVDA on Windows already uses the IAccessibleTableCell interface and thus announcing focused cells works fine with this change in place. Orca on Linux currently doesn't make use of the AT-SPI TableCell interface yet, but with a suggested change to do so [1], announcement of selected cells works with the qt6 VCL plugin with a current qtbase dev branch as well - when combined with the suggested changes to implement support for the AT-SPI TableCell interface in Qt [2] [3] and the LO change based on that [4] and a fix for a nullptr dereference [5]. The gtk3 VCL plugin doesn't expose the AT-SPI TableCell interface yet, but once it does so (via `AtkTableCell`), it also works with the suggested Orca change [1] in place. (Adding that is planned for an upcoming change, works with a local WIP patch.) For handling return values that are larger than what platform APIs support, the following approach has been chosen for now: 1) When the return value is for the count of (selected) children, the maximum value N supported by the platform API is returned. (This is what `ScAccessibleTableBase::getAccessibleChildCount` did previously.) The first N elements can be accessed by their actual (selection) indices. 2) When the return value is the child/cell index, -2 is returned for objects whose index is greater than the maximum value supported by the platform API. Using a non-negative value would mean that the index would refer to *another* actually existing child. A child index of -1 on the other hand tends to be interpreted as "child is invalid" or "object isn't actually a child of its (previous) parent any more)". For the Orca case, this would result in objects with a child index of -1 not being announced, as they are considered "zombies" [6]. What's still somewhat problematic is the case where more than 2^31 children are *selected*, since access to those children still happens by the index into the selection in the platform APIs, and not all selected items are accessible this way. (Screen readers usually just retrieve the first and last element from the selection and announce those.) Orca already seems to apply different handling for the case for fully selected rows and columns, so "All cells selected" or "Columns ... to ... selected" is announced just fine even if more than 2^31 cells are selected. (Side note: While Microsoft User Interface Automation - UIA - also uses 32-bit indices, it also has specific methods in the ISelectionProvider2 interface that allow to explicitly retrieve the first and last selected item, `ISelectionProvider2::get_FirstSelectedItem` and `ISelectionProvider2::get_LastSelectedItem`, but we currently don't support UIA on Windows.) Bound checks at the beginning of the methods from the `XAccessibleContext`, `XAccessibleSelection` and `XAccessibleTable` interfaces that take a child index (or in helper methods called by those) should generally already prevent too large indices from being passed to the methods in the lower layer code that take smaller integer types. Such bound checking has been been added in various places where it wasn't present yet. If there any remaining issues of this kind that show after this commit, they can probably be solved in a similar way (s.e.g. the change to `AccessibleBrowseBox::getAccessibleChild` in this commit). A few asserts were also added at places where my understanding is that values shouldn't be larger than what is supported by a called method anyway. A test case will be added in a following change. [1] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/131 [2] https://codereview.qt-project.org/c/qt/qtbase/+/428566 [3] https://codereview.qt-project.org/c/qt/qtbase/+/428567 [4] https://gerrit.libreoffice.org/c/core/+/138750 [5] https://codereview.qt-project.org/c/qt/qtbase/+/430157 [6] https://gitlab.gnome.org/GNOME/orca/-/blob/82c8542002e36e0d3d918088d583162d25136143/src/orca/script_utilities.py#L5155 Change-Id: I3af590c988b0e6754fc72545918412f39e8fea07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139258 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-27cid#1509234 DCN: Don't Catch NullPointer ExceptionCaolán McNamara
and cid#1509229 DCN: Don't Catch NullPointer Exception Change-Id: I113de964ff07fc771ac64acb8583341cd518d0e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-26cid#1509239 DCN: Don't Catch NullPointer ExceptionCaolán McNamara
and cid#1509234 DCN: Don't Catch NullPointer Exception cid#1509229 DCN: Don't Catch NullPointer Exception cid#1509219 DCN: Don't Catch NullPointer Exception cid#1509216 DCN: Don't Catch NullPointer Exception Change-Id: Iab1512b4e5ecd632104a58b1fc09ef150825f498 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509396 Explicit null dereferencedCaolán McNamara
and cid#1509395 Explicit null dereferenced Change-Id: Ifd8dffe2ff2432ee2f0ef18bb2a480c2f042910b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-18cid#1327197 UwF: Unwritten fieldCaolán McNamara
Change-Id: Ib132101078a67803d21393c875e55f7a7bf8d225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-12Fix typosAndrea Gelmini
Change-Id: I67e6e34265342b56bb922d2d9fc3a3385c8990d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138182 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-08[API CHANGE] Drop css::accessibility::XAccessibleStateSetNoel Grandin
which is internal API, unused (as far as I can tell) by external users. This state is purely a bitset (as implemented by utl::AccessibleStateSetHelper) so we can just return it as a 64-bit value. This shaves significant time off the performance profiles of code that loads very complex shapes, because this state is frequently used, and we no longer need to allocate a return value on the heap for every call. Change-Id: Icf1b3bd367c256646ae9015f9127025f59459c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136786 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-10qa: Fix occlusion check coordinates in _XAccessibleComponent.javaColomban Wendling
This could erroneously skip a check because the child was erroneously deemed obscured by another object. Change-Id: I67d76ea272874671ae328266bdbdeb037c0dc625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133842 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
generated by cgit (git 2.34.1) at 2024-12-28 19:18:23 +0000