summaryrefslogtreecommitdiff
path: root/qadevOOo
AgeCommit message (Collapse)Author
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove comment noiseNoel Grandin
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6 Reviewed-on: https://gerrit.libreoffice.org/13408 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some comment noiseNoel Grandin
Change-Id: I51118fecf9de27407b4c5a66cd6577574939e001
2014-11-25java: remove some comment noiseNoel Grandin
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25java: final fields that can be staticNoel Grandin
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24java,qadev: remove unused parameters and local varsNoel Grandin
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873 Reviewed-on: https://gerrit.libreoffice.org/13097 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18java: rather use @Deprecated annotationNoel Grandin
than an empty @deprecated tag Change-Id: I1646ce1c0c8823ac5be0153aeb8eb2b830e7ebfa Reviewed-on: https://gerrit.libreoffice.org/12525 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30java: calling ready() on a BufferedReader is a dodgy way..Noel Grandin
..to detect end-of-file Change-Id: I3b1d5eca3a7424d72b5e3ab741f7407ad7e65193
2014-10-30java: Questionable use of non-short-circuit logicRobert Antoni Buj i Gelonch
Change-Id: Ied831cb5d6645e2696ff2d3d57843fc7a1f82f7e Reviewed-on: https://gerrit.libreoffice.org/12137 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-30runner: Dereference of the result of readLine() without nullcheckRobert Antoni Buj i Gelonch
Change-Id: I3d02436446a79137ce42b1a190c9e3985fbb9246 Reviewed-on: https://gerrit.libreoffice.org/12135 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25java: prevent overflow by using 'long int' arithmetic in multiplicationRobert Antoni Buj i Gelonch
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998 Reviewed-on: https://gerrit.libreoffice.org/12001 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19runner: Iterate over each Entry in a MapRobert Antoni Buj i Gelonch
Change-Id: I48de54ea88e7fd9f2d903c172eb2b6e1a5b73edd Reviewed-on: https://gerrit.libreoffice.org/11918 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18java: loss of precissionRobert Antoni Buj i Gelonch
Change-Id: I0563a76b1d2c838e6301bf7a9ed154c77a98c0d9 Reviewed-on: https://gerrit.libreoffice.org/12000 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: dodgy &= operationNoel Grandin
Change-Id: Ia909797e08948a8ad0e6f536ce2af57880dc13ef
2014-10-17java: when rethrowing exceptions, store the originalNoel Grandin
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
2014-10-16runner: if .. else if .. elseRobert Antoni Buj i Gelonch
Change-Id: If9c07074b60b14d0f4e947754d4bf34e4f2f9676 Reviewed-on: https://gerrit.libreoffice.org/11990 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: always use braces for while loopsNoel Grandin
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-16java: reduce the depth of some deeply nested if blocksNoel Grandin
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
2014-10-15runner: replace '.size() == 0' with '.isEmpty()' (collections)Robert Antoni Buj i Gelonch
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty() Change-Id: I9a8f4feab9120d2d9fbf845f305380cda9b263bb Reviewed-on: https://gerrit.libreoffice.org/11968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14reformat ValueChangerNoel Grandin
so that it is at least marginally legible Change-Id: I20882ad77d6488bb1f2b9dc9e91dc47458596b4a
2014-10-14runner: Null pointer dereferenceRobert Antoni Buj i Gelonch
Change-Id: Id38a9e0bddbf3c9038abbc5de7137ee5d3f39db6 Reviewed-on: https://gerrit.libreoffice.org/11924 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-14runner: finally block to ensure that a resource is closed (Prior to Java SE 7)Robert Antoni Buj i Gelonch
http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html Change-Id: I5ecefd3e5bf84fea2a8735a44236ed4c86b440c4 Reviewed-on: https://gerrit.libreoffice.org/11950 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13java: Collections.addAll for adding an array of elements to a CollectionRobert Antoni Buj i Gelonch
Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09 Reviewed-on: https://gerrit.libreoffice.org/11953 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13java: import from the same packageRobert Antoni Buj i Gelonch
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9 Reviewed-on: https://gerrit.libreoffice.org/11955 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13runner: Object comparisonRobert Antoni Buj i Gelonch
Change-Id: I41b245f20652187dc36b4639272d0ddbc602afda Reviewed-on: https://gerrit.libreoffice.org/11921 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: code will never be executedRobert Antoni Buj i Gelonch
Change-Id: I0484a11b3511c1d7f70e9ae8407eb7d19bcc852d Reviewed-on: https://gerrit.libreoffice.org/11929 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: Concatenating null strings in Java (JDK 1.5+)Robert Antoni Buj i Gelonch
JLS, Section 15.18.1.1: If the reference is null, it is converted to the string "null". http://docs.oracle.com/javase/specs/jls/se5.0/html/expressions.html#15.18.1.1 Change-Id: Idae09c02b24da38ec6f3475fd0af35ef48a2405b Reviewed-on: https://gerrit.libreoffice.org/11930 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: remove import from same packageRobert Antoni Buj i Gelonch
Change-Id: I4aeb7f58034f8808325639d07aa2dc55959d97a8 Reviewed-on: https://gerrit.libreoffice.org/11932 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: remove import from java.lang PackageRobert Antoni Buj i Gelonch
Change-Id: Iedad24dfbdd60a05a09888f699f2467960f5cbe9 Reviewed-on: https://gerrit.libreoffice.org/11933 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-12runner: 'static final' to declare constants when it isn't an interfaceRobert Antoni Buj i Gelonch
Change-Id: Iea1e672e5468b66fd1ba5389bd781f03d0c7f419 Reviewed-on: https://gerrit.libreoffice.org/11931 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11It is more efficient to use the integer implementations of String.indexOf()Robert Antoni Buj i Gelonch
Change-Id: Idb1e4945088b8443e9b507826e5289ee758a2bd2 Reviewed-on: https://gerrit.libreoffice.org/11919 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10runner: The if statement is redundantRobert Antoni Buj i Gelonch
Change-Id: Ida40034bdfe6a44a936db1243ad6c71616caada3 Reviewed-on: https://gerrit.libreoffice.org/11895 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09typo: proeprty -> propertyAndras Timar
Change-Id: Ib20ca28c2236fc99e1339b6e57e8641a213116c7
2014-10-09typo: Lable -> LabelAndras Timar
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
2014-10-07java: simplify some for loops to while loopsNoel Grandin
Change-Id: I323ab12c634d3baa4f624b63d7d483112c23192c
2014-10-07while loop that ends in a return is more accurately an if blockNoel Grandin
Change-Id: I94b74b46b185e1061b6b72acdf3d9dc0c1d122c8
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: use equalsIgnoreCase() instead of toLowerCase().equals()Noel Grandin
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
2014-10-07java: use equals() to compare Strings, not ==Noel Grandin
Change-Id: Ia41a4899fb82df7b580a020765404c4ef0cddfa2
2014-10-07java: simplify conditions involving logical negationNoel Grandin
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-07java: optimise calls to toArrayNoel Grandin
passing in a correctly sized array requires one less allocation Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
generated by cgit (git 2.34.1) at 2025-01-13 07:49:56 +0000